Changeset 69693 in webkit

Timestamp:

Oct 13, 2010 1:29:40 PM (14 years ago)

Author:

kbr@google.com

Message:

2010-10-13 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Revert changes to WebViewImpl in r69633
​https://bugs.webkit.org/show_bug.cgi?id=47610

Revert change to WebViewImpl.cpp in
​http://trac.webkit.org/changeset/69633 which incorrectly used
PassRefPtr for a local variable instead of RefPtr. This was a fix
for changes in ​http://trac.webkit.org/changeset/69619 and
​http://trac.webkit.org/changeset/69624 .

• src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebViewImpl.cpp (modified) (2 diffs)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-10-13  Kenneth Russell  <kbr@google.com>
+
+        Reviewed by James Robinson.
+
+        Revert changes to WebViewImpl in r69633
+        https://bugs.webkit.org/show_bug.cgi?id=47610
+
+        Revert change to WebViewImpl.cpp in
+        http://trac.webkit.org/changeset/69633 which incorrectly used
+        PassRefPtr for a local variable instead of RefPtr. This was a fix
+        for changes in http://trac.webkit.org/changeset/69619 and
+        http://trac.webkit.org/changeset/69624 .
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
+
 2010-10-13  Gavin Barraclough  <barraclough@apple.com>
 

trunk/WebKit/chromium/src/WebViewImpl.cpp

@@ -2370 +2370 @@
     }
 
-    PassRefPtr<GraphicsContext3D> context = m_temporaryOnscreenGraphicsContext3D.release();
+    RefPtr<GraphicsContext3D> context = m_temporaryOnscreenGraphicsContext3D.release();
     if (!context) {
         context = GraphicsContext3D::create(GraphicsContext3D::Attributes(), m_page->chrome(), GraphicsContext3D::RenderDirectlyToHostWindow);
@@ -2376 +2376 @@
             context->reshape(std::max(1, m_size.width), std::max(1, m_size.height));
     }
-    m_layerRenderer = LayerRendererChromium::create(context);
+    m_layerRenderer = LayerRendererChromium::create(context.release());
     if (m_layerRenderer) {
         m_isAcceleratedCompositingActive = true;