Changeset 69803 in webkit

Timestamp:

Oct 14, 2010 2:05:38 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-10-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r69795.
​http://trac.webkit.org/changeset/69795
​https://bugs.webkit.org/show_bug.cgi?id=47687

'See discussion at webkit.org/b/47609' (Requested by mwenge on
#webkit).

• platform/qt/Skipped:

2010-10-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r69795.
​http://trac.webkit.org/changeset/69795
​https://bugs.webkit.org/show_bug.cgi?id=47687

'See discussion at webkit.org/b/47609' (Requested by mwenge on
#webkit).

• WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::canHandleRequest): (WebCore::FrameLoaderClientQt::dispatchUnableToImplementPolicy):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt/Skipped (modified) (1 diff)
• WebKit/qt/ChangeLog (modified) (1 diff)
• WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-10-14  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r69795.
+        http://trac.webkit.org/changeset/69795
+        https://bugs.webkit.org/show_bug.cgi?id=47687
+
+        'See discussion at webkit.org/b/47609' (Requested by mwenge on
+        #webkit).
+
+        * platform/qt/Skipped:
+
 2010-10-14  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/LayoutTests/platform/qt/Skipped

@@ -723 +723 @@
 
 # timeout
+http/tests/misc/redirect-to-external-url.html
 http/tests/security/feed-urls-from-remote.html
 

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-10-14  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r69795.
+        http://trac.webkit.org/changeset/69795
+        https://bugs.webkit.org/show_bug.cgi?id=47687
+
+        'See discussion at webkit.org/b/47609' (Requested by mwenge on
+        #webkit).
+
+        * WebCoreSupport/FrameLoaderClientQt.cpp:
+        (WebCore::FrameLoaderClientQt::canHandleRequest):
+        (WebCore::FrameLoaderClientQt::dispatchUnableToImplementPolicy):
+
 2010-10-14  Robert Hogan  <robert@webkit.org>
 

trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp

@@ -709 +709 @@
 }
 
-bool FrameLoaderClientQt::canHandleRequest(const WebCore::ResourceRequest& request) const
-{
-    if (QWebPagePrivate::drtRun) {
-        // Just reject the scheme used in
-        // LayoutTests/http/tests/misc/redirect-to-external-url.html
-        QUrl url = QUrl(request.url());
-        if (url.scheme() == "spaceballs")
-            return false;
-    }
+bool FrameLoaderClientQt::canHandleRequest(const WebCore::ResourceRequest&) const
+{
     return true;
 }
@@ -1200 +1193 @@
 }
 
-void FrameLoaderClientQt::dispatchUnableToImplementPolicy(const WebCore::ResourceError& error)
-{
-    if (!m_webFrame)
-        return;
-
-    if (QWebPagePrivate::drtRun) {
-        printf("Policy delegate: unable to implement policy with error domain '%s', "
-              "error code %d, in frame '%s'\n",
-              error.domain().utf8().data(), error.errorCode(), m_webFrame->frameName().toUtf8().data());
-    }
+void FrameLoaderClientQt::dispatchUnableToImplementPolicy(const WebCore::ResourceError&)
+{
+    notImplemented();
 }