Changeset 69804 in webkit

Timestamp:

Oct 14, 2010 2:11:52 PM (14 years ago)

Author:

zmo@google.com

Message:

2010-10-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Cache link status at linkProgram and use it in useProgram instead of querying GPU
​https://bugs.webkit.org/show_bug.cgi?id=47685

• html/canvas/WebGLProgram.cpp: Always cache link status at linkStatus and use it upon query. (WebCore::WebGLProgram::WebGLProgram):
• html/canvas/WebGLProgram.h: Ditto. (WebCore::WebGLProgram::getLinkStatus): (WebCore::WebGLProgram::setLinkStatus):
• html/canvas/WebGLRenderingContext.cpp: Ditto. (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::useProgram):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/canvas/WebGLProgram.cpp (modified) (1 diff)
• html/canvas/WebGLProgram.h (modified) (2 diffs)
• html/canvas/WebGLRenderingContext.cpp (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-14  Zhenyao Mo  <zmo@google.com>
+
+        Reviewed by Kenneth Russell.
+
+        Cache link status at linkProgram and use it in useProgram instead of querying GPU
+        https://bugs.webkit.org/show_bug.cgi?id=47685
+
+        * html/canvas/WebGLProgram.cpp: Always cache link status at linkStatus and use it upon query.
+        (WebCore::WebGLProgram::WebGLProgram):
+        * html/canvas/WebGLProgram.h: Ditto.
+        (WebCore::WebGLProgram::getLinkStatus):
+        (WebCore::WebGLProgram::setLinkStatus):
+        * html/canvas/WebGLRenderingContext.cpp: Ditto.
+        (WebCore::WebGLRenderingContext::getProgramParameter):
+        (WebCore::WebGLRenderingContext::linkProgram):
+        (WebCore::WebGLRenderingContext::useProgram):
+
 2010-10-14  Justin Schuh  <jschuh@chromium.org>
 

trunk/WebCore/html/canvas/WebGLProgram.cpp

@@ -41 +41 @@
 WebGLProgram::WebGLProgram(WebGLRenderingContext* ctx)
     : WebGLObject(ctx)
-    , m_linkFailure(false)
+    , m_linkStatus(false)
 {
     setObject(context()->graphicsContext3D()->createProgram());

trunk/WebCore/html/canvas/WebGLProgram.h

@@ -51 +51 @@
     bool isUsingVertexAttrib0() const;
 
-    // Return true means getProgramParameter(LINK_STATUS) should return
-    // false; return false means we should actually call
-    // getProgramParameter(LINK_STATUS) to find out.
-    bool isLinkFailureFlagSet() const { return m_linkFailure; }
-    void setLinkFailureFlag(bool failed) { m_linkFailure = failed; }
+    bool getLinkStatus() const { return m_linkStatus; }
+    void setLinkStatus(bool status) { m_linkStatus = status; }
 
     WebGLShader* getAttachedShader(GraphicsContext3D::WebGLEnumType);
@@ -71 +68 @@
     Vector<int> m_activeAttribLocations;
 
-    bool m_linkFailure;
+    bool m_linkStatus;
 
     RefPtr<WebGLShader> m_vertexShader;

trunk/WebCore/html/canvas/WebGLRenderingContext.cpp

@@ -1485 +1485 @@
         return WebGLGetInfo(static_cast<bool>(value));
     case GraphicsContext3D::LINK_STATUS:
-        if (program->isLinkFailureFlagSet())
-            return WebGLGetInfo(false);
-        m_context->getProgramiv(objectOrZero(program), pname, &value);
-        return WebGLGetInfo(static_cast<bool>(value));
+        return WebGLGetInfo(program->getLinkStatus());
     case GraphicsContext3D::INFO_LOG_LENGTH:
     case GraphicsContext3D::ATTACHED_SHADERS:
@@ -1898 +1895 @@
     if (!isGLES2Compliant()) {
         if (!program->getAttachedShader(GraphicsContext3D::VERTEX_SHADER) || !program->getAttachedShader(GraphicsContext3D::FRAGMENT_SHADER)) {
-            program->setLinkFailureFlag(true);
+            program->setLinkStatus(false);
             return;
         }
-        program->setLinkFailureFlag(false);
     }
 
     m_context->linkProgram(objectOrZero(program));
     program->cacheActiveAttribLocations();
+    // cache link status
+    int value = 0;
+    m_context->getProgramiv(objectOrZero(program), GraphicsContext3D::LINK_STATUS, &value);
+    program->setLinkStatus(static_cast<bool>(value));
     cleanupAfterGraphicsCall(false);
 }
@@ -2715 +2715 @@
 void WebGLRenderingContext::useProgram(WebGLProgram* program, ExceptionCode& ec)
 {
+    UNUSED_PARAM(ec);
     if (program && program->context() != this) {
         m_context->synthesizeGLError(GraphicsContext3D::INVALID_OPERATION);
         return;
     }
-    if (program && program->object() && !getProgramParameter(program, GraphicsContext3D::LINK_STATUS, ec).getBool()) {
+    if (program && program->object() && !program->getLinkStatus()) {
         m_context->synthesizeGLError(GraphicsContext3D::INVALID_OPERATION);
         cleanupAfterGraphicsCall(false);