Changeset 69914 in webkit

Timestamp:

Oct 16, 2010 9:48:06 AM (14 years ago)

Author:

inferno@chromium.org

Message:

2010-10-16 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

Requires a user gesture when opening file choose dialog.
​https://bugs.webkit.org/show_bug.cgi?id=47593

Test: fast/forms/input-file-not-open-without-gesture.html

• rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):

2010-10-16 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

Requires a user gesture when opening file choose dialog.
​https://bugs.webkit.org/show_bug.cgi?id=47593

• fast/forms/input-file-not-open-without-gesture-expected.txt: Added.
• fast/forms/input-file-not-open-without-gesture.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/input-file-not-open-without-gesture-expected.txt (added)
• LayoutTests/fast/forms/input-file-not-open-without-gesture.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderFileUploadControl.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-10-16  Johnny Ding  <jnd@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Requires a user gesture when opening file choose dialog.
+        https://bugs.webkit.org/show_bug.cgi?id=47593
+
+        * fast/forms/input-file-not-open-without-gesture-expected.txt: Added.
+        * fast/forms/input-file-not-open-without-gesture.html: Added.
+
 2010-10-16  Alex Milowski  <alex@milowski.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-16  Johnny Ding  <jnd@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Requires a user gesture when opening file choose dialog.
+        https://bugs.webkit.org/show_bug.cgi?id=47593
+
+        Test: fast/forms/input-file-not-open-without-gesture.html
+
+        * rendering/RenderFileUploadControl.cpp:
+        (WebCore::RenderFileUploadControl::click):
+
 2010-10-16  Alex Milowski  <alex@milowski.com>
 

trunk/WebCore/rendering/RenderFileUploadControl.cpp

@@ -125 +125 @@
 void RenderFileUploadControl::click()
 {
+    // Requires a user gesture to open the file dialog.
+    if (!frame() || !frame()->loader()->isProcessingUserGesture())
+        return;
     if (Chrome* chromePointer = chrome())
-        chromePointer->runOpenPanel(node()->document()->frame(), m_fileChooser);
+        chromePointer->runOpenPanel(frame(), m_fileChooser);
 }