Changeset 69939 in webkit


Ignore:
Timestamp:
Oct 17, 2010 9:02:16 PM (14 years ago)
Author:
tonikitoo@webkit.org
Message:

2010-10-17 Antonio Gomes <​agomes@rim.com>

Reviewed by Simon Fraser.

Enrich /fast/dom/nodesFromRect-basic.html test
​https://bugs.webkit.org/show_bug.cgi?id=47766

The patch makes fast/dom/nodesFromRect-basic.html test more precise:
instead of calling nodesFromRect always with equal vertical (up and down) and
horizontal (right and left) padding values, it are now tests it by passing
different padding values on the various directions.

It is now possible due to the work on bug 46336: Make Document::nodesFromRect more flexible.

  • fast/dom/nodesFromRect-basic-expected.txt:
  • fast/dom/nodesFromRect-basic.html:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r69937 r69939  
     12010-10-17  Antonio Gomes  <agomes@rim.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Enrich /fast/dom/nodesFromRect-basic.html test
     6        https://bugs.webkit.org/show_bug.cgi?id=47766
     7
     8        The patch makes fast/dom/nodesFromRect-basic.html test more precise:
     9        instead of calling nodesFromRect always with equal vertical (up and down) and
     10        horizontal (right and left) padding values, it are now tests it by passing
     11        different padding values on the various directions.
     12
     13        It is now possible due to the work on bug 46336: Make Document::nodesFromRect more flexible.
     14
     15        * fast/dom/nodesFromRect-basic-expected.txt:
     16        * fast/dom/nodesFromRect-basic.html:
     17
    1182010-10-17  Julien Chaffraix  <jchaffraix@codeaurora.org>
    219

  • trunk/LayoutTests/fast/dom/nodesFromRect-basic-expected.txt

    r68475 r69939  
    33TEST COMPLETE
    44PASS All correct nodes found for rect [53,71], [0,0,0,0]
     5PASS All correct nodes found for rect [53,71], [10,0,0,0]
     6PASS All correct nodes found for rect [53,71], [0,10,0,0]
     7PASS All correct nodes found for rect [53,71], [0,0,10,0]
     8PASS All correct nodes found for rect [53,71], [0,0,0,10]
    59PASS All correct nodes found for rect [53,71], [0,10,0,10]
    610PASS All correct nodes found for rect [53,71], [10,0,10,0]
    711PASS All correct nodes found for rect [53,71], [10,10,10,10]
     12PASS All correct nodes found for rect [152,105], [10,0,0,0]
     13PASS All correct nodes found for rect [152,105], [0,10,0,0]
     14PASS All correct nodes found for rect [152,105], [0,0,10,0]
     15PASS All correct nodes found for rect [152,105], [0,0,0,10]
    816PASS All correct nodes found for rect [152,105], [10,0,10,0]
    917PASS All correct nodes found for rect [152,105], [0,10,0,10]
    … …  
    1220PASS All correct nodes found for rect [153,193], [0,20,0,20]
    1321PASS All correct nodes found for rect [153,193], [20,0,20,0]
     22PASS All correct nodes found for rect [77,240], [0,0,0,0]
     23PASS All correct nodes found for rect [77,240], [1,0,0,0]
     24PASS All correct nodes found for rect [77,240], [0,0,1,0]
     25PASS All correct nodes found for rect [77,240], [1,0,1,0]
    1426PASS All correct nodes found for rect [144,183], [0,0,0,0]
    1527PASS All correct nodes found for rect [144,183], [1,0,1,0]
    1628PASS All correct nodes found for rect [144,183], [0,1,0,1]
     29PASS All correct nodes found for rect [144,183], [0,0,1,0]
     30PASS All correct nodes found for rect [144,183], [0,0,0,1]
     31PASS All correct nodes found for rect [144,183], [0,0,1,1]
    1732PASS All correct nodes found for rect [144,183], [1,1,1,1]
    1833PASS All correct nodes found for rect [77,240], [0,0,0,0]
    19 PASS All correct nodes found for rect [77,240], [0,10,0,10]
    20 PASS All correct nodes found for rect [77,240], [10,0,10,0]
    21 PASS All correct nodes found for rect [77,240], [10,10,10,10]
     34PASS All correct nodes found for rect [77,240], [0,1,0,1]
     35PASS All correct nodes found for rect [77,240], [1,0,0,0]
     36PASS All correct nodes found for rect [77,240], [0,0,1,0]
     37PASS All correct nodes found for rect [77,240], [1,0,1,0]
     38PASS All correct nodes found for rect [77,240], [1,1,1,1]
    2239PASS All correct nodes found for rect [39,212], [0,0,0,0]
     40PASS All correct nodes found for rect [39,212], [10,0,0,0]
     41PASS All correct nodes found for rect [39,212], [0,0,10,0]
     42PASS All correct nodes found for rect [39,212], [10,1,30,0]
     43PASS All correct nodes found for rect [39,212], [10,5,30,0]
     44PASS All correct nodes found for rect [39,212], [10,15,30,0]
    2345PASS All correct nodes found for rect [39,212], [10,0,10,0]
    2446PASS All correct nodes found for rect [39,212], [0,10,0,10]

  • trunk/LayoutTests/fast/dom/nodesFromRect-basic.html

    r68475 r69939  
    2424
    2525      check(53, 71, 0, 0, 0, 0, [e.body]);
     26      check(53, 71, 10, 0,  0,  0, [e.h1, e.body]);
     27      check(53, 71, 0,  10, 0,  0, [e.p3, e.body]);
     28      check(53, 71, 0,  0,  10, 0, [e.d1, e.body]);
     29      check(53, 71, 0,  0,  0, 10, [e.body]);
    2630      check(53, 71, 0, 10, 0, 10, [e.p3, e.body]);
    2731      check(53, 71, 10, 0, 10, 0, [e.d1, e.h1, e.body]);
    2832      check(53, 71, 10, 10, 10, 10, [e.p3, e.d1, e.h1, e.body]);
    2933
     34      check(152, 105, 10, 0, 0, 0, [e.p3, e.body]);
     35      check(152, 105, 0, 10, 0, 0, [e.p4, e.body]);
     36      check(152, 105, 0, 0, 10, 0, [e.body]);
     37      check(152, 105, 0, 0, 0, 10, [e.d1, e.body]);
    3038      check(152, 105, 10, 0, 10, 0, [e.p3, e.body]);
    3139      check(152, 105, 0, 10, 0, 10, [e.p4, e.d1, e.body]);
    … …  
    3947      check(153,193,20, 0, 20, 0, [e.p5, e.body]);
    4048
     49      check(77,  240, 0, 0, 0, 0, [e.p2]);
     50      check(77,  240, 1, 0, 0, 0, [e.p5, e.p2]);
     51      check(77,  240, 0, 0, 1, 0, [e.span, e.p2]);
     52      check(77,  240, 1, 0, 1, 0, [e.p5, e.span, e.p2]);
     53
    4154      // Precise pixel checks:
    4255      check(144, 183, 0, 0, 0, 0, [e.body]);
    4356      check(144, 183, 1, 0, 1, 0, [e.p5, e.body]);
    4457      check(144, 183, 0, 1, 0, 1, [e.d2, e.body]);
     58      check(144, 183, 0, 0, 1, 0, [e.p5, e.body]);
     59      check(144, 183, 0, 0, 0, 1, [e.d2, e.body]);
     60      check(144, 183, 0, 0, 1, 1, [e.p5, e.d2, e.body]);
    4561      check(144, 183, 1, 1, 1, 1, [e.p5, e.d2, e.body]);
    4662      check(77, 240, 0, 0, 0, 0, [e.p2]);
    47       check(77, 240, 0, 10, 0, 10, [e.p2]);
    48       check(77, 240, 10, 0, 10, 0, [e.p5, e.span, e.p2]);
    49       check(77, 240, 10, 10, 10, 10, [e.p5, e.span, e.p2]);
     63      check(77, 240, 0, 1, 0, 1, [e.p2]);
     64      check(77, 240, 1, 0, 0, 0, [e.p5, e.p2]);
     65      check(77, 240, 0, 0, 1, 0, [e.span, e.p2]);
     66      check(77, 240, 1, 0, 1, 0, [e.p5, e.span, e.p2]);
     67      check(77, 240, 1, 1, 1, 1, [e.p5, e.span, e.p2]);
    5068
    5169      // Expanding area checks:
    5270      check(39, 212, 0,  0, 0, 0, [e.body]);
     71      check(39, 212, 10, 0,  0,  0, [e.d2, e.body]);
     72      check(39, 212, 0,  0,  10, 0, [e.p2, e.body]);
     73      check(39, 212, 10, 1,  30, 0, [e.d2, e.p2, e.body]);
     74      check(39, 212, 10, 5,  30, 0, [e.span, e.d2, e.p2, e.body]);
     75      check(39, 212, 10, 15, 30, 0, [e.p5, e.span, e.d2, e.p2, e.body]);
    5376      check(39, 212, 10, 0, 10, 0, [e.d2, e.p2, e.body]);
    5477      check(39, 212, 0, 10, 0, 10, [e.p5, e.body]);
Note: See TracChangeset for help on using the changeset viewer.