Changeset 69951 in webkit

Timestamp:

Oct 18, 2010 4:42:26 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-10-18 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

commit-queue's flaky test notice is very Pythony
​https://bugs.webkit.org/show_bug.cgi?id=47790

This patch make the list of tests delimted by \n instead of just
converting the array to a string.

• Scripts/webkitpy/tool/commands/queues.py:
• Scripts/webkitpy/tool/commands/queues_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/commands/queues.py (modified) (1 diff)
• Scripts/webkitpy/tool/commands/queues_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-10-18  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by David Levin.
+
+        commit-queue's flaky test notice is very Pythony
+        https://bugs.webkit.org/show_bug.cgi?id=47790
+
+        This patch make the list of tests delimted by \n instead of just
+        converting the array to a string.
+
+        * Scripts/webkitpy/tool/commands/queues.py:
+        * Scripts/webkitpy/tool/commands/queues_unittest.py:
+
 2010-10-14  Antonio Gomes  <agomes@rim.com>
 

trunk/WebKitTools/Scripts/webkitpy/tool/commands/queues.py

@@ -291 +291 @@
 
     def report_flaky_tests(self, patch, flaky_tests):
-        message = "The %s encountered the following flaky tests while processing attachment %s:\n\n%s\n\nPlease file bugs against the tests.  The commit-queue is continuing to process your patch." % (self.name, patch.id(), flaky_tests)
+        message = "The %s encountered the following flaky tests while processing attachment %s:\n\n%s\n\nPlease file bugs against the tests.  The commit-queue is continuing to process your patch." % (self.name, patch.id(), "\n".join(flaky_tests))
         self._tool.bugs.post_comment_to_bug(patch.bug_id(), message, cc=self.watchers)
 

trunk/WebKitTools/Scripts/webkitpy/tool/commands/queues_unittest.py

@@ -329 +329 @@
 The commit-queue encountered the following flaky tests while processing attachment 197:
 
-['foo/bar.html', 'bar/baz.html']
+foo/bar.html
+bar/baz.html
 
 Please file bugs against the tests.  The commit-queue is continuing to process your patch.