Changeset 69984 in webkit

Timestamp:

Oct 18, 2010 12:33:58 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-10-18 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by Darin Adler.

Missing support for document.createEvent("OrientationEvent")
​https://bugs.webkit.org/show_bug.cgi?id=32492

Add support for document.createEvent("OrientationEvent") to help unit testing of
onOrientationChange event.

• fast/dom/DeviceOrientation/create-event-onorientationchange-expected.txt: Added.
• fast/dom/DeviceOrientation/create-event-onorientationchange.html: Added.
• fast/dom/DeviceOrientation/script-tests/create-event-onorientationchange.js: Added.

2010-10-18 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by Darin Adler.

Missing support for document.createEvent("OrientationEvent")
​https://bugs.webkit.org/show_bug.cgi?id=32492

Add support for document.createEvent("OrientationEvent") to help unit testing of
onOrientationChange event.

Test: fast/dom/DeviceOrientation/create-event-onorientationchange.html

• dom/Document.cpp: (WebCore::Document::createEvent):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/DeviceOrientation/create-event-onorientationchange-expected.txt (added)
• LayoutTests/fast/dom/DeviceOrientation/create-event-onorientationchange.html (added)
• LayoutTests/fast/dom/DeviceOrientation/script-tests/create-event-onorientationchange.js (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/Document.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-10-18  Yongjun Zhang  <yongjun_zhang@apple.com>
+
+        Reviewed by Darin Adler.
+
+        Missing support for document.createEvent("OrientationEvent")
+        https://bugs.webkit.org/show_bug.cgi?id=32492
+
+        Add support for document.createEvent("OrientationEvent") to help unit testing of
+        onOrientationChange event.
+
+        * fast/dom/DeviceOrientation/create-event-onorientationchange-expected.txt: Added.
+        * fast/dom/DeviceOrientation/create-event-onorientationchange.html: Added.
+        * fast/dom/DeviceOrientation/script-tests/create-event-onorientationchange.js: Added.
+
 2010-10-18  Jeremy Orlow  <jorlow@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-18  Yongjun Zhang  <yongjun_zhang@apple.com>
+
+        Reviewed by Darin Adler.
+
+        Missing support for document.createEvent("OrientationEvent")
+        https://bugs.webkit.org/show_bug.cgi?id=32492
+
+        Add support for document.createEvent("OrientationEvent") to help unit testing of
+        onOrientationChange event.
+
+        Test: fast/dom/DeviceOrientation/create-event-onorientationchange.html
+
+        * dom/Document.cpp:
+        (WebCore::Document::createEvent):
+
 2010-10-18  Jeremy Orlow  <jorlow@chromium.org>
 

trunk/WebCore/dom/Document.cpp

@@ -3464 +3464 @@
         event = DeviceOrientationEvent::create();
 #endif
+#if ENABLE(ORIENTATION_EVENTS)
+    else if (eventType == "OrientationEvent")
+        event = Event::create();
+#endif
     if (event)
         return event.release();