Changeset 70027 in webkit

Timestamp:

Oct 18, 2010 10:33:57 PM (14 years ago)

Author:

tkent@chromium.org

Message:

2010-10-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Should not save state of a detached form control.
​https://bugs.webkit.org/show_bug.cgi?id=47811

• fast/forms/state-save-of-detached-control-expected.txt: Added.
• fast/forms/state-save-of-detached-control.html: Added.

2010-10-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Should not save state of a detached form control.
​https://bugs.webkit.org/show_bug.cgi?id=47811

Test: fast/forms/state-save-of-detached-control.html

• html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): If the node is detached, don't save the state.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/state-save-of-detached-control-expected.txt (added)
• LayoutTests/fast/forms/state-save-of-detached-control.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLFormControlElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-10-18  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Should not save state of a detached form control.
+        https://bugs.webkit.org/show_bug.cgi?id=47811
+
+        * fast/forms/state-save-of-detached-control-expected.txt: Added.
+        * fast/forms/state-save-of-detached-control.html: Added.
+
 2010-10-18  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-18  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Should not save state of a detached form control.
+        https://bugs.webkit.org/show_bug.cgi?id=47811
+
+        Test: fast/forms/state-save-of-detached-control.html
+
+        * html/HTMLFormControlElement.cpp:
+        (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState):
+          If the node is detached, don't save the state.
+
 2010-10-18  Xan Lopez  <xlopez@igalia.com>
 

trunk/WebCore/html/HTMLFormControlElement.cpp

@@ -441 +441 @@
 {
     // We don't save/restore control state in a form with autocomplete=off.
-    return autoComplete();
+    return attached() && autoComplete();
 }