Changeset 70064 in webkit


Ignore:
Timestamp:
Oct 19, 2010 9:43:57 AM (14 years ago)
Author:
tony@chromium.org
Message:

2010-10-19 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] DumpRenderTree shouldn't put '.' in include path
​https://bugs.webkit.org/show_bug.cgi?id=47877

  • WebKit.gyp: Replace '.' with <(chromium_src_dir) and add public

2010-10-19 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] DumpRenderTree shouldn't put '.' in include path
​https://bugs.webkit.org/show_bug.cgi?id=47877

Fix include paths.

  • DumpRenderTree/chromium/AccessibilityController.cpp:
  • DumpRenderTree/chromium/AccessibilityUIElement.cpp:
  • DumpRenderTree/chromium/AccessibilityUIElement.h:
  • DumpRenderTree/chromium/CppBoundClass.cpp:
  • DumpRenderTree/chromium/CppVariant.cpp:
  • DumpRenderTree/chromium/CppVariant.h:
  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp:
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
  • DumpRenderTree/chromium/EventSender.cpp:
  • DumpRenderTree/chromium/EventSender.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp:
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/MockSpellCheck.cpp:
  • DumpRenderTree/chromium/NotificationPresenter.cpp:
  • DumpRenderTree/chromium/NotificationPresenter.h:
  • DumpRenderTree/chromium/PlainTextController.cpp:
  • DumpRenderTree/chromium/Task.cpp:
  • DumpRenderTree/chromium/TestNavigationController.h:
  • DumpRenderTree/chromium/TestShell.cpp:
  • DumpRenderTree/chromium/TestWebWorker.h:
  • DumpRenderTree/chromium/TextInputController.cpp:
  • DumpRenderTree/chromium/WebPreferences.cpp:
  • DumpRenderTree/chromium/WebPreferences.h:
  • DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
  • DumpRenderTree/chromium/WebThemeEngineDRT.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
Location:
trunk
Files:
33 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKit/chromium/ChangeLog

    r69996 r70064  
     12010-10-19  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        [chromium] DumpRenderTree shouldn't put '.' in include path
     6        https://bugs.webkit.org/show_bug.cgi?id=47877
     7
     8        * WebKit.gyp: Replace '.' with <(chromium_src_dir) and add public
     9
    1102010-10-18  Adrienne Walker  <enne@google.com>
    211

  • trunk/WebKit/chromium/WebKit.gyp

    r69870 r70064  
    830830            ],
    831831            'include_dirs': [
    832                 '.',
     832                '<(chromium_src_dir)',
     833                'public',
    833834                '../../JavaScriptCore',
    834835                '../../JavaScriptCore/wtf', # wtf/text/*.h refers headers in wtf/ without wtf/.

  • trunk/WebKitTools/ChangeLog

    r70062 r70064  
     12010-10-19  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        [chromium] DumpRenderTree shouldn't put '.' in include path
     6        https://bugs.webkit.org/show_bug.cgi?id=47877
     7
     8        Fix include paths.
     9
     10        * DumpRenderTree/chromium/AccessibilityController.cpp:
     11        * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
     12        * DumpRenderTree/chromium/AccessibilityUIElement.h:
     13        * DumpRenderTree/chromium/CppBoundClass.cpp:
     14        * DumpRenderTree/chromium/CppVariant.cpp:
     15        * DumpRenderTree/chromium/CppVariant.h:
     16        * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
     17        * DumpRenderTree/chromium/DRTDevToolsAgent.h:
     18        * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
     19        * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
     20        * DumpRenderTree/chromium/DRTDevToolsClient.h:
     21        * DumpRenderTree/chromium/EventSender.cpp:
     22        * DumpRenderTree/chromium/EventSender.h:
     23        * DumpRenderTree/chromium/LayoutTestController.cpp:
     24        * DumpRenderTree/chromium/LayoutTestController.h:
     25        * DumpRenderTree/chromium/MockSpellCheck.cpp:
     26        * DumpRenderTree/chromium/NotificationPresenter.cpp:
     27        * DumpRenderTree/chromium/NotificationPresenter.h:
     28        * DumpRenderTree/chromium/PlainTextController.cpp:
     29        * DumpRenderTree/chromium/Task.cpp:
     30        * DumpRenderTree/chromium/TestNavigationController.h:
     31        * DumpRenderTree/chromium/TestShell.cpp:
     32        * DumpRenderTree/chromium/TestWebWorker.h:
     33        * DumpRenderTree/chromium/TextInputController.cpp:
     34        * DumpRenderTree/chromium/WebPreferences.cpp:
     35        * DumpRenderTree/chromium/WebPreferences.h:
     36        * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
     37        * DumpRenderTree/chromium/WebThemeEngineDRT.h:
     38        * DumpRenderTree/chromium/WebViewHost.cpp:
     39        * DumpRenderTree/chromium/WebViewHost.h:
     40
    1412010-10-19  Sam Weinig  <sam@webkit.org>
    242

  • trunk/WebKitTools/DumpRenderTree/chromium/AccessibilityController.cpp

    r66305 r70064  
    3333
    3434#include "TestShell.h"
    35 #include "public/WebAccessibilityCache.h"
    36 #include "public/WebAccessibilityObject.h"
    37 #include "public/WebFrame.h"
    38 #include "public/WebString.h"
    39 #include "public/WebView.h"
     35#include "WebAccessibilityCache.h"
     36#include "WebAccessibilityObject.h"
     37#include "WebFrame.h"
     38#include "WebString.h"
     39#include "WebView.h"
    4040
    4141using namespace WebKit;

  • trunk/WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp

    r55655 r70064  
    3232#include "AccessibilityUIElement.h"
    3333
    34 #include "public/WebAccessibilityObject.h"
    35 #include "public/WebCString.h"
    36 #include "public/WebString.h"
     34#include "WebAccessibilityObject.h"
     35#include "WebCString.h"
     36#include "WebString.h"
    3737#include <wtf/Assertions.h>
    3838

  • trunk/WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.h

    r55655 r70064  
    3333
    3434#include "CppBoundClass.h"
    35 #include "public/WebAccessibilityObject.h"
     35#include "WebAccessibilityObject.h"
    3636#include <wtf/Vector.h>
    3737

  • trunk/WebKitTools/DumpRenderTree/chromium/CppBoundClass.cpp

    r55563 r70064  
    4343#include "CppBoundClass.h"
    4444
    45 #include "public/WebBindings.h"
    46 #include "public/WebFrame.h"
    47 #include "public/WebString.h"
     45#include "WebBindings.h"
     46#include "WebFrame.h"
     47#include "WebString.h"
    4848#include <wtf/Assertions.h>
    4949#include <wtf/OwnPtr.h>

  • trunk/WebKitTools/DumpRenderTree/chromium/CppVariant.cpp

    r57188 r70064  
    3232#include "CppVariant.h"
    3333
    34 #include "public/WebBindings.h"
     34#include "WebBindings.h"
    3535#include <limits>
    3636#include <wtf/Assertions.h>

  • trunk/WebKitTools/DumpRenderTree/chromium/CppVariant.h

    r64530 r70064  
    4343#define CppVariant_h
    4444
    45 #include "public/WebBindings.h"
     45#include "WebBindings.h"
    4646#include "webkit/support/webkit_support.h"
    4747#include <string>

  • trunk/WebKitTools/DumpRenderTree/chromium/DRTDevToolsAgent.cpp

    r66811 r70064  
    3535#include "DRTDevToolsClient.h"
    3636
    37 #include "public/WebCString.h"
    38 #include "public/WebDevToolsAgent.h"
    39 #include "public/WebString.h"
    40 #include "public/WebView.h"
     37#include "WebCString.h"
     38#include "WebDevToolsAgent.h"
     39#include "WebString.h"
     40#include "WebView.h"
    4141#include "webkit/support/webkit_support.h"
    4242

  • trunk/WebKitTools/DumpRenderTree/chromium/DRTDevToolsAgent.h

    r66811 r70064  
    3434#include "DRTDevToolsCallArgs.h"
    3535#include "Task.h"
    36 #include "public/WebDevToolsAgentClient.h"
     36#include "WebDevToolsAgentClient.h"
    3737#include <wtf/HashMap.h>
    3838#include <wtf/Noncopyable.h>

  • trunk/WebKitTools/DumpRenderTree/chromium/DRTDevToolsCallArgs.h

    r64534 r70064  
    3232#define DRTDevToolsCallArgs_h
    3333
    34 #include "public/WebString.h"
     34#include "WebString.h"
    3535#include <wtf/Assertions.h>
    3636

  • trunk/WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.cpp

    r68700 r70064  
    3535#include "DRTDevToolsCallArgs.h"
    3636
    37 #include "public/WebDevToolsAgent.h"
    38 #include "public/WebDevToolsFrontend.h"
    39 #include "public/WebFrame.h"
    40 #include "public/WebScriptSource.h"
    41 #include "public/WebString.h"
    42 #include "public/WebView.h"
     37#include "WebDevToolsAgent.h"
     38#include "WebDevToolsFrontend.h"
     39#include "WebFrame.h"
     40#include "WebScriptSource.h"
     41#include "WebString.h"
     42#include "WebView.h"
    4343#include "webkit/support/webkit_support.h"
    4444

  • trunk/WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.h

    r66701 r70064  
    3434#include "DRTDevToolsCallArgs.h"
    3535#include "Task.h"
    36 #include "public/WebDevToolsFrontendClient.h"
     36#include "WebDevToolsFrontendClient.h"
    3737#include <wtf/Noncopyable.h>
    3838#include <wtf/OwnPtr.h>

  • trunk/WebKitTools/DumpRenderTree/chromium/EventSender.cpp

    r69346 r70064  
    4545
    4646#include "TestShell.h"
    47 #include "public/WebDragData.h"
    48 #include "public/WebDragOperation.h"
    49 #include "public/WebPoint.h"
    50 #include "public/WebString.h"
    51 #include "public/WebTouchPoint.h"
    52 #include "public/WebView.h"
     47#include "WebDragData.h"
     48#include "WebDragOperation.h"
     49#include "WebPoint.h"
     50#include "WebString.h"
     51#include "WebTouchPoint.h"
     52#include "WebView.h"
    5353#include "webkit/support/webkit_support.h"
    5454#include <wtf/Deque.h>
    … …  
    5656
    5757#if OS(WINDOWS)
    58 #include "public/win/WebInputEventFactory.h"
     58#include "win/WebInputEventFactory.h"
    5959#endif
    6060

  • trunk/WebKitTools/DumpRenderTree/chromium/EventSender.h

    r66701 r70064  
    4040#include "CppBoundClass.h"
    4141#include "Task.h"
    42 #include "public/WebDragOperation.h"
    43 #include "public/WebInputEvent.h"
    44 #include "public/WebPoint.h"
     42#include "WebDragOperation.h"
     43#include "WebInputEvent.h"
     44#include "WebPoint.h"
    4545
    4646class TestShell;

  • trunk/WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp

    r69952 r70064  
    3535#include "DRTDevToolsAgent.h"
    3636#include "TestShell.h"
     37#include "WebAnimationController.h"
     38#include "WebBindings.h"
     39#include "WebConsoleMessage.h"
     40#include "WebData.h"
     41#include "WebDeviceOrientation.h"
     42#include "WebDeviceOrientationClientMock.h"
     43#include "WebDocument.h"
     44#include "WebElement.h"
     45#include "WebFrame.h"
     46#include "WebGeolocationServiceMock.h"
     47#include "WebInputElement.h"
     48#include "WebKit.h"
     49#include "WebNotificationPresenter.h"
     50#include "WebScriptSource.h"
     51#include "WebSecurityPolicy.h"
     52#include "WebSettings.h"
     53#include "WebSize.h"
     54#include "WebSpeechInputControllerMock.h"
     55#include "WebURL.h"
     56#include "WebView.h"
    3757#include "WebViewHost.h"
    38 #include "public/WebAnimationController.h"
    39 #include "public/WebBindings.h"
    40 #include "public/WebConsoleMessage.h"
    41 #include "public/WebData.h"
    42 #include "public/WebDeviceOrientation.h"
    43 #include "public/WebDeviceOrientationClientMock.h"
    44 #include "public/WebDocument.h"
    45 #include "public/WebElement.h"
    46 #include "public/WebFrame.h"
    47 #include "public/WebGeolocationServiceMock.h"
    48 #include "public/WebInputElement.h"
    49 #include "public/WebKit.h"
    50 #include "public/WebNotificationPresenter.h"
    51 #include "public/WebScriptSource.h"
    52 #include "public/WebSecurityPolicy.h"
    53 #include "public/WebSettings.h"
    54 #include "public/WebSize.h"
    55 #include "public/WebSpeechInputControllerMock.h"
    56 #include "public/WebURL.h"
    57 #include "public/WebView.h"
    5858#include "webkit/support/webkit_support.h"
    5959#include <algorithm>

  • trunk/WebKitTools/DumpRenderTree/chromium/LayoutTestController.h

    r69952 r70064  
    4444#include "CppBoundClass.h"
    4545#include "Task.h"
    46 #include "public/WebString.h"
    47 #include "public/WebURL.h"
     46#include "WebString.h"
     47#include "WebURL.h"
    4848#include <wtf/Deque.h>
    4949#include <wtf/OwnPtr.h>

  • trunk/WebKitTools/DumpRenderTree/chromium/MockSpellCheck.cpp

    r65092 r70064  
    3232#include "MockSpellCheck.h"
    3333
     34#include "WebString.h"
    3435#include <wtf/ASCIICType.h>
    3536#include <wtf/Assertions.h>
    3637#include <wtf/text/WTFString.h>
    37 
    38 #include "public/WebString.h"
    3938
    4039using namespace WebKit;

  • trunk/WebKitTools/DumpRenderTree/chromium/NotificationPresenter.cpp

    r66701 r70064  
    3232#include "NotificationPresenter.h"
    3333
     34#include "WebKit.h"
     35#include "WebKitClient.h"
     36#include "WebNotification.h"
     37#include "WebNotificationPermissionCallback.h"
     38#include "WebSecurityOrigin.h"
     39#include "WebString.h"
     40#include "WebURL.h"
    3441#include "googleurl/src/gurl.h"
    35 #include "public/WebKit.h"
    36 #include "public/WebKitClient.h"
    37 #include "public/WebNotification.h"
    38 #include "public/WebNotificationPermissionCallback.h"
    39 #include "public/WebSecurityOrigin.h"
    40 #include "public/WebString.h"
    41 #include "public/WebURL.h"
    4242#include <wtf/text/CString.h>
    4343#include <wtf/text/WTFString.h>

  • trunk/WebKitTools/DumpRenderTree/chromium/NotificationPresenter.h

    r66470 r70064  
    3232#define NotificationPresenter_h
    3333
    34 #include "public/WebNotification.h"
    35 #include "public/WebNotificationPresenter.h"
     34#include "WebNotification.h"
     35#include "WebNotificationPresenter.h"
    3636#include <wtf/HashMap.h>
    3737#include <wtf/HashSet.h>

  • trunk/WebKitTools/DumpRenderTree/chromium/PlainTextController.cpp

    r55712 r70064  
    3434
    3535#include "TestShell.h"
    36 #include "public/WebBindings.h"
    37 #include "public/WebRange.h"
    38 #include "public/WebString.h"
     36#include "WebBindings.h"
     37#include "WebRange.h"
     38#include "WebString.h"
    3939
    4040using namespace WebKit;

  • trunk/WebKitTools/DumpRenderTree/chromium/Task.cpp

    r66701 r70064  
    3232#include "Task.h"
    3333
    34 #include "public/WebKit.h"
    35 #include "public/WebKitClient.h"
     34#include "WebKit.h"
     35#include "WebKitClient.h"
    3636#include "webkit/support/webkit_support.h"
    3737

  • trunk/WebKitTools/DumpRenderTree/chromium/TestNavigationController.h

    r64710 r70064  
    3232#define TestNavigationController_h
    3333
    34 #include "public/WebDataSource.h"
    35 #include "public/WebHistoryItem.h"
    36 #include "public/WebString.h"
    37 #include "public/WebURL.h"
     34#include "WebDataSource.h"
     35#include "WebHistoryItem.h"
     36#include "WebString.h"
     37#include "WebURL.h"
    3838#include "webkit/support/webkit_support.h"
    3939#include <string>

  • trunk/WebKitTools/DumpRenderTree/chromium/TestShell.cpp

    r68801 r70064  
    3535#include "DRTDevToolsClient.h"
    3636#include "LayoutTestController.h"
     37#include "WebDataSource.h"
     38#include "WebDocument.h"
     39#include "WebElement.h"
     40#include "WebFrame.h"
     41#include "WebHistoryItem.h"
     42#include "WebKit.h"
     43#include "WebRuntimeFeatures.h"
     44#include "WebScriptController.h"
     45#include "WebSettings.h"
     46#include "WebSize.h"
     47#include "WebSpeechInputControllerMock.h"
     48#include "WebString.h"
     49#include "WebURLRequest.h"
     50#include "WebURLResponse.h"
     51#include "WebView.h"
    3752#include "WebViewHost.h"
    38 #include "public/WebDataSource.h"
    39 #include "public/WebDocument.h"
    40 #include "public/WebElement.h"
    41 #include "public/WebFrame.h"
    42 #include "public/WebHistoryItem.h"
    43 #include "public/WebKit.h"
    44 #include "public/WebRuntimeFeatures.h"
    45 #include "public/WebScriptController.h"
    46 #include "public/WebSettings.h"
    47 #include "public/WebSize.h"
    48 #include "public/WebSpeechInputControllerMock.h"
    49 #include "public/WebString.h"
    50 #include "public/WebURLRequest.h"
    51 #include "public/WebURLResponse.h"
    52 #include "public/WebView.h"
    5353#include "skia/ext/bitmap_platform_device.h"
    5454#include "skia/ext/platform_canvas.h"

  • trunk/WebKitTools/DumpRenderTree/chromium/TestWebWorker.h

    r59555 r70064  
    3232#define TestWebWorker_h
    3333
    34 #include "public/WebMessagePortChannel.h"
    35 #include "public/WebWorker.h"
    36 #include "public/WebWorkerClient.h"
     34#include "WebMessagePortChannel.h"
     35#include "WebWorker.h"
     36#include "WebWorkerClient.h"
    3737#include <wtf/RefCounted.h>
    3838

  • trunk/WebKitTools/DumpRenderTree/chromium/TextInputController.cpp

    r69952 r70064  
    3333
    3434#include "TestShell.h"
    35 #include "public/WebBindings.h"
    36 #include "public/WebFrame.h"
    37 #include "public/WebRange.h"
    38 #include "public/WebString.h"
    39 #include "public/WebView.h"
     35#include "WebBindings.h"
     36#include "WebFrame.h"
     37#include "WebRange.h"
     38#include "WebString.h"
     39#include "WebView.h"
    4040#include <wtf/StringExtras.h>
    4141#include <string>

  • trunk/WebKitTools/DumpRenderTree/chromium/WebPreferences.cpp

    r68801 r70064  
    3232#include "WebPreferences.h"
    3333
    34 #include "public/WebView.h"
     34#include "WebView.h"
    3535
    3636using namespace WebKit;

  • trunk/WebKitTools/DumpRenderTree/chromium/WebPreferences.h

    r68801 r70064  
    3232#define WebPerferences_h
    3333
    34 #include "public/WebSettings.h"
    35 #include "public/WebString.h"
    36 #include "public/WebURL.h"
     34#include "WebSettings.h"
     35#include "WebString.h"
     36#include "WebURL.h"
    3737
    3838namespace WebKit {

  • trunk/WebKitTools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp

    r63589 r70064  
    3232#include "WebThemeEngineDRT.h"
    3333
     34#include "WebRect.h"
    3435#include "WebThemeControlDRT.h"
    35 #include "public/WebRect.h"
    3636#include "third_party/skia/include/core/SkRect.h"
    3737

  • trunk/WebKitTools/DumpRenderTree/chromium/WebThemeEngineDRT.h

    r69591 r70064  
    4848#define WebThemeEngineDRT_h
    4949
    50 #include "public/win/WebThemeEngine.h"
     50#include "win/WebThemeEngine.h"
    5151#include <wtf/Noncopyable.h>
    5252

  • trunk/WebKitTools/DumpRenderTree/chromium/WebViewHost.cpp

    r69673 r70064  
    3636#include "TestShell.h"
    3737#include "TestWebWorker.h"
    38 #include "public/WebCString.h"
    39 #include "public/WebConsoleMessage.h"
    40 #include "public/WebContextMenuData.h"
    41 #include "public/WebDataSource.h"
    42 #include "public/WebDragData.h"
    43 #include "public/WebElement.h"
    44 #include "public/WebFrame.h"
    45 #include "public/WebGeolocationServiceMock.h"
    46 #include "public/WebHistoryItem.h"
    47 #include "public/WebNode.h"
    48 #include "public/WebRange.h"
    49 #include "public/WebRect.h"
    50 #include "public/WebScreenInfo.h"
    51 #include "public/WebSize.h"
    52 #include "public/WebStorageNamespace.h"
    53 #include "public/WebURLRequest.h"
    54 #include "public/WebURLResponse.h"
    55 #include "public/WebView.h"
    56 #include "public/WebWindowFeatures.h"
     38#include "WebCString.h"
     39#include "WebConsoleMessage.h"
     40#include "WebContextMenuData.h"
     41#include "WebDataSource.h"
     42#include "WebDragData.h"
     43#include "WebElement.h"
     44#include "WebFrame.h"
     45#include "WebGeolocationServiceMock.h"
     46#include "WebHistoryItem.h"
     47#include "WebNode.h"
     48#include "WebRange.h"
     49#include "WebRect.h"
     50#include "WebScreenInfo.h"
     51#include "WebSize.h"
     52#include "WebStorageNamespace.h"
     53#include "WebURLRequest.h"
     54#include "WebURLResponse.h"
     55#include "WebView.h"
     56#include "WebWindowFeatures.h"
    5757#include "skia/ext/platform_canvas.h"
    5858#include "webkit/support/webkit_support.h"

  • trunk/WebKitTools/DumpRenderTree/chromium/WebViewHost.h

    r69673 r70064  
    3434#include "MockSpellCheck.h"
    3535#include "TestNavigationController.h"
    36 #include "public/WebAccessibilityNotification.h"
    37 #include "public/WebCursorInfo.h"
    38 #include "public/WebFrameClient.h"
    39 #include "public/WebViewClient.h"
     36#include "WebAccessibilityNotification.h"
     37#include "WebCursorInfo.h"
     38#include "WebFrameClient.h"
     39#include "WebViewClient.h"
    4040#include <wtf/HashMap.h>
    4141#include <wtf/HashSet.h>
Note: See TracChangeset for help on using the changeset viewer.