Changeset 70228 in webkit

Timestamp:

Oct 21, 2010 4:26:57 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-10-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Don't CC authors of flaky tests
​https://bugs.webkit.org/show_bug.cgi?id=48038

Some authors found this too annoying. We'll look for another way to
close the flaky test loop.

• Scripts/webkitpy/tool/commands/queues.py:
• Scripts/webkitpy/tool/commands/queues_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/commands/queues.py (modified) (2 diffs)
• Scripts/webkitpy/tool/commands/queues_unittest.py (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-10-21  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Don't CC authors of flaky tests
+        https://bugs.webkit.org/show_bug.cgi?id=48038
+
+        Some authors found this too annoying.  We'll look for another way to
+        close the flaky test loop.
+
+        * Scripts/webkitpy/tool/commands/queues.py:
+        * Scripts/webkitpy/tool/commands/queues_unittest.py:
+
 2010-10-21  Eric Seidel  <eric@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/tool/commands/queues.py

@@ -48 +48 @@
 from webkitpy.tool.bot.feeders import CommitQueueFeeder, EWSFeeder
 from webkitpy.tool.bot.queueengine import QueueEngine, QueueEngineDelegate
-from webkitpy.tool.grammar import pluralize
+from webkitpy.tool.grammar import pluralize, join_with_separators
 from webkitpy.tool.multicommandtool import Command, TryAgain
 
@@ -302 +302 @@
     def report_flaky_tests(self, patch, flaky_tests):
         authors = self._author_emails_for_tests(flaky_tests)
-        cc_explaination = "  The author(s) of the test(s) have been CCed on this bug." if authors else ""
-        message = "The %s encountered the following flaky tests while processing attachment %s:\n\n%s\n\nPlease file bugs against the tests.%s  The commit-queue is continuing to process your patch." % (self.name, patch.id(), "\n".join(flaky_tests), cc_explaination)
-        self._tool.bugs.post_comment_to_bug(patch.bug_id(), message, cc=authors)
+        author_nag = "  The author(s) of the test(s) are %s." % join_with_separators(authors) if authors else ""
+        message = "The %s encountered the following flaky tests while processing attachment %s:\n\n%s\n\nPlease file bugs against the tests.%s  The commit-queue is continuing to process your patch." % (self.name, patch.id(), "\n".join(flaky_tests), author_nag)
+        self._tool.bugs.post_comment_to_bug(patch.bug_id(), message)
 
     # StepSequenceErrorHandler methods

trunk/WebKitTools/Scripts/webkitpy/tool/commands/queues_unittest.py

@@ -313 +313 @@
         queue = CommitQueue()
         queue.bind_to_tool(MockTool())
-        expected_stderr = """MOCK bug comment: bug_id=142, cc=['abarth@webkit.org']
+        expected_stderr = """MOCK bug comment: bug_id=142, cc=None
 --- Begin comment ---
 The commit-queue encountered the following flaky tests while processing attachment 197:
@@ -320 +320 @@
 bar/baz.html
 
-Please file bugs against the tests.  The author(s) of the test(s) have been CCed on this bug.  The commit-queue is continuing to process your patch.
+Please file bugs against the tests.  The author(s) of the test(s) are abarth@webkit.org.  The commit-queue is continuing to process your patch.
 --- End comment ---