Changeset 70262 in webkit

Timestamp:

Oct 21, 2010 1:31:17 PM (14 years ago)

Author:

noam.rosenthal@nokia.com

Message:

2010-10-21 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

[Qt] When doing rendering through tiling, it seems the tiles are not initialized before rendering
​https://bugs.webkit.org/show_bug.cgi?id=48070

No new tests. Auto-tests for Tiled Backing Store should be added, see bug 48082

• page/Frame.cpp: (WebCore::Frame::tiledBackingStoreBackgroundColor):
• page/Frame.h:
• platform/graphics/TiledBackingStoreClient.h:
• platform/graphics/qt/TileQt.cpp: (WebCore::Tile::updateBackBuffer):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Frame.cpp (modified) (1 diff)
• page/Frame.h (modified) (1 diff)
• platform/graphics/TiledBackingStoreClient.h (modified) (1 diff)
• platform/graphics/qt/TileQt.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-21  No'am Rosenthal  <noam.rosenthal@nokia.com>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] When doing rendering through tiling, it seems the tiles are not initialized before rendering
+        https://bugs.webkit.org/show_bug.cgi?id=48070
+
+        No new tests. Auto-tests for Tiled Backing Store should be added, see bug 48082
+
+        * page/Frame.cpp:
+        (WebCore::Frame::tiledBackingStoreBackgroundColor):
+        * page/Frame.h:
+        * platform/graphics/TiledBackingStoreClient.h:
+        * platform/graphics/qt/TileQt.cpp:
+        (WebCore::Tile::updateBackBuffer):
+
 2010-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/WebCore/page/Frame.cpp

@@ -880 +880 @@
     return m_page->chrome()->client()->visibleRectForTiledBackingStore();
 }
+
+Color Frame::tiledBackingStoreBackgroundColor() const
+{
+    if (!m_view)
+        return Color();
+    return m_view->baseBackgroundColor();
+}
 #endif
 

trunk/WebCore/page/Frame.h

@@ -238 +238 @@
         virtual IntRect tiledBackingStoreContentsRect();
         virtual IntRect tiledBackingStoreVisibleRect();
+        virtual Color tiledBackingStoreBackgroundColor() const;
 
         OwnPtr<TiledBackingStore> m_tiledBackingStore;

trunk/WebCore/platform/graphics/TiledBackingStoreClient.h

@@ -31 +31 @@
     virtual IntRect tiledBackingStoreContentsRect() = 0;
     virtual IntRect tiledBackingStoreVisibleRect() = 0;
+    virtual Color tiledBackingStoreBackgroundColor() const = 0;
 };
 

trunk/WebCore/platform/graphics/qt/TileQt.cpp

@@ -98 +98 @@
 
     if (!m_backBuffer) {
-        if (!m_buffer)
+        if (!m_buffer) {
             m_backBuffer = new QPixmap(m_backingStore->m_tileSize.width(), m_backingStore->m_tileSize.height());
-        else {
+            m_backBuffer->fill(m_backingStore->m_client->tiledBackingStoreBackgroundColor());
+        } else {
             // Currently all buffers are updated synchronously at the same time so there is no real need
             // to have separate back and front buffers. Just use the existing buffer.