Changeset 70327 in webkit


Ignore:
Timestamp:
Oct 22, 2010 1:06:20 PM (13 years ago)
Author:
abarth@webkit.org
Message:

2010-10-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

ASSERT while viewing Google C++ style guide
https://bugs.webkit.org/show_bug.cgi?id=48148

Make sure we don't hit an ASSERT when an XSLT outputs HTML.

  • fast/xsl/resources/to-html.xsl: Added.
  • fast/xsl/transform-to-html-expected.txt: Added.
  • fast/xsl/transform-to-html.xml: Added.

2010-10-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

ASSERT while viewing Google C++ style guide
https://bugs.webkit.org/show_bug.cgi?id=48148

This code used to stop the parser twice. Instead of reaching in an
trying to stop the parser manually, we now just let close() do the work
for us.

Test: fast/xsl/transform-to-html.xml

  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r70322 r70327  
     12010-10-22  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        ASSERT while viewing Google C++ style guide
     6        https://bugs.webkit.org/show_bug.cgi?id=48148
     7
     8        Make sure we don't hit an ASSERT when an XSLT outputs HTML.
     9
     10        * fast/xsl/resources/to-html.xsl: Added.
     11        * fast/xsl/transform-to-html-expected.txt: Added.
     12        * fast/xsl/transform-to-html.xml: Added.
     13
    1142010-10-22  Dimitri Glazkov  <dglazkov@chromium.org>
    215
  • trunk/WebCore/ChangeLog

    r70325 r70327  
     12010-10-22  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        ASSERT while viewing Google C++ style guide
     6        https://bugs.webkit.org/show_bug.cgi?id=48148
     7
     8        This code used to stop the parser twice.  Instead of reaching in an
     9        trying to stop the parser manually, we now just let close() do the work
     10        for us.
     11
     12        Test: fast/xsl/transform-to-html.xml
     13
     14        * xml/XSLTProcessor.cpp:
     15        (WebCore::XSLTProcessor::createDocumentFromSource):
     16
    1172010-10-22  Patrick Gansterer  <paroga@webkit.org>
    218
  • trunk/WebCore/xml/XSLTProcessor.cpp

    r66963 r70327  
    9191
    9292    result->write(documentSource);
    93     result->finishParsing();
    9493    result->close();
    9594
Note: See TracChangeset for help on using the changeset viewer.