Changeset 70359 in webkit


Ignore:
Timestamp:
Oct 22, 2010 3:51:39 PM (13 years ago)
Author:
andersca@apple.com
Message:

WebContext::ensureWebProcess shouldn't send multiple InitializeWebProcess messages.
https://bugs.webkit.org/show_bug.cgi?id=48158
<rdar://problem/8512572>

Reviewed by Sam Weinig.

If the web process was launching when another call to ensureWebProcess is sent, we
would end up sending another InitializeWebProcess message to it which would result
in assertions firing. Fix this by only checking for m_process, and not requiring a process
to be valid (which it won't be until it's finished launching).

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):

Location:
trunk/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit2/ChangeLog

    r70357 r70359  
     12010-10-22  Anders Carlsson  <andersca@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        WebContext::ensureWebProcess shouldn't send multiple InitializeWebProcess messages.
     6        https://bugs.webkit.org/show_bug.cgi?id=48158
     7        <rdar://problem/8512572>
     8
     9        If the web process was launching when another call to ensureWebProcess is sent, we
     10        would end up sending another InitializeWebProcess message to it which would result
     11        in assertions firing. Fix this by only checking for m_process, and not requiring a process
     12        to be valid (which it won't be until it's finished launching).
     13       
     14        * UIProcess/WebContext.cpp:
     15        (WebKit::WebContext::ensureWebProcess):
     16
    1172010-10-22  Anders Carlsson  <andersca@apple.com>
    218
  • trunk/WebKit2/UIProcess/WebContext.cpp

    r70357 r70359  
    142142void WebContext::ensureWebProcess()
    143143{
    144     if (hasValidProcess())
     144    if (m_process)
    145145        return;
    146146
Note: See TracChangeset for help on using the changeset viewer.