Changeset 70407 in webkit

Timestamp:

Oct 23, 2010 7:19:36 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-10-23 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

Remove unused method HTMLFrameElementBase::setNameAndOpenURLCallback()
​https://bugs.webkit.org/show_bug.cgi?id=48197

With the landing of the patch for bug #45365 in
changeset 67182 <​http://trac.webkit.org/changeset/67182>,
HTMLFrameElementBase::setNameAndOpenURLCallback() is not needed.
Therefore, we remove it.

Before changeset 67182, HTMLFrameElementBase::attach() set up a post-attach
callback to HTMLFrameElementBase::setNameAndOpenURLCallback(). Changeset 67182
removed this callback.

No functionality was changed. So, no new tests.

• html/HTMLFrameElementBase.cpp: Remove HTMLFrameElementBase::setNameAndOpenURLCallback().
• html/HTMLFrameElementBase.h: Ditto.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLFrameElementBase.cpp (modified) (1 diff)
• html/HTMLFrameElementBase.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-23  Daniel Bates  <dbates@rim.com>
+
+        Reviewed by Adam Barth.
+
+        Remove unused method HTMLFrameElementBase::setNameAndOpenURLCallback()
+        https://bugs.webkit.org/show_bug.cgi?id=48197
+
+        With the landing of the patch for bug #45365 in
+        changeset 67182 <http://trac.webkit.org/changeset/67182>, 
+        HTMLFrameElementBase::setNameAndOpenURLCallback() is not needed.
+        Therefore, we remove it.
+
+        Before changeset 67182, HTMLFrameElementBase::attach() set up a post-attach
+        callback to HTMLFrameElementBase::setNameAndOpenURLCallback(). Changeset 67182
+        removed this callback.
+
+        No functionality was changed. So, no new tests.
+
+        * html/HTMLFrameElementBase.cpp: Remove HTMLFrameElementBase::setNameAndOpenURLCallback().
+        * html/HTMLFrameElementBase.h: Ditto.
+
 2010-10-23  Xan Lopez  <xlopez@igalia.com>
 

trunk/WebCore/html/HTMLFrameElementBase.cpp

@@ -167 +167 @@
 }
 
-void HTMLFrameElementBase::setNameAndOpenURLCallback(Node* n)
-{
-    static_cast<HTMLFrameElementBase*>(n)->setNameAndOpenURL();
-}
-
 void HTMLFrameElementBase::updateOnReparenting()
 {

trunk/WebCore/html/HTMLFrameElementBase.h

@@ -71 +71 @@
     void openURL(bool lockHistory = true, bool lockBackForwardList = true);
 
-    static void setNameAndOpenURLCallback(Node*);
-
     AtomicString m_URL;
     AtomicString m_frameName;