Changeset 70414 in webkit

Timestamp:

Oct 24, 2010 9:12:44 AM (13 years ago)

Author:

Nikolas Zimmermann

Message:

2010-10-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dimitri Glazkov.

Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly
​https://bugs.webkit.org/show_bug.cgi?id=48179

Fix WebGL tests. Accept 'boolean' as valid numeric type in StrictTypeChecking mode.

• bindings/scripts/CodeGeneratorJS.pm:
• bindings/scripts/CodeGeneratorV8.pm:

2010-10-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dimitri Glazkov.

Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly
​https://bugs.webkit.org/show_bug.cgi?id=48179

It turns out the CodeGenerator changes are right, and the webgl tests have a problem, since StrictTypeChecking was enabled for numeric types.
When calling gl.bindAttribLocation() be sure to pass the second argument as integer, not as string.
Fixes all failing webgl tests on the snow leopard bot.

• fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
• fast/canvas/webgl/resources/webgl-test-utils.js: (WebGLTestUtils):
• fast/canvas/webgl/resources/webgl-test.js: (createProgram):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html (modified) (1 diff)
• LayoutTests/fast/canvas/webgl/resources/webgl-test-utils.js (modified) (1 diff)
• LayoutTests/fast/canvas/webgl/resources/webgl-test.js (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bindings/scripts/CodeGeneratorJS.pm (modified) (2 diffs)
• WebCore/bindings/scripts/CodeGeneratorV8.pm (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-10-24  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        Reviewed by Dimitri Glazkov.
+
+        Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly
+        https://bugs.webkit.org/show_bug.cgi?id=48179
+
+        It turns out the CodeGenerator changes are right, and the webgl tests have a problem, since StrictTypeChecking was enabled for numeric types.
+        When calling gl.bindAttribLocation() be sure to pass the second argument as integer, not as string.
+        Fixes all failing webgl tests on the snow leopard bot.
+
+        * fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
+        * fast/canvas/webgl/resources/webgl-test-utils.js:
+        (WebGLTestUtils):
+        * fast/canvas/webgl/resources/webgl-test.js:
+        (createProgram):
+
 2010-10-23  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html

@@ -80 +80 @@
     var attribs = [ "pos", "colorIn" ];
     for (var i in attribs)
-        gl.bindAttribLocation(gl.program, i, attribs[i]);
+        gl.bindAttribLocation(gl.program, parseInt(i), attribs[i]);
 
     // Link the program

trunk/LayoutTests/fast/canvas/webgl/resources/webgl-test-utils.js

@@ -569 +569 @@
   // Bind attributes
   for (var i in attribs) {
-    gl.bindAttribLocation (program, i, attribs[i]);
+    gl.bindAttribLocation (program, parseInt(i), attribs[i]);
   }
 

trunk/LayoutTests/fast/canvas/webgl/resources/webgl-test.js

@@ -188 +188 @@
     if (attribs) {
         for (var i in attribs) {
-            gl.bindAttribLocation (prog, i, attribs[i]);
+            gl.bindAttribLocation (prog, parseInt(i), attribs[i]);
   }
     }

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-24  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        Reviewed by Dimitri Glazkov.
+
+        Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly
+        https://bugs.webkit.org/show_bug.cgi?id=48179
+
+        Fix WebGL tests. Accept 'boolean' as valid numeric type in StrictTypeChecking mode.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        * bindings/scripts/CodeGeneratorV8.pm:
+
 2010-10-24  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -1823 +1823 @@
                                     push(@implContent, "    };\n");
                                 } elsif ($codeGenerator->IsNumericType($argType)) {
-                                    push(@implContent, "    if (!value.isUndefinedOrNull() && !value.isNumber()) {\n");
+                                    push(@implContent, "    if (!value.isUndefinedOrNull() && !value.isNumber() && !value.isBoolean()) {\n");
                                     push(@implContent, "        throwVMTypeError(exec);\n");
                                     push(@implContent, "        return;\n");
@@ -2086 +2086 @@
                                     push(@implContent, "        return throwVMTypeError(exec);\n");
                                 } elsif ($codeGenerator->IsNumericType($argType)) {
-                                    push(@implContent, "    if (exec->argumentCount() > $argsIndex && !${argValue}.isUndefinedOrNull() && !${argValue}.isNumber())\n");
+                                    push(@implContent, "    if (exec->argumentCount() > $argsIndex && !${argValue}.isUndefinedOrNull() && !${argValue}.isNumber() && !${argValue}.isBoolean())\n");
                                     push(@implContent, "        return throwVMTypeError(exec);\n");
                                 }

trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -954 +954 @@
             push(@implContentDecls, "    }\n");
         } elsif ($codeGenerator->IsNumericType($argType)) {
-            push(@implContentDecls, "    if (!isUndefinedOrNull(value) && !value->IsNumber()) {\n");
+            push(@implContentDecls, "    if (!isUndefinedOrNull(value) && !value->IsNumber() && !value->IsBoolean()) {\n");
             push(@implContentDecls, "        V8Proxy::throwTypeError();\n");
             push(@implContentDecls, "        return;\n");
@@ -1418 +1418 @@
                     push(@implContentDecls, "    }\n");
                 } elsif ($codeGenerator->IsNumericType($argType)) {
-                    push(@implContentDecls, "    if (args.Length() > $paramIndex && !isUndefinedOrNull($argValue) && !${argValue}->IsNumber()) {\n");
+                    push(@implContentDecls, "    if (args.Length() > $paramIndex && !isUndefinedOrNull($argValue) && !${argValue}->IsNumber() && !${argValue}->IsBoolean()) {\n");
                     push(@implContentDecls, "        V8Proxy::throwTypeError();\n");
                     push(@implContentDecls, "        return notHandledByInterceptor();\n");