Changeset 70557 in webkit

Timestamp:

Oct 26, 2010 12:47:41 PM (13 years ago)

Author:

jocelyn.turcotte@nokia.com

Message:

2010-10-26 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix an assert with QtPixmapInstance creation.
​https://bugs.webkit.org/show_bug.cgi?id=48323

This places the newly refcounted QtPixmapInstance in a RefPtr
to prevent an assert on the first ref() call.

• bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bridge/qt/qt_pixmapruntime.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Qt] Fix an assert with QtPixmapInstance creation.
+        https://bugs.webkit.org/show_bug.cgi?id=48323
+
+        This places the newly refcounted QtPixmapInstance in a RefPtr
+        to prevent an assert on the first ref() call.
+
+        * bridge/qt/qt_pixmapruntime.cpp:
+        (JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject):
+
 2010-10-26  Kenichi Ishibashi  <bashi@google.com>
 

trunk/WebCore/bridge/qt/qt_pixmapruntime.cpp

@@ -356 +356 @@
 {
     JSLock lock(SilenceAssertionsOnly);
-    QtPixmapInstance* instance = new QtPixmapInstance(root, data);
+    RefPtr<QtPixmapInstance> instance = adoptRef(new QtPixmapInstance(root, data));
     return instance->createRuntimeObject(exec);
 }