Changeset 70572 in webkit
- Timestamp:
- Oct 26, 2010 1:56:40 PM (13 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r70570 r70572 1 2010-10-26 Adam Roben <aroben@apple.com> 2 3 Clear up confusion between "3D rendering" and "accelerated compositing" 4 5 WebKit has no software-based 3D rendering implementation, so 3D 6 rendering can only be enabled when accelerated compositing is. But DRT 7 was falsely reporting that 3D rendering was available on machines that 8 don't support accelerated compositing, leading to much confusion. 9 10 Reviewed by Darin Adler. 11 12 Fixes <http://webkit.org/b/48370> REGRESSION (r70540): Many 13 transforms/3d tests are failing on the XP bots 14 15 * DumpRenderTree/win/DumpRenderTree.cpp: 16 (main): When ENABLE(3D_RENDERING) is turned on, only report that 3D 17 rendering is available when acclerated compositing is also available. 18 19 * Scripts/old-run-webkit-tests: Skip tests that use the 20 -webkit-transform-3d media query when 3D rendering is disabled, 21 rather than when accelerated compositing is disabled. 22 1 23 2010-10-26 Eric Seidel <eric@webkit.org> 2 24 -
trunk/WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp
r70291 r70572 1308 1308 BOOL acceleratedCompositingAvailable; 1309 1309 standardPreferences->acceleratedCompositingEnabled(&acceleratedCompositingAvailable); 1310 BOOL threeDRenderingAvailable = 1310 1311 1311 #if ENABLE(3D_RENDERING) 1312 true; 1312 // In theory, we could have a software-based 3D rendering implementation that we use when 1313 // hardware-acceleration is not available. But we don't have any such software 1314 // implementation, so 3D rendering is only available when hardware-acceleration is. 1315 BOOL threeDRenderingAvailable = acceleratedCompositingAvailable; 1313 1316 #else 1314 false;1317 BOOL threeDRenderingAvailable = FALSE; 1315 1318 #endif 1316 1319 -
trunk/WebKitTools/Scripts/old-run-webkit-tests
r70528 r70572 529 529 $ignoredDirectories{'compositing'} = 1; 530 530 531 # These tests use the -webkit-transform-3d media query, which depends on532 # accelerated compositing support.533 $ignoredFiles{'fast/media/mq-transform-02.html'} = 1;534 $ignoredFiles{'fast/media/mq-transform-03.html'} = 1;535 536 531 # This test has slightly different floating-point rounding when accelerated 537 532 # compositing is enabled. … … 554 549 $ignoredDirectories{'animations/3d'} = 1; 555 550 $ignoredDirectories{'transforms/3d'} = 1; 551 552 # These tests use the -webkit-transform-3d media query. 553 $ignoredFiles{'fast/media/mq-transform-02.html'} = 1; 554 $ignoredFiles{'fast/media/mq-transform-03.html'} = 1; 556 555 } 557 556
Note: See TracChangeset
for help on using the changeset viewer.