Changeset 70609 in webkit
- Timestamp:
- Oct 26, 2010 10:22:23 PM (13 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 10 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/ChangeLog
r70418 r70609 1 2010-10-26 Antonio Gomes <agomes@rim.com> 2 3 Reviewed by Martin Robinson. 4 5 [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea) 6 https://bugs.webkit.org/show_bug.cgi?id=48199 7 8 * GNUmakefile.am: Added WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp|h to GTK+'s build system; 9 * autotools/symbols.filter: Added DumpRenderTreeSupportGtk symbols to symbols.filter so they do not get 10 filtered and get visible by DRT. 11 1 12 2010-10-24 Anders Bakken <agbakken@gmail.com> 2 13 -
trunk/GNUmakefile.am
r69858 r70609 363 363 WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp \ 364 364 WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h \ 365 WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp \ 366 WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h \ 365 367 WebKit/gtk/WebCoreSupport/FrameNetworkingContextGtk.h \ 366 368 WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp \ -
trunk/LayoutTests/ChangeLog
r70598 r70609 1 2010-10-26 Antonio Gomes <agomes@rim.com> 2 3 Reviewed by Martin Robinson. 4 5 [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea) 6 https://bugs.webkit.org/show_bug.cgi?id=48199 7 8 * platform/gtk/Skipped: Unskiped fast/events/tab-focus-anchor.html. 9 1 10 2010-10-26 MORITA Hajime <morrita@google.com> 2 11 -
trunk/LayoutTests/platform/gtk/Skipped
r70551 r70609 4655 4655 editing/input/scroll-viewport-page-up-down.html 4656 4656 fast/events/popup-when-select-change.html 4657 fast/events/tab-focus-anchor.html4658 4657 http/tests/misc/slow-loading-mask.html 4659 4658 http/tests/plugins/plugin-document-has-focus.html -
trunk/WebKit/gtk/ChangeLog
r70574 r70609 1 2010-10-26 Antonio Gomes <agomes@rim.com> 2 3 Reviewed by Martin Robinson. 4 5 [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea) 6 https://bugs.webkit.org/show_bug.cgi?id=48199 7 8 Implemented an initial version of the DumpRenderTreeSupportGtk class. 9 The main idea is that it groups together the bodies of many LayoutTestController 10 methods, so they can directly access WebCore features. This way we eliminate the 11 need of adding APIs to WebKitGTK just to expand its test coverage through DRT. 12 13 The DumpRenderTreeSupportGtk class so far includes a getter and setter for the WebKitTabToLinksPreferenceKey 14 property as a sample implementation. Also it makes it possible to unskip fast/events/tab-focus-anchor.html and 15 to fix stderr messages from all 22 spatial-navigation tests in fast/events/spatial-navigation. 16 17 * WebCoreSupport/ChromeClientGtk.cpp: 18 (WebKit::ChromeClient::tabsToLinks): 19 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added. 20 (DumpRenderTreeSupportGtk::DumpRenderTreeSupportGtk): 21 (DumpRenderTreeSupportGtk::~DumpRenderTreeSupportGtk): 22 (DumpRenderTreeSupportGtk::setDumpRenderTreeModeEnabled): 23 (DumpRenderTreeSupportGtk::dumpRenderTreeModeEnabled): Getter to the WebKitTabToLinksPreferenceKey property. 24 (DumpRenderTreeSupportGtk::setLinksIncludedInFocusChain): Setter to the WebKitTabToLinksPreferenceKey property. 25 (DumpRenderTreeSupportGtk::linksIncludedInFocusChain): 26 * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added. 27 1 28 2010-10-26 Jenn Braithwaite <jennb@chromium.org> 2 29 -
trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
r70333 r70609 26 26 27 27 #include "Console.h" 28 #include "DumpRenderTreeSupportGtk.h" 28 29 #include "FileSystem.h" 29 30 #include "FileChooser.h" … … 332 333 bool ChromeClient::tabsToLinks() const 333 334 { 335 if (DumpRenderTreeSupportGtk::dumpRenderTreeModeEnabled()) 336 return DumpRenderTreeSupportGtk::linksIncludedInFocusChain(); 337 334 338 return true; 335 339 } -
trunk/WebKitTools/ChangeLog
r70608 r70609 1 2010-10-26 Antonio Gomes <agomes@rim.com> 2 3 Reviewed by Martin Robinson. 4 5 [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea) 6 https://bugs.webkit.org/show_bug.cgi?id=48199 7 8 Implements support to WebKitTabToLinksPreferenceKey through LayoutTestController::overridePreference. 9 The corresponding DumpRenderTreeSupportGtk method is called in the DRT context only. 10 11 * DumpRenderTree/gtk/DumpRenderTree.cpp: 12 (resetDefaultsToConsistentValues): 13 (createWebView): 14 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 15 (LayoutTestController::overridePreference): 16 1 17 2010-10-26 Ariya Hidayat <ariya@sencha.com> 2 18 -
trunk/WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp
r70253 r70609 39 39 #include "LayoutTestController.h" 40 40 #include "PixelDumpSupport.h" 41 #include "WebCoreSupport/DumpRenderTreeSupportGtk.h" 41 42 #include "WorkQueue.h" 42 43 #include "WorkQueueItem.h" … … 444 445 445 446 setlocale(LC_ALL, ""); 447 448 DumpRenderTreeSupportGtk::setLinksIncludedInFocusChain(true); 446 449 } 447 450 … … 995 998 WebKitWebView* view = WEBKIT_WEB_VIEW(webkit_web_view_new()); 996 999 1000 DumpRenderTreeSupportGtk::setDumpRenderTreeModeEnabled(true); 1001 997 1002 // From bug 11756: Use a frame group name for all WebViews created by 998 1003 // DumpRenderTree to allow testing of cross-page frame lookup. -
trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
r70385 r70609 34 34 #include "LayoutTestController.h" 35 35 36 #include "../../../WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h" 36 37 #include "DumpRenderTree.h" 37 38 #include "WorkQueue.h" … … 684 685 propertyName = "enable-page-cache"; 685 686 else if (g_str_equal(originalName.get(), "WebKitPluginsEnabled")) 686 687 propertyName = "enable-plugins"; 687 688 else if (g_str_equal(originalName.get(), "WebKitHyperlinkAuditingEnabled")) 688 propertyName = "enable-hyperlink-auditing"; 689 else { 689 propertyName = "enable-hyperlink-auditing"; 690 else if (g_str_equal(originalName.get(), "WebKitTabToLinksPreferenceKey")) { 691 DumpRenderTreeSupportGtk::setLinksIncludedInFocusChain(!g_ascii_strcasecmp(valueAsString.get(), "true") || !g_ascii_strcasecmp(valueAsString.get(), "1")); 692 return; 693 } else { 690 694 fprintf(stderr, "LayoutTestController::overridePreference tried to override " 691 695 "unknown preference '%s'.\n", originalName.get()); -
trunk/autotools/symbols.filter
r50205 r70609 5 5 _ZN3WTF8fastFreeEPv; 6 6 _ZN3WTF10fastCallocEjj; 7 7 _ZN24DumpRenderTreeSupportGtk*; 8 8 local: 9 9 _Z*;
Note: See TracChangeset
for help on using the changeset viewer.