Changeset 70609 in webkit


Ignore:
Timestamp:
Oct 26, 2010 10:22:23 PM (13 years ago)
Author:
tonikitoo@webkit.org
Message:

[GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea)
https://bugs.webkit.org/show_bug.cgi?id=48199

Reviewed by Martin Robinson.
Patch by Antonio Gomes <agomes@rim.com>

.:

  • GNUmakefile.am: Added WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp|h to GTK+'s build system;
  • autotools/symbols.filter: Added DumpRenderTreeSupportGtk symbols to symbols.filter so they do not get filtered and get visible by DRT.

WebKit/gtk:

Implemented an initial version of the DumpRenderTreeSupportGtk class.
The main idea is that it groups together the bodies of many LayoutTestController
methods, so they can directly access WebCore features. This way we eliminate the
need of adding APIs to WebKitGTK just to expand its test coverage through DRT.

The DumpRenderTreeSupportGtk class so far includes a getter and setter for the WebKitTabToLinksPreferenceKey
property as a sample implementation. Also it makes it possible to unskip fast/events/tab-focus-anchor.html and
to fix stderr messages from all 22 spatial-navigation tests in fast/events/spatial-navigation.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::tabsToLinks):

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added.

(DumpRenderTreeSupportGtk::DumpRenderTreeSupportGtk):
(DumpRenderTreeSupportGtk::~DumpRenderTreeSupportGtk):
(DumpRenderTreeSupportGtk::setDumpRenderTreeModeEnabled):
(DumpRenderTreeSupportGtk::dumpRenderTreeModeEnabled): Getter to the WebKitTabToLinksPreferenceKey property.
(DumpRenderTreeSupportGtk::setLinksIncludedInFocusChain): Setter to the WebKitTabToLinksPreferenceKey property.
(DumpRenderTreeSupportGtk::linksIncludedInFocusChain):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h: Added.

WebKitTools:

Implements support to WebKitTabToLinksPreferenceKey through LayoutTestController::overridePreference.
The corresponding DumpRenderTreeSupportGtk method is called in the DRT context only.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):
(createWebView):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference):

LayoutTests:

  • platform/gtk/Skipped: Unskiped fast/events/tab-focus-anchor.html.
Location:
trunk
Files:
2 added
10 edited

Legend:

Unmodified
Added
Removed
  • trunk/ChangeLog

    r70418 r70609  
     12010-10-26  Antonio Gomes  <agomes@rim.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea)
     6        https://bugs.webkit.org/show_bug.cgi?id=48199
     7
     8        * GNUmakefile.am: Added WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp|h to GTK+'s build system;
     9        * autotools/symbols.filter: Added DumpRenderTreeSupportGtk symbols to symbols.filter so they do not get
     10          filtered and get visible by DRT.
     11
    1122010-10-24  Anders Bakken  <agbakken@gmail.com>
    213
  • trunk/GNUmakefile.am

    r69858 r70609  
    363363        WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp \
    364364        WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h \
     365        WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp \
     366        WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h \
    365367        WebKit/gtk/WebCoreSupport/FrameNetworkingContextGtk.h \
    366368        WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp \
  • trunk/LayoutTests/ChangeLog

    r70598 r70609  
     12010-10-26  Antonio Gomes  <agomes@rim.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea)
     6        https://bugs.webkit.org/show_bug.cgi?id=48199
     7
     8        * platform/gtk/Skipped: Unskiped fast/events/tab-focus-anchor.html.
     9
    1102010-10-26  MORITA Hajime  <morrita@google.com>
    211
  • trunk/LayoutTests/platform/gtk/Skipped

    r70551 r70609  
    46554655editing/input/scroll-viewport-page-up-down.html
    46564656fast/events/popup-when-select-change.html
    4657 fast/events/tab-focus-anchor.html
    46584657http/tests/misc/slow-loading-mask.html
    46594658http/tests/plugins/plugin-document-has-focus.html
  • trunk/WebKit/gtk/ChangeLog

    r70574 r70609  
     12010-10-26  Antonio Gomes  <agomes@rim.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea)
     6        https://bugs.webkit.org/show_bug.cgi?id=48199
     7
     8        Implemented an initial version of the DumpRenderTreeSupportGtk class.
     9        The main idea is that it groups together the bodies of many LayoutTestController
     10        methods, so they can directly access WebCore features. This way we eliminate the
     11        need of adding APIs to WebKitGTK just to expand its test coverage through DRT.
     12
     13        The DumpRenderTreeSupportGtk class so far includes a getter and setter for the WebKitTabToLinksPreferenceKey
     14        property as a sample implementation. Also it makes it possible to unskip fast/events/tab-focus-anchor.html and
     15        to fix stderr messages from all 22 spatial-navigation tests in fast/events/spatial-navigation.
     16
     17        * WebCoreSupport/ChromeClientGtk.cpp:
     18        (WebKit::ChromeClient::tabsToLinks):
     19        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added.
     20        (DumpRenderTreeSupportGtk::DumpRenderTreeSupportGtk):
     21        (DumpRenderTreeSupportGtk::~DumpRenderTreeSupportGtk):
     22        (DumpRenderTreeSupportGtk::setDumpRenderTreeModeEnabled):
     23        (DumpRenderTreeSupportGtk::dumpRenderTreeModeEnabled): Getter to the WebKitTabToLinksPreferenceKey property.
     24        (DumpRenderTreeSupportGtk::setLinksIncludedInFocusChain): Setter to the WebKitTabToLinksPreferenceKey property.
     25        (DumpRenderTreeSupportGtk::linksIncludedInFocusChain):
     26        * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added.
     27
    1282010-10-26  Jenn Braithwaite  <jennb@chromium.org>
    229
  • trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

    r70333 r70609  
    2626
    2727#include "Console.h"
     28#include "DumpRenderTreeSupportGtk.h"
    2829#include "FileSystem.h"
    2930#include "FileChooser.h"
     
    332333bool ChromeClient::tabsToLinks() const
    333334{
     335    if (DumpRenderTreeSupportGtk::dumpRenderTreeModeEnabled())
     336        return DumpRenderTreeSupportGtk::linksIncludedInFocusChain();
     337
    334338    return true;
    335339}
  • trunk/WebKitTools/ChangeLog

    r70608 r70609  
     12010-10-26  Antonio Gomes  <agomes@rim.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea)
     6        https://bugs.webkit.org/show_bug.cgi?id=48199
     7
     8        Implements support to WebKitTabToLinksPreferenceKey through LayoutTestController::overridePreference.
     9        The corresponding DumpRenderTreeSupportGtk method is called in the DRT context only.
     10
     11        * DumpRenderTree/gtk/DumpRenderTree.cpp:
     12        (resetDefaultsToConsistentValues):
     13        (createWebView):
     14        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
     15        (LayoutTestController::overridePreference):
     16
    1172010-10-26  Ariya Hidayat  <ariya@sencha.com>
    218
  • trunk/WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp

    r70253 r70609  
    3939#include "LayoutTestController.h"
    4040#include "PixelDumpSupport.h"
     41#include "WebCoreSupport/DumpRenderTreeSupportGtk.h"
    4142#include "WorkQueue.h"
    4243#include "WorkQueueItem.h"
     
    444445
    445446    setlocale(LC_ALL, "");
     447
     448    DumpRenderTreeSupportGtk::setLinksIncludedInFocusChain(true);
    446449}
    447450
     
    995998    WebKitWebView* view = WEBKIT_WEB_VIEW(webkit_web_view_new());
    996999
     1000    DumpRenderTreeSupportGtk::setDumpRenderTreeModeEnabled(true);
     1001
    9971002    // From bug 11756: Use a frame group name for all WebViews created by
    9981003    // DumpRenderTree to allow testing of cross-page frame lookup.
  • trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

    r70385 r70609  
    3434#include "LayoutTestController.h"
    3535
     36#include "../../../WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h"
    3637#include "DumpRenderTree.h"
    3738#include "WorkQueue.h"
     
    684685        propertyName = "enable-page-cache";
    685686    else if (g_str_equal(originalName.get(), "WebKitPluginsEnabled"))
    686          propertyName = "enable-plugins";
     687        propertyName = "enable-plugins";
    687688    else if (g_str_equal(originalName.get(), "WebKitHyperlinkAuditingEnabled"))
    688          propertyName = "enable-hyperlink-auditing";
    689     else {
     689        propertyName = "enable-hyperlink-auditing";
     690    else if (g_str_equal(originalName.get(), "WebKitTabToLinksPreferenceKey")) {
     691        DumpRenderTreeSupportGtk::setLinksIncludedInFocusChain(!g_ascii_strcasecmp(valueAsString.get(), "true") || !g_ascii_strcasecmp(valueAsString.get(), "1"));
     692        return;
     693    } else {
    690694        fprintf(stderr, "LayoutTestController::overridePreference tried to override "
    691695                "unknown preference '%s'.\n", originalName.get());
  • trunk/autotools/symbols.filter

    r50205 r70609  
    55_ZN3WTF8fastFreeEPv;
    66_ZN3WTF10fastCallocEjj;
    7 
     7_ZN24DumpRenderTreeSupportGtk*;
    88local:
    99_Z*;
Note: See TracChangeset for help on using the changeset viewer.