Changeset 70617 in webkit

Timestamp:

Oct 26, 2010 11:38:35 PM (14 years ago)

Author:

rwlbuis@webkit.org

Message:

2010-10-26 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Nikolas Zimmermann.

Title-Element has no popup on <svg>-Elements, but on <g>
​https://bugs.webkit.org/show_bug.cgi?id=47669

Allow tooltips on non-root svg elements.

No new tests.

• svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• svg/SVGStyledElement.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-26  Rob Buis  <rwlbuis@gmail.com>
+
+        Reviewed by Nikolas Zimmermann.
+
+        Title-Element has no popup on <svg>-Elements, but on <g>
+        https://bugs.webkit.org/show_bug.cgi?id=47669
+
+        Allow tooltips on non-root svg elements.
+
+        No new tests.
+
+        * svg/SVGStyledElement.cpp:
+
 2010-10-26  Dai Mikurube  <dmikurube@google.com>
 

trunk/WebCore/svg/SVGStyledElement.cpp

@@ -67 +67 @@
 String SVGStyledElement::title() const
 {
-    // According to spec, we should not return titles when hovering over <svg> elements (those 
+    // According to spec, we should not return titles when hovering over root <svg> elements (those
     // <title> elements are the title of the document, not a tooltip) so we instantly return.
-    if (hasTagName(SVGNames::svgTag))
-        return String();
+    if (hasTagName(SVGNames::svgTag)) {
+        const SVGSVGElement* svg = static_cast<const SVGSVGElement*>(this);
+        if (svg->isOutermostSVG())
+            return String();
+    }
     
     // Walk up the tree, to find out whether we're inside a <use> shadow tree, to find the right title.