Changeset 70641 in webkit

Timestamp:

Oct 27, 2010 6:15:49 AM (13 years ago)

Author:

Adam Roben

Message:

Only decompress pixel buffers when needed (and fix a crash in the process)

Fixes <​http://webkit.org/b/48417> Crash when running
compositing/video/video-background-color.html on Windows

Reviewed by Anders Carlsson.

• platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint): Only
decompress the pixel buffer when it has an incompatible format. This
also has the benefit of only decompressing the buffer when a
QTDecompressionSession has been created! (I assume this was just a typo
from when this code was added in r70252.)

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-27  Adam Roben  <aroben@apple.com>
+
+        Only decompress pixel buffers when needed (and fix a crash in the
+        process)
+
+        Fixes <http://webkit.org/b/48417> Crash when running
+        compositing/video/video-background-color.html on Windows
+
+        Reviewed by Anders Carlsson.
+
+        * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
+        (WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint): Only
+        decompress the pixel buffer when it has an incompatible format. This
+        also has the benefit of only decompressing the buffer when a
+        QTDecompressionSession has been created! (I assume this was just a typo
+        from when this code was added in r70252.)
+
 2010-10-27  Mario Sanchez Prada  <msanchez@igalia.com>
 

trunk/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp

@@ -744 +744 @@
                 if (!m_decompressionSession || !m_decompressionSession->canDecompress(buffer))
                     m_decompressionSession = QTDecompressionSession::create(buffer.pixelFormatType(), buffer.width(), buffer.height());
+                buffer = m_decompressionSession->decompress(buffer);
             }
-
-            buffer = m_decompressionSession->decompress(buffer);
         }
 #endif