Changeset 70651 in webkit


Ignore:
Timestamp:
Oct 27, 2010 8:58:20 AM (14 years ago)
Author:
Martin Robinson
Message:

2010-10-27 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails
​https://bugs.webkit.org/show_bug.cgi?id=38956

  • platform/gtk/Skipped: removed test from skipped list

2010-10-27 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails
​https://bugs.webkit.org/show_bug.cgi?id=38956

Added a new utility function that turns SoupURIs into
KURLs. That addresses some issues with SoupURIs like for example
soup_uri_to_string ignoring the URI password. Basic authentication
using URL credentials should work now.

  • GNUmakefile.am:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::loadResourceSynchronously):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage):
  • platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):
  • platform/network/soup/SoupURIUtils.cpp: Added. (WebCore::soupURIToKURL):
  • platform/network/soup/SoupURIUtils.h: Added.
Location:
trunk
Files:
2 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r70649 r70651  
     12010-10-27  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        [Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails
     6        https://bugs.webkit.org/show_bug.cgi?id=38956
     7
     8        * platform/gtk/Skipped: removed test from skipped list
     9
    1102010-10-27  Martin Robinson  <mrobinson@igalia.com>
    211

  • trunk/LayoutTests/platform/gtk/Skipped

    r70609 r70651  
    52305230fast/css/font-face-woff.html
    52315231
    5232 # https://bugs.webkit.org/show_bug.cgi?id=38956
    5233 http/tests/xmlhttprequest/basic-auth-default.html
    5234 
    52355232# https://bugs.webkit.org/show_bug.cgi?id=40049
    52365233http/tests/inspector/resource-har-conversion.html

  • trunk/WebCore/ChangeLog

    r70650 r70651  
     12010-10-27  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        [Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails
     6        https://bugs.webkit.org/show_bug.cgi?id=38956
     7
     8        Added a new utility function that turns SoupURIs into
     9        KURLs. That addresses some issues with SoupURIs like for example
     10        soup_uri_to_string ignoring the URI password. Basic authentication
     11        using URL credentials should work now.
     12
     13        * GNUmakefile.am:
     14        * platform/network/soup/ResourceHandleSoup.cpp:
     15        (WebCore::ResourceHandle::start):
     16        (WebCore::ResourceHandle::loadResourceSynchronously):
     17        * platform/network/soup/ResourceRequestSoup.cpp:
     18        (WebCore::ResourceRequest::updateFromSoupMessage):
     19        * platform/network/soup/ResourceResponseSoup.cpp:
     20        (WebCore::ResourceResponse::updateFromSoupMessage):
     21        * platform/network/soup/SoupURIUtils.cpp: Added.
     22        (WebCore::soupURIToKURL):
     23        * platform/network/soup/SoupURIUtils.h: Added.
     24
    1252010-10-27  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
    226

  • trunk/WebCore/GNUmakefile.am

    r70631 r70651  
    36173617        WebCore/platform/network/soup/SocketStreamHandle.h \
    36183618        WebCore/platform/network/soup/SocketStreamHandleSoup.cpp \
     3619        WebCore/platform/network/soup/SoupURIUtils.cpp \
     3620        WebCore/platform/network/soup/SoupURIUtils.h \
    36193621        WebCore/platform/network/soup/cache/soup-directory-input-stream.c \
    36203622        WebCore/platform/network/soup/cache/soup-directory-input-stream.h \

  • trunk/WebCore/platform/network/soup/ResourceHandleSoup.cpp

    r70038 r70651  
    673673        return false;
    674674
     675    if (!(d->m_user.isEmpty() || d->m_pass.isEmpty())) {
     676        // If credentials were specified for this request, add them to the url,
     677        // so that they will be passed to NetworkRequest.
     678        KURL urlWithCredentials(firstRequest().url());
     679        urlWithCredentials.setUser(d->m_user);
     680        urlWithCredentials.setPass(d->m_pass);
     681        d->m_firstRequest.setURL(urlWithCredentials);
     682    }
     683
    675684    KURL url = firstRequest().url();
    676685    String urlString = url.string();

  • trunk/WebCore/platform/network/soup/ResourceRequestSoup.cpp

    r70038 r70651  
    2626#include "MIMETypeRegistry.h"
    2727#include "PlatformString.h"
     28#include "SoupURIUtils.h"
    2829#include <wtf/text/CString.h>
    2930
    … …  
    8990void ResourceRequest::updateFromSoupMessage(SoupMessage* soupMessage)
    9091{
    91     SoupURI* soupURI = soup_message_get_uri(soupMessage);
    92     GOwnPtr<gchar> uri(soup_uri_to_string(soupURI, FALSE));
    93     m_url = KURL(KURL(), String::fromUTF8(uri.get()));
     92    m_url = soupURIToKURL(soup_message_get_uri(soupMessage));
    9493
    9594    m_httpMethod = String::fromUTF8(soupMessage->method);
    … …  
    108107#ifdef HAVE_LIBSOUP_2_29_90
    109108    SoupURI* firstParty = soup_message_get_first_party(soupMessage);
    110     if (firstParty) {
    111         GOwnPtr<gchar> firstPartyURI(soup_uri_to_string(firstParty, FALSE));
    112         m_firstPartyForCookies = KURL(KURL(), String::fromUTF8(firstPartyURI.get()));
    113     }
     109    if (firstParty)
     110        m_firstPartyForCookies = soupURIToKURL(firstParty);
    114111#endif
    115112

  • trunk/WebCore/platform/network/soup/ResourceResponseSoup.cpp

    r56825 r70651  
    2626#include "MIMETypeRegistry.h"
    2727#include "PlatformString.h"
     28#include "SoupURIUtils.h"
    2829#include <wtf/text/CString.h>
    2930
    … …  
    5758void ResourceResponse::updateFromSoupMessage(SoupMessage* soupMessage)
    5859{
    59     SoupURI* soupURI = soup_message_get_uri(soupMessage);
    60     GOwnPtr<gchar> uri(soup_uri_to_string(soupURI, FALSE));
    61     m_url = KURL(KURL(), String::fromUTF8(uri.get()));
     60    m_url = soupURIToKURL(soup_message_get_uri(soupMessage));
    6261
    6362    m_httpStatusCode = soupMessage->status_code;
Note: See TracChangeset for help on using the changeset viewer.