Changeset 70682 in webkit


Ignore:
Timestamp:
Oct 27, 2010 11:53:55 AM (13 years ago)
Author:
apavlov@chromium.org
Message:

2010-10-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=48431

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking):
  • http/tests/inspector/resource-parameters.html:
  • inspector/audits-panel-functional.html:
  • inspector/styles-source-offsets.html:

2010-10-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=48431

  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createPanelEnabler): (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r70681 r70682  
     12010-10-27  Alexander Pavlov  <apavlov@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
     6        https://bugs.webkit.org/show_bug.cgi?id=48431
     7
     8        * http/tests/inspector/inspector-test2.js:
     9        (initialize_InspectorTest.InspectorTest.enableResourceTracking):
     10        (initialize_InspectorTest.InspectorTest.disableResourceTracking):
     11        * http/tests/inspector/resource-parameters.html:
     12        * inspector/audits-panel-functional.html:
     13        * inspector/styles-source-offsets.html:
     14
    1152010-10-27  Abhishek Arya  <inferno@chromium.org>
    216
  • trunk/LayoutTests/http/tests/inspector/inspector-test2.js

    r70532 r70682  
    119119    else {
    120120        InspectorTest._reloadPageCallback = callback;
    121         WebInspector.panels.resources._toggleResourceTracking();
     121        WebInspector.panels.resources.toggleResourceTracking();
    122122    }
    123123}
     
    129129
    130130    if (WebInspector.panels.resources.resourceTrackingEnabled)
    131         WebInspector.panels.resources._toggleResourceTracking();
     131        WebInspector.panels.resources.toggleResourceTracking();
    132132}
    133133
  • trunk/LayoutTests/http/tests/inspector/resource-parameters.html

    r70532 r70682  
    3434{
    3535    if (!WebInspector.panels.resources.resourceTrackingEnabled) {
    36         WebInspector.panels.resources._toggleResourceTracking();
     36        WebInspector.panels.resources.toggleResourceTracking();
    3737        return "enabling";
    3838    }
     
    4444    var resource = WebInspector.resourceForURL("http://localhost:8000/inspector/resources/post-target.cgi?queryParam1=queryValue1&queryParam2=");
    4545
    46     WebInspector.panels.resources._toggleResourceTracking();
     46    WebInspector.panels.resources.toggleResourceTracking();
    4747
    4848    if (!resource) {
  • trunk/LayoutTests/inspector/audits-panel-functional.html

    r70532 r70682  
    4242        }
    4343    } else if (!WebInspector.panels.resources.resourceTrackingEnabled) {
    44         WebInspector.panels.resources._toggleResourceTracking();
     44        WebInspector.panels.resources.toggleResourceTracking();
    4545        return "refreshing";
    4646    }
     
    6161            // Avoid influencing tests that require resource tracking to be disabled.
    6262            if (!Preferences.networkPanelEnabled)
    63                 WebInspector.panels.resources._toggleResourceTracking();
     63                WebInspector.panels.resources.toggleResourceTracking();
    6464            testController.runAfterPendingDispatches(function() {
    6565                testController.notifyDone(output.join("\n"));
  • trunk/LayoutTests/inspector/styles-source-offsets.html

    r70532 r70682  
    2626{
    2727    if (!Preferences.networkPanelEnabled && !WebInspector.panels.resources.resourceTrackingEnabled) {
    28         WebInspector.panels.resources._toggleResourceTracking();
     28        WebInspector.panels.resources.toggleResourceTracking();
    2929        return "refreshing";
    3030    }
  • trunk/WebCore/ChangeLog

    r70681 r70682  
     12010-10-27  Alexander Pavlov  <apavlov@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
     6        https://bugs.webkit.org/show_bug.cgi?id=48431
     7
     8        * inspector/front-end/AuditsPanel.js:
     9        (WebInspector.AuditsPanel.prototype._reloadResources):
     10        * inspector/front-end/ResourcesPanel.js:
     11        (WebInspector.ResourcesPanel.prototype._createPanelEnabler):
     12        (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
     13
    1142010-10-27  Abhishek Arya  <inferno@chromium.org>
    215
  • trunk/WebCore/inspector/front-end/AuditsPanel.js

    r70532 r70682  
    207207
    208208        if (WebInspector.panels.resources && !WebInspector.panels.resources.resourceTrackingEnabled) {
    209             InspectorBackend.enableResourceTracking(false);
     209            WebInspector.panels.resources.toggleResourceTracking(false);
    210210            this._updateLauncherViewControls(true);
    211211        } else
  • trunk/WebCore/inspector/front-end/ResourcesPanel.js

    r70622 r70682  
    440440
    441441        this.enableToggleButton = new WebInspector.StatusBarButton("", "enable-toggle-status-bar-item");
    442         this.enableToggleButton.addEventListener("click", this._toggleResourceTracking.bind(this), false);
     442        this.enableToggleButton.addEventListener("click", this.toggleResourceTracking.bind(this), false);
    443443    },
    444444
     
    10661066        if (this._resourceTrackingEnabled)
    10671067            return;
    1068         this._toggleResourceTracking(this.panelEnablerView.alwaysEnabled);
    1069     },
    1070 
    1071     _toggleResourceTracking: function(optionalAlways)
     1068        this.toggleResourceTracking(this.panelEnablerView.alwaysEnabled);
     1069    },
     1070
     1071    toggleResourceTracking: function(optionalAlways)
    10721072    {
    10731073        function callback(newState) {
Note: See TracChangeset for help on using the changeset viewer.