Changeset 70683 in webkit
- Timestamp:
- Oct 27, 2010 11:58:18 AM (13 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r70679 r70683 1 2010-10-27 Dimitri Glazkov <dglazkov@chromium.org> 2 3 Unreviewed, rolling out r70674. 4 http://trac.webkit.org/changeset/70674 5 https://bugs.webkit.org/show_bug.cgi?id=48053 6 7 Broke Chromium Windows build. 8 9 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 10 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 11 1 12 2010-10-25 Tony Chang <tony@chromium.org> 2 13 -
trunk/WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py
r70674 r70683 353 353 def cancel(self): 354 354 """Clean up http lock and set a flag telling this thread to quit.""" 355 self._stop_ servers_with_lock()355 self._stop_http_lock() 356 356 WatchableThread.cancel(self) 357 357 … … 401 401 self._filename_list_queue.get_nowait() 402 402 except Queue.Empty: 403 self._stop_ servers_with_lock()403 self._stop_http_lock() 404 404 self._kill_dump_render_tree() 405 405 tests_run_file.close() 406 406 return 407 407 408 if self._current_group == "tests_to_http_lock": 409 self._start_servers_with_lock() 410 elif self._have_http_lock: 411 self._stop_servers_with_lock() 408 if self._options.wait_for_httpd: 409 if self._current_group == "tests_to_http_lock": 410 self._http_lock_wait_begin = time.time() 411 self._port.acquire_http_lock() 412 413 self._port.start_http_server() 414 self._port.start_websocket_server() 415 416 self._have_http_lock = True 417 self._http_lock_wait_end = time.time() 418 elif self._have_http_lock: 419 self._stop_http_lock() 412 420 413 421 self._num_tests_in_current_group = len(self._filename_list) … … 552 560 self._driver.start() 553 561 554 def _start_servers_with_lock(self): 555 """Acquire http lock and start the servers.""" 556 self._http_lock_wait_begin = time.time() 557 _log.debug('Acquire http lock ...') 558 self._port.acquire_http_lock() 559 _log.debug('Starting HTTP server ...') 560 self._port.start_http_server() 561 _log.debug('Starting WebSocket server ...') 562 self._port.start_websocket_server() 563 self._http_lock_wait_end = time.time() 564 self._have_http_lock = True 565 566 def _stop_servers_with_lock(self): 562 def _stop_http_lock(self): 567 563 """Stop the servers and release http lock.""" 568 564 if self._have_http_lock: 569 _log.debug('Stopping HTTP server ...')570 565 self._port.stop_http_server() 571 _log.debug('Stopping WebSocket server ...')572 566 self._port.stop_websocket_server() 573 _log.debug('Release http lock ...')574 567 self._port.release_http_lock() 575 568 self._have_http_lock = False -
trunk/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
r70674 r70683 741 741 return None 742 742 743 # Do not start when http locking is enabled. 744 if not self._options.wait_for_httpd: 745 if self.needs_http(): 746 self._printer.print_update('Starting HTTP server ...') 747 self._port.start_http_server() 748 749 if self.needs_websocket(): 750 self._printer.print_update('Starting WebSocket server ...') 751 self._port.start_websocket_server() 752 # self._websocket_secure_server.Start() 753 743 754 return result_summary 744 755 … … 830 841 _log.debug("flushing stderr") 831 842 sys.stderr.flush() 843 if not self._options.wait_for_httpd: 844 _log.debug("stopping http server") 845 self._port.stop_http_server() 846 _log.debug("stopping websocket server") 847 self._port.stop_websocket_server() 832 848 _log.debug("stopping helper") 833 849 self._port.stop_helper() … … 1579 1595 default=True, dest="record_results", 1580 1596 help="Don't record the results."), 1597 optparse.make_option("--wait-for-httpd", action="store_true", 1598 default=False, dest="wait_for_httpd", 1599 help="Wait for http locks."), 1581 1600 # old-run-webkit-tests also has HTTP toggle options: 1582 1601 # --[no-]http Run (or do not run) http tests
Note: See TracChangeset
for help on using the changeset viewer.