Changeset 70686 in webkit

Timestamp:

Oct 27, 2010 12:09:21 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-10-27 Renata Hodovan <​reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

preserveAlpha attributes were misspeled in SVGFEConcolveMatrixElement tests.
​https://bugs.webkit.org/show_bug.cgi?id=48403

Since expecteds and pixel tests didn't change after correcting this attribute has no effect so it is removed.
For checking preserveAlpha attribute we have already a dom test which is not affected by this patch.

• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-bias-attr.js:
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-divisor-attr.js:
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-in-attr.js:
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.js:
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.js:
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js:
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetX-attr.js:
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetY-attr.js:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-bias-attr.js (modified) (1 diff)
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-divisor-attr.js (modified) (1 diff)
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-in-attr.js (modified) (1 diff)
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.js (modified) (1 diff)
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.js (modified) (1 diff)
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js (modified) (1 diff)
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetX-attr.js (modified) (1 diff)
• svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetY-attr.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-10-27  Renata Hodovan  <reni@inf.u-szeged.hu>
+
+        Reviewed by Dirk Schulze.
+
+        preserveAlpha attributes were misspeled in SVGFEConcolveMatrixElement tests.
+        https://bugs.webkit.org/show_bug.cgi?id=48403
+
+        Since expecteds and pixel tests didn't change after correcting this attribute has no effect so it is removed.
+        For checking preserveAlpha attribute we have already a dom test which is not affected by this patch.
+
+        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-bias-attr.js:
+        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-divisor-attr.js:
+        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-in-attr.js:
+        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.js:
+        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.js:
+        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js:
+        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetX-attr.js:
+        * svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetY-attr.js:
+
 2010-10-27  Dimitri Glazkov  <dglazkov@chromium.org>
 

trunk/LayoutTests/svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-bias-attr.js

@@ -9 +9 @@
 convolveMatrixElement.setAttribute("order", "3");
 convolveMatrixElement.setAttribute("kernelMatrix", "3 0 3 0 0 0 3 0 3");
-convolveMatrixElement.setAttribute("preserveToAlpha", "true");
 convolveMatrixElement.setAttribute("bias", "0.5");
 

trunk/LayoutTests/svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-divisor-attr.js

@@ -9 +9 @@
 convolveMatrixElement.setAttribute("order", "3");
 convolveMatrixElement.setAttribute("kernelMatrix", "3 0 3 0 0 0 3 0 3");
-convolveMatrixElement.setAttribute("preserveToAlpha", "true");
 convolveMatrixElement.setAttribute("divisor", "20");
 

trunk/LayoutTests/svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-in-attr.js

@@ -9 +9 @@
 convolveMatrixElement.setAttribute("order", "3");
 convolveMatrixElement.setAttribute("kernelMatrix", "3 0 3 0 0 0 3 0 3");
-convolveMatrixElement.setAttribute("preserveToAlpha", "true");
 
 var filterElement = createSVGElement("filter");

trunk/LayoutTests/svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.js

@@ -9 +9 @@
 convolveMatrixElement.setAttribute("order", "3");
 convolveMatrixElement.setAttribute("kernelMatrix", "-2 0 0 0 1 0 0 0 2");
-convolveMatrixElement.setAttribute("preserveToAlpha", "true");
 
 var filterElement = createSVGElement("filter");

trunk/LayoutTests/svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.js

@@ -9 +9 @@
 convolveMatrixElement.setAttribute("order", "3");
 convolveMatrixElement.setAttribute("kernelMatrix", "3 0 5 0 0 0 3 0 3");
-convolveMatrixElement.setAttribute("preserveToAlpha", "true");
 convolveMatrixElement.setAttribute("kernelUnitLength", "1");
 

trunk/LayoutTests/svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js

@@ -9 +9 @@
 convolveMatrixElement.setAttribute("order", "2 2");
 convolveMatrixElement.setAttribute("kernelMatrix", "3 0 3 0 0 0 3 0 3");
-convolveMatrixElement.setAttribute("preserveToAlpha", "true");
 
 var filterElement = createSVGElement("filter");

trunk/LayoutTests/svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetX-attr.js

@@ -9 +9 @@
 convolveMatrixElement.setAttribute("order", "3");
 convolveMatrixElement.setAttribute("kernelMatrix", "3 0 3 0 0 0 3 0 3");
-convolveMatrixElement.setAttribute("preserveToAlpha", "true");
 convolveMatrixElement.setAttribute("targetX", "2");
 

trunk/LayoutTests/svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetY-attr.js

@@ -9 +9 @@
 convolveMatrixElement.setAttribute("order", "3.9");
 convolveMatrixElement.setAttribute("kernelMatrix", "3 0 3 0 0 0 3 0 3");
-convolveMatrixElement.setAttribute("preserveToAlpha", "true");
 convolveMatrixElement.setAttribute("targetY", "2");