Changeset 70718 in webkit

Timestamp:

Oct 27, 2010 2:57:24 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-10-27 Adam Barth <​abarth@webkit.org>

Reviewed by Ojan Vafai.

REGRESSION(66511): CORDYS Process Factory doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=48453

Test some appendChild cases that didn't have coverage before.

• fast/dom/allowed-children-expected.txt: Added.
• fast/dom/allowed-children.html: Added.

2010-10-27 Adam Barth <​abarth@webkit.org>

Reviewed by Ojan Vafai.

REGRESSION(66511): CORDYS Process Factory doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=48453

When Ojan refactored this function in 66511, he missed an "else",
which causes us to generated HIERARCHY_REQUEST_ERR in some cases where
we're not supposed to. This patch restores the "else" behavior (using
an early return) and adds a test for the cases that caused problems in
the field.

Test: fast/dom/allowed-children.html

• dom/Node.cpp: (WebCore::isChildTypeAllowed):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/allowed-children-expected.txt (added)
• LayoutTests/fast/dom/allowed-children.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/Node.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-10-27  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Ojan Vafai.
+
+        REGRESSION(66511): CORDYS Process Factory doesn't work
+        https://bugs.webkit.org/show_bug.cgi?id=48453
+
+        Test some appendChild cases that didn't have coverage before.
+
+        * fast/dom/allowed-children-expected.txt: Added.
+        * fast/dom/allowed-children.html: Added.
+
 2010-10-27  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-10-27  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Ojan Vafai.
+
+        REGRESSION(66511): CORDYS Process Factory doesn't work
+        https://bugs.webkit.org/show_bug.cgi?id=48453
+
+        When Ojan refactored this function in 66511, he missed an "else",
+        which causes us to generated HIERARCHY_REQUEST_ERR in some cases where
+        we're not supposed to.  This patch restores the "else" behavior (using
+        an early return) and adds a test for the cases that caused problems in
+        the field.
+
+        Test: fast/dom/allowed-children.html
+
+        * dom/Node.cpp:
+        (WebCore::isChildTypeAllowed):
+
 2010-10-27  Beth Dakin  <bdakin@apple.com>
 

trunk/WebCore/dom/Node.cpp

@@ -1081 +1081 @@
         if (!newParent->childTypeAllowed(child->nodeType()))
             return false;
+        return true;
     }
     
@@ -1087 +1088 @@
             return false;
     }
-
     return true;
 }