Changeset 70763 in webkit


Ignore:
Timestamp:
Oct 28, 2010 3:41:58 AM (13 years ago)
Author:
morrita@google.com
Message:

2010-10-28 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

WebKit needs to expose an Element::spellcheck attribute to javascript.
​https://bugs.webkit.org/show_bug.cgi?id=25536

  • editing/spelling/script-tests/spelling-attribute-change.js: Added.
  • editing/spelling/spelling-attribute-change-expected.txt: Added.
  • editing/spelling/spelling-attribute-change.html: Added.
  • fast/dom/HTMLElement/script-tests/spellcheck.js: Added.
  • fast/dom/HTMLElement/spellcheck-expected.txt: Added.
  • fast/dom/HTMLElement/spellcheck.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2010-10-27 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

WebKit needs to expose an Element::spellcheck attribute to javascript.
​https://bugs.webkit.org/show_bug.cgi?id=25536

Published Element.spellcheck property on IDL, implemented it.

Tests: editing/spelling/spelling-attribute-change.html

fast/dom/HTMLElement/spellcheck.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::spellcheck): (WebCore::HTMLElement::setSpellcheck):
  • html/HTMLElement.h:
  • html/HTMLElement.idl:
Location:
trunk
Files:
6 added
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r70762 r70763  
     12010-10-28  MORITA Hajime  <morrita@google.com>
     2
     3        Reviewed by Kent Tamura.
     4
     5        WebKit needs to expose an Element::spellcheck attribute to javascript.
     6        https://bugs.webkit.org/show_bug.cgi?id=25536
     7
     8        * editing/spelling/script-tests/spelling-attribute-change.js: Added.
     9        * editing/spelling/spelling-attribute-change-expected.txt: Added.
     10        * editing/spelling/spelling-attribute-change.html: Added.
     11        * fast/dom/HTMLElement/script-tests/spellcheck.js: Added.
     12        * fast/dom/HTMLElement/spellcheck-expected.txt: Added.
     13        * fast/dom/HTMLElement/spellcheck.html: Added.
     14        * platform/chromium/test_expectations.txt:
     15        * platform/gtk/Skipped:
     16        * platform/qt/Skipped:
     17
    1182010-10-27  Pavel Feldman  <pfeldman@chromium.org>
    219

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r70709 r70763  
    691691BUG11577 WIN LINUX : editing/spelling/spellcheck-attribute.html = FAIL
    692692BUG11577 WIN LINUX : editing/spelling/spelling-linebreak.html = FAIL
     693BUG11577 WIN LINUX : editing/spelling/spelling-attribute-change.html  = FAIL
    693694
    694695// TODO(erg): Attempted to rebaseline these tests as part of the above

  • trunk/LayoutTests/platform/gtk/Skipped

    r70651 r70763  
    982982editing/spelling/spelling-backspace-between-lines.html
    983983editing/spelling/spelling-linebreak.html
     984editing/spelling/spelling-attribute-change.html
    984985editing/style/5065910.html
    985986editing/style/apple-style-editable-mix.html

  • trunk/LayoutTests/platform/qt/Skipped

    r70542 r70763  
    22452245# https://bugs.webkit.org/show_bug.cgi?id=45435
    22462246editing/spelling/spelling-backspace-between-lines.html
     2247
     2248editing/spelling/spelling-attribute-change.html
    22472249
    22482250# ============================================================================= #

  • trunk/WebCore/ChangeLog

    r70762 r70763  
     12010-10-27  MORITA Hajime  <morrita@google.com>
     2
     3        Reviewed by Kent Tamura.
     4
     5        WebKit needs to expose an Element::spellcheck attribute to javascript.
     6        https://bugs.webkit.org/show_bug.cgi?id=25536
     7
     8        Published Element.spellcheck property on IDL, implemented it.
     9       
     10        Tests: editing/spelling/spelling-attribute-change.html
     11               fast/dom/HTMLElement/spellcheck.html
     12
     13        * html/HTMLElement.cpp:
     14        (WebCore::HTMLElement::spellcheck):
     15        (WebCore::HTMLElement::setSpellcheck):
     16        * html/HTMLElement.h:
     17        * html/HTMLElement.idl:
     18
    1192010-10-27  Pavel Feldman  <pfeldman@chromium.org>
    220

  • trunk/WebCore/html/HTMLElement.cpp

    r69868 r70763  
    726726}
    727727
     728bool HTMLElement::spellcheck() const
     729{
     730    return isSpellCheckingEnabled();
     731}
     732
     733void HTMLElement::setSpellcheck(bool enable)
     734{
     735    setAttribute(spellcheckAttr, enable ? "true" : "false");
     736}
     737
     738
    728739void HTMLElement::click()
    729740{

  • trunk/WebCore/html/HTMLElement.h

    r66062 r70763  
    6767    void setDraggable(bool);
    6868
     69    bool spellcheck() const;
     70    void setSpellcheck(bool);
     71
    6972    void click();
    7073

  • trunk/WebCore/html/HTMLElement.idl

    r68440 r70763  
    6363        readonly attribute boolean isContentEditable;
    6464
     65                 attribute boolean spellcheck;
     66
    6567#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
    6668        readonly attribute DOMString titleDisplayString;
Note: See TracChangeset for help on using the changeset viewer.