Changeset 70840 in webkit


Ignore:
Timestamp:
Oct 28, 2010 9:48:43 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2010-10-28 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

iframes forced into slow scrolling mode by containing RenderLayer sometimes
​https://bugs.webkit.org/show_bug.cgi?id=48570

Adds a test that verifies that the repaint region for a scrolled iframe is not
larger than necessary.

  • fast/repaint/iframe-scroll-repaint.html: Added.
  • fast/repaint/resources/iframe-scroll-repaint-iframe.html: Added.
  • platform/mac/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
  • platform/mac/fast/repaint/iframe-scroll-repaint-expected.png: Added.
  • platform/mac/fast/repaint/iframe-scroll-repaint-expected.txt: Added.

2010-10-28 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

iframes forced into slow scrolling mode by containing RenderLayer sometimes
​https://bugs.webkit.org/show_bug.cgi?id=48570

Only performs the overlap test for RenderLayers that paint themselves. This
prevents marking RenderWidgets as being overlapped unnecessarily.

Test: fast/repaint/iframe-scroll-repaint.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
Location:
trunk
Files:
5 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r70839 r70840  
     12010-10-28  James Robinson  <jamesr@chromium.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        iframes forced into slow scrolling mode by containing RenderLayer sometimes
     6        https://bugs.webkit.org/show_bug.cgi?id=48570
     7
     8        Adds a test that verifies that the repaint region for a scrolled iframe is not
     9        larger than necessary.
     10
     11        * fast/repaint/iframe-scroll-repaint.html: Added.
     12        * fast/repaint/resources/iframe-scroll-repaint-iframe.html: Added.
     13        * platform/mac/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
     14        * platform/mac/fast/repaint/iframe-scroll-repaint-expected.png: Added.
     15        * platform/mac/fast/repaint/iframe-scroll-repaint-expected.txt: Added.
     16
    1172010-10-28  Dmitry Titov  <dimich@chromium.org>
    218

  • trunk/WebCore/ChangeLog

    r70837 r70840  
     12010-10-28  James Robinson  <jamesr@chromium.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        iframes forced into slow scrolling mode by containing RenderLayer sometimes
     6        https://bugs.webkit.org/show_bug.cgi?id=48570
     7
     8        Only performs the overlap test for RenderLayers that paint themselves.  This
     9        prevents marking RenderWidgets as being overlapped unnecessarily.
     10
     11        Test: fast/repaint/iframe-scroll-repaint.html
     12
     13        * rendering/RenderLayer.cpp:
     14        (WebCore::RenderLayer::paintLayer):
     15
    1162010-10-28  Sheriff Bot  <webkit.review.bot@gmail.com>
    217

  • trunk/WebCore/rendering/RenderLayer.cpp

    r70664 r70840  
    24452445        paintingRootForRenderer = paintingRoot;
    24462446
    2447     if (overlapTestRequests)
     2447    if (overlapTestRequests && isSelfPaintingLayer())
    24482448        performOverlapTests(*overlapTestRequests, layerBounds);
    24492449
Note: See TracChangeset for help on using the changeset viewer.