Changeset 71010 in webkit


Ignore:
Timestamp:
Nov 1, 2010 12:07:20 AM (13 years ago)
Author:
pfeldman@chromium.org
Message:

2010-10-31 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: unhide new network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=48725

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.h:
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel):
  • inspector/front-end/Settings.js:
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addResourceToFrame): (WebInspector.StoragePanel.prototype.addDocumentURL): (WebInspector.StoragePanel.prototype.showFileSystem): (WebInspector.FileSystemTreeElement): (WebInspector.FileSystemTreeElement.prototype.get itemURL): (WebInspector.FileSystemTreeElement.prototype.onselect):
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
  • inspector/front-end/networkPanel.css: (#network-close-button): (.network.panel.viewing-resource #network-close-button):

2010-10-31 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: unhide new network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=48725

  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/inspector/resource-parameters-expected.txt:
  • inspector/console-log-syntax-error-expected.txt:
  • inspector/elements-panel-styles-expected.txt:

2010-10-31 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: unhide new network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=48725

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
Location:
trunk
Files:
16 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r71005 r71010  
     12010-10-31  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        Web Inspector: unhide new network and resources panels.
     6        https://bugs.webkit.org/show_bug.cgi?id=48725
     7
     8        * http/tests/inspector/console-xhr-logging-expected.txt:
     9        * http/tests/inspector/resource-parameters-expected.txt:
     10        * inspector/console-log-syntax-error-expected.txt:
     11        * inspector/elements-panel-styles-expected.txt:
     12
    1132010-10-31  Jeremy Moskovich  <jeremy@chromium.org>
    214
  • trunk/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt

    r66735 r71010  
    1313XHR finished loading: "http://127.0.0.1:8000/inspector/resources/xhr-exists.html".
    1414console-xhr-logging.html:40sending a GET request to resources/xhr-does-not-exist.html
    15 resources/xhr-does-not-exist.htmlFailed to load resource: the server responded with a status of 404 (Not Found)
     15xhr-does-not-exist.htmlFailed to load resource: the server responded with a status of 404 (Not Found)
    1616XHR finished loading: "http://127.0.0.1:8000/inspector/resources/xhr-does-not-exist.html".
    1717console-xhr-logging.html:40sending a POST request to resources/post-target.cgi
     
    2020console-xhr-logging.html:40sending a GET request to resources/xhr-exists.html
    2121console-xhr-logging.html:40sending a GET request to resources/xhr-does-not-exist.html
    22 resources/xhr-does-not-exist.htmlFailed to load resource: the server responded with a status of 404 (Not Found)
     22xhr-does-not-exist.htmlFailed to load resource: the server responded with a status of 404 (Not Found)
    2323console-xhr-logging.html:40sending a POST request to resources/post-target.cgi
    2424
  • trunk/LayoutTests/http/tests/inspector/resource-parameters-expected.txt

    r67474 r71010  
    44
    55{
    6     pageref : "about:blank"
     6    pageref : "http://localhost:8000/inspector/resources/post-target.cgi?queryParam1=queryValue1&queryParam2="
    77    startedDateTime : <string>
    88    time : <number>
  • trunk/LayoutTests/inspector/elements-panel-styles-expected.txt

    r67469 r71010  
    33[expanded]  ()
    44color: blue;
    5     .foo, .foo::before - blue resources/elements-panel-styles.css:15
    6     /-- overloaded --/ .foo - black resources/elements-panel-styles.css:10
     5    .foo, .foo::before - blue elements-panel-styles.css:15
     6    /-- overloaded --/ .foo - black elements-panel-styles.css:10
    77display: none;
    88    element.style - none
    99    /-- overloaded --/ div - block user agent stylesheet
    1010font-family: serif;
    11     #container - serif resources/elements-panel-styles.css:5
     11    #container - serif elements-panel-styles.css:5
    1212font-size: 14px;
    13     #container - 14px resources/elements-panel-styles.css:5
    14     /-- overloaded --/ body - 12px resources/elements-panel-styles.css:1
     13    #container - 14px elements-panel-styles.css:5
     14    /-- overloaded --/ body - 12px elements-panel-styles.css:1
    1515margin-bottom: 2px;
    16     .foo - 2px resources/elements-panel-styles.css:10
     16    .foo - 2px elements-panel-styles.css:10
    1717margin-left: 0px;
    18     .foo - 0px resources/elements-panel-styles.css:10
     18    .foo - 0px elements-panel-styles.css:10
    1919margin-right: 0px;
    20     .foo - 0px resources/elements-panel-styles.css:10
     20    .foo - 0px elements-panel-styles.css:10
    2121margin-top: 10px;
    22     .foo - 10px resources/elements-panel-styles.css:10
     22    .foo - 10px elements-panel-styles.css:10
    2323
    2424[expanded] element.style { ()
     
    2626
    2727======== Matched CSS Rules ========
    28 [expanded] .foo { (resources/elements-panel-styles.css:33)
     28[expanded] .foo { (elements-panel-styles.css:33)
    2929
    30 [expanded] .foo, .foo::before { (resources/elements-panel-styles.css:15)
     30[expanded] .foo, .foo::before { (elements-panel-styles.css:15)
    3131color: blue;
    3232content: '[before Foo]';
    3333
    34 [expanded] .foo { (resources/elements-panel-styles.css:10)
     34[expanded] .foo { (elements-panel-styles.css:10)
    3535/-- overloaded --/ color: black;
    3636margin: 10px 0px 2px;
     
    4444
    4545======== Inherited from div#container ========
    46 [expanded] #container { (resources/elements-panel-styles.css:5)
     46[expanded] #container { (elements-panel-styles.css:5)
    4747font-family: serif;
    4848font-size: 14px;
    4949
    5050======== Inherited from body ========
    51 [expanded] body { (resources/elements-panel-styles.css:1)
     51[expanded] body { (elements-panel-styles.css:1)
    5252/-- overloaded --/ font-size: 12px;
    5353
    5454
    5555======== Pseudo ::before element ========
    56 [expanded] .foo::before { (resources/elements-panel-styles.css:37)
     56[expanded] .foo::before { (elements-panel-styles.css:37)
    5757
    58 [expanded] .foo::before { (resources/elements-panel-styles.css:20)
     58[expanded] .foo::before { (elements-panel-styles.css:20)
    5959color: red;
    6060
    61 [expanded] .foo, .foo::before { (resources/elements-panel-styles.css:15)
     61[expanded] .foo, .foo::before { (elements-panel-styles.css:15)
    6262/-- overloaded --/ color: blue;
    6363content: '[before Foo]';
     
    6565
    6666======== Pseudo ::after element ========
    67 [expanded] .foo::after { (resources/elements-panel-styles.css:28)
     67[expanded] .foo::after { (elements-panel-styles.css:28)
    6868content: '[after Foo 2]';
    6969font-family: courier;
    7070
    71 [expanded] .foo::after { (resources/elements-panel-styles.css:24)
     71[expanded] .foo::after { (elements-panel-styles.css:24)
    7272color: green;
    7373/-- overloaded --/ content: '[after Foo]';
  • trunk/WebCore/ChangeLog

    r71009 r71010  
     12010-10-31  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        Web Inspector: unhide new network and resources panels.
     6        https://bugs.webkit.org/show_bug.cgi?id=48725
     7
     8        * English.lproj/localizedStrings.js:
     9        * inspector/InspectorController.h:
     10        * inspector/front-end/NetworkPanel.js:
     11        (WebInspector.NetworkPanel):
     12        * inspector/front-end/Settings.js:
     13        * inspector/front-end/StoragePanel.js:
     14        (WebInspector.StoragePanel):
     15        (WebInspector.StoragePanel.prototype.reset):
     16        (WebInspector.StoragePanel.prototype.addResourceToFrame):
     17        (WebInspector.StoragePanel.prototype.addDocumentURL):
     18        (WebInspector.StoragePanel.prototype.showFileSystem):
     19        (WebInspector.FileSystemTreeElement):
     20        (WebInspector.FileSystemTreeElement.prototype.get itemURL):
     21        (WebInspector.FileSystemTreeElement.prototype.onselect):
     22        * inspector/front-end/inspector.js:
     23        (WebInspector.updateResource):
     24        * inspector/front-end/networkPanel.css:
     25        (#network-close-button):
     26        (.network.panel.viewing-resource #network-close-button):
     27
    1282010-10-26  MORITA Hajime  <morrita@google.com>
    229
  • trunk/WebCore/inspector/InspectorController.h

    r70956 r71010  
    8787class StorageArea;
    8888
    89 #define LEGACY_RESOURCE_TRACKING_ENABLED 1
     89#define LEGACY_RESOURCE_TRACKING_ENABLED 0
    9090
    9191#if LEGACY_RESOURCE_TRACKING_ENABLED
  • trunk/WebCore/inspector/front-end/NetworkPanel.js

    r70989 r71010  
    5757
    5858    var closeButtonElement = document.createElement("button");
    59     closeButtonElement.className = "network-close-button";
     59    closeButtonElement.id = "network-close-button";
    6060    closeButtonElement.addEventListener("click", this._toggleGridMode.bind(this), false);
    61     this._viewsContainerElement.appendChild(closeButtonElement);
     61    this.element.appendChild(closeButtonElement);
    6262
    6363    this._createSortingFunctions();
     
    6767    this._createFilterStatusBarItems();
    6868    this._createSummaryBar();
     69
     70    if (!WebInspector.applicationSettings.resourcesLargeRows)
     71        this._setLargerResources(WebInspector.applicationSettings.resourcesLargeRows);
    6972
    7073    this._popoverHelper = new WebInspector.PopoverHelper(this.element, this._getPopoverAnchor.bind(this), this._showPopover.bind(this), true);
     
    614617        this._largerResourcesButton = new WebInspector.StatusBarButton(WebInspector.UIString("Use small resource rows."), "network-larger-resources-status-bar-item");
    615618        this._largerResourcesButton.toggled = WebInspector.applicationSettings.resourcesLargeRows;
    616         if (!WebInspector.applicationSettings.resourcesLargeRows)
    617             this._setLargerResources(WebInspector.applicationSettings.resourcesLargeRows);
    618619        this._largerResourcesButton.addEventListener("click", this._toggleLargerResources.bind(this), false);
    619620    },
     
    902903            this._viewsContainerElement.removeStyleClass("small");
    903904        }
     905        this._positionSummaryBar();
    904906    },
    905907
  • trunk/WebCore/inspector/front-end/Resource.js

    r70853 r71010  
    2626 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2727 */
    28 
    2928WebInspector.Resource = function(identifier, url)
    3029{
     
    333332                break;
    334333            case WebInspector.Resource.Type.WebSocket:
    335                 this.category = WebInspector.resourceCategories.websocket;
     334                this.category = WebInspector.resourceCategories.websockets;
    336335                break;
    337336            case WebInspector.Resource.Type.Other:
     
    644643                callbacks[i](this._content, this._contentEncoded);
    645644            this._pendingContentCallbacks.length = 0;
     645            delete this._contentRequested;
    646646        }
    647647        WebInspector.ResourceManager.getContent(this, this._contentEncoded, onResourceContent.bind(this));
  • trunk/WebCore/inspector/front-end/ResourceManager.js

    r70989 r71010  
    8080        var resource = new WebInspector.Resource(identifier, url);
    8181        resource.loader = loader;
    82         resource.documentURL = loader.url;
     82        if (loader)
     83            resource.documentURL = loader.url;
    8384
    8485        this._resourcesById[identifier] = resource;
     
    137138
    138139        resource.cached = true;
     140        delete resource.timing;
    139141        WebInspector.panels.network.refreshResource(resource);
    140142    },
     
    268270    didCreateWebSocket: function(identifier, requestURL)
    269271    {
    270         this.identifierForInitialRequest(identifier, requestURL);
    271         var resource = this._resourcesById[identifier];
     272        var resource = this._createResource(identifier, requestURL);
    272273        resource.type = WebInspector.Resource.Type.WebSocket;
    273 
    274274        WebInspector.panels.network.refreshResource(resource);
    275275    },
     
    474474{
    475475    // FIXME: eventually, cached resources will have no identifiers.
    476     if (resource.loader)
     476    if (Preferences.networkPanelEnabled)
    477477        InspectorBackend.resourceContent(resource.loader.frameId, resource.url, base64Encode, callback);
    478478    else
  • trunk/WebCore/inspector/front-end/Settings.js

    r70989 r71010  
    4646    nativeInstrumentationEnabled: false,
    4747    resourceExportEnabled: false,
    48     networkPanelEnabled: false,
     48    networkPanelEnabled: true,
    4949    fileSystemEnabled: false,
    5050    useDataURLForResourceImageIcons: true
  • trunk/WebCore/inspector/front-end/StoragePanel.js

    r70989 r71010  
    6060
    6161    if (Preferences.fileSystemEnabled) {
    62         this.fileSystemListTreeElement = new WebInspector.StorageCategoryTreeElement(this, WebInspector.UIString("File System"), "file-system-storage-tree-item");
     62        this.fileSystemListTreeElement = new WebInspector.StorageCategoryTreeElement(this, WebInspector.UIString("File System"), "FileSystem", "file-system-storage-tree-item");
    6363        this.sidebarTree.appendChild(this.fileSystemListTreeElement);
    6464        this.fileSystemListTreeElement.expand();
     
    7575    this._domStorage = [];
    7676    this._cookieViews = {};
     77    this._origins = {};
    7778    this._domains = {};
    7879}
     
    8990    },
    9091
     92    elementsToRestoreScrollPositionsFor: function()
     93    {
     94        return [this.sidebarElement];
     95    },
     96
    9197    show: function()
    9298    {
    9399        WebInspector.Panel.prototype.show.call(this);
     100
     101        if (this.visibleView instanceof WebInspector.ResourceView) {
     102            // SourceViews are shared between the panels.
     103            this.visibleView.headersVisible = true;
     104            this.visibleView.show(this.storageViews);
     105        }
     106
    94107        if (this._initializedDefaultSelection)
    95108            return;
     
    117130    reset: function()
    118131    {
     132        this._origins = {};
    119133        this._domains = {};
    120134        for (var i = 0; i < this._databases.length; ++i) {
     
    199213    addResourceToFrame: function(frameId, resource)
    200214    {
    201         if (!this._domains[resource.domain]) {
    202             this._domains[resource.domain] = true;
    203             this.addCookieDomain(resource.domain);
    204             this.addApplicationCache(resource.domain);
    205         }
     215        this.addDocumentURL(resource.documentURL);
    206216
    207217        if (resource.statusCode >= 301 && resource.statusCode <= 303)
     
    245255        if (resource.type === WebInspector.Resource.Type.XHR) {
    246256            var resourceTreeElement = this._findTreeElementForResource(resource);
    247             resourceTreeElement.parent.removeChild(resourceTreeElement);
     257            if (resourceTreeElement)
     258                resourceTreeElement.parent.removeChild(resourceTreeElement);
    248259        }
    249260    },
     
    257268        this.databasesListTreeElement.appendChild(databaseTreeElement);
    258269    },
    259    
    260     addCookieDomain: function(domain)
    261     {
    262         var cookieDomainTreeElement = new WebInspector.CookieTreeElement(this, domain);
    263         this.cookieListTreeElement.appendChild(cookieDomainTreeElement);
     270
     271    addDocumentURL: function(url)
     272    {
     273        var parsedURL = url.asParsedURL();
     274        if (!parsedURL)
     275            return;
     276
     277        var domain = parsedURL.host;
     278        if (!this._domains[domain]) {
     279            this._domains[domain] = true;
     280
     281            var cookieDomainTreeElement = new WebInspector.CookieTreeElement(this, domain);
     282            this.cookieListTreeElement.appendChild(cookieDomainTreeElement);
     283
     284            var applicationCacheTreeElement = new WebInspector.ApplicationCacheTreeElement(this, domain);
     285            this.applicationCacheListTreeElement.appendChild(applicationCacheTreeElement);
     286        }
     287
     288        if (Preferences.fileSystemEnabled) {
     289            // FIXME: This should match the SecurityOrigin::toString(), add a test for this.
     290            var securityOrigin = parsedURL.scheme + "://" + parsedURL.host + (parsedURL.port ? (":" + parsedURL.port) : "");
     291            if (!this._origins[securityOrigin]) {
     292                this._origins[securityOrigin] = true;
     293                var fileSystemTreeElement = new WebInspector.FileSystemTreeElement(this, securityOrigin);
     294                this.fileSystemListTreeElement.appendChild(fileSystemTreeElement);
     295            }
     296        }
    264297    },
    265298
     
    275308    },
    276309
    277     addApplicationCache: function(domain)
    278     {
    279         var applicationCacheTreeElement = new WebInspector.ApplicationCacheTreeElement(this, domain);
    280         this.applicationCacheListTreeElement.appendChild(applicationCacheTreeElement);
    281     },
    282 
    283     addFileSystem: function(origin)
    284     {
    285         var fileSystemTreeElement = new WebInspector.FileSystemTreeElement(this, origin);
    286         this.fileSystemListTreeElement.appendChild(fileSystemTreeElement);
    287     },
    288    
    289310    selectDatabase: function(databaseId)
    290311    {
     
    410431    },
    411432
    412     showFileSystem: function(treeElement, fileSystemDomain)
    413     {
    414         this._fileSystemView =  new WebInspector.FileSystemView(treeElement, fileSystemDomain);
     433    showFileSystem: function(treeElement, origin)
     434    {
     435        this._fileSystemView = new WebInspector.FileSystemView(treeElement, origin);
    415436        this._innerShowView(this._fileSystemView);
    416437    },
     
    652673        function isAncestor(ancestor, object)
    653674        {
    654             console.error("There should be no calls to isAncestor, but there was one for ", object);
     675            // Redirects, XHRs do not belong to the tree, it is fine to silently return false here.
    655676            return false;
    656677        }
     
    658679        function getParent(object)
    659680        {
    660             console.error("There should be no calls to getParent, but there was one for ", object);
     681            // Redirects, XHRs do not belong to the tree, it is fine to silently return false here.
    661682            return null;
    662683        }
     
    10711092WebInspector.ApplicationCacheTreeElement.prototype.__proto__ = WebInspector.BaseStorageTreeElement.prototype;
    10721093
    1073 WebInspector.FileSystemTreeElement = function(storagePanel, fileSystemDomain)
     1094WebInspector.FileSystemTreeElement = function(storagePanel, origin)
    10741095{
    1075     WebInspector.BaseStorageTreeElement.call(this, storagePanel, null, fileSystemDomain ? fileSystemDomain : WebInspector.UIString("Local Files"), "file-system-storage-tree-item");
    1076     this._fileSystemDomain = fileSystemDomain;
     1096    WebInspector.BaseStorageTreeElement.call(this, storagePanel, null, origin, "file-system-storage-tree-item");
     1097    this._origin = origin;
    10771098}
    10781099
    10791100WebInspector.FileSystemTreeElement.prototype = {
     1101    get itemURL()
     1102    {
     1103        return "file-system://" + encodeURI(this._origin);
     1104    },
     1105
    10801106    onselect: function()
    10811107    {
    1082         this._storagePanel.showFileSystem(this, this._fileSystemDomain);
     1108        WebInspector.BaseStorageTreeElement.prototype.onselect.call(this);
     1109        this._storagePanel.showFileSystem(this, this._origin);
    10831110    }
    10841111}
  • trunk/WebCore/inspector/front-end/inspector.js

    r70956 r71010  
    5151var WebInspector = {
    5252    resources: {},
    53     cookieDomains: {},
    54     applicationCacheDomains: {},
    55     fileSystemOrigins: {},
    5653    missingLocalizedStrings: {},
    5754    pendingDispatches: 0,
     
    557554        xhr: new WebInspector.ResourceCategory("xhr", WebInspector.UIString("XHR"), "rgb(231,231,10)"),
    558555        fonts: new WebInspector.ResourceCategory("fonts", WebInspector.UIString("Fonts"), "rgb(255,82,62)"),
    559         websocket: new WebInspector.ResourceCategory("websockets", WebInspector.UIString("WebSocket"), "rgb(186,186,186)"), // FIXME: Decide the color.
     556        websockets: new WebInspector.ResourceCategory("websockets", WebInspector.UIString("WebSocket"), "rgb(186,186,186)"), // FIXME: Decide the color.
    560557        other: new WebInspector.ResourceCategory("other", WebInspector.UIString("Other"), "rgb(186,186,186)")
    561558    };
     
    12951292            this.mainResource = resource;
    12961293
    1297         var parsedURL = payload.documentURL.asParsedURL();
    1298         if (parsedURL) {
    1299             this._addCookieDomain(parsedURL.host);
    1300             this._addAppCacheDomain(parsedURL.host);
    1301             if (Preferences.fileSystemEnabled)
    1302                 // This should match the SecurityOrigin::toString(). FIXME: Add a test for this.
    1303                 this._addFileSystemOrigin(parsedURL.scheme + "://" + parsedURL.host + (parsedURL.port ? (":" + parsedURL.port) : ""));
    1304         }
     1294        this.panels.storage.addDocumentURL(payload.documentURL);
    13051295    }
    13061296
     
    13921382        payload.version);
    13931383    this.panels.storage.addDatabase(database);
    1394 }
    1395 
    1396 WebInspector._addCookieDomain = function(domain)
    1397 {
    1398     // Eliminate duplicate domains from the list.
    1399     if (domain in this.cookieDomains)
    1400         return;
    1401     this.cookieDomains[domain] = true;
    1402 
    1403     if (!this.panels.storage)
    1404         return;
    1405     this.panels.storage.addCookieDomain(domain);
    1406 }
    1407 
    1408 WebInspector._addAppCacheDomain = function(domain)
    1409 {
    1410     // Eliminate duplicate domains from the list.
    1411     if (domain in this.applicationCacheDomains)
    1412         return;
    1413     this.applicationCacheDomains[domain] = true;
    1414 
    1415     if (!this.panels.storage)
    1416         return;
    1417     this.panels.storage.addApplicationCache(domain);
    1418 }
    1419 
    1420 WebInspector._addFileSystemOrigin = function(origin)
    1421 {
    1422     if (!this.panels.storage)
    1423         return;
    1424     // Eliminate duplicate origins.
    1425     // FIXME: Move appcache/cookies/filesystem domain dup checks in StoragePanel.js
    1426     if (origin in this.fileSystemOrigins)
    1427         return;
    1428     this.fileSystemOrigins[origin] = true;
    1429     this.panels.storage.addFileSystem(origin);
    14301384}
    14311385
  • trunk/WebCore/inspector/front-end/networkPanel.css

    r70879 r71010  
    2323}
    2424
    25 .network.panel .data-grid td {
     25.network.panel .data-grid td:not(.network-summary) {
    2626    line-height: 17px;
    2727    height: 37px;
     
    488488    font-size: 11px;
    489489    font-weight: bold;
    490     padding-top: 1px;
     490    padding-top: 3px;
    491491    padding-left: 10px;
    492492    z-index: 2000;
     
    545545}
    546546
    547 .network-close-button {
     547#network-close-button {
    548548    position: absolute;
    549549    width: 14px;
     
    556556    right: 5px;
    557557    z-index: 10;
     558    display: none;
     559}
     560
     561.network.panel.viewing-resource #network-close-button  {
     562    display: block;
    558563}
    559564
  • trunk/WebKit/chromium/ChangeLog

    r70976 r71010  
     12010-10-31  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        Web Inspector: unhide new network and resources panels.
     6        https://bugs.webkit.org/show_bug.cgi?id=48725
     7
     8        * src/WebDevToolsAgentImpl.cpp:
     9        (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
     10
    1112010-10-29  Daniel Bates  <dbates@rim.com>
    212
  • trunk/WebKit/chromium/src/WebDevToolsAgentImpl.cpp

    r69948 r71010  
    265265        if (!ic->hasFrontend())
    266266            connectFrontend(true);
     267
     268#if LEGACY_RESOURCE_TRACKING_ENABLED
    267269        m_resourceTrackingWasEnabled = ic->resourceTrackingEnabled();
     270#endif
    268271        ic->startTimelineProfiler();
     272#if LEGACY_RESOURCE_TRACKING_ENABLED
    269273        if (!m_resourceTrackingWasEnabled) {
    270274            // TODO(knorton): Introduce some kind of agents dependency here so that
     
    272276            ic->setResourceTrackingEnabled(true);
    273277        }
     278#endif
    274279        m_debuggerAgentImpl->setAutoContinueOnException(true);
    275280    } else {
    276281      ic->stopTimelineProfiler();
     282#if LEGACY_RESOURCE_TRACKING_ENABLED       
    277283      if (!m_resourceTrackingWasEnabled)
    278284          ic->setResourceTrackingEnabled(false);
    279285      m_resourceTrackingWasEnabled = false;
     286#endif
    280287    }
    281288    m_client->runtimePropertyChanged(
Note: See TracChangeset for help on using the changeset viewer.