Changeset 71027 in webkit

Timestamp:

Nov 1, 2010 8:23:32 AM (13 years ago)

Author:

jschuh@chromium.org

Message:

2010-11-01 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Check for NULL node in SVGUseElement::associateInstancesWithShadowTreeElements loop
​https://bugs.webkit.org/show_bug.cgi?id=48741

• svg/custom/use-on-use-with-child-and-empty-target-expected.txt: Added.
• svg/custom/use-on-use-with-child-and-empty-target.svg: Added.

2010-11-01 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Check for NULL node in SVGUseElement::associateInstancesWithShadowTreeElements loop
​https://bugs.webkit.org/show_bug.cgi?id=48741

Test: svg/custom/use-on-use-with-child-and-empty-target.svg

• svg/SVGUseElement.cpp: (WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/custom/use-on-use-with-child-and-empty-target-expected.txt (added)
• LayoutTests/svg/custom/use-on-use-with-child-and-empty-target.svg (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/svg/SVGUseElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-11-01  Justin Schuh  <jschuh@chromium.org>
+
+        Reviewed by Dirk Schulze.
+
+        Check for NULL node in SVGUseElement::associateInstancesWithShadowTreeElements loop
+        https://bugs.webkit.org/show_bug.cgi?id=48741
+
+        * svg/custom/use-on-use-with-child-and-empty-target-expected.txt: Added.
+        * svg/custom/use-on-use-with-child-and-empty-target.svg: Added.
+
 2010-11-01  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-11-01  Justin Schuh  <jschuh@chromium.org>
+
+        Reviewed by Dirk Schulze.
+
+        Check for NULL node in SVGUseElement::associateInstancesWithShadowTreeElements loop
+        https://bugs.webkit.org/show_bug.cgi?id=48741
+
+        Test: svg/custom/use-on-use-with-child-and-empty-target.svg
+
+        * svg/SVGUseElement.cpp:
+        (WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
+
 2010-11-01  Mario Sanchez Prada  <msanchez@igalia.com>
 

trunk/WebCore/svg/SVGUseElement.cpp

@@ -949 +949 @@
            node = node->nextSibling();
 
+        if (!node)
+            break;
+
         associateInstancesWithShadowTreeElements(node, instance);
         node = node->nextSibling();