Changeset 71066 in webkit

Timestamp:

Nov 1, 2010 3:40:25 PM (13 years ago)

Author:

mdelaney@apple.com

Message:

2010-11-01 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Setting attr repeatDur=0 on SVG element causes hang
​https://bugs.webkit.org/show_bug.cgi?id=48785

Test: svg/animations/repeatDur-zero.xhtml

• svg/animation/SVGSMILElement.cpp: Fixing bound checking for legal repeatDur values.

2010-11-01 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Setting attr repeatDur=0 on SVG element causes hang
​https://bugs.webkit.org/show_bug.cgi?id=48785

• svg/animations/repeatDur-zero.xhtml: Added. Tests if setting attr repeatDur=0 causes a hang or not.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/svg/animations (added)
• LayoutTests/platform/mac/svg/animations/repeatDur-zero-expected.txt (added)
• LayoutTests/svg/animations/repeatDur-zero.xhtml (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/svg/animation/SVGSMILElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-11-01  Matthew Delaney  <mdelaney@apple.com>
+
+        Reviewed by Simon Fraser.
+
+        Setting attr repeatDur=0 on SVG element causes hang
+        https://bugs.webkit.org/show_bug.cgi?id=48785
+
+        * svg/animations/repeatDur-zero.xhtml: Added. Tests if setting attr repeatDur=0 causes a hang or not.
+
 2010-11-01  Dmitry Titov  <dimich@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-11-01  Matthew Delaney  <mdelaney@apple.com>
+
+        Reviewed by Simon Fraser.
+
+        Setting attr repeatDur=0 on SVG element causes hang
+        https://bugs.webkit.org/show_bug.cgi?id=48785
+
+        Test: svg/animations/repeatDur-zero.xhtml
+
+        * svg/animation/SVGSMILElement.cpp: Fixing bound checking for legal repeatDur values.
+
 2010-10-31  Adam Barth  <abarth@webkit.org>
 

trunk/WebCore/svg/animation/SVGSMILElement.cpp

@@ -529 +529 @@
     const AtomicString& value = getAttribute(SVGNames::repeatDurAttr);
     SMILTime clockValue = parseClockValue(value);
-    return m_cachedRepeatDur = clockValue < 0 ? SMILTime::unresolved() : clockValue;
+    m_cachedRepeatDur = clockValue <= 0 ? SMILTime::unresolved() : clockValue;
+    return m_cachedRepeatDur;
 }