Changeset 71123 in webkit

Timestamp:

Nov 2, 2010 9:44:27 AM (13 years ago)

Author:

zmo@google.com

Message:

2010-11-01 Zhenyao Mo <​zmo@google.com>

Reviewed by Andreas Kling.

vertexAttribPointer should generate INVALID_VALUE if the stride exceeds 255
​https://bugs.webkit.org/show_bug.cgi?id=48677

Test: fast/canvas/webgl/gl-vertexattribpointer.html

• html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::vertexAttribPointer): Generate INVALID_VALUE if stride > 255.

2010-11-01 Zhenyao Mo <​zmo@google.com>

Reviewed by Andreas Kling.

vertexAttribPointer should generate INVALID_VALUE if the stride exceeds 255
​https://bugs.webkit.org/show_bug.cgi?id=48677

• fast/canvas/webgl/gl-vertexattribpointer-expected.txt: Added.
• fast/canvas/webgl/gl-vertexattribpointer.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/canvas/webgl/gl-vertexattribpointer-expected.txt (added)
• LayoutTests/fast/canvas/webgl/gl-vertexattribpointer.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/canvas/WebGLRenderingContext.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-11-01  Zhenyao Mo  <zmo@google.com>
+
+        Reviewed by Andreas Kling.
+
+        vertexAttribPointer should generate INVALID_VALUE if the stride exceeds 255
+        https://bugs.webkit.org/show_bug.cgi?id=48677
+
+        * fast/canvas/webgl/gl-vertexattribpointer-expected.txt: Added.
+        * fast/canvas/webgl/gl-vertexattribpointer.html: Added.
+
 2010-11-02  Stephen White  <senorblanco@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-11-01  Zhenyao Mo  <zmo@google.com>
+
+        Reviewed by Andreas Kling.
+
+        vertexAttribPointer should generate INVALID_VALUE if the stride exceeds 255
+        https://bugs.webkit.org/show_bug.cgi?id=48677
+
+        Test: fast/canvas/webgl/gl-vertexattribpointer.html
+
+        * html/canvas/WebGLRenderingContext.cpp:
+        (WebCore::WebGLRenderingContext::vertexAttribPointer): Generate INVALID_VALUE if stride > 255.
+
 2010-11-01  Martin Robinson  <mrobinson@igalia.com>
 

trunk/WebCore/html/canvas/WebGLRenderingContext.cpp

@@ -2846 +2846 @@
         return;
     }
-    if (size < 1 || size > 4 || stride < 0 || offset < 0) {
+    if (size < 1 || size > 4 || stride < 0 || stride > 255 || offset < 0) {
         m_context->synthesizeGLError(GraphicsContext3D::INVALID_VALUE);
         return;