Changeset 71139 in webkit


Ignore:
Timestamp:
Nov 2, 2010 11:31:44 AM (13 years ago)
Author:
pfeldman@chromium.org
Message:

2010-11-02 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make properties and event listeners look consistent with the styles section.
​https://bugs.webkit.org/show_bug.cgi?id=48827

  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback): (WebInspector.PropertiesSidebarPane.prototype.update):
  • inspector/front-end/inspector.css: (.events-pane .section:not(:nth-of-type(1))): (.event-bar:first-child): (.section .header): (.section .header::before): (.section.expanded .header::before): (.section .header .title, .event-bar .header .title): (.section .header .subtitle, .event-bar .header .subtitle): (.section.expanded .properties, .event-bar.expanded .event-properties): (.properties-tree): (.event-bar): (.event-bars .event-bar .header): (.event-bars .event-bar .header .title): (.event-bars .event-bar .header::before):

2010-11-02 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make properties and event listeners look consistent with the styles section.
​https://bugs.webkit.org/show_bug.cgi?id=48827

  • src/js/devTools.css:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r71138 r71139  
     12010-11-02  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        Web Inspector: make properties and event listeners look consistent with the styles section.
     6        https://bugs.webkit.org/show_bug.cgi?id=48827
     7
     8        * inspector/front-end/EventListenersSidebarPane.js:
     9        * inspector/front-end/PropertiesSection.js:
     10        (WebInspector.PropertiesSection):
     11        * inspector/front-end/PropertiesSidebarPane.js:
     12        (WebInspector.PropertiesSidebarPane.prototype.update.callback):
     13        (WebInspector.PropertiesSidebarPane.prototype.update):
     14        * inspector/front-end/inspector.css:
     15        (.events-pane .section:not(:nth-of-type(1))):
     16        (.event-bar:first-child):
     17        (.section .header):
     18        (.section .header::before):
     19        (.section.expanded .header::before):
     20        (.section .header .title, .event-bar .header .title):
     21        (.section .header .subtitle, .event-bar .header .subtitle):
     22        (.section.expanded .properties, .event-bar.expanded .event-properties):
     23        (.properties-tree):
     24        (.event-bar):
     25        (.event-bars .event-bar .header):
     26        (.event-bars .event-bar .header .title):
     27        (.event-bars .event-bar .header::before):
     28
    1292010-11-02  Dan Bernstein  <mitz@apple.com>
    230

  • trunk/WebCore/inspector/front-end/EventListenersSidebarPane.js

    r71109 r71139  
    152152            var eventListener = filteredEventListeners[i];
    153153            var eventListenerBar = new WebInspector.EventListenerBar(eventListener, this._nodeId);
    154             if (i < length - 1) {
    155                 var connector = document.createElement("div");
    156                 connector.className = "event-bar-connector";
    157                 eventListenerBar.element.appendChild(connector);
    158             }
    159 
    160154            this.eventBars.appendChild(eventListenerBar.element);
    161155        }
    … …  
    179173    this.editable = false;
    180174    this.element.className = "event-bar"; /* Changed from "section" */
     175    this.headerElement.addStyleClass("source-code");
    181176    this.propertiesElement.className = "event-properties properties-tree source-code"; /* Changed from "properties" */
    182177}

  • trunk/WebCore/inspector/front-end/PropertiesSidebarPane.js

    r65499 r71139  
    5555                if (title.match(/Prototype$/))
    5656                    title = title.replace(/Prototype$/, "");
    57                 var section = new WebInspector.ObjectPropertiesSection(prototype, title, WebInspector.UIString("Prototype"));
     57                var section = new WebInspector.ObjectPropertiesSection(prototype, title);
    5858                self.sections.push(section);
    5959                body.appendChild(section.element);

  • trunk/WebCore/inspector/front-end/inspector.css

    r71109 r71139  
    13121312}
    13131313
    1314 .section:nth-last-of-type(1), .event-bar:nth-last-of-type(1) {
    1315     margin-bottom: 1px;
    1316 }
    1317 
    13181314.watch-expressions-buttons-container {
    13191315    text-align: center;
    13201316}
    13211317
     1318.events-pane .section:not(:nth-of-type(1)) {
     1319    border-top: 1px solid rgb(191, 191, 191);
     1320}
     1321
    13221322.event-bar:first-child {
    13231323    margin-top: 1px;
    13241324}
    13251325
    1326 .event-bar:nth-last-of-type(1) .header {
    1327     border-bottom: 1px solid rgb(163, 163, 163);
    1328 }
    1329 
    13301326.section .header {
    1331     padding: 2px 8px 4px 18px;
    1332     border-top: 1px solid rgb(145, 160, 192);
    1333     background-image: -webkit-gradient(linear, left top, left bottom, from(rgb(162, 177, 207)), to(rgb(120, 138, 177)));
     1327    color: rgb(50, 50, 50);
     1328    padding: 0 8px 0 18px;
    13341329    min-height: 18px;
    13351330    white-space: nowrap;
    13361331    -webkit-background-origin: padding;
    13371332    -webkit-background-clip: padding;
     1333    opacity: 0.8;
    13381334}
    13391335
    13401336.section .header::before {
    13411337    position: absolute;
    1342     top: 4px;
     1338    top: 2px;
    13431339    left: 7px;
    13441340    width: 8px;
    13451341    height: 8px;
    1346     content: url(Images/treeRightTriangleWhite.png);
     1342    content: url(Images/treeRightTriangleBlack.png);
    13471343}
    13481344
    13491345.section.expanded .header::before {
    1350     content: url(Images/treeDownTriangleWhite.png);
     1346    content: url(Images/treeDownTriangleBlack.png);
    13511347}
    13521348
    13531349.section .header .title, .event-bar .header .title {
    1354     color: white;
    13551350    font-weight: bold;
    13561351    word-wrap: break-word;
    13571352    white-space: normal;
     1353    font-size: 12px;
    13581354}
    13591355
    … …  
    13721368.section .header .subtitle, .event-bar .header .subtitle {
    13731369    float: right;
    1374     font-size: 10px;
     1370    font-size: 12px;
    13751371    margin-left: 5px;
    13761372    max-width: 55%;
    1377     color: rgba(255, 255, 255, 0.7);
    13781373    text-overflow: ellipsis;
    13791374    overflow: hidden;
    … …  
    13901385.section.expanded .properties, .event-bar.expanded .event-properties {
    13911386    display: block;
     1387    padding-left: 18px;
    13921388}
    13931389
    … …  
    14021398.properties-tree {
    14031399    margin: 0;
    1404     padding: 2px 6px 3px;
     1400    padding: 0 6px 2px;
    14051401    list-style: none;
    14061402    min-height: 18px;
    … …  
    14801476.event-bar {
    14811477    position: relative;
    1482 }
    1483 
    1484 .event-bar-connector {
    1485     position: absolute;
    1486     left: 75%;
    1487     bottom: -7px;
    1488     margin-left: -7px;
    1489     content: url(Images/grayConnectorPoint.png);
    1490     z-index: 3;
    1491 }
    1492 
    1493 .event-bar.expanded .event-bar-connector {
    1494     content: url(Images/whiteConnectorPoint.png);
     1478    left: 12px;
    14951479}
    14961480
    14971481.event-bars .event-bar .header {
    1498     padding: 2px 8px 4px 18px;
    1499     border-top: 1px solid rgb(163, 163, 163);
    1500     background-image: -webkit-gradient(linear, left top, left bottom, from(rgb(243, 243, 243)), to(rgb(207, 207, 207)));
    1501     min-height: 18px;
     1482    padding: 0 8px 0 18px;
     1483    min-height: 16px;
     1484    opacity: 1.0;
    15021485    white-space: nowrap;
    15031486    -webkit-background-origin: padding;
    … …  
    15051488}
    15061489
    1507 .event-bars .event-bar.expanded .header {
    1508     border-bottom: 1px solid rgb(163, 163, 163);
    1509 }
    1510 
    15111490.event-bars .event-bar .header .title {
    1512     font-weight: bold;
     1491    font-weight: normal;
    15131492    color: #333;
    15141493    text-shadow: white 0 1px 0;
    … …  
    15211500.event-bars .event-bar .header::before {
    15221501    position: absolute;
    1523     top: 4px;
     1502    top: 0;
    15241503    left: 7px;
    15251504    width: 8px;

  • trunk/WebKit/chromium/ChangeLog

    r71077 r71139  
     12010-11-02  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        Web Inspector: make properties and event listeners look consistent with the styles section.
     6        https://bugs.webkit.org/show_bug.cgi?id=48827
     7
     8        * src/js/devTools.css:
     9
    1102010-11-01  Tony Chang  <tony@chromium.org>
    211

  • trunk/WebKit/chromium/src/js/devTools.css

    r66752 r71139  
    3636    font-weight: normal;
    3737    line-height: 12px;
    38 }
    39 
    40 .section > .header {
    41     border: 1px solid rgb(92, 116, 157);
    42     background-image: -webkit-gradient(linear, left top, left bottom, from(rgb(105, 133, 180)), to(rgb(92, 116, 157)));
    4338}
    4439
Note: See TracChangeset for help on using the changeset viewer.