Changeset 71232 in webkit


Ignore:
Timestamp:
Nov 3, 2010 5:15:21 AM (13 years ago)
Author:
Nikolas Zimmermann
Message:

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48898

Fix Chromium/V8 build for real, verified using a local ToT Chromium build.

  • bindings/scripts/CodeGeneratorV8.pm:
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r71230 r71232  
     12010-11-03  Nikolas Zimmermann  <nzimmermann@rim.com>
     2
     3        Not reviewed.
     4
     5        Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
     6        https://bugs.webkit.org/show_bug.cgi?id=48898
     7
     8        Fix Chromium/V8 build for real, verified using a local ToT Chromium build.
     9
     10        * bindings/scripts/CodeGeneratorV8.pm:
     11
    1122010-11-03  Nikolas Zimmermann  <nzimmermann@rim.com>
    213
  • trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r71230 r71232  
    229229    } elsif ($svgNativeType =~ /SVGStringListPropertyTearOff/) {
    230230        $svgListPropertyType = "SVGStringList";
    231         $implIncludes{"SVGStringListPropertyTearOff.h"} = 1;
    232231        $implIncludes{"$svgWrappedNativeType.h"} = 1;
    233232    }
     
    276275    push(@headerContent, "\ntemplate<typename PODType> class V8SVGPODTypeWrapper;\n") if $podType;
    277276    push(@headerContent, "\ntemplate<typename PropertyType> class SVGPropertyTearOff;\n") if $svgPropertyType;
    278     if ($svgListPropertyType eq "SVGStringList") {
    279         push(@headerContent, "\nclass SVGStringListPropertyTearOff;\n");
    280     } else {
    281         push(@headerContent, "\ntemplate<typename PropertyType> class SVGListPropertyTearOff;\n");
     277    if ($svgListPropertyType) {
     278        if ($svgListPropertyType eq "SVGStringList") {
     279            push(@headerContent, "\nclass SVGStringListPropertyTearOff;\n");
     280        } else {
     281            push(@headerContent, "\ntemplate<typename PropertyType> class SVGListPropertyTearOff;\n");
     282        }
    282283    }
    283284    push(@headerContent, "\nclass $className {\n");
     
    752753    } elsif ($svgNativeType) {
    753754        my $svgWrappedNativeType = $codeGenerator->GetSVGWrappedTypeNeedingTearOff($implClassName);
    754         if ($svgWrappedNativeType =~ /List$/) {
     755        if ($svgWrappedNativeType =~ /List$/ or $implClassName eq "SVGStringList") {
    755756            push(@implContentDecls, <<END);
    756757    $svgNativeType* imp = V8${implClassName}::toNative(info.Holder());
     
    932933        my $tearOffType = $codeGenerator->GetSVGTypeNeedingTearOff($attrType);
    933934        if ($tearOffType eq "SVGStringListPropertyTearOff") {
     935            $implIncludes{"SVGStringListPropertyTearOff.h"} = 1;
    934936            my $extraImp = "GetOwnerElementForType<$implClassName, IsDerivedFromSVGElement<$implClassName>::value>::ownerElement(imp), ";
    935937            push(@implContentDecls, "    return toV8(WTF::getPtr(${tearOffType}::create($extraImp$result)));\n");
Note: See TracChangeset for help on using the changeset viewer.