Changeset 71268 in webkit


Ignore:
Timestamp:
Nov 3, 2010 2:19:29 PM (13 years ago)
Author:
mdelaney@apple.com
Message:

2010-11-03 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

Fix canvas/philip/tests/2d.pattern.image.undefined.html
https://bugs.webkit.org/show_bug.cgi?id=48894

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: Changed error thrown to match the spec.

2010-11-03 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

Fix canvas/philip/tests/2d.pattern.image.undefined.html
https://bugs.webkit.org/show_bug.cgi?id=48894

  • canvas/philip/tests/2d.pattern.image.string.html: Updated test to agree with spec.
  • platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.null-expected.txt: Removed. Now passing.
  • platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.undefined-expected.txt: Removed. Now passing.
  • platform/mac-leopard/Skipped: Removed now passing tests.
  • platform/gtk/Skipped: Removed now passing tests.
  • platform/qt/Skipped: Removed now passing tests.
Location:
trunk
Files:
2 deleted
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r71267 r71268  
     12010-11-03  Matthew Delaney  <mdelaney@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Fix canvas/philip/tests/2d.pattern.image.undefined.html
     6        https://bugs.webkit.org/show_bug.cgi?id=48894
     7
     8        * canvas/philip/tests/2d.pattern.image.string.html: Updated test to agree with spec.
     9        * platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.null-expected.txt: Removed. Now passing.
     10        * platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.undefined-expected.txt: Removed. Now passing.
     11        * platform/mac-leopard/Skipped: Removed now passing tests.
     12        * platform/gtk/Skipped: Removed now passing tests.
     13        * platform/qt/Skipped: Removed now passing tests.
     14
    1152010-11-03  Dumitru Daniliuc  <dumi@chromium.org>
    216
  • trunk/LayoutTests/canvas/philip/tests/2d.pattern.image.string.html

    r63623 r71268  
    2222_addTest(function(canvas, ctx) {
    2323
    24 try { var _thrown = false;
    25   ctx.createPattern('../images/red.png', 'repeat');
    26 } catch (e) { if (!(e instanceof TypeError)) _fail("Failed assertion: expected exception of type TypeError, got: "+e); _thrown = true; } finally { _assert(_thrown, "should throw exception of type TypeError: ctx.createPattern('../images/red.png', 'repeat')"); }
     24try { var _thrown = false; ctx.createPattern('../images/red.png', 'repeat');} catch (e) { if (e.code != DOMException.TYPE_MISMATCH_ERR) _fail("Failed assertion: expected exception of type TYPE_MISMATCH_ERR, got: "+e.message); _thrown = true; } finally { _assert(_thrown, "should throw exception of type TYPE_MISMATCH_ERR: ctx.createPattern('../images/red.png', 'repeat')"); }
    2725
    2826
  • trunk/LayoutTests/platform/gtk/Skipped

    r71221 r71268  
    53795379canvas/philip/tests/2d.pattern.image.broken.html
    53805380canvas/philip/tests/2d.pattern.image.incomplete.html
    5381 canvas/philip/tests/2d.pattern.image.null.html
    5382 canvas/philip/tests/2d.pattern.image.undefined.html
    53835381canvas/philip/tests/2d.shadow.enable.blur.html
    53845382canvas/philip/tests/2d.shadow.enable.x.html
  • trunk/LayoutTests/platform/mac-leopard/Skipped

    r71011 r71268  
    135135canvas/philip/tests/2d.pattern.image.broken.html
    136136canvas/philip/tests/2d.pattern.image.incomplete.html
    137 canvas/philip/tests/2d.pattern.image.null.html
    138 canvas/philip/tests/2d.pattern.image.undefined.html
    139137canvas/philip/tests/2d.shadow.enable.blur.html
    140138canvas/philip/tests/2d.shadow.enable.x.html
  • trunk/LayoutTests/platform/qt/Skipped

    r71102 r71268  
    52065206canvas/philip/tests/2d.pattern.image.broken.html
    52075207canvas/philip/tests/2d.pattern.image.incomplete.html
    5208 canvas/philip/tests/2d.pattern.image.null.html
    5209 canvas/philip/tests/2d.pattern.image.undefined.html
    52105208canvas/philip/tests/2d.shadow.transform.2.html
    52115209canvas/philip/tests/2d.text.draw.baseline.bottom.html
  • trunk/WebCore/ChangeLog

    r71266 r71268  
     12010-11-03  Matthew Delaney  <mdelaney@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Fix canvas/philip/tests/2d.pattern.image.undefined.html
     6        https://bugs.webkit.org/show_bug.cgi?id=48894
     7
     8        * bindings/js/JSCanvasRenderingContext2DCustom.cpp: Changed error thrown to match the spec.
     9
    1102010-11-03  Simon Fraser  <simon.fraser@apple.com>
    211
  • trunk/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp

    r65613 r71268  
    344344
    345345    JSValue value = exec->argument(0);
    346     if (!value.isObject())
    347         return throwTypeError(exec);
     346    if (!value.isObject()) {
     347        setDOMException(exec, TYPE_MISMATCH_ERR);
     348        return jsUndefined();
     349    }
    348350    JSObject* o = asObject(value);
    349351
Note: See TracChangeset for help on using the changeset viewer.