Changeset 71296 in webkit

Timestamp:

Nov 3, 2010 6:55:38 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-11-03 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use sentence boundaries instead of start/end sentence
​https://bugs.webkit.org/show_bug.cgi?id=48422

Using sentence boundaries all intersentence
whitespace/control/format characters are assigned to a
sentence. This is what ICU does, so we have to do the same in
order to get the same results with glib unicode backend. It fixes
the sentence tests cases in test fast/dom/Range/range-expand.html.

• platform/text/gtk/TextBreakIteratorGtk.cpp: (WebCore::textBreakNext): (WebCore::textBreakPrevious):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/text/gtk/TextBreakIteratorGtk.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] Use sentence boundaries instead of start/end sentence
+        https://bugs.webkit.org/show_bug.cgi?id=48422
+
+        Using sentence boundaries all intersentence
+        whitespace/control/format characters are assigned to a
+        sentence. This is what ICU does, so we have to do the same in
+        order to get the same results with glib unicode backend. It fixes
+        the sentence tests cases in test fast/dom/Range/range-expand.html.
+
+        * platform/text/gtk/TextBreakIteratorGtk.cpp:
+        (WebCore::textBreakNext):
+        (WebCore::textBreakPrevious):
+
 2010-11-03  Zhenyao Mo  <zmo@google.com>
 

trunk/WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp

@@ -301 +301 @@
             || (iterator->m_type == UBRK_WORD && (iterator->m_logAttrs[index].is_word_start || iterator->m_logAttrs[index].is_word_end))
             || (iterator->m_type == UBRK_CHARACTER && iterator->m_logAttrs[index].is_cursor_position)
-            || (iterator->m_type == UBRK_SENTENCE && (iterator->m_logAttrs[index].is_sentence_start || iterator->m_logAttrs[index].is_sentence_end)) ) {
+            || (iterator->m_type == UBRK_SENTENCE && iterator->m_logAttrs[index].is_sentence_boundary)) {
             break;
         }
@@ -316 +316 @@
             || (iterator->m_type == UBRK_WORD && (iterator->m_logAttrs[index].is_word_start || iterator->m_logAttrs[index].is_word_end))
             || (iterator->m_type == UBRK_CHARACTER && iterator->m_logAttrs[index].is_cursor_position)
-            || (iterator->m_type == UBRK_SENTENCE && (iterator->m_logAttrs[index].is_sentence_start || iterator->m_logAttrs[index].is_sentence_end)) ) {
+            || (iterator->m_type == UBRK_SENTENCE && iterator->m_logAttrs[index].is_sentence_boundary)) {
             break;
         }