Changeset 71314 in webkit


Ignore:
Timestamp:
Nov 4, 2010 1:49:37 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2010-11-04 Shane Stephens <shanestephens@google.com>

Reviewed by Tony Chang.

SVGStyledTransformableElement supplemental transforms pre-multiplied
but should be post-multiplied.
https://bugs.webkit.org/show_bug.cgi?id=48026

  • svg/animations/animate-path-nested-transforms-expected.txt: Added.
  • svg/animations/animate-path-nested-transforms.svg: Added.

2010-11-04 Shane Stephens <shanestephens@google.com>

Reviewed by Tony Chang.

SVGStyledTransformableElement supplemental transforms pre-multiplied
but should be post-multiplied.
https://bugs.webkit.org/show_bug.cgi?id=48026

Test: svg/animations/animate-path-nested-transforms.svg

  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::animatedLocalTransform):

Switched order of multiplication. Note that due to a bug in
AffineTransform's operator* implementation the order of arguments is
reversed (see http://bugs.webkit.org/show_bug.cgi?id=48031).

Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r71313 r71314  
     12010-11-04  Shane Stephens  <shanestephens@google.com>
     2
     3        Reviewed by Tony Chang.
     4
     5        SVGStyledTransformableElement supplemental transforms pre-multiplied
     6        but should be post-multiplied.
     7        https://bugs.webkit.org/show_bug.cgi?id=48026
     8
     9        * svg/animations/animate-path-nested-transforms-expected.txt: Added.
     10        * svg/animations/animate-path-nested-transforms.svg: Added.
     11
    1122010-11-04  James Simonsen  <simonjam@chromium.org>
    213
  • trunk/WebCore/ChangeLog

    r71313 r71314  
     12010-11-04  Shane Stephens  <shanestephens@google.com>
     2
     3        Reviewed by Tony Chang.
     4
     5        SVGStyledTransformableElement supplemental transforms pre-multiplied
     6        but should be post-multiplied.
     7        https://bugs.webkit.org/show_bug.cgi?id=48026
     8
     9        Test: svg/animations/animate-path-nested-transforms.svg
     10
     11        * svg/SVGStyledTransformableElement.cpp:
     12        (WebCore::SVGStyledTransformableElement::animatedLocalTransform):
     13       
     14        Switched order of multiplication.  Note that due to a bug in
     15        AffineTransform's operator* implementation the order of arguments is
     16        reversed (see http://bugs.webkit.org/show_bug.cgi?id=48031).
     17
    1182010-11-04  James Simonsen  <simonjam@chromium.org>
    219
  • trunk/WebCore/svg/SVGStyledTransformableElement.cpp

    r70323 r71314  
    5555AffineTransform SVGStyledTransformableElement::animatedLocalTransform() const
    5656{
    57     return m_supplementalTransform ? transform()->concatenate().matrix() * *m_supplementalTransform : transform()->concatenate().matrix();
     57    return m_supplementalTransform ? *m_supplementalTransform * transform()->concatenate().matrix() : transform()->concatenate().matrix();
    5858}
    5959   
Note: See TracChangeset for help on using the changeset viewer.