Changeset 71317 in webkit

Timestamp:

Nov 4, 2010 2:59:46 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-11-04 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Ignore static text children of text field controls in the accessibility tree.
​https://bugs.webkit.org/show_bug.cgi?id=48944

• accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AccessibilityRenderObject.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-11-04  Chris Guillory  <chris.guillory@google.com>
+
+        Reviewed by Chris Fleizach.
+
+        Ignore static text children of text field controls in the accessibility tree.
+        https://bugs.webkit.org/show_bug.cgi?id=48944
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
+
 2010-11-04  Erik Arvidsson  <arv@chromium.org>
 

trunk/WebCore/accessibility/AccessibilityRenderObject.cpp

@@ -1774 +1774 @@
         if (m_renderer->isBR() || !renderText->firstTextBox())
             return true;
-        
+
+        // static text beneath TextControls is reported along with the text control text so it's ignored.
+        for (AccessibilityObject* parent = parentObject(); parent; parent = parent->parentObject()) { 
+            if (parent->roleValue() == TextFieldRole)
+                return true;
+        }
+
         // text elements that are just empty whitespace should not be returned
         return renderText->text()->containsOnlyWhitespace();