Changeset 71399 in webkit


Ignore:
Timestamp:
Nov 5, 2010 2:42:42 AM (13 years ago)
Author:
rolandsteiner@chromium.org
Message:

2010-11-05 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dirk Schulze.

Bug 48979 - [Chromium] SVGListPropertyTearOff.h: function commitChange ASSERTs on Win & Mac
https://bugs.webkit.org/show_bug.cgi?id=48979

Remove Chromium expectation entry.

  • platform/chromium/test_expectations.txt:

2010-11-05 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dirk Schulze.

Bug 48979 - [Chromium] SVGListPropertyTearOff.h: function commitChange ASSERTs on Win & Mac
https://bugs.webkit.org/show_bug.cgi?id=48979

Function removeItemValuesAndWrappers(): Move code out of 'if' statement so that
'wrappers' and 'values' stay synced.

test: svg/dom/baseVal-animVal-crash.html doesn't ASSERT

  • svg/properties/SVGListProperty.h: (WebCore::SVGListProperty::removeItemValuesAndWrappers):
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r71397 r71399  
     12010-11-05  Roland Steiner  <rolandsteiner@chromium.org>
     2
     3        Reviewed by Dirk Schulze.
     4
     5        Bug 48979 - [Chromium] SVGListPropertyTearOff.h: function commitChange ASSERTs on Win & Mac
     6        https://bugs.webkit.org/show_bug.cgi?id=48979
     7
     8        Remove Chromium expectation entry.
     9
     10        * platform/chromium/test_expectations.txt:
     11
    1122010-11-05  Fumitoshi Ukai  <ukai@chromium.org>
    213
  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r71397 r71399  
    33903390BUG48973 WIN LINUX : editing/style/iframe-onload-crash.html = CRASH
    33913391
    3392 // started to ASSERT somewhere between WebKit r71224 and r71305
    3393 BUG48979 WIN MAC DEBUG : svg/dom/baseVal-animVal-crash.html = CRASH
    3394 
    33953392// Added in r71317
    33963393BUG61978 WIN MAC : svg/animations/animate-path-nested-transforms.html = CRASH PASS
  • trunk/WebCore/ChangeLog

    r71396 r71399  
     12010-11-05  Roland Steiner  <rolandsteiner@chromium.org>
     2
     3        Reviewed by Dirk Schulze.
     4
     5        Bug 48979 - [Chromium] SVGListPropertyTearOff.h: function commitChange ASSERTs on Win & Mac
     6        https://bugs.webkit.org/show_bug.cgi?id=48979
     7
     8        Function removeItemValuesAndWrappers(): Move code out of 'if' statement so that
     9        'wrappers' and 'values' stay synced.
     10
     11        test: svg/dom/baseVal-animVal-crash.html doesn't ASSERT
     12
     13        * svg/properties/SVGListProperty.h:
     14        (WebCore::SVGListProperty::removeItemValuesAndWrappers):
     15
    1162010-11-05  John Reck  <jreck@google.com>
    217
  • trunk/WebCore/svg/properties/SVGListProperty.h

    r71329 r71399  
    338338        // Detach the existing wrapper.
    339339        RefPtr<ListItemTearOff>& oldItem = wrappers.at(index);
    340         if (oldItem) {
     340        if (oldItem)
    341341            oldItem->detachWrapper();
    342             wrappers.remove(index);
    343         }
    344 
     342
     343        wrappers.remove(index);
    345344        values.remove(index);
    346345
Note: See TracChangeset for help on using the changeset viewer.