Changeset 71437 in webkit

Timestamp:

Nov 5, 2010 11:24:27 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-11-05 Charlie Reis <​creis@chromium.org>

Reviewed by Darin Fisher.

Need to expose HistoryController::previousItem() for Chromium WebKit API.
​https://bugs.webkit.org/show_bug.cgi?id=48809

• loader/HistoryController.h:

2010-11-05 Charlie Reis <​creis@chromium.org>

Reviewed by Darin Fisher.

WebFrame::previousHistoryItem() should return last committed item.
​https://bugs.webkit.org/show_bug.cgi?id=48809

• src/WebFrameImpl.cpp:

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/loader/HistoryController.h (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/src/WebFrameImpl.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-11-05  Charlie Reis  <creis@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        Need to expose HistoryController::previousItem() for Chromium WebKit API.
+        https://bugs.webkit.org/show_bug.cgi?id=48809
+
+        * loader/HistoryController.h:
+
 2010-11-05  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/WebCore/loader/HistoryController.h

@@ -76 +76 @@
     bool currentItemShouldBeReplaced() const;
 
+    HistoryItem* previousItem() const { return m_previousItem.get(); }
+
     HistoryItem* provisionalItem() const { return m_provisionalItem.get(); }
     void setProvisionalItem(HistoryItem*);

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-11-05  Charlie Reis  <creis@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        WebFrame::previousHistoryItem() should return last committed item.
+        https://bugs.webkit.org/show_bug.cgi?id=48809
+
+        * src/WebFrameImpl.cpp:
+
 2010-10-27  Jeremy Orlow  <jorlow@chromium.org>
 

trunk/WebKit/chromium/src/WebFrameImpl.cpp

@@ -987 +987 @@
     // is expected to query the history item after a navigation occurs, after
     // the desired history item has become the previous entry.
-    return WebHistoryItem(viewImpl()->previousHistoryItem());
+    return WebHistoryItem(m_frame->loader()->history()->previousItem());
 }