Changeset 71452 in webkit


Ignore:
Timestamp:
Nov 5, 2010 3:00:54 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2010-11-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Simon Fraser.

Querying selection start and end should be const
https://bugs.webkit.org/show_bug.cgi?id=48786

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selectionStart): (WebCore::RenderTextControl::selectionEnd): (WebCore::RenderTextControl::visiblePositionForIndex): (WebCore::RenderTextControl::indexForVisiblePosition):
  • rendering/RenderTextControl.h:

2010-11-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Simon Fraser.

Querying selection start and end should be const
https://bugs.webkit.org/show_bug.cgi?id=48786

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::selectionStart): (WebKit::WebInputElement::selectionEnd):
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r71451 r71452  
     12010-11-05  Ilya Sherman  <isherman@chromium.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Querying selection start and end should be const
     6        https://bugs.webkit.org/show_bug.cgi?id=48786
     7
     8        * rendering/RenderTextControl.cpp:
     9        (WebCore::RenderTextControl::selectionStart):
     10        (WebCore::RenderTextControl::selectionEnd):
     11        (WebCore::RenderTextControl::visiblePositionForIndex):
     12        (WebCore::RenderTextControl::indexForVisiblePosition):
     13        * rendering/RenderTextControl.h:
     14
    1152010-11-05  Chris Marrin  <cmarrin@apple.com>
    216
  • trunk/WebCore/rendering/RenderTextControl.cpp

    r70945 r71452  
    201201}
    202202
    203 int RenderTextControl::selectionStart()
     203int RenderTextControl::selectionStart() const
    204204{
    205205    Frame* frame = this->frame();
     
    209209}
    210210
    211 int RenderTextControl::selectionEnd()
     211int RenderTextControl::selectionEnd() const
    212212{
    213213    Frame* frame = this->frame();
     
    265265}
    266266
    267 VisiblePosition RenderTextControl::visiblePositionForIndex(int index)
     267VisiblePosition RenderTextControl::visiblePositionForIndex(int index) const
    268268{
    269269    if (index <= 0)
     
    282282}
    283283
    284 int RenderTextControl::indexForVisiblePosition(const VisiblePosition& pos)
     284int RenderTextControl::indexForVisiblePosition(const VisiblePosition& pos) const
    285285{
    286286    Position indexPosition = pos.deepEquivalent();
  • trunk/WebCore/rendering/RenderTextControl.h

    r70945 r71452  
    4141    void setLastChangeWasUserEdit(bool lastChangeWasUserEdit);
    4242
    43     int selectionStart();
    44     int selectionEnd();
     43    int selectionStart() const;
     44    int selectionEnd() const;
    4545    PassRefPtr<Range> selection(int start, int end) const;
    4646
     
    5050    void selectionChanged(bool userTriggered);
    5151
    52     VisiblePosition visiblePositionForIndex(int index);
    53     int indexForVisiblePosition(const VisiblePosition&);
     52    VisiblePosition visiblePositionForIndex(int index) const;
     53    int indexForVisiblePosition(const VisiblePosition&) const;
    5454
    5555    void updatePlaceholderVisibility(bool, bool);
  • trunk/WebKit/chromium/ChangeLog

    r71451 r71452  
     12010-11-05  Ilya Sherman  <isherman@chromium.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Querying selection start and end should be const
     6        https://bugs.webkit.org/show_bug.cgi?id=48786
     7
     8        * public/WebInputElement.h:
     9        * src/WebInputElement.cpp:
     10        (WebKit::WebInputElement::selectionStart):
     11        (WebKit::WebInputElement::selectionEnd):
     12
    1132010-11-05  Chris Marrin  <cmarrin@apple.com>
    214
  • trunk/WebKit/chromium/public/WebInputElement.h

    r71158 r71452  
    7777        WEBKIT_API void dispatchFormControlChangeEvent();
    7878        WEBKIT_API void setSelectionRange(int, int);
    79         WEBKIT_API int selectionStart();
    80         WEBKIT_API int selectionEnd();
     79        WEBKIT_API int selectionStart() const;
     80        WEBKIT_API int selectionEnd() const;
    8181        WEBKIT_API bool isValidValue(const WebString&) const;
    8282
  • trunk/WebKit/chromium/src/WebInputElement.cpp

    r71158 r71452  
    146146}
    147147
    148 int WebInputElement::selectionStart()
     148int WebInputElement::selectionStart() const
    149149{
    150     return unwrap<HTMLInputElement>()->selectionStart();
     150    return constUnwrap<HTMLInputElement>()->selectionStart();
    151151}
    152152
    153 int WebInputElement::selectionEnd()
     153int WebInputElement::selectionEnd() const
    154154{
    155     return unwrap<HTMLInputElement>()->selectionEnd();
     155    return constUnwrap<HTMLInputElement>()->selectionEnd();
    156156}
    157157
Note: See TracChangeset for help on using the changeset viewer.