Changeset 71452 in webkit
- Timestamp:
- Nov 5, 2010 3:00:54 PM (13 years ago)
- Location:
- trunk
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r71451 r71452 1 2010-11-05 Ilya Sherman <isherman@chromium.org> 2 3 Reviewed by Simon Fraser. 4 5 Querying selection start and end should be const 6 https://bugs.webkit.org/show_bug.cgi?id=48786 7 8 * rendering/RenderTextControl.cpp: 9 (WebCore::RenderTextControl::selectionStart): 10 (WebCore::RenderTextControl::selectionEnd): 11 (WebCore::RenderTextControl::visiblePositionForIndex): 12 (WebCore::RenderTextControl::indexForVisiblePosition): 13 * rendering/RenderTextControl.h: 14 1 15 2010-11-05 Chris Marrin <cmarrin@apple.com> 2 16 -
trunk/WebCore/rendering/RenderTextControl.cpp
r70945 r71452 201 201 } 202 202 203 int RenderTextControl::selectionStart() 203 int RenderTextControl::selectionStart() const 204 204 { 205 205 Frame* frame = this->frame(); … … 209 209 } 210 210 211 int RenderTextControl::selectionEnd() 211 int RenderTextControl::selectionEnd() const 212 212 { 213 213 Frame* frame = this->frame(); … … 265 265 } 266 266 267 VisiblePosition RenderTextControl::visiblePositionForIndex(int index) 267 VisiblePosition RenderTextControl::visiblePositionForIndex(int index) const 268 268 { 269 269 if (index <= 0) … … 282 282 } 283 283 284 int RenderTextControl::indexForVisiblePosition(const VisiblePosition& pos) 284 int RenderTextControl::indexForVisiblePosition(const VisiblePosition& pos) const 285 285 { 286 286 Position indexPosition = pos.deepEquivalent(); -
trunk/WebCore/rendering/RenderTextControl.h
r70945 r71452 41 41 void setLastChangeWasUserEdit(bool lastChangeWasUserEdit); 42 42 43 int selectionStart() ;44 int selectionEnd() ;43 int selectionStart() const; 44 int selectionEnd() const; 45 45 PassRefPtr<Range> selection(int start, int end) const; 46 46 … … 50 50 void selectionChanged(bool userTriggered); 51 51 52 VisiblePosition visiblePositionForIndex(int index) ;53 int indexForVisiblePosition(const VisiblePosition&) ;52 VisiblePosition visiblePositionForIndex(int index) const; 53 int indexForVisiblePosition(const VisiblePosition&) const; 54 54 55 55 void updatePlaceholderVisibility(bool, bool); -
trunk/WebKit/chromium/ChangeLog
r71451 r71452 1 2010-11-05 Ilya Sherman <isherman@chromium.org> 2 3 Reviewed by Simon Fraser. 4 5 Querying selection start and end should be const 6 https://bugs.webkit.org/show_bug.cgi?id=48786 7 8 * public/WebInputElement.h: 9 * src/WebInputElement.cpp: 10 (WebKit::WebInputElement::selectionStart): 11 (WebKit::WebInputElement::selectionEnd): 12 1 13 2010-11-05 Chris Marrin <cmarrin@apple.com> 2 14 -
trunk/WebKit/chromium/public/WebInputElement.h
r71158 r71452 77 77 WEBKIT_API void dispatchFormControlChangeEvent(); 78 78 WEBKIT_API void setSelectionRange(int, int); 79 WEBKIT_API int selectionStart() ;80 WEBKIT_API int selectionEnd() ;79 WEBKIT_API int selectionStart() const; 80 WEBKIT_API int selectionEnd() const; 81 81 WEBKIT_API bool isValidValue(const WebString&) const; 82 82 -
trunk/WebKit/chromium/src/WebInputElement.cpp
r71158 r71452 146 146 } 147 147 148 int WebInputElement::selectionStart() 148 int WebInputElement::selectionStart() const 149 149 { 150 return unwrap<HTMLInputElement>()->selectionStart();150 return constUnwrap<HTMLInputElement>()->selectionStart(); 151 151 } 152 152 153 int WebInputElement::selectionEnd() 153 int WebInputElement::selectionEnd() const 154 154 { 155 return unwrap<HTMLInputElement>()->selectionEnd();155 return constUnwrap<HTMLInputElement>()->selectionEnd(); 156 156 } 157 157
Note: See TracChangeset
for help on using the changeset viewer.