Changeset 71600 in webkit


Ignore:
Timestamp:
Nov 8, 2010 7:41:14 PM (13 years ago)
Author:
kenneth@webkit.org
Message:

2010-11-08 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Send page scroll requests to the PageClient when scroll delegation is turned on
https://bugs.webkit.org/show_bug.cgi?id=49171

Implement the IPC and API required for making scroll delegation work
with WebKit2. This is only used when you have tiling enabled.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::pageDidRequestScroll):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::pageDidRequestScroll):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::delegatedScrollRequested):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::pageDidRequestScroll):
  • WebProcess/WebPage/WebPage.h:
Location:
trunk/WebKit2
Files:
11 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit2/ChangeLog

    r71599 r71600  
     12010-11-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
     2
     3        Reviewed by Andreas Kling.
     4
     5        Send page scroll requests to the PageClient when scroll delegation is turned on
     6        https://bugs.webkit.org/show_bug.cgi?id=49171
     7
     8        Implement the IPC and API required for making scroll delegation work
     9        with WebKit2. This is only used when you have tiling enabled.
     10
     11        * UIProcess/API/qt/qwkpage.cpp:
     12        (QWKPagePrivate::pageDidRequestScroll):
     13        * UIProcess/API/qt/qwkpage.h:
     14        * UIProcess/API/qt/qwkpage_p.h:
     15        * UIProcess/PageClient.h:
     16        * UIProcess/WebPageProxy.cpp:
     17        (WebKit::WebPageProxy::pageDidRequestScroll):
     18        * UIProcess/WebPageProxy.h:
     19        * UIProcess/WebPageProxy.messages.in:
     20        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
     21        (WebKit::WebChromeClient::delegatedScrollRequested):
     22        * WebProcess/WebPage/WebPage.cpp:
     23        (WebKit::WebPage::pageDidRequestScroll):
     24        * WebProcess/WebPage/WebPage.h:
     25
    1262010-11-08  Ivan Krstić  <ike@apple.com>
    227
  • trunk/WebKit2/UIProcess/API/qt/qwkpage.cpp

    r71347 r71600  
    9797    viewportArguments = args;
    9898    emit q->viewportChangeRequested();
     99}
     100
     101void QWKPagePrivate::pageDidRequestScroll(const IntSize& delta)
     102{
     103    emit q->scrollRequested(delta.width(), delta.height());
    99104}
    100105
  • trunk/WebKit2/UIProcess/API/qt/qwkpage.h

    r71029 r71600  
    108108    Q_SIGNAL void urlChanged(const QUrl&);
    109109    Q_SIGNAL void contentsSizeChanged(const QSize&);
     110    Q_SIGNAL void scrollRequested(int dx, int dy);
    110111    Q_SIGNAL void cursorChanged(const QCursor&);
    111112    Q_SIGNAL void viewportChangeRequested();
  • trunk/WebKit2/UIProcess/API/qt/qwkpage_p.h

    r71347 r71600  
    4949    void pageDidLeaveAcceleratedCompositing() { }
    5050#endif // USE(ACCELERATED_COMPOSITING)
     51    virtual void pageDidRequestScroll(const WebCore::IntSize&);
    5152    virtual void processDidCrash() { }
    5253    virtual void didRelaunchProcess() { }
  • trunk/WebKit2/UIProcess/PageClient.h

    r71347 r71600  
    5555    virtual void toolTipChanged(const String&, const String&) = 0;
    5656
     57#if ENABLE(TILED_BACKING_STORE)
     58    virtual void pageDidRequestScroll(const WebCore::IntSize&) = 0;
     59#endif
    5760#if PLATFORM(QT)
    5861    virtual void didChangeContentsSize(const WebCore::IntSize&) = 0;
  • trunk/WebKit2/UIProcess/WebPageProxy.cpp

    r71585 r71600  
    10151015}
    10161016
     1017#if ENABLE(TILED_BACKING_STORE)
     1018void WebPageProxy::pageDidRequestScroll(const IntSize& delta)
     1019{
     1020    m_pageClient->pageDidRequestScroll(delta);
     1021}
     1022#endif
     1023
    10171024void WebPageProxy::didChangeViewportData(const ViewportArguments& args)
    10181025{
  • trunk/WebKit2/UIProcess/WebPageProxy.h

    r71585 r71600  
    297297    void didChangeViewportData(const WebCore::ViewportArguments&);
    298298    void pageDidScroll();
     299#if ENABLE(TILED_BACKING_STORE)
     300    void pageDidRequestScroll(const WebCore::IntSize&);
     301#endif
    299302#if PLATFORM(QT)
    300303    void didChangeContentsSize(const WebCore::IntSize&);
  • trunk/WebKit2/UIProcess/WebPageProxy.messages.in

    r71585 r71600  
    5151    RunBeforeUnloadConfirmPanel(WTF::String message, uint64_t frameID) -> (bool shouldClose)
    5252    PageDidScroll()
     53#if ENABLE(TILED_BACKING_STORE)
     54    PageDidRequestScroll(WebCore::IntSize delta)
     55#endif
    5356#if PLATFORM(QT)
    5457    DidChangeContentsSize(WebCore::IntSize newSize)
  • trunk/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp

    r71565 r71600  
    344344void WebChromeClient::delegatedScrollRequested(const IntSize& scrollDelta)
    345345{
    346     notImplemented();
     346    m_page->pageDidRequestScroll(scrollDelta);
    347347}
    348348#endif
  • trunk/WebKit2/WebProcess/WebPage/WebPage.cpp

    r71585 r71600  
    489489}
    490490
     491#if ENABLE(TILED_BACKING_STORE)
     492void WebPage::pageDidRequestScroll(const IntSize& delta)
     493{
     494    send(Messages::WebPageProxy::PageDidRequestScroll(delta));
     495}
     496#endif
     497
    491498WebContextMenu* WebPage::contextMenu()
    492499{
  • trunk/WebKit2/WebProcess/WebPage/WebPage.h

    r71585 r71600  
    189189
    190190    void pageDidScroll();
    191    
     191#if ENABLE(TILED_BACKING_STORE)
     192    void pageDidRequestScroll(const WebCore::IntSize& delta);
     193#endif
     194
    192195    WebContextMenu* contextMenu();
    193196
Note: See TracChangeset for help on using the changeset viewer.