Changeset 71716 in webkit

Timestamp:

Nov 9, 2010 9:06:48 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-11-09 Helder Correia <​helder@sencha.com>

Reviewed by Darin Adler.

Philip Canvas test 2d.path.rect.winding fails
​https://bugs.webkit.org/show_bug.cgi?id=49225

Remove test from skipped list.

• platform/gtk/Skipped:
• platform/mac-leopard/Skipped:
• platform/qt/Skipped:

2010-11-09 Helder Correia <​helder@sencha.com>

Reviewed by Darin Adler.

Philip Canvas test 2d.path.rect.winding fails
​https://bugs.webkit.org/show_bug.cgi?id=49225

Rect path direction is important for nonzero winding rule.

The rect(x, y, w, h) method must create a new subpath containing just the four points
(x, y), (x+w, y), (x+w, y+h), (x, y+h), with those four points connected by straight
lines, and must then mark the subpath as closed.

• html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::rect):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• LayoutTests/platform/mac-leopard/Skipped (modified) (1 diff)
• LayoutTests/platform/qt/Skipped (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/canvas/CanvasRenderingContext2D.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-11-09  Helder Correia  <helder@sencha.com>
+
+        Reviewed by Darin Adler.
+
+        Philip Canvas test 2d.path.rect.winding fails
+        https://bugs.webkit.org/show_bug.cgi?id=49225
+
+        Remove test from skipped list.
+
+        * platform/gtk/Skipped:
+        * platform/mac-leopard/Skipped:
+        * platform/qt/Skipped:
+
 2010-11-09  Adrienne Walker  <enne@google.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -5335 +5335 @@
 canvas/philip/tests/2d.path.arcTo.ensuresubpath.2.html
 canvas/philip/tests/2d.path.clip.empty.html
-canvas/philip/tests/2d.path.rect.winding.html
 canvas/philip/tests/2d.pattern.image.broken.html
 canvas/philip/tests/2d.pattern.image.incomplete.html

trunk/LayoutTests/platform/mac-leopard/Skipped

@@ -131 +131 @@
 canvas/philip/tests/2d.path.arcTo.ensuresubpath.2.html
 canvas/philip/tests/2d.path.clip.empty.html
-canvas/philip/tests/2d.path.rect.winding.html
 canvas/philip/tests/2d.pattern.image.broken.html
 canvas/philip/tests/2d.pattern.image.incomplete.html

trunk/LayoutTests/platform/qt/Skipped

@@ -5064 +5064 @@
 canvas/philip/tests/2d.path.quadraticCurveTo.shape.html
 canvas/philip/tests/2d.path.quadraticCurveTo.scaled.html
-canvas/philip/tests/2d.path.rect.winding.html
 canvas/philip/tests/2d.path.rect.zero.6.html
 canvas/philip/tests/2d.path.stroke.scale2.html

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-11-09  Helder Correia  <helder@sencha.com>
+
+        Reviewed by Darin Adler.
+
+        Philip Canvas test 2d.path.rect.winding fails
+        https://bugs.webkit.org/show_bug.cgi?id=49225
+
+        Rect path direction is important for nonzero winding rule.
+
+        The rect(x, y, w, h) method must create a new subpath containing just the four points
+        (x, y), (x+w, y), (x+w, y+h), (x, y+h), with those four points connected by straight
+        lines, and must then mark the subpath as closed.
+
+        * html/canvas/CanvasRenderingContext2D.cpp:
+        (WebCore::CanvasRenderingContext2D::rect):
+
 2010-11-09  Fumitoshi Ukai  <ukai@chromium.org>
 

trunk/WebCore/html/canvas/CanvasRenderingContext2D.cpp

@@ -794 +794 @@
     }
 
-    if (width < 0) {
-        width = -width;
-        x -= width;
-    }
-
-    if (height < 0) {
-        height = -height;
-        y -= height;
-    }
-
     m_path.addRect(FloatRect(x, y, width, height));
 }