Changeset 71802 in webkit

Timestamp:

Nov 11, 2010 3:20:11 AM (13 years ago)

Author:

Nikolas Zimmermann

Message:

2010-11-10 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGMatrix/SVGTransform/SVGTransformList to the new SVGPropertyTearOff concept
​https://bugs.webkit.org/show_bug.cgi?id=49311

Move the last list type, SVGTransformList, and the last POD types, SVGMatrix & SVGTransform, over to the new SVGPropertyTearOff concept.
Removes the need for a custom JSSVGMatrix/V8SVGMatrix implementation, it's all integrated within the bindings now.

Tests: svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg

svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg
svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg
svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg
svg/W3C-SVG-1.1-SE/types-dom-01-b.svg
svg/W3C-SVG-1.1-SE/types-dom-02-f.svg
svg/W3C-SVG-1.1-SE/types-dom-03-b.svg
svg/W3C-SVG-1.1-SE/types-dom-04-b.svg
svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
svg/dom/SVGMatrix.html
svg/dom/SVGTransform.html
svg/dom/SVGTransformList.html

• Android.jscbindings.mk: Removed JSSVGMatrixCustom.cpp.
• Android.v8bindings.mk: Removed V8SVGMatrixCustom.cpp.
• CMakeLists.txt: Remove JSSVGMatrixCustom.cpp.
• GNUmakefile.am: Ditto. Add SVGAnimatedTransformListPropertyTearOff.h/SVGStaticPropertyWithParentTearOff.h/SVGTransformListPropertyTearOff.h/SVGAnimatedTransformList.h/SVGMatrix.h to build.
• WebCore.gypi: Ditto.
• WebCore.pro: Ditto.
• WebCore.vcproj/WebCore.vcproj: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• bindings/js/JSBindingsAllInOne.cpp: Remove JSSVGMatrixCustom.cpp
• bindings/js/JSSVGMatrixCustom.cpp: Removed.
• bindings/scripts/CodeGenerator.pm: Convert SVGMatrix/SVGTransform/SVGTransformList to the new concept.
• bindings/scripts/CodeGeneratorJS.pm: Ditto.
• bindings/scripts/CodeGeneratorObjC.pm: Ditto.
• bindings/scripts/CodeGeneratorV8.pm: Ditto.
• bindings/v8/custom/V8SVGMatrixCustom.cpp: Removed.
• svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGTransformList handling.
• svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
• svg/SVGAnimateTransformElement.cpp: Adapt to SVGTransformList API changes. (WebCore::transformListFor): (WebCore::SVGAnimateTransformElement::resetToBaseValue): (WebCore::SVGAnimateTransformElement::calculateAnimatedValue): (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
• svg/SVGAnimatedTransformList.h: Added.
• svg/SVGGradientElement.cpp: Ditto. (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::parseMappedAttribute):
• svg/SVGGradientElement.h: Ditto.
• svg/SVGLinearGradientElement.cpp: Ditto. (WebCore::SVGLinearGradientElement::collectGradientAttributes):
• svg/SVGMatrix.h: Added. SVGMatrix inherits from AffineTransform, and is only used in the bindings. It implements SVGs special requirements. (WebCore::SVGMatrix::translate): Returns a copy of the matrix, not affecting the original matrix. (WebCore::SVGMatrix::scale): Ditto. (WebCore::SVGMatrix::scaleNonUniform): Ditto. (WebCore::SVGMatrix::rotate): Ditto. (WebCore::SVGMatrix::flipX): Ditto. (WebCore::SVGMatrix::flipY): Ditto. (WebCore::SVGMatrix::skewX): Ditto. (WebCore::SVGMatrix::skewY): Ditto. (WebCore::SVGMatrix::multiply): Ditto. (WebCore::SVGMatrix::inverse): Ditto. (WebCore::SVGMatrix::rotateFromVector): Dittto.
• svg/SVGMatrix.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise on all attributes/functions.
• svg/SVGPatternElement.cpp: Adapt to SVGTransformList API changes. (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::parseMappedAttribute): (WebCore::SVGPatternElement::collectPatternAttributes):
• svg/SVGPatternElement.h: Ditto.
• svg/SVGPoint.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise for 'matrixTransform', now that SVGMatrix has been converted to the new scheme.
• svg/SVGRadialGradientElement.cpp: Adapt to SVGTransformList API changes. (WebCore::SVGRadialGradientElement::collectGradientAttributes):
• svg/SVGSVGElement.cpp: Ditto. (WebCore::SVGSVGElement::createSVGTransformFromMatrix): (WebCore::SVGSVGElement::viewBoxToViewTransform):
• svg/SVGSVGElement.h: Ditto.
• svg/SVGStyledTransformableElement.cpp: Ditto. (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement): (WebCore::SVGStyledTransformableElement::animatedLocalTransform): (WebCore::SVGStyledTransformableElement::parseMappedAttribute):
• svg/SVGStyledTransformableElement.h: Ditto.
• svg/SVGTextElement.cpp: Ditto. (WebCore::SVGTextElement::SVGTextElement): (WebCore::SVGTextElement::parseMappedAttribute): (WebCore::SVGTextElement::animatedLocalTransform):
• svg/SVGTextElement.h: Ditto.
• svg/SVGTransform.cpp: Modernize code, inlined some getters. (WebCore::SVGTransform::SVGTransform): (WebCore::SVGTransform::setMatrix):
• svg/SVGTransform.h: Reindent header. (WebCore::SVGTransform::type): (WebCore::SVGTransform::svgMatrix): (WebCore::SVGTransform::matrix): (WebCore::SVGTransform::angle): (WebCore::SVGTransform::rotationCenter): (WebCore::SVGTransform::isValid): (WebCore::operator==): Avoid function calls, make operator== a friend of SVGTransform, and compare members directly. (WebCore::operator!=):
• svg/SVGTransform.idl:
• svg/SVGTransformList.cpp: Rewritten as plain Vector<SVGTransform>. (WebCore::SVGTransformList::createSVGTransformFromMatrix): (WebCore::SVGTransformList::consolidate): (WebCore::SVGTransformList::concatenate): (WebCore::SVGTransformList::valueAsString):
• svg/SVGTransformList.h: (WebCore::SVGTransformList::SVGTransformList):
• svg/SVGTransformList.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise on all attributes/functions.
• svg/SVGTransformable.cpp: Adapt to SVGTransformList API changes. (WebCore::SVGTransformable::parseTransformAttribute):
• svg/SVGTransformable.h: Ditto.
• svg/SVGViewSpec.cpp: Ditto. (WebCore::SVGViewSpec::SVGViewSpec): (WebCore::SVGViewSpec::setTransform): (WebCore::SVGViewSpec::parseViewSpec):
• svg/SVGViewSpec.h: Ditto. (WebCore::SVGViewSpec::transform):
• svg/properties/SVGAnimatedListPropertyTearOff.h: Made constructor and members protected.
• svg/properties/SVGAnimatedPropertyMacros.h: Add new helper macro DECLARE_ANIMATED_TRANSFORM_LIST_PROPERTY. This is needed until we expand all macros.
• svg/properties/SVGAnimatedTransformListPropertyTearOff.h: Added. Extends SVGAnimatedListPropertyTearOff, returning SVGTransformListPropertyTearOff objects. (WebCore::SVGAnimatedTransformListPropertyTearOff::baseVal): (WebCore::SVGAnimatedTransformListPropertyTearOff::animVal): (WebCore::SVGAnimatedTransformListPropertyTearOff::create): (WebCore::SVGAnimatedTransformListPropertyTearOff::SVGAnimatedTransformListPropertyTearOff):
• svg/properties/SVGListPropertyTearOff.h: Made construct and members protected.
• svg/properties/SVGProperty.h: Declare commitChange() as pure virtual method.
• svg/properties/SVGPropertyTraits.h: Handle SVGTransformList.
• svg/properties/SVGStaticPropertyWithParentTearOff.h: Added. Same concept as JSSVGStaticPODTypeWrapperWithParent, used to expose SVGPropertyTearOffs for types

that are using this concept themselves. (SVGMatrix attribute of SVGTransform, both are POD types, using SVGPropertyTearOff).

(WebCore::SVGStaticPropertyWithParentTearOff::create):
(WebCore::SVGStaticPropertyWithParentTearOff::commitChange):
(WebCore::SVGStaticPropertyWithParentTearOff::SVGStaticPropertyWithParentTearOff):

• svg/properties/SVGTransformListPropertyTearOff.h: Added. Extends SVGListPropertyTearOff by two special SVGTransformList methods: consolidate and createSVGTransformFromMatrix. (WebCore::SVGTransformListPropertyTearOff::create): (WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix): (WebCore::SVGTransformListPropertyTearOff::consolidate): (WebCore::SVGTransformListPropertyTearOff::SVGTransformListPropertyTearOff):

2010-11-10 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGMatrix/SVGTransform/SVGTransformList to the new SVGPropertyTearOff concept
​https://bugs.webkit.org/show_bug.cgi?id=49311

Add tests covering StrictTypeChecking and RequiresAllArguments=Raise for SVGMatrix/SVGPoint.
Imported several new tests from SVG 1.1 2nd Edition, regarding SVG DOM primitives.

• platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
• svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg: Added.
• svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg: Added.
• svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg: Added.
• svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg: Added.
• svg/W3C-SVG-1.1-SE/types-dom-01-b.svg: Added.
• svg/W3C-SVG-1.1-SE/types-dom-02-f.svg: Added.
• svg/W3C-SVG-1.1-SE/types-dom-03-b.svg: Added.
• svg/W3C-SVG-1.1-SE/types-dom-04-b.svg: Added.
• svg/W3C-SVG-1.1-SE/types-dom-05-b.svg: Added.
• svg/dom/SVGMatrix-expected.txt: Added.
• svg/dom/SVGMatrix.html: Added.
• svg/dom/SVGPoint-expected.txt:
• svg/dom/SVGTransform-expected.txt: Added.
• svg/dom/SVGTransform.html: Added.
• svg/dom/SVGTransformList-expected.txt: Added.
• svg/dom/SVGTransformList.html: Added.
• svg/dom/script-tests/SVGMatrix.js: Added.
• svg/dom/script-tests/SVGPoint.js:
• svg/dom/script-tests/SVGTransform.js: Added.
• svg/dom/script-tests/SVGTransformList.js: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png (added)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt (added)
• LayoutTests/svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg (added)
• LayoutTests/svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg (added)
• LayoutTests/svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg (added)
• LayoutTests/svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg (added)
• LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-01-b.svg (added)
• LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-02-f.svg (added)
• LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-03-b.svg (added)
• LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-04-b.svg (added)
• LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-05-b.svg (added)
• LayoutTests/svg/animations/animate-gradient-transform-expected.txt (modified) (1 diff)
• LayoutTests/svg/animations/script-tests/animate-gradient-transform.js (modified) (3 diffs)
• LayoutTests/svg/dom/SVGMatrix-expected.txt (added)
• LayoutTests/svg/dom/SVGMatrix.html (added)
• LayoutTests/svg/dom/SVGPoint-expected.txt (modified) (1 diff)
• LayoutTests/svg/dom/SVGTransform-expected.txt (added)
• LayoutTests/svg/dom/SVGTransform.html (added)
• LayoutTests/svg/dom/SVGTransformList-expected.txt (added)
• LayoutTests/svg/dom/SVGTransformList.html (added)
• LayoutTests/svg/dom/script-tests/SVGMatrix.js (added)
• LayoutTests/svg/dom/script-tests/SVGPoint.js (modified) (1 diff)
• LayoutTests/svg/dom/script-tests/SVGTransform.js (added)
• LayoutTests/svg/dom/script-tests/SVGTransformList.js (added)
• WebCore/Android.jscbindings.mk (modified) (1 diff)
• WebCore/Android.v8bindings.mk (modified) (1 diff)
• WebCore/CMakeLists.txt (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/GNUmakefile.am (modified) (5 diffs)
• WebCore/WebCore.gypi (modified) (6 diffs)
• WebCore/WebCore.pro (modified) (6 diffs)
• WebCore/WebCore.vcproj/WebCore.vcproj (modified) (5 diffs)
• WebCore/WebCore.xcodeproj/project.pbxproj (modified) (33 diffs)
• WebCore/bindings/js/JSBindingsAllInOne.cpp (modified) (1 diff)
• WebCore/bindings/js/JSSVGMatrixCustom.cpp (deleted)
• WebCore/bindings/scripts/CodeGenerator.pm (modified) (5 diffs)
• WebCore/bindings/scripts/CodeGeneratorJS.pm (modified) (28 diffs)
• WebCore/bindings/scripts/CodeGeneratorObjC.pm (modified) (23 diffs)
• WebCore/bindings/scripts/CodeGeneratorV8.pm (modified) (44 diffs)
• WebCore/bindings/v8/custom/V8SVGMatrixCustom.cpp (deleted)
• WebCore/svg/DeprecatedSVGAnimatedPropertyTraits.h (modified) (2 diffs)
• WebCore/svg/DeprecatedSVGAnimatedTemplate.h (modified) (2 diffs)
• WebCore/svg/SVGAnimateTransformElement.cpp (modified) (5 diffs)
• WebCore/svg/SVGAnimatedTransformList.h (added)
• WebCore/svg/SVGGradientElement.cpp (modified) (2 diffs)
• WebCore/svg/SVGGradientElement.h (modified) (2 diffs)
• WebCore/svg/SVGLinearGradientElement.cpp (modified) (1 diff)
• WebCore/svg/SVGMatrix.h (added)
• WebCore/svg/SVGMatrix.idl (modified) (1 diff)
• WebCore/svg/SVGPatternElement.cpp (modified) (3 diffs)
• WebCore/svg/SVGPatternElement.h (modified) (2 diffs)
• WebCore/svg/SVGPoint.idl (modified) (1 diff)
• WebCore/svg/SVGRadialGradientElement.cpp (modified) (1 diff)
• WebCore/svg/SVGSVGElement.cpp (modified) (3 diffs)
• WebCore/svg/SVGSVGElement.h (modified) (2 diffs)
• WebCore/svg/SVGStyledTransformableElement.cpp (modified) (3 diffs)
• WebCore/svg/SVGStyledTransformableElement.h (modified) (1 diff)
• WebCore/svg/SVGTextElement.cpp (modified) (3 diffs)
• WebCore/svg/SVGTextElement.h (modified) (2 diffs)
• WebCore/svg/SVGTransform.cpp (modified) (5 diffs)
• WebCore/svg/SVGTransform.h (modified) (1 diff)
• WebCore/svg/SVGTransform.idl (modified) (2 diffs)
• WebCore/svg/SVGTransformList.cpp (modified) (3 diffs)
• WebCore/svg/SVGTransformList.h (modified) (1 diff)
• WebCore/svg/SVGTransformList.idl (modified) (1 diff)
• WebCore/svg/SVGTransformable.cpp (modified) (5 diffs)
• WebCore/svg/SVGTransformable.h (modified) (1 diff)
• WebCore/svg/SVGViewSpec.cpp (modified) (3 diffs)
• WebCore/svg/SVGViewSpec.h (modified) (2 diffs)
• WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h (modified) (2 diffs)
• WebCore/svg/properties/SVGAnimatedPropertyMacros.h (modified) (2 diffs)
• WebCore/svg/properties/SVGAnimatedTransformListPropertyTearOff.h (added)
• WebCore/svg/properties/SVGListPropertyTearOff.h (modified) (2 diffs)
• WebCore/svg/properties/SVGProperty.h (modified) (1 diff)
• WebCore/svg/properties/SVGPropertyTearOff.h (modified) (2 diffs)
• WebCore/svg/properties/SVGPropertyTraits.h (modified) (2 diffs)
• WebCore/svg/properties/SVGStaticPropertyWithParentTearOff.h (added)
• WebCore/svg/properties/SVGTransformListPropertyTearOff.h (added)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        Reviewed by Dirk Schulze.
+
+        Convert SVGMatrix/SVGTransform/SVGTransformList to the new SVGPropertyTearOff concept
+        https://bugs.webkit.org/show_bug.cgi?id=49311
+
+        Add tests covering StrictTypeChecking and RequiresAllArguments=Raise for SVGMatrix/SVGPoint.
+        Imported several new tests from SVG 1.1 2nd Edition, regarding SVG DOM primitives.
+
+        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
+        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
+        * svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg: Added.
+        * svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg: Added.
+        * svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg: Added.
+        * svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg: Added.
+        * svg/W3C-SVG-1.1-SE/types-dom-01-b.svg: Added.
+        * svg/W3C-SVG-1.1-SE/types-dom-02-f.svg: Added.
+        * svg/W3C-SVG-1.1-SE/types-dom-03-b.svg: Added.
+        * svg/W3C-SVG-1.1-SE/types-dom-04-b.svg: Added.
+        * svg/W3C-SVG-1.1-SE/types-dom-05-b.svg: Added.
+        * svg/dom/SVGMatrix-expected.txt: Added.
+        * svg/dom/SVGMatrix.html: Added.
+        * svg/dom/SVGPoint-expected.txt:
+        * svg/dom/SVGTransform-expected.txt: Added.
+        * svg/dom/SVGTransform.html: Added.
+        * svg/dom/SVGTransformList-expected.txt: Added.
+        * svg/dom/SVGTransformList.html: Added.
+        * svg/dom/script-tests/SVGMatrix.js: Added.
+        * svg/dom/script-tests/SVGPoint.js:
+        * svg/dom/script-tests/SVGTransform.js: Added.
+        * svg/dom/script-tests/SVGTransformList.js: Added.
+
 2010-11-11  Kent Tamura  <tkent@chromium.org>
 

trunk/LayoutTests/svg/animations/animate-gradient-transform-expected.txt

@@ -7 +7 @@
 
 PASS gradient.gradientTransform.baseVal.consolidate().matrix.e is 0
-PASS gradient.gradientTransform.animVal.consolidate().matrix.e is 0
+PASS gradient.gradientTransform.animVal.consolidate().matrix.e threw exception Error: NO_MODIFICATION_ALLOWED_ERR: DOM Exception 7.
 PASS gradient.gradientTransform.baseVal.consolidate().matrix.e is 100
-PASS gradient.gradientTransform.animVal.consolidate().matrix.e is 100
+PASS gradient.gradientTransform.animVal.consolidate().matrix.e threw exception Error: NO_MODIFICATION_ALLOWED_ERR: DOM Exception 7.
 PASS gradient.gradientTransform.baseVal.consolidate().matrix.e is 200
-PASS gradient.gradientTransform.animVal.consolidate().matrix.e is 200
+PASS gradient.gradientTransform.animVal.consolidate().matrix.e threw exception Error: NO_MODIFICATION_ALLOWED_ERR: DOM Exception 7.
 PASS successfullyParsed is true
 

trunk/LayoutTests/svg/animations/script-tests/animate-gradient-transform.js

@@ -47 +47 @@
     // Check initial conditions
     shouldBe("gradient.gradientTransform.baseVal.consolidate().matrix.e", "0");
-    shouldBe("gradient.gradientTransform.animVal.consolidate().matrix.e", "0");
+    shouldThrow("gradient.gradientTransform.animVal.consolidate().matrix.e");
 }
 
@@ -54 +54 @@
     // Check half-time conditions
     shouldBe("gradient.gradientTransform.baseVal.consolidate().matrix.e", "100");
-    shouldBe("gradient.gradientTransform.animVal.consolidate().matrix.e", "100");
+    shouldThrow("gradient.gradientTransform.animVal.consolidate().matrix.e");
 }
 
@@ -61 +61 @@
     // Check end conditions
     shouldBe("gradient.gradientTransform.baseVal.consolidate().matrix.e", "200");
-    shouldBe("gradient.gradientTransform.animVal.consolidate().matrix.e", "200");
+    shouldThrow("gradient.gradientTransform.animVal.consolidate().matrix.e");
 }
 

trunk/LayoutTests/svg/dom/SVGPoint-expected.txt

@@ -20 +20 @@
 PASS point.x is 100
 PASS point.y is 0
+
+Reset to -50, 100
+
+Check 'matrixTransform' method - multiply with -1,0,0,2,10,10 matrix, should flip x coordinate, multiply y by two and translate each coordinate by 10
+PASS (newPoint = point.matrixTransform(ctm)).toString() is "[object SVGPoint]"
+PASS newPoint.x is 60
+PASS newPoint.y is 210
+
+Check invalid arguments for 'matrixTransform'
+PASS point.matrixTransform() threw exception SyntaxError: Not enough arguments.
+PASS point.matrixTransform(-1) threw exception TypeError: Type error.
+PASS point.matrixTransform(5) threw exception TypeError: Type error.
+PASS point.matrixTransform('aString') threw exception TypeError: Type error.
+PASS point.matrixTransform(point) threw exception TypeError: Type error.
+PASS point.matrixTransform(svgElement) threw exception TypeError: Type error.
 PASS successfullyParsed is true
 

trunk/LayoutTests/svg/dom/script-tests/SVGPoint.js

@@ -24 +24 @@
 shouldBe("point.y", "0");
 
+debug("");
+debug("Reset to -50, 100");
+point.x = -50;
+point.y = 100;
+
+debug("");
+debug("Check 'matrixTransform' method - multiply with -1,0,0,2,10,10 matrix, should flip x coordinate, multiply y by two and translate each coordinate by 10");
+var ctm = svgElement.createSVGMatrix();
+ctm.a = -1;
+ctm.d = 2;
+ctm.e = 10;
+ctm.f = 10;
+shouldBeEqualToString("(newPoint = point.matrixTransform(ctm)).toString()", "[object SVGPoint]");
+shouldBe("newPoint.x", "60");
+shouldBe("newPoint.y", "210");
+
+debug("");
+debug("Check invalid arguments for 'matrixTransform'");
+shouldThrow("point.matrixTransform()");
+shouldThrow("point.matrixTransform(-1)");
+shouldThrow("point.matrixTransform(5)");
+shouldThrow("point.matrixTransform('aString')");
+shouldThrow("point.matrixTransform(point)");
+shouldThrow("point.matrixTransform(svgElement)");
+
 successfullyParsed = true;

trunk/WebCore/Android.jscbindings.mk

@@ -147 +147 @@
         bindings/js/JSSVGElementInstanceCustom.cpp \
         bindings/js/JSSVGLengthCustom.cpp \
-        bindings/js/JSSVGMatrixCustom.cpp \
         bindings/js/JSSVGPathSegCustom.cpp \
         bindings/js/JSSVGPathSegListCustom.cpp \

trunk/WebCore/Android.v8bindings.mk

@@ -156 +156 @@
         bindings/v8/custom/V8SVGElementCustom.cpp \
         bindings/v8/custom/V8SVGLengthCustom.cpp \
-        bindings/v8/custom/V8SVGMatrixCustom.cpp
         bindings/v8/custom/V8SVGPathSegCustom.cpp \
 endif

trunk/WebCore/CMakeLists.txt

@@ -1716 +1716 @@
         bindings/js/JSSVGElementInstanceCustom.cpp
         bindings/js/JSSVGLengthCustom.cpp
-        bindings/js/JSSVGMatrixCustom.cpp
         bindings/js/JSSVGPathSegCustom.cpp
         bindings/js/JSSVGPathSegListCustom.cpp

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        Reviewed by Dirk Schulze.
+
+        Convert SVGMatrix/SVGTransform/SVGTransformList to the new SVGPropertyTearOff concept
+        https://bugs.webkit.org/show_bug.cgi?id=49311
+
+        Move the last list type, SVGTransformList, and the last POD types, SVGMatrix & SVGTransform, over to the new SVGPropertyTearOff concept.
+        Removes the need for a custom JSSVGMatrix/V8SVGMatrix implementation, it's all integrated within the bindings now.
+
+        Tests: svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg
+               svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg
+               svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg
+               svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg
+               svg/W3C-SVG-1.1-SE/types-dom-01-b.svg
+               svg/W3C-SVG-1.1-SE/types-dom-02-f.svg
+               svg/W3C-SVG-1.1-SE/types-dom-03-b.svg
+               svg/W3C-SVG-1.1-SE/types-dom-04-b.svg
+               svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
+               svg/dom/SVGMatrix.html
+               svg/dom/SVGTransform.html
+               svg/dom/SVGTransformList.html
+
+        * Android.jscbindings.mk: Removed JSSVGMatrixCustom.cpp.
+        * Android.v8bindings.mk: Removed V8SVGMatrixCustom.cpp.
+        * CMakeLists.txt: Remove JSSVGMatrixCustom.cpp. 
+        * GNUmakefile.am: Ditto. Add SVGAnimatedTransformListPropertyTearOff.h/SVGStaticPropertyWithParentTearOff.h/SVGTransformListPropertyTearOff.h/SVGAnimatedTransformList.h/SVGMatrix.h to build.
+        * WebCore.gypi: Ditto.
+        * WebCore.pro: Ditto.
+        * WebCore.vcproj/WebCore.vcproj: Ditto.
+        * WebCore.xcodeproj/project.pbxproj: Ditto.
+        * bindings/js/JSBindingsAllInOne.cpp: Remove JSSVGMatrixCustom.cpp
+        * bindings/js/JSSVGMatrixCustom.cpp: Removed.
+        * bindings/scripts/CodeGenerator.pm: Convert SVGMatrix/SVGTransform/SVGTransformList to the new concept.
+        * bindings/scripts/CodeGeneratorJS.pm: Ditto.
+        * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
+        * bindings/scripts/CodeGeneratorV8.pm: Ditto.
+        * bindings/v8/custom/V8SVGMatrixCustom.cpp: Removed.
+        * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGTransformList handling.
+        * svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
+        * svg/SVGAnimateTransformElement.cpp: Adapt to SVGTransformList API changes.
+        (WebCore::transformListFor):
+        (WebCore::SVGAnimateTransformElement::resetToBaseValue):
+        (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
+        (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
+        * svg/SVGAnimatedTransformList.h: Added.
+        * svg/SVGGradientElement.cpp: Ditto.
+        (WebCore::SVGGradientElement::SVGGradientElement):
+        (WebCore::SVGGradientElement::parseMappedAttribute):
+        * svg/SVGGradientElement.h: Ditto.
+        * svg/SVGLinearGradientElement.cpp: Ditto.
+        (WebCore::SVGLinearGradientElement::collectGradientAttributes):
+        * svg/SVGMatrix.h: Added. SVGMatrix inherits from AffineTransform, and is only used in the bindings. It implements SVGs special requirements.
+        (WebCore::SVGMatrix::translate): Returns a copy of the matrix, not affecting the original matrix.
+        (WebCore::SVGMatrix::scale): Ditto.
+        (WebCore::SVGMatrix::scaleNonUniform): Ditto.
+        (WebCore::SVGMatrix::rotate): Ditto.
+        (WebCore::SVGMatrix::flipX): Ditto.
+        (WebCore::SVGMatrix::flipY): Ditto.
+        (WebCore::SVGMatrix::skewX): Ditto.
+        (WebCore::SVGMatrix::skewY): Ditto.
+        (WebCore::SVGMatrix::multiply): Ditto.
+        (WebCore::SVGMatrix::inverse): Ditto.
+        (WebCore::SVGMatrix::rotateFromVector): Dittto.
+        * svg/SVGMatrix.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise on all attributes/functions.
+        * svg/SVGPatternElement.cpp: Adapt to SVGTransformList API changes.
+        (WebCore::SVGPatternElement::SVGPatternElement):
+        (WebCore::SVGPatternElement::parseMappedAttribute):
+        (WebCore::SVGPatternElement::collectPatternAttributes):
+        * svg/SVGPatternElement.h: Ditto.
+        * svg/SVGPoint.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise for 'matrixTransform', now that SVGMatrix has been converted to the new scheme.
+        * svg/SVGRadialGradientElement.cpp: Adapt to SVGTransformList API changes.
+        (WebCore::SVGRadialGradientElement::collectGradientAttributes):
+        * svg/SVGSVGElement.cpp: Ditto.
+        (WebCore::SVGSVGElement::createSVGTransformFromMatrix):
+        (WebCore::SVGSVGElement::viewBoxToViewTransform):
+        * svg/SVGSVGElement.h: Ditto.
+        * svg/SVGStyledTransformableElement.cpp: Ditto.
+        (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
+        (WebCore::SVGStyledTransformableElement::animatedLocalTransform):
+        (WebCore::SVGStyledTransformableElement::parseMappedAttribute):
+        * svg/SVGStyledTransformableElement.h: Ditto.
+        * svg/SVGTextElement.cpp: Ditto.
+        (WebCore::SVGTextElement::SVGTextElement):
+        (WebCore::SVGTextElement::parseMappedAttribute):
+        (WebCore::SVGTextElement::animatedLocalTransform):
+        * svg/SVGTextElement.h: Ditto.
+        * svg/SVGTransform.cpp: Modernize code, inlined some getters.
+        (WebCore::SVGTransform::SVGTransform):
+        (WebCore::SVGTransform::setMatrix):
+        * svg/SVGTransform.h: Reindent header.
+        (WebCore::SVGTransform::type):
+        (WebCore::SVGTransform::svgMatrix):
+        (WebCore::SVGTransform::matrix):
+        (WebCore::SVGTransform::angle):
+        (WebCore::SVGTransform::rotationCenter):
+        (WebCore::SVGTransform::isValid):
+        (WebCore::operator==): Avoid function calls, make operator== a friend of SVGTransform, and compare members directly.
+        (WebCore::operator!=):
+        * svg/SVGTransform.idl:
+        * svg/SVGTransformList.cpp: Rewritten as plain Vector<SVGTransform>.
+        (WebCore::SVGTransformList::createSVGTransformFromMatrix):
+        (WebCore::SVGTransformList::consolidate):
+        (WebCore::SVGTransformList::concatenate):
+        (WebCore::SVGTransformList::valueAsString):
+        * svg/SVGTransformList.h:
+        (WebCore::SVGTransformList::SVGTransformList):
+        * svg/SVGTransformList.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise on all attributes/functions.
+        * svg/SVGTransformable.cpp: Adapt to SVGTransformList API changes.
+        (WebCore::SVGTransformable::parseTransformAttribute):
+        * svg/SVGTransformable.h: Ditto.
+        * svg/SVGViewSpec.cpp: Ditto.
+        (WebCore::SVGViewSpec::SVGViewSpec):
+        (WebCore::SVGViewSpec::setTransform):
+        (WebCore::SVGViewSpec::parseViewSpec):
+        * svg/SVGViewSpec.h: Ditto.
+        (WebCore::SVGViewSpec::transform):
+        * svg/properties/SVGAnimatedListPropertyTearOff.h: Made constructor and members protected.
+        * svg/properties/SVGAnimatedPropertyMacros.h: Add new helper macro DECLARE_ANIMATED_TRANSFORM_LIST_PROPERTY. This is needed until we expand all macros.
+        * svg/properties/SVGAnimatedTransformListPropertyTearOff.h: Added. Extends SVGAnimatedListPropertyTearOff, returning SVGTransformListPropertyTearOff objects.
+        (WebCore::SVGAnimatedTransformListPropertyTearOff::baseVal):
+        (WebCore::SVGAnimatedTransformListPropertyTearOff::animVal):
+        (WebCore::SVGAnimatedTransformListPropertyTearOff::create):
+        (WebCore::SVGAnimatedTransformListPropertyTearOff::SVGAnimatedTransformListPropertyTearOff):
+        * svg/properties/SVGListPropertyTearOff.h: Made construct and members protected.
+        * svg/properties/SVGProperty.h: Declare commitChange() as pure virtual method.
+        * svg/properties/SVGPropertyTraits.h: Handle SVGTransformList.
+        * svg/properties/SVGStaticPropertyWithParentTearOff.h: Added. Same concept as JSSVGStaticPODTypeWrapperWithParent, used to expose SVGPropertyTearOffs for types
+                                                               that are using this concept themselves. (SVGMatrix attribute of SVGTransform, both are POD types, using SVGPropertyTearOff).
+        (WebCore::SVGStaticPropertyWithParentTearOff::create):
+        (WebCore::SVGStaticPropertyWithParentTearOff::commitChange):
+        (WebCore::SVGStaticPropertyWithParentTearOff::SVGStaticPropertyWithParentTearOff):
+        * svg/properties/SVGTransformListPropertyTearOff.h: Added. Extends SVGListPropertyTearOff by two special SVGTransformList methods: consolidate and createSVGTransformFromMatrix.
+        (WebCore::SVGTransformListPropertyTearOff::create):
+        (WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
+        (WebCore::SVGTransformListPropertyTearOff::consolidate):
+        (WebCore::SVGTransformListPropertyTearOff::SVGTransformListPropertyTearOff):
+
 2010-11-11  Alejandro G. Castro  <alex@igalia.com>
 

trunk/WebCore/GNUmakefile.am

@@ -799 +799 @@
         WebCore/bindings/js/JSSVGElementInstanceCustom.cpp \
         WebCore/bindings/js/JSSVGLengthCustom.cpp \
-        WebCore/bindings/js/JSSVGMatrixCustom.cpp \
         WebCore/bindings/js/JSSVGPathSegCustom.cpp \
         WebCore/bindings/js/JSSVGPathSegListCustom.cpp \
@@ -3061 +3060 @@
         WebCore/svg/properties/SVGAnimatedPropertyTearOff.h \
         WebCore/svg/properties/SVGAnimatedStaticPropertyTearOff.h \
+        WebCore/svg/properties/SVGAnimatedTransformListPropertyTearOff.h \
         WebCore/svg/properties/SVGListProperty.h \
         WebCore/svg/properties/SVGListPropertyTearOff.h \
@@ -3068 +3068 @@
         WebCore/svg/properties/SVGStaticListPropertyTearOff.h \
         WebCore/svg/properties/SVGStaticPropertyTearOff.h \
+        WebCore/svg/properties/SVGStaticPropertyWithParentTearOff.h \
+        WebCore/svg/properties/SVGTransformListPropertyTearOff.h \
         WebCore/svg/RadialGradientAttributes.h \
         WebCore/svg/SVGAElement.cpp \
@@ -3090 +3092 @@
         WebCore/svg/SVGAnimatedRect.h \
         WebCore/svg/SVGAnimatedString.h \
+        WebCore/svg/SVGAnimatedTransformList.h \
         WebCore/svg/SVGAnimateElement.cpp \
         WebCore/svg/SVGAnimateElement.h \
@@ -3232 +3235 @@
         WebCore/svg/SVGMaskElement.cpp \
         WebCore/svg/SVGMaskElement.h \
+        WebCore/svg/SVGMatrix.h \
         WebCore/svg/SVGMetadataElement.cpp \
         WebCore/svg/SVGMetadataElement.h \

trunk/WebCore/WebCore.gypi

@@ -678 +678 @@
             'bindings/js/JSSVGElementInstanceCustom.cpp',
             'bindings/js/JSSVGLengthCustom.cpp',
-            'bindings/js/JSSVGMatrixCustom.cpp',
             'bindings/js/JSSVGPathSegCustom.cpp',
             'bindings/js/JSSVGPathSegListCustom.cpp',
@@ -838 +837 @@
             'bindings/v8/custom/V8SVGElementCustom.cpp',
             'bindings/v8/custom/V8SVGLengthCustom.cpp',
-            'bindings/v8/custom/V8SVGMatrixCustom.cpp',
             'bindings/v8/custom/V8SVGPathSegCustom.cpp',
             'bindings/v8/custom/V8SharedWorkerCustom.cpp',
@@ -3975 +3973 @@
             'svg/properties/SVGAnimatedPropertyTearOff.h',
             'svg/properties/SVGAnimatedStaticPropertyTearOff.h',
+            'svg/properties/SVGAnimatedTransformListPropertyTearOff.h',
             'svg/properties/SVGListProperty.h',
             'svg/properties/SVGListPropertyTearOff.h',
@@ -3982 +3981 @@
             'svg/properties/SVGStaticListPropertyTearOff.h',
             'svg/properties/SVGStaticPropertyTearOff.h',
+            'svg/properties/SVGStaticPropertyWithParentTearOff.h',
+            'svg/properties/SVGTransformListPropertyTearOff.h',
             'svg/ColorDistance.cpp',
             'svg/ColorDistance.h',
@@ -4020 +4021 @@
             'svg/SVGAnimatedRect.h',
             'svg/SVGAnimatedString.h',
+            'svg/SVGAnimatedTransformList.h',
             'svg/SVGAnimationElement.cpp',
             'svg/SVGAnimationElement.h',
@@ -4158 +4160 @@
             'svg/SVGMaskElement.cpp',
             'svg/SVGMaskElement.h',
+            'svg/SVGMatrix.h',
             'svg/SVGMetadataElement.cpp',
             'svg/SVGMetadataElement.h',

trunk/WebCore/WebCore.pro

@@ -472 +472 @@
         bindings/v8/custom/V8SVGElementCustom.cpp \
         bindings/v8/custom/V8SVGLengthCustom.cpp \
-        bindings/v8/custom/V8SVGMatrixCustom.cpp \
         bindings/v8/custom/V8SVGPathSegCustom.cpp \
         \
@@ -2372 +2371 @@
     svg/properties/SVGAnimatedPropertyTearOff.h \
     svg/properties/SVGAnimatedStaticPropertyTearOff.h \
+    svg/properties/SVGAnimatedTransformListPropertyTearOff.h \
     svg/properties/SVGListProperty.h \
     svg/properties/SVGListPropertyTearOff.h \
@@ -2379 +2379 @@
     svg/properties/SVGStaticListPropertyTearOff.h \
     svg/properties/SVGStaticPropertyTearOff.h \
+    svg/properties/SVGStaticPropertyWithParentTearOff.h \
+    svg/properties/SVGTransformListPropertyTearOff.h \
     svg/SVGAElement.h \
     svg/SVGAltGlyphElement.h \
@@ -2395 +2397 @@
     svg/SVGAnimatedRect.h \
     svg/SVGAnimatedString.h \
+    svg/SVGAnimatedTransformList.h \
     svg/SVGAnimateElement.h \
     svg/SVGAnimateMotionElement.h \
@@ -2464 +2467 @@
     svg/SVGMarkerElement.h \
     svg/SVGMaskElement.h \
+    svg/SVGMatrix.h \
     svg/SVGMetadataElement.h \
     svg/SVGMissingGlyphElement.h \
@@ -3370 +3374 @@
             bindings/js/JSSVGElementInstanceCustom.cpp \
             bindings/js/JSSVGLengthCustom.cpp \
-            bindings/js/JSSVGMatrixCustom.cpp \
             bindings/js/JSSVGPathSegCustom.cpp \
             bindings/js/JSSVGPathSegListCustom.cpp

trunk/WebCore/WebCore.vcproj/WebCore.vcproj

@@ -60252 +60252 @@
                                 </File>
                                 <File
-                                        RelativePath="..\bindings\js\JSSVGMatrixCustom.cpp"
-                                        >
-                                        <FileConfiguration
-                                                Name="Debug|Win32"
-                                                ExcludedFromBuild="true"
-                                                >
-                                                <Tool
-                                                        Name="VCCLCompilerTool"
-                                                />
-                                        </FileConfiguration>
-                                        <FileConfiguration
-                                                Name="Release|Win32"
-                                                ExcludedFromBuild="true"
-                                                >
-                                                <Tool
-                                                        Name="VCCLCompilerTool"
-                                                />
-                                        </FileConfiguration>
-                                        <FileConfiguration
-                                                Name="Debug_Internal|Win32"
-                                                ExcludedFromBuild="true"
-                                                >
-                                                <Tool
-                                                        Name="VCCLCompilerTool"
-                                                />
-                                        </FileConfiguration>
-                                        <FileConfiguration
-                                                Name="Debug_Cairo|Win32"
-                                                ExcludedFromBuild="true"
-                                                >
-                                                <Tool
-                                                        Name="VCCLCompilerTool"
-                                                />
-                                        </FileConfiguration>
-                                        <FileConfiguration
-                                                Name="Release_Cairo|Win32"
-                                                ExcludedFromBuild="true"
-                                                >
-                                                <Tool
-                                                        Name="VCCLCompilerTool"
-                                                />
-                                        </FileConfiguration>
-                                        <FileConfiguration
-                                                Name="Debug_All|Win32"
-                                                ExcludedFromBuild="true"
-                                                >
-                                                <Tool
-                                                        Name="VCCLCompilerTool"
-                                                />
-                                        </FileConfiguration>
-                                </File>
-                                <File
                                         RelativePath="..\bindings\js\JSSVGPathSegCustom.cpp"
                                         >
@@ -61885 +61833 @@
                         </File>
                         <File
+                                RelativePath="..\svg\SVGAnimatedTransformList.h"
+                                >
+                        </File>
+                        <File
                                 RelativePath="..\svg\SVGAnimateElement.h"
                                 >
@@ -62378 +62330 @@
                         <File
                                 RelativePath="..\svg\SVGMaskElement.h"
+                                >
+                        </File>
+                        <File
+                                RelativePath="..\svg\SVGMatrix.h"
                                 >
                         </File>
@@ -62932 +62888 @@
                                 </File>
                                 <File
+                                        RelativePath="..\svg\properties\SVGAnimatedTransformListPropertyTearOff.h"
+                                        >
+                                </File>
+                                <File
                                         RelativePath="..\svg\properties\SVGListProperty.h"
                                         >
@@ -62957 +62917 @@
                                 <File
                                         RelativePath="..\svg\properties\SVGStaticPropertyTearOff.h"
+                                        >
+                                </File>
+                                <File
+                                        RelativePath="..\svg\properties\SVGStaticPropertyWithParentTearOff.h"
+                                        >
+                                </File>
+                                <File
+                                        RelativePath="..\svg\properties\SVGTransformListPropertyTearOff.h"
                                         >
                                 </File>

trunk/WebCore/WebCore.xcodeproj/project.pbxproj

@@ -61 +61 @@
                 0804BF6E0EE09C3B0006C000 /* WMLDoElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0804BF6C0EE09C3B0006C000 /* WMLDoElement.cpp */; };
                 0804BF6F0EE09C3B0006C000 /* WMLDoElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 0804BF6D0EE09C3B0006C000 /* WMLDoElement.h */; };
+                0806E57A12893045007CED32 /* SVGMatrix.h in Headers */ = {isa = PBXBuildFile; fileRef = 0806E57912893045007CED32 /* SVGMatrix.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 08082373117987C100241DE8 /* RenderSVGResourceContainer.h in Headers */ = {isa = PBXBuildFile; fileRef = 08082372117987C100241DE8 /* RenderSVGResourceContainer.h */; };
                 080AEC810ED8708B00DF4CCE /* WMLIntrinsicEvent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 080AEC7D0ED8708A00DF4CCE /* WMLIntrinsicEvent.cpp */; };
@@ -96 +97 @@
                 082341C60FCF3A9500D75BD6 /* WMLSelectElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 082341C40FCF3A9400D75BD6 /* WMLSelectElement.h */; };
                 0823D159127AD6AC000EBC95 /* SVGAnimatedInteger.h in Headers */ = {isa = PBXBuildFile; fileRef = 0823D158127AD6AC000EBC95 /* SVGAnimatedInteger.h */; settings = {ATTRIBUTES = (Private, ); }; };
+                08250939128BD4D800E2ED8E /* SVGAnimatedTransformList.h in Headers */ = {isa = PBXBuildFile; fileRef = 08250938128BD4D800E2ED8E /* SVGAnimatedTransformList.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 082FCAC4110927CE00CC4821 /* JSSVGContextCache.h in Headers */ = {isa = PBXBuildFile; fileRef = 082FCAC3110927CE00CC4821 /* JSSVGContextCache.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 083192AA112B43050083C3B9 /* RenderSVGResource.h in Headers */ = {isa = PBXBuildFile; fileRef = 083192A7112B43050083C3B9 /* RenderSVGResource.h */; };
@@ -144 +146 @@
                 085797091278394C00A8EC5F /* SVGAnimatedBoolean.h in Headers */ = {isa = PBXBuildFile; fileRef = 085797081278394C00A8EC5F /* SVGAnimatedBoolean.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 08591AA50F085C4E009BACB1 /* InputElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 08591AA40F085C4E009BACB1 /* InputElement.h */; settings = {ATTRIBUTES = (Private, ); }; };
+                085A15931289A8DD002710E3 /* SVGAnimatedTransformListPropertyTearOff.h in Headers */ = {isa = PBXBuildFile; fileRef = 085A15921289A8DD002710E3 /* SVGAnimatedTransformListPropertyTearOff.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 085AFDC80F2977350061F2B3 /* WMLFormControlElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 085AFDC60F2977350061F2B3 /* WMLFormControlElement.cpp */; };
                 085AFDC90F2977350061F2B3 /* WMLFormControlElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 085AFDC70F2977350061F2B3 /* WMLFormControlElement.h */; settings = {ATTRIBUTES = (); }; };
@@ -235 +238 @@
                 08C6A7AB117DFBAB00FEA1A2 /* RenderSVGResourceSolidColor.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 08C6A7A9117DFBAB00FEA1A2 /* RenderSVGResourceSolidColor.cpp */; };
                 08C6A7AC117DFBAB00FEA1A2 /* RenderSVGResourceSolidColor.h in Headers */ = {isa = PBXBuildFile; fileRef = 08C6A7AA117DFBAB00FEA1A2 /* RenderSVGResourceSolidColor.h */; };
+                08C7136E128956A3001B107E /* SVGTransformListPropertyTearOff.h in Headers */ = {isa = PBXBuildFile; fileRef = 08C7136D128956A3001B107E /* SVGTransformListPropertyTearOff.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 08C7A2C710DC7462002D368B /* SVGNames.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 656581E909D1508D000E61D7 /* SVGNames.h */; };
                 08C859C01274575400A5728D /* SVGAnimatedRect.h in Headers */ = {isa = PBXBuildFile; fileRef = 08C859BF1274575300A5728D /* SVGAnimatedRect.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 08C925190FCC7C4A00480DEC /* FilterEffect.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 08C925170FCC7C4A00480DEC /* FilterEffect.cpp */; };
                 08C9251A0FCC7C4A00480DEC /* FilterEffect.h in Headers */ = {isa = PBXBuildFile; fileRef = 08C925180FCC7C4A00480DEC /* FilterEffect.h */; };
+                08CA3D4412894A3800FFF260 /* SVGStaticPropertyWithParentTearOff.h in Headers */ = {isa = PBXBuildFile; fileRef = 08CA3D4312894A3800FFF260 /* SVGStaticPropertyWithParentTearOff.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 08CD61BC0ED3929C002DDF51 /* WMLTaskElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 08CD61B80ED3929C002DDF51 /* WMLTaskElement.cpp */; };
                 08CD61BD0ED3929C002DDF51 /* WMLTaskElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 08CD61B90ED3929C002DDF51 /* WMLTaskElement.h */; };
@@ -4227 +4232 @@
                 B25599A40D00D8BA00BB825C /* SVGImage.h in Headers */ = {isa = PBXBuildFile; fileRef = B255990C0D00D8B900BB825C /* SVGImage.h */; };
                 B25599A50D00D8BA00BB825C /* EmptyClients.h in Headers */ = {isa = PBXBuildFile; fileRef = B255990D0D00D8B900BB825C /* EmptyClients.h */; };
-                B25DFAAF0B2E2929000E6510 /* JSSVGMatrixCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = B25DFAAE0B2E2929000E6510 /* JSSVGMatrixCustom.cpp */; };
                 B262B8040D1F32D000158F09 /* SVGFont.cpp in Sources */ = {isa = PBXBuildFile; fileRef = B262B8030D1F32D000158F09 /* SVGFont.cpp */; };
                 B266CD4D0C3AEC6500EB08D2 /* JSSVGException.cpp in Sources */ = {isa = PBXBuildFile; fileRef = B266CD4B0C3AEC6500EB08D2 /* JSSVGException.cpp */; };
@@ -6110 +6114 @@
                 0804BF6C0EE09C3B0006C000 /* WMLDoElement.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WMLDoElement.cpp; sourceTree = "<group>"; };
                 0804BF6D0EE09C3B0006C000 /* WMLDoElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WMLDoElement.h; sourceTree = "<group>"; };
+                0806E57912893045007CED32 /* SVGMatrix.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGMatrix.h; sourceTree = "<group>"; };
                 08082372117987C100241DE8 /* RenderSVGResourceContainer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderSVGResourceContainer.h; sourceTree = "<group>"; };
                 080AEC7D0ED8708A00DF4CCE /* WMLIntrinsicEvent.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WMLIntrinsicEvent.cpp; sourceTree = "<group>"; };
@@ -6145 +6150 @@
                 082341C40FCF3A9400D75BD6 /* WMLSelectElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WMLSelectElement.h; sourceTree = "<group>"; };
                 0823D158127AD6AC000EBC95 /* SVGAnimatedInteger.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGAnimatedInteger.h; sourceTree = "<group>"; };
+                08250938128BD4D800E2ED8E /* SVGAnimatedTransformList.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGAnimatedTransformList.h; sourceTree = "<group>"; };
                 082FCAC3110927CE00CC4821 /* JSSVGContextCache.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSSVGContextCache.h; sourceTree = "<group>"; };
                 083192A7112B43050083C3B9 /* RenderSVGResource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderSVGResource.h; sourceTree = "<group>"; };
@@ -6191 +6197 @@
                 085797081278394C00A8EC5F /* SVGAnimatedBoolean.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGAnimatedBoolean.h; sourceTree = "<group>"; };
                 08591AA40F085C4E009BACB1 /* InputElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InputElement.h; sourceTree = "<group>"; };
+                085A15921289A8DD002710E3 /* SVGAnimatedTransformListPropertyTearOff.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGAnimatedTransformListPropertyTearOff.h; sourceTree = "<group>"; };
                 085AFDC60F2977350061F2B3 /* WMLFormControlElement.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WMLFormControlElement.cpp; sourceTree = "<group>"; };
                 085AFDC70F2977350061F2B3 /* WMLFormControlElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WMLFormControlElement.h; sourceTree = "<group>"; };
@@ -6270 +6277 @@
                 08C6A7A9117DFBAB00FEA1A2 /* RenderSVGResourceSolidColor.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RenderSVGResourceSolidColor.cpp; sourceTree = "<group>"; };
                 08C6A7AA117DFBAB00FEA1A2 /* RenderSVGResourceSolidColor.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderSVGResourceSolidColor.h; sourceTree = "<group>"; };
+                08C7136D128956A3001B107E /* SVGTransformListPropertyTearOff.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGTransformListPropertyTearOff.h; sourceTree = "<group>"; };
                 08C859BF1274575300A5728D /* SVGAnimatedRect.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGAnimatedRect.h; sourceTree = "<group>"; };
                 08C925170FCC7C4A00480DEC /* FilterEffect.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = FilterEffect.cpp; path = filters/FilterEffect.cpp; sourceTree = "<group>"; };
                 08C925180FCC7C4A00480DEC /* FilterEffect.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = FilterEffect.h; path = filters/FilterEffect.h; sourceTree = "<group>"; };
+                08CA3D4312894A3800FFF260 /* SVGStaticPropertyWithParentTearOff.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGStaticPropertyWithParentTearOff.h; sourceTree = "<group>"; };
                 08CD61B80ED3929C002DDF51 /* WMLTaskElement.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WMLTaskElement.cpp; sourceTree = "<group>"; };
                 08CD61B90ED3929C002DDF51 /* WMLTaskElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WMLTaskElement.h; sourceTree = "<group>"; };
@@ -10229 +10238 @@
                 B255990C0D00D8B900BB825C /* SVGImage.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = SVGImage.h; sourceTree = "<group>"; };
                 B255990D0D00D8B900BB825C /* EmptyClients.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = EmptyClients.h; sourceTree = "<group>"; };
-                B25DFAAE0B2E2929000E6510 /* JSSVGMatrixCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = JSSVGMatrixCustom.cpp; sourceTree = "<group>"; };
                 B262B8030D1F32D000158F09 /* SVGFont.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = SVGFont.cpp; sourceTree = "<group>"; };
                 B266CD4B0C3AEC6500EB08D2 /* JSSVGException.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = JSSVGException.cpp; sourceTree = "<group>"; };
@@ -11802 +11810 @@
                                 088A0DFF126EF1DB00978F7A /* SVGAnimatedPropertyTearOff.h */,
                                 08525E621278C00100A84778 /* SVGAnimatedStaticPropertyTearOff.h */,
+                                085A15921289A8DD002710E3 /* SVGAnimatedTransformListPropertyTearOff.h */,
                                 0810764312828556007C63BA /* SVGListProperty.h */,
                                 088A0E00126EF1DB00978F7A /* SVGListPropertyTearOff.h */,
@@ -11809 +11818 @@
                                 0880F70D1282B46D00948505 /* SVGStaticListPropertyTearOff.h */,
                                 0813A4E91284132600992511 /* SVGStaticPropertyTearOff.h */,
+                                08CA3D4312894A3800FFF260 /* SVGStaticPropertyWithParentTearOff.h */,
+                                08C7136D128956A3001B107E /* SVGTransformListPropertyTearOff.h */,
                         );
                         path = properties;
@@ -14546 +14557 @@
                                 4F1534DD11B532EC0021FD86 /* EditingBehavior.h */,
                                 4F1534DF11B533020021FD86 /* EditingBehaviorTypes.h */,
+                                9BAB6C6B12550631001626D4 /* EditingStyle.cpp */,
                                 9BAB6C6A12550631001626D4 /* EditingStyle.h */,
-                                9BAB6C6B12550631001626D4 /* EditingStyle.cpp */,
                                 4B3043CA0AE0373B00A82647 /* Editor.cpp */,
                                 4B3043CB0AE0373B00A82647 /* Editor.h */,
@@ -16137 +16148 @@
                                 084DB59A128008CC002A6D64 /* SVGAnimatedString.h */,
                                 B22277F60D00BF1F0071B782 /* SVGAnimatedString.idl */,
+                                08250938128BD4D800E2ED8E /* SVGAnimatedTransformList.h */,
                                 B22277F80D00BF1F0071B782 /* SVGAnimatedTransformList.idl */,
                                 B22277F90D00BF1F0071B782 /* SVGAnimateElement.cpp */,
@@ -16345 +16357 @@
                                 B22278B10D00BF200071B782 /* SVGMaskElement.h */,
                                 B22278B20D00BF200071B782 /* SVGMaskElement.idl */,
+                                0806E57912893045007CED32 /* SVGMatrix.h */,
                                 B22278B30D00BF200071B782 /* SVGMatrix.idl */,
                                 B22278B40D00BF200071B782 /* SVGMetadataElement.cpp */,
@@ -17138 +17151 @@
                                 08A48A6D0E86CF6D00E225DD /* JSSVGElementInstanceCustom.cpp */,
                                 08E4FE450E2BD41400F4CAE0 /* JSSVGLengthCustom.cpp */,
-                                B25DFAAE0B2E2929000E6510 /* JSSVGMatrixCustom.cpp */,
                                 B2C96D8C0B3AF2B7005E80EC /* JSSVGPathSegCustom.cpp */,
                                 B297BC6F0B3C14CF0045A590 /* JSSVGPathSegListCustom.cpp */,
@@ -17286 +17298 @@
                         isa = PBXGroup;
                         children = (
-                                A8D2B2521287A56000AF4DDA /* cache */,
                                 1A8F6BB00DB55CDC001DB794 /* appcache */,
                                 512DD8E80D91E691000F89EE /* archive */,
+                                A8D2B2521287A56000AF4DDA /* cache */,
                                 5126E6B60A2E3AEF005C29FA /* icon */,
                                 93A1EAA20A5634D8006960A0 /* mac */,
@@ -18581 +18593 @@
                                 1A569CFC0D7E2B82007C3983 /* c_runtime.h in Headers */,
                                 1A569CFE0D7E2B82007C3983 /* c_utility.h in Headers */,
-                                BCB16C180979C3BD00467741 /* MemoryCache.h in Headers */,
                                 BCB16C1A0979C3BD00467741 /* CachedCSSStyleSheet.h in Headers */,
                                 BC64B4CC0CB4295D005F2B62 /* CachedFont.h in Headers */,
@@ -19630 +19641 @@
                                 976D6C91122B8A3D001FD1F7 /* FileWriter.h in Headers */,
                                 893C47A81238908B002B3D86 /* FileWriterCallback.h in Headers */,
+                                46700ED1127B96CB00F5D5D6 /* FileWriterSync.h in Headers */,
                                 BC5EB69F0E81DAEB00B25965 /* FillLayer.h in Headers */,
                                 845E72F80FD261EE00A87D79 /* Filter.h in Headers */,
@@ -20457 +20469 @@
                                 4E19592C0A39DACC00220FE5 /* MediaQueryEvaluator.h in Headers */,
                                 4E19592E0A39DACC00220FE5 /* MediaQueryExp.h in Headers */,
+                                BCB16C180979C3BD00467741 /* MemoryCache.h in Headers */,
                                 9FFE3E7B11B59C5D0037874E /* MemoryInfo.h in Headers */,
                                 93309DFA099E64920056E581 /* MergeIdenticalElementsCommand.h in Headers */,
@@ -20748 +20761 @@
                                 5162C7F511F77EFB00612EFE /* SchemeRegistry.h in Headers */,
                                 BCEC01BE0C274DAC009F4EC9 /* Screen.h in Headers */,
+                                A84D82C111D3474800972990 /* ScriptableDocumentParser.h in Headers */,
                                 F39BE95C12673BF400E0A674 /* ScriptArguments.h in Headers */,
-                                A84D82C111D3474800972990 /* ScriptableDocumentParser.h in Headers */,
                                 7AFD4A8B1131C2760035B883 /* ScriptBreakpoint.h in Headers */,
                                 41F1D21F0EF35C2A00DA8753 /* ScriptCachedFrameData.h in Headers */,
@@ -20927 +20940 @@
                                 08525E631278C00100A84778 /* SVGAnimatedStaticPropertyTearOff.h in Headers */,
                                 084DB59B128008CC002A6D64 /* SVGAnimatedString.h in Headers */,
+                                085A15931289A8DD002710E3 /* SVGAnimatedTransformListPropertyTearOff.h in Headers */,
                                 B22279900D00BF220071B782 /* SVGAnimateElement.h in Headers */,
                                 B22279930D00BF220071B782 /* SVGAnimateMotionElement.h in Headers */,
@@ -21012 +21026 @@
                                 08735FB910E91232006D6FAD /* SVGMarkerLayoutInfo.h in Headers */,
                                 B2227A470D00BF220071B782 /* SVGMaskElement.h in Headers */,
+                                0806E57A12893045007CED32 /* SVGMatrix.h in Headers */,
                                 B2227A4B0D00BF220071B782 /* SVGMetadataElement.h in Headers */,
                                 B2A1F2B10CEF0ABF00442F6A /* SVGMissingGlyphElement.h in Headers */,
@@ -21071 +21086 @@
                                 0880F70E1282B46D00948505 /* SVGStaticListPropertyTearOff.h in Headers */,
                                 0813A4EA1284132600992511 /* SVGStaticPropertyTearOff.h in Headers */,
+                                08CA3D4412894A3800FFF260 /* SVGStaticPropertyWithParentTearOff.h in Headers */,
                                 B2227AA90D00BF220071B782 /* SVGStopElement.h in Headers */,
                                 B2227AAC0D00BF220071B782 /* SVGStringList.h in Headers */,
@@ -21101 +21117 @@
                                 B2227ADD0D00BF220071B782 /* SVGTransformDistance.h in Headers */,
                                 B2227ADF0D00BF220071B782 /* SVGTransformList.h in Headers */,
+                                08C7136E128956A3001B107E /* SVGTransformListPropertyTearOff.h in Headers */,
                                 B2227AE20D00BF220071B782 /* SVGTRefElement.h in Headers */,
                                 B2227AE50D00BF220071B782 /* SVGTSpanElement.h in Headers */,
@@ -21345 +21362 @@
                                 E1BE512E0CF6C512002EA959 /* XSLTUnicodeSort.h in Headers */,
                                 97DD4D870FDF4D6E00ECF9A4 /* XSSAuditor.h in Headers */,
-                                46700ED1127B96CB00F5D5D6 /* FileWriterSync.h in Headers */,
+                                08250939128BD4D800E2ED8E /* SVGAnimatedTransformList.h in Headers */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;
@@ -21405 +21422 @@
                         buildConfigurationList = 149C284308902B11008A9EFC /* Build configuration list for PBXProject "WebCore" */;
                         compatibilityVersion = "Xcode 2.4";
-                        developmentRegion = English;
                         hasScannedForEncodings = 1;
                         knownRegions = (
@@ -21734 +21750 @@
                                 1A569CFB0D7E2B82007C3983 /* c_runtime.cpp in Sources */,
                                 1A569CFD0D7E2B82007C3983 /* c_utility.cpp in Sources */,
-                                BCB16C170979C3BD00467741 /* MemoryCache.cpp in Sources */,
                                 BCB16C190979C3BD00467741 /* CachedCSSStyleSheet.cpp in Sources */,
                                 BC64B4CB0CB4295D005F2B62 /* CachedFont.cpp in Sources */,
@@ -22269 +22284 @@
                                 976D6C8D122B8A3D001FD1F7 /* FileThread.cpp in Sources */,
                                 976D6C90122B8A3D001FD1F7 /* FileWriter.cpp in Sources */,
+                                46700ED0127B96CB00F5D5D6 /* FileWriterSync.cpp in Sources */,
                                 BC5EB69E0E81DAEB00B25965 /* FillLayer.cpp in Sources */,
                                 08C925190FCC7C4A00480DEC /* FilterEffect.cpp in Sources */,
@@ -22984 +23000 @@
                                 B2FA3DAA0AB75A6F000E5AC4 /* JSSVGMaskElement.cpp in Sources */,
                                 B2FA3DAC0AB75A6F000E5AC4 /* JSSVGMatrix.cpp in Sources */,
-                                B25DFAAF0B2E2929000E6510 /* JSSVGMatrixCustom.cpp in Sources */,
                                 B2FA3DAE0AB75A6F000E5AC4 /* JSSVGMetadataElement.cpp in Sources */,
                                 B27B28290CEF0C0700D39D54 /* JSSVGMissingGlyphElement.cpp in Sources */,
@@ -23161 +23176 @@
                                 4E19592B0A39DACC00220FE5 /* MediaQueryEvaluator.cpp in Sources */,
                                 4E19592D0A39DACC00220FE5 /* MediaQueryExp.cpp in Sources */,
+                                BCB16C170979C3BD00467741 /* MemoryCache.cpp in Sources */,
                                 9FFE3E7A11B59C5D0037874E /* MemoryInfo.cpp in Sources */,
                                 93309DF9099E64920056E581 /* MergeIdenticalElementsCommand.cpp in Sources */,
@@ -23385 +23401 @@
                                 51AA3F6F0BD5AA9E00892971 /* ResourceLoaderMac.mm in Sources */,
                                 973E325610883B7C005BC493 /* ResourceLoadNotifier.cpp in Sources */,
+                                D0CE58F8125E4CC200F3F199 /* ResourceLoadScheduler.cpp in Sources */,
                                 514C767C0CE923A1007EF3CD /* ResourceRequestBase.cpp in Sources */,
                                 514C76530CE9234E007EF3CD /* ResourceRequestMac.mm in Sources */,
@@ -23915 +23932 @@
                                 E1BE512D0CF6C512002EA959 /* XSLTUnicodeSort.cpp in Sources */,
                                 97DD4D860FDF4D6E00ECF9A4 /* XSSAuditor.cpp in Sources */,
-                                46700ED0127B96CB00F5D5D6 /* FileWriterSync.cpp in Sources */,
-                                D0CE58F8125E4CC200F3F199 /* ResourceLoadScheduler.cpp in Sources */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;

trunk/WebCore/bindings/js/JSBindingsAllInOne.cpp

@@ -117 +117 @@
 #include "JSSVGElementInstanceCustom.cpp"
 #include "JSSVGLengthCustom.cpp"
-#include "JSSVGMatrixCustom.cpp"
 #include "JSSVGPathSegCustom.cpp"
 #include "JSSVGPathSegListCustom.cpp"

trunk/WebCore/bindings/scripts/CodeGenerator.pm

@@ -51 +51 @@
 my %primitiveTypeHash = ( "boolean" => 1, "void" => 1, "Date" => 1);
 
-my %podTypeHash = ("SVGTransform" => 1);
-my %podTypesWithWritablePropertiesHash = ("SVGMatrix" => 1);
 my %stringTypeHash = ("DOMString" => 1, "AtomicString" => 1);
 
 my %nonPointerTypeHash = ("DOMTimeStamp" => 1, "CompareHow" => 1, "SVGPaintType" => 1);
-
-my %svgNewStyleAnimatedTypeHash = ("SVGAnimatedAngle" => 1, "SVGAnimatedBoolean" => 1,
-                                   "SVGAnimatedEnumeration" => 1, "SVGAnimatedInteger" => 1,
-                                   "SVGAnimatedLength" => 1, "SVGAnimatedLengthList" => 1,
-                                   "SVGAnimatedNumber" => 1, "SVGAnimatedNumberList" => 1,
-                                   "SVGAnimatedPreserveAspectRatio" => 1, "SVGAnimatedRect" => 1,
-                                   "SVGAnimatedString" => 1);
 
 my %svgAnimatedTypeHash = ("SVGAnimatedAngle" => 1, "SVGAnimatedBoolean" => 1,
@@ -82 +73 @@
     "SVGLength" => "SVGPropertyTearOff<SVGLength>",
     "SVGLengthList" => "SVGListPropertyTearOff<SVGLengthList>",
+    "SVGMatrix" => "SVGPropertyTearOff<SVGMatrix>",
     "SVGNumber" => "SVGPropertyTearOff<float>",
     "SVGNumberList" => "SVGListPropertyTearOff<SVGNumberList>",
@@ -88 +80 @@
     "SVGPreserveAspectRatio" => "SVGPropertyTearOff<SVGPreserveAspectRatio>",
     "SVGRect" => "SVGPropertyTearOff<FloatRect>",
-    "SVGStringList" => "SVGStaticListPropertyTearOff<SVGStringList>"
+    "SVGStringList" => "SVGStaticListPropertyTearOff<SVGStringList>",
+    "SVGTransform" => "SVGPropertyTearOff<SVGTransform>",
+    "SVGTransformList" => "SVGTransformListPropertyTearOff"
 );
 
 my %svgTypeWithWritablePropertiesNeedingTearOff = (
-    "SVGPoint" => 1
+    "SVGPoint" => 1,
+    "SVGMatrix" => 1
 );
 
@@ -313 +308 @@
     my $type = shift;
 
-    # Special case: SVGRect.h / SVGPoint.h / SVGNumber.h / SVGMatrix.h do not exist.
-    return 1 if $type eq "SVGRect" or $type eq "SVGPoint" or $type eq "SVGNumber" or $type eq "SVGMatrix";
-    return 0;
-}
-
-# FIXME: This method will go away once all SVG animated properties are converted to the new scheme.
-sub IsPodType
-{
-    my $object = shift;
-    my $type = shift;
-
-    return 1 if $podTypeHash{$type};
-    return 1 if $podTypesWithWritablePropertiesHash{$type};
-    return 0;
-}
-
-sub IsPodTypeWithWriteableProperties
-{
-    my $object = shift;
-    my $type = shift;
-
-    return 1 if $podTypesWithWritablePropertiesHash{$type};
+    # Special case: SVGRect.h / SVGPoint.h / SVGNumber.h do not exist.
+    return 1 if $type eq "SVGRect" or $type eq "SVGPoint" or $type eq "SVGNumber";
     return 0;
 }
@@ -416 +391 @@
     } elsif ($svgTypeNeedingTearOff =~ /SVGStaticListPropertyTearOff/) {
         $svgTypeNeedingTearOff =~ s/SVGStaticListPropertyTearOff<//;
-    }
+    }  elsif ($svgTypeNeedingTearOff =~ /SVGTransformListPropertyTearOff/) {
+        $svgTypeNeedingTearOff =~ s/SVGTransformListPropertyTearOff<//;
+    } 
 
     $svgTypeNeedingTearOff =~ s/>//;
     return $svgTypeNeedingTearOff;
-}
-
-# FIXME: This method will go away once all SVG animated properties are converted to the new scheme.
-sub IsSVGNewStyleAnimatedType
-{
-    my $object = shift;
-    my $type = shift;
-
-    return 1 if $svgNewStyleAnimatedTypeHash{$type};
-    return 0;
 }
 

trunk/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -326 +326 @@
     return 0 unless $implClassName =~ /SVG/;
     return 0 if $implClassName =~ /Element/;
-    return 0 if $codeGenerator->IsSVGNewStyleAnimatedType($implClassName);
+    return 0 if $codeGenerator->IsSVGAnimatedType($implClassName);
     return 0 if $codeGenerator->IsSVGTypeNeedingTearOff($implClassName);
 
@@ -673 +673 @@
     $implType = $svgNativeType if $svgNativeType;
 
-    # FIXME: Old style SVG JS bindings, will vanish soon.
-    my $podType = $dataNode->extendedAttributes->{"PODType"};
-    if ($podType) {
-        $implType = "JSSVGPODTypeWrapper<$podType> ";
-        $headerIncludes{"$podType.h"} = 1 if $podType ne "float";
-        $headerIncludes{"JSSVGPODTypeWrapper.h"} = 1;
-    }
-
-    my $svgPropertyOrPodType;
-    $svgPropertyOrPodType = $podType if $podType;
-    $svgPropertyOrPodType = $svgPropertyType if $svgPropertyType;
-    $svgPropertyOrPodType = $svgListPropertyType if $svgListPropertyType;
+    my $svgPropertyOrListPropertyType;
+    $svgPropertyOrListPropertyType = $svgPropertyType if $svgPropertyType;
+    $svgPropertyOrListPropertyType = $svgListPropertyType if $svgListPropertyType;
 
     my $numConstants = @{$dataNode->constants};
@@ -692 +683 @@
     push(@headerContent, "\nnamespace WebCore {\n\n");
 
-    if ($codeGenerator->IsSVGNewStyleAnimatedType($implClassName)) {
+    if ($codeGenerator->IsSVGAnimatedType($implClassName)) {
         $headerIncludes{"$implClassName.h"} = 1;
     } else {
         # Implementation class forward declaration
-        AddClassForwardIfNeeded($implClassName) unless $svgPropertyOrPodType;
+        AddClassForwardIfNeeded($implClassName) unless $svgPropertyOrListPropertyType;
     }
 
@@ -945 +936 @@
 
     if (!$hasParent || $dataNode->extendedAttributes->{"GenerateToJS"} || $dataNode->extendedAttributes->{"CustomToJS"}) {
-        if ($podType) {
-            push(@headerContent, "JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, $implType*, SVGElement*);\n");
-        } elsif ($svgPropertyType) {
+        if ($svgPropertyType) {
             push(@headerContent, "JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, $implType*);\n");
         } elsif (IsSVGTypeNeedingContextParameter($implClassName)) {
@@ -956 +945 @@
     }
     if (!$hasParent || $dataNode->extendedAttributes->{"GenerateNativeConverter"}) {
-
-        if ($podType) {
-            push(@headerContent, "$podType to${interfaceName}(JSC::JSValue);\n");
-        } elsif ($interfaceName eq "NodeFilter") {
+        if ($interfaceName eq "NodeFilter") {
             push(@headerContent, "PassRefPtr<NodeFilter> toNodeFilter(JSC::JSValue);\n");
         } else {
@@ -1431 +1417 @@
     $implType = $svgNativeType if $svgNativeType;
 
-    my $podType = $dataNode->extendedAttributes->{"PODType"};
-    if ($podType) {
-        $implType = "JSSVGPODTypeWrapper<$podType> ";
-    }
-
-    my $svgPropertyOrPodType;
-    $svgPropertyOrPodType = $podType if $podType;
-    $svgPropertyOrPodType = $svgPropertyType if $svgPropertyType;
-    $svgPropertyOrPodType = $svgListPropertyType if $svgListPropertyType;
+    my $svgPropertyOrListPropertyType;
+    $svgPropertyOrListPropertyType = $svgPropertyType if $svgPropertyType;
+    $svgPropertyOrListPropertyType = $svgListPropertyType if $svgListPropertyType;
 
     # Constructor
@@ -1562 +1542 @@
                 push(@implContent, "    ${className}* castedThis = static_cast<$className*>(asObject(slotBase));\n");
 
-                my $implClassNameForValueConversion = "";
-                if (!$svgPropertyOrPodType and ($codeGenerator->IsSVGAnimatedType($implClassName) or $attribute->type !~ /^readonly/)) {
-                    $implClassNameForValueConversion = $implClassName;
-                }
-
                 if ($dataNode->extendedAttributes->{"CheckDomainSecurity"} && 
                         !$attribute->signature->extendedAttributes->{"DoNotCheckDomainSecurity"} &&
@@ -1579 +1554 @@
                     $implIncludes{"JSDOMBinding.h"} = 1;
                     push(@implContent, "    $implClassName* imp = static_cast<$implClassName*>(castedThis->impl());\n");
-                    push(@implContent, "    return checkNodeSecurity(exec, imp->$implGetterFunctionName()) ? " . NativeToJSValue($attribute->signature, 0, $implClassName, $implClassNameForValueConversion, "imp->$implGetterFunctionName()", "castedThis") . " : jsUndefined();\n");
+                    push(@implContent, "    return checkNodeSecurity(exec, imp->$implGetterFunctionName()) ? " . NativeToJSValue($attribute->signature, 0, $implClassName, "imp->$implGetterFunctionName()", "castedThis") . " : jsUndefined();\n");
                 } elsif ($attribute->signature->extendedAttributes->{"CheckFrameSecurity"}) {
                     $implIncludes{"Document.h"} = 1;
                     $implIncludes{"JSDOMBinding.h"} = 1;
                     push(@implContent, "    $implClassName* imp = static_cast<$implClassName*>(castedThis->impl());\n");
-                    push(@implContent, "    return checkNodeSecurity(exec, imp->contentDocument()) ? " . NativeToJSValue($attribute->signature,  0, $implClassName, $implClassNameForValueConversion, "imp->$implGetterFunctionName()", "castedThis") . " : jsUndefined();\n");
+                    push(@implContent, "    return checkNodeSecurity(exec, imp->contentDocument()) ? " . NativeToJSValue($attribute->signature, 0, $implClassName, "imp->$implGetterFunctionName()", "castedThis") . " : jsUndefined();\n");
                 } elsif ($type eq "EventListener") {
                     $implIncludes{"EventListener.h"} = 1;
@@ -1617 +1592 @@
 
                     if ($svgListPropertyType) {
-                        push(@implContent, "    JSValue result =  " . NativeToJSValue($attribute->signature, 0, $implClassName, "", "castedThis->impl()->$implGetterFunctionName()", "castedThis") . ";\n");
-                    } elsif ($svgPropertyOrPodType) {
-                        push(@implContent, "    $svgPropertyOrPodType imp(*castedThis->impl());\n") if $podType;
-                        push(@implContent, "    $svgPropertyOrPodType& imp = castedThis->impl()->propertyReference();\n") if !$podType;
-                        if ($svgPropertyOrPodType eq "float") { # Special case for JSSVGNumber
-                            push(@implContent, "    JSValue result =  " . NativeToJSValue($attribute->signature, 0, $implClassName, "", "imp", "castedThis") . ";\n");
+                        push(@implContent, "    JSValue result =  " . NativeToJSValue($attribute->signature, 0, $implClassName, "castedThis->impl()->$implGetterFunctionName()", "castedThis") . ";\n");
+                    } elsif ($svgPropertyOrListPropertyType) {
+                        push(@implContent, "    $svgPropertyOrListPropertyType& imp = castedThis->impl()->propertyReference();\n");
+                        if ($svgPropertyOrListPropertyType eq "float") { # Special case for JSSVGNumber
+                            push(@implContent, "    JSValue result =  " . NativeToJSValue($attribute->signature, 0, $implClassName, "imp", "castedThis") . ";\n");
                         } else {
-                            push(@implContent, "    JSValue result =  " . NativeToJSValue($attribute->signature, 0, $implClassName, "", "imp.$implGetterFunctionName()", "castedThis") . ";\n");
+                            push(@implContent, "    JSValue result =  " . NativeToJSValue($attribute->signature, 0, $implClassName, "imp.$implGetterFunctionName()", "castedThis") . ";\n");
                         }
                     } else {
                         my $getterExpression = "imp->" . $codeGenerator->GetterExpressionPrefix(\%implIncludes, $interfaceName, $attribute) . ")";
-                        my $jsType = NativeToJSValue($attribute->signature, 0, $implClassName, $implClassNameForValueConversion, $getterExpression, "castedThis");
+                        my $jsType = NativeToJSValue($attribute->signature, 0, $implClassName, $getterExpression, "castedThis");
                         push(@implContent, "    $implClassName* imp = static_cast<$implClassName*>(castedThis->impl());\n");
                         if ($codeGenerator->IsSVGAnimatedType($type)) {
                             push(@implContent, "    RefPtr<$type> obj = $jsType;\n");
-
-                            if ($codeGenerator->IsSVGNewStyleAnimatedType($type)) {
-                                push(@implContent, "    JSValue result =  toJS(exec, castedThis->globalObject(), obj.get());\n");
-                            } else {
-                                push(@implContent, "    JSValue result =  toJS(exec, castedThis->globalObject(), obj.get(), imp);\n");
-                            }
+                            push(@implContent, "    JSValue result =  toJS(exec, castedThis->globalObject(), obj.get());\n");
                         } else {
                             push(@implContent, "    JSValue result = $jsType;\n");
@@ -1648 +1617 @@
                 } else {
                     push(@implContent, "    ExceptionCode ec = 0;\n");                    
-                    if ($svgPropertyOrPodType) {
-                        push(@implContent, "    $svgPropertyOrPodType imp(*castedThis->impl());\n");
-                        push(@implContent, "    JSC::JSValue result = " . NativeToJSValue($attribute->signature, 0, $implClassName, "", "imp.$implGetterFunctionName(ec)", "castedThis") . ";\n");
+                    if ($svgPropertyOrListPropertyType) {
+                        push(@implContent, "    $svgPropertyOrListPropertyType imp(*castedThis->impl());\n");
+                        push(@implContent, "    JSC::JSValue result = " . NativeToJSValue($attribute->signature, 0, $implClassName, "imp.$implGetterFunctionName(ec)", "castedThis") . ";\n");
                     } else {
                         push(@implContent, "    $implClassName* imp = static_cast<$implClassName*>(castedThis->impl());\n");
-                        push(@implContent, "    JSC::JSValue result = " . NativeToJSValue($attribute->signature, 0, $implClassName, $implClassNameForValueConversion, "imp->$implGetterFunctionName(ec)", "castedThis") . ";\n");
+                        push(@implContent, "    JSC::JSValue result = " . NativeToJSValue($attribute->signature, 0, $implClassName, "imp->$implGetterFunctionName(ec)", "castedThis") . ";\n");
                     }
 
@@ -1813 +1782 @@
 
                             my $nativeValue = JSValueToNative($attribute->signature, "value");
-                            if ($svgPropertyOrPodType) {
-                                push(@implContent, "    $svgPropertyOrPodType podImp(*imp);\n") if $podType;
-                                push(@implContent, "    $svgPropertyOrPodType& podImp = imp->propertyReference();\n") if !$podType;
-                                if ($svgPropertyOrPodType eq "float") { # Special case for JSSVGNumber
+                            if ($svgPropertyOrListPropertyType) {
+                                push(@implContent, "    $svgPropertyOrListPropertyType& podImp = imp->propertyReference();\n");
+                                if ($svgPropertyOrListPropertyType eq "float") { # Special case for JSSVGNumber
                                     push(@implContent, "    podImp = $nativeValue;\n");
                                 } else {
@@ -1824 +1792 @@
                                     push(@implContent, "    setDOMException(exec, ec);\n") if @{$attribute->setterExceptions};
                                 }
-                                push(@implContent, "    imp->commitChange(podImp, castedThis);\n") if $podType;
                                 if ($svgPropertyType) {
                                     if (@{$attribute->setterExceptions}) {
@@ -1916 +1883 @@
             }
 
-            # Special case for JSSVGLengthList / JSSVGTransformList / JSSVGPointList / JSSVGNumberList
-            # Instead of having JSSVG*Custom.cpp implementations for the SVGList interface for all of these
-            # classes, we directly forward the calls to JSSVGPODListCustom, which centralizes the otherwise
-            # duplicated code for the JSSVG*List classes mentioned above.
-            my $svgPODListType;
-            if ($implClassName =~ /SVG.*List/ and !$svgListPropertyType) {
-                $svgPODListType = $implClassName;
-                $svgPODListType =~ s/List$//;
-                $svgPODListType = "" unless $codeGenerator->IsPodType($svgPODListType);
-                
-                # Ignore additional (non-SVGList) SVGTransformList methods, that are not handled through JSSVGPODListCustom
-                $svgPODListType = "" if $functionImplementationName =~ /createSVGTransformFromMatrix/;
-                $svgPODListType = "" if $functionImplementationName =~ /consolidate/;
-            }
-
             if ($function->signature->extendedAttributes->{"Custom"} || $function->signature->extendedAttributes->{"JSCCustom"}) {
                 push(@implContent, "    return JSValue::encode(castedThis->" . $functionImplementationName . "(exec));\n");
-            } elsif ($svgPODListType) {
-                $implIncludes{"JS${svgPODListType}.h"} = 1;
-                $implIncludes{"JSSVGPODListCustom.h"} = 1;
-                push(@implContent, "    return JSValue::encode(JSSVGPODListCustom::$functionImplementationName<$className, " . GetNativeType($svgPODListType)
-                                 . ">(castedThis, exec, to" . $svgPODListType . "));\n");
             } else {
                 push(@implContent, "    $implType* imp = static_cast<$implType*>(castedThis->impl());\n");
-                push(@implContent, "    $svgPropertyOrPodType podImp(*imp);\n") if $podType;
-                push(@implContent, "    $svgPropertyOrPodType& podImp = imp->propertyReference();\n") if !$podType and $svgPropertyType;
+                push(@implContent, "    $svgPropertyOrListPropertyType& podImp = imp->propertyReference();\n") if $svgPropertyType;
 
                 my $numParameters = @{$function->parameters};
@@ -1980 +1926 @@
                     my $argsIndex = 0;
                     my $paramIndex = 0;
-                    my $functionString = (($svgPropertyOrPodType and !$svgListPropertyType) ? "podImp." : "imp->") . $functionImplementationName . "(";
+                    my $functionString = (($svgPropertyOrListPropertyType and !$svgListPropertyType) ? "podImp." : "imp->") . $functionImplementationName . "(";
                     my $hasOptionalArguments = 0;
 
@@ -2025 +1971 @@
                             }
                             push(@implContent, "    if (argsCount <= $argsIndex) {\n");
-                            GenerateImplementationFunctionCall($function, $functionString, $paramIndex, "    " x 2, $podType, $svgPropertyType, $implClassName);
+                            GenerateImplementationFunctionCall($function, $functionString, $paramIndex, "    " x 2, $svgPropertyType, $implClassName);
                             push(@implContent, "    }\n\n");
                         }
@@ -2123 +2069 @@
 
                     push(@implContent, "\n");
-                    GenerateImplementationFunctionCall($function, $functionString, $paramIndex, "    ", $podType, $svgPropertyType, $implClassName);
+                    GenerateImplementationFunctionCall($function, $functionString, $paramIndex, "    ", $svgPropertyType, $implClassName);
                 }
             }
@@ -2193 +2139 @@
         if ($svgPropertyType) {
             push(@implContent, "    return getDOMObjectWrapper<$className, $implType>(exec, globalObject, object);\n");
-        } elsif ($podType) {
-            push(@implContent, "    return getDOMObjectWrapper<$className, $implType>(exec, globalObject, object, context);\n");
         } elsif (IsSVGTypeNeedingContextParameter($implClassName)) {
             push(@implContent, "    return getDOMObjectWrapper<$className>(exec, globalObject, object, context);\n");
@@ -2204 +2148 @@
 
     if ((!$hasParent or $dataNode->extendedAttributes->{"GenerateNativeConverter"}) and !$dataNode->extendedAttributes->{"CustomNativeConverter"}) {
-        if ($podType) {
-            push(@implContent, "$podType to${interfaceName}(JSC::JSValue value)\n");
-            push(@implContent, "{\n");
-            push(@implContent, "    return value.inherits(&${className}::s_info) ? ($podType) *static_cast<$className*>(asObject(value))->impl() : $podType()");
-        } else {
-            push(@implContent, "$implType* to${interfaceName}(JSC::JSValue value)\n");
-            push(@implContent, "{\n");
-            push(@implContent, "    return value.inherits(&${className}::s_info) ? static_cast<$className*>(asObject(value))->impl() : 0");
-        }
-
+        push(@implContent, "$implType* to${interfaceName}(JSC::JSValue value)\n");
+        push(@implContent, "{\n");
+        push(@implContent, "    return value.inherits(&${className}::s_info) ? static_cast<$className*>(asObject(value))->impl() : 0");
         push(@implContent, ";\n}\n");
     }
@@ -2388 +2325 @@
     my $paramIndex = shift;
     my $indent = shift;
-    my $podType = shift;
     my $svgPropertyType = shift;
     my $implClassName = shift;
@@ -2407 +2343 @@
         push(@implContent, $indent . "$functionString;\n");
         push(@implContent, $indent . "setDOMException(exec, ec);\n") if @{$function->raisesExceptions};
-        push(@implContent, $indent . "imp->commitChange(podImp, castedThis);\n") if $podType;
 
         if ($svgPropertyType) {
@@ -2420 +2355 @@
         push(@implContent, $indent . "return JSValue::encode(jsUndefined());\n");
     } else {
-        push(@implContent, "\n" . $indent . "JSC::JSValue result = " . NativeToJSValue($function->signature, 1, $implClassName, "", $functionString, "castedThis") . ";\n");
+        push(@implContent, "\n" . $indent . "JSC::JSValue result = " . NativeToJSValue($function->signature, 1, $implClassName, $functionString, "castedThis") . ";\n");
         push(@implContent, $indent . "setDOMException(exec, ec);\n") if @{$function->raisesExceptions};
 
@@ -2427 +2362 @@
             push(@implContent, $indent . "if (exec->hadException())\n");
             push(@implContent, $indent . "    return JSValue::encode(jsUndefined());\n");
-        }
-
-        if ($podType and not $function->signature->extendedAttributes->{"Immutable"}) {
-            # Immutable methods do not commit changes back to the instance, thus producing
-            # a new instance rather than mutating existing one.
-            push(@implContent, $indent . "imp->commitChange(podImp, castedThis);\n");
         }
 
@@ -2459 +2388 @@
     "SerializedScriptValue" => "RefPtr<SerializedScriptValue>",
     "IDBKey" => "RefPtr<IDBKey>",
-    "SVGMatrix" => "AffineTransform",
     "SVGPaintType" => "SVGPaint::SVGPaintType",
-    "SVGTransform" => "SVGTransform",
     "boolean" => "bool",
     "double" => "double",
@@ -2509 +2436 @@
         $headerIncludes{"$svgWrappedNativeType.h"} = 1;
         $headerIncludes{"SVGAnimatedListPropertyTearOff.h"} = 1;
+    } elsif ($svgNativeType =~ /SVGTransformListPropertyTearOff/) {
+        $svgListPropertyType = $svgWrappedNativeType;
+        $headerIncludes{"$svgWrappedNativeType.h"} = 1;
+        $headerIncludes{"SVGAnimatedListPropertyTearOff.h"} = 1;
+        $headerIncludes{"SVGTransformListPropertyTearOff.h"} = 1;
     }
 
@@ -2573 +2505 @@
     my $inFunctionCall = shift;
     my $implClassName = shift;
-    my $implClassNameForValueConversion = shift;
     my $value = shift;
     my $thisValue = shift;
@@ -2607 +2538 @@
     
     my $globalObject = "$thisValue->globalObject()";
-    if ($codeGenerator->IsPodType($type)) {
-        $implIncludes{"JS$type.h"} = 1;
-
-        my $nativeType = GetNativeType($type);
-
-        my $getter = $value;
-        $getter =~ s/imp->//;
-        $getter =~ s/\(\)//;
-
-        my $setter = "set" . $codeGenerator->WK_ucfirst($getter);
-
-        # Function calls will never return 'modifyable' POD types (ie. SVGRect getBBox()) - no need to keep track changes to the returned SVGRect
-        if ($inFunctionCall eq 0
-            and not $codeGenerator->IsSVGAnimatedType($implClassName)
-            and $codeGenerator->IsPodTypeWithWriteableProperties($type)
-            and not defined $signature->extendedAttributes->{"Immutable"}) {
-            if ($codeGenerator->IsPodType($implClassName)) {
-                return "toJS(exec, $globalObject, JSSVGStaticPODTypeWrapperWithPODTypeParent<$nativeType, $implClassName>::create($value, $thisValue->impl()).get(), JSSVGContextCache::svgContextForDOMObject(castedThis))";
-            } else {
-                return "toJS(exec, $globalObject, JSSVGStaticPODTypeWrapperWithParent<$nativeType, $implClassName>::create(imp, &${implClassName}::$getter, &${implClassName}::$setter).get(), imp)";
-            }
-        }
-
-        if ($implClassNameForValueConversion eq "") {
-            return "toJS(exec, $globalObject, JSSVGStaticPODTypeWrapper<$nativeType>::create($value).get(), 0 /* no context on purpose */)";
-        } else {
-            return "toJS(exec, $globalObject, JSSVGDynamicPODTypeWrapperCache<$nativeType, $implClassNameForValueConversion>::lookupOrCreateWrapper(imp, &${implClassNameForValueConversion}::$getter, &${implClassNameForValueConversion}::$setter).get(), JSSVGContextCache::svgContextForDOMObject(castedThis));"
-        }
-    } 
 
     if ($type eq "CSSStyleDeclaration") {
@@ -2676 +2578 @@
     }
 
-    if ($codeGenerator->IsSVGNewStyleAnimatedType($implClassName)) {
+    if ($codeGenerator->IsSVGAnimatedType($implClassName)) {
         # Convert from abstract SVGProperty to real type, so the right toJS() method can be invoked.
         $value = "static_cast<" . GetNativeType($type) . ">($value)";
@@ -2682 +2584 @@
         my $tearOffType = $codeGenerator->GetSVGTypeNeedingTearOff($type);
         if ($codeGenerator->IsSVGTypeWithWritablePropertiesNeedingTearOff($type) and $inFunctionCall eq 0 and not defined $signature->extendedAttributes->{"Immutable"}) {
-            $tearOffType =~ s/SVGPropertyTearOff</SVGStaticPropertyTearOff<$implClassName, /;
-            $implIncludes{"SVGStaticPropertyTearOff.h"} = 1;
-
             my $getter = $value;
+            $getter =~ s/imp\.//;
             $getter =~ s/imp->//;
             $getter =~ s/\(\)//;
-            my $updater = "update" . $codeGenerator->WK_ucfirst($getter);
-            $value = "${tearOffType}::create(imp, $value, &${implClassName}::$updater)";
+            my $updateMethod = "&${implClassName}::update" . $codeGenerator->WK_ucfirst($getter);
+
+            my $selfIsTearOffType = $codeGenerator->IsSVGTypeNeedingTearOff($implClassName);
+            if ($selfIsTearOffType) {
+                $implIncludes{"SVGStaticPropertyWithParentTearOff.h"} = 1;
+                $tearOffType =~ s/SVGPropertyTearOff</SVGStaticPropertyWithParentTearOff<$implClassName, /;
+
+                if ($value =~ /matrix/ and $implClassName eq "SVGTransform") {
+                    # SVGTransform offers a matrix() method for internal usage that returns an AffineTransform
+                    # and a svgMatrix() method returning a SVGMatrix, used for the bindings.
+                    $value =~ s/matrix/svgMatrix/;
+                }
+
+                $value = "${tearOffType}::create(castedThis->impl(), $value, $updateMethod)";
+            } else {
+                $implIncludes{"SVGStaticPropertyTearOff.h"} = 1;
+                $tearOffType =~ s/SVGPropertyTearOff</SVGStaticPropertyTearOff<$implClassName, /;
+                $value = "${tearOffType}::create(imp, $value, $updateMethod)";
+            }
         } elsif ($tearOffType =~ /SVGStaticListPropertyTearOff/) {
             my $extraImp = "GetOwnerElementForType<$implClassName, IsDerivedFromSVGElement<$implClassName>::value>::ownerElement(imp), ";

trunk/WebCore/bindings/scripts/CodeGeneratorObjC.pm

@@ -493 +493 @@
     if ($codeGenerator->IsStringType($type) || IsNativeObjCType($type)) {
         push(@attributes, "copy");
-    } elsif ($codeGenerator->IsPodType($type) || $codeGenerator->IsSVGAnimatedType($type)) {
+    } elsif ($codeGenerator->IsSVGAnimatedType($type)) {
         push(@attributes, "retain");
     } elsif (!$codeGenerator->IsStringType($type) && !$codeGenerator->IsPrimitiveType($type) && $type ne "DOMTimeStamp" && $type ne "CompareHow" && $type ne "SVGPaintType") {
@@ -588 +588 @@
     }
 
-    if ($codeGenerator->IsSVGNewStyleAnimatedType($type)) {
+    if ($codeGenerator->IsSVGAnimatedType($type)) {
         $implIncludes{"${type}.h"} = 1;
         $implIncludes{"DOM${type}Internal.h"} = 1;
-        return;
-    }
-
-    if ($codeGenerator->IsSVGAnimatedType($type)) {
-        $implIncludes{"DeprecatedSVGAnimatedTemplate.h"} = 1;
-        $implIncludes{"DOM${type}Internal.h"} = 1;
-        return;
-    }
-
-    if ($type eq "SVGMatrix") {
-        $implIncludes{"AffineTransform.h"} = 1;
-        $implIncludes{"DOMSVGMatrixInternal.h"} = 1;
-        $implIncludes{"SVGException.h"} = 1;
         return;
     }
@@ -682 +669 @@
         }
     } elsif ($svgNativeType =~ /SVGListPropertyTearOff/ or $svgNativeType =~ /SVGStaticListPropertyTearOff/) {
+        $svgListPropertyType = "WebCore::$svgWrappedNativeType";
+        $svgListPropertyType =~ s/</\<WebCore::/;
+    } elsif ($svgNativeType =~ /SVGTransformListPropertyTearOff/) {
         $svgListPropertyType = "WebCore::$svgWrappedNativeType";
         $svgListPropertyType =~ s/</\<WebCore::/;
@@ -1000 +990 @@
     unless ($isProtocol) {
         # Generate internal interfaces
-        my $podType = $dataNode->extendedAttributes->{"PODType"};
-        my $podTypeWithNamespace;
         my $implClassName = GetImplClassName($interfaceName);
         my $implClassNameWithNamespace = "WebCore::" . $implClassName;
@@ -1009 +997 @@
         $implType = $svgNativeType if $svgNativeType;
 
-        if ($podType) {
-            $podTypeWithNamespace = ($podType eq "float") ? "$podType" : "WebCore::$podType";
-        }
- 
         # Generate interface definitions. 
         @internalHeaderContent = split("\r", $implementationLicenseTemplate);
@@ -1018 +1002 @@
         push(@internalHeaderContent, "\n#import <WebCore/$className.h>\n\n");
         push(@internalHeaderContent, "#import <WebCore/SVGAnimatedPropertyTearOff.h>\n\n") if $svgPropertyType;
-        push(@internalHeaderContent, "#import <WebCore/SVGAnimatedListPropertyTearOff.h>\n\n") if $svgListPropertyType;
+        if ($svgListPropertyType) {
+            push(@internalHeaderContent, "#import <WebCore/SVGAnimatedListPropertyTearOff.h>\n\n");
+            push(@internalHeaderContent, "#import <WebCore/SVGTransformListPropertyTearOff.h>\n\n") if $svgListPropertyType =~ /SVGTransformList/;
+        }
         push(@internalHeaderContent, $interfaceAvailabilityVersionCheck) if length $interfaceAvailabilityVersion;
 
@@ -1027 +1014 @@
         my $startedNamespace = 0;
 
-        if ($codeGenerator->IsSVGNewStyleAnimatedType($interfaceName)) {
+        if ($codeGenerator->IsSVGAnimatedType($interfaceName)) {
             push(@internalHeaderContent, "#import <WebCore/$implClassName.h>\n\n");
-        } elsif ($codeGenerator->IsSVGAnimatedType($interfaceName)) {
-            push(@internalHeaderContent, "#import <WebCore/DeprecatedSVGAnimatedTemplate.h>\n\n");
         } else {
             push(@internalHeaderContent, "namespace WebCore {\n");
             $startedNamespace = 1;
-            if ($podType and $podType ne "float") {
-                push(@internalHeaderContent, "    class $podType;\n");
-            } elsif ($interfaceName eq "Node") {
+            if ($interfaceName eq "Node") {
                 push(@internalHeaderContent, "    class EventTarget;\n    class Node;\n");
             } else {
@@ -1044 +1027 @@
         }
 
-        if ($podType) {
-            push(@internalHeaderContent, "$podTypeWithNamespace core($className *);\n");
-            push(@internalHeaderContent, "$className *kit($podTypeWithNamespace);\n");
-        } else {
-            push(@internalHeaderContent, "$implType* core($className *);\n");
-            push(@internalHeaderContent, "$className *kit($implType*);\n");
-        }
+        push(@internalHeaderContent, "$implType* core($className *);\n");
+        push(@internalHeaderContent, "$className *kit($implType*);\n");
 
         if ($dataNode->extendedAttributes->{Polymorphic}) {
@@ -1085 +1063 @@
     my $numAttributes = @{$dataNode->attributes};
     my $numFunctions = @{$dataNode->functions};
-
-    my $podType = $dataNode->extendedAttributes->{"PODType"};
-    my $podTypeWithNamespace;
     my $implType = $implClassNameWithNamespace;
 
     my ($svgPropertyType, $svgListPropertyType, $svgNativeType) = GetSVGPropertyTypes($implClassName);
     $implType = $svgNativeType if $svgNativeType;
-
-    if ($podType) {
-        $podTypeWithNamespace = ($podType eq "float") ? "$podType" : "WebCore::$podType";
-    }
 
     # - Add default header template.
@@ -1125 +1096 @@
     $implIncludes{"DOMSVGPathSegInternal.h"} = 1 if $interfaceName =~ /^SVGPathSeg.+/;
 
-    if ($codeGenerator->IsSVGAnimatedType($interfaceName) and !$codeGenerator->IsSVGNewStyleAnimatedType($interfaceName)) {
-        $implIncludes{"DeprecatedSVGAnimatedTemplate.h"} = 1;
-    } elsif ($interfaceName =~ /(\w+)(Abs|Rel)$/) {
+    if ($interfaceName =~ /(\w+)(Abs|Rel)$/) {
         $implIncludes{"$1.h"} = 1;
     } else {
-        if (!$podType) {
-            if (!$codeGenerator->AvoidInclusionOfType($implClassName)) {
-                $implIncludes{"$implClassName.h"} = 1 ;
-            } elsif ($codeGenerator->IsSVGTypeNeedingTearOff($implClassName)) {
-                my $includeType = $codeGenerator->GetSVGWrappedTypeNeedingTearOff($implClassName);
-                $implIncludes{"${includeType}.h"} = 1;
-            }
-        } else {
-            $implIncludes{"$podType.h"} = 1 unless $podType eq "float";
+        if (!$codeGenerator->AvoidInclusionOfType($implClassName)) {
+            $implIncludes{"$implClassName.h"} = 1 ;
+        } elsif ($codeGenerator->IsSVGTypeNeedingTearOff($implClassName)) {
+            my $includeType = $codeGenerator->GetSVGWrappedTypeNeedingTearOff($implClassName);
+            $implIncludes{"${includeType}.h"} = 1;
         }
     } 
@@ -1147 +1112 @@
 
     # add implementation accessor
-    if ($podType) {
-        push(@implContent, "#define IMPL reinterpret_cast<$podTypeWithNamespace*>(_internal)\n\n");
-    } elsif ($parentImplClassName eq "Object") {
+    if ($parentImplClassName eq "Object") {
         push(@implContent, "#define IMPL reinterpret_cast<$implType*>(_internal)\n\n");
     } else {
@@ -1172 +1135 @@
             push(@implContent, "        IMPL->deref();\n");
             push(@implContent, "    };\n");
-        } elsif ($podType) {
-            push(@implContent, "    delete IMPL;\n");
         } else {
             push(@implContent, "    if (_internal)\n");
@@ -1188 +1149 @@
             push(@implContent, "        IMPL->deref();\n");
             push(@implContent, "    };\n");
-        } elsif ($podType) {
-            push(@implContent, "    delete IMPL;\n");
         } else {
             push(@implContent, "    if (_internal)\n");
@@ -1286 +1245 @@
                 $getterContentHead = "WTF::String::number(" . $getterContentHead;
                 $getterContentTail .= ")";
-            } elsif ($codeGenerator->IsPodType($idlType) or $idlType eq "Date") {
+            } elsif ($idlType eq "Date") {
                 $getterContentHead = "kit($getterContentHead";
                 $getterContentTail .= ")";
@@ -1297 +1256 @@
                     $getterContentHead = "IMPL->propertyReference().$getterContentHead";
                 }
-            } elsif ($codeGenerator->IsSVGNewStyleAnimatedType($implClassName) and $codeGenerator->IsSVGTypeNeedingTearOff($idlType)) {
+
+                if ($codeGenerator->IsSVGTypeWithWritablePropertiesNeedingTearOff($idlType) and not defined $attribute->signature->extendedAttributes->{"Immutable"}) {
+                    my $getter = $getterContentHead;
+                    $getter =~ s/\(\)//;
+                    
+                    my $tearOffType = GetSVGTypeWithNamespace($idlType);
+                    my $selfIsTearOffType = $codeGenerator->IsSVGTypeNeedingTearOff($implClassName);
+                    if ($selfIsTearOffType) {
+                        $implIncludes{"SVGStaticPropertyWithParentTearOff.h"} = 1;
+                        $tearOffType =~ s/SVGPropertyTearOff</SVGStaticPropertyWithParentTearOff<$implClassNameWithNamespace, /;
+
+                        my $getter = $getterExpressionPrefix;
+                        $getter =~ s/IMPL->//;
+                        $getter =~ s/\(//;
+                        my $updateMethod = "&${implClassNameWithNamespace}::update" . $codeGenerator->WK_ucfirst($getter);
+
+                        if ($getterContentHead =~ /matrix/ and $implClassName eq "SVGTransform") {
+                            # SVGTransform offers a matrix() method for internal usage that returns an AffineTransform
+                            # and a svgMatrix() method returning a SVGMatrix, used for the bindings.
+                            $getterContentHead =~ s/matrix/svgMatrix/;
+                        }
+
+                        $getterContentHead = "${tearOffType}::create(IMPL, $getterContentHead$getterContentTail, $updateMethod)";
+
+                        $getterContentHead = "kit(WTF::getPtr($getterContentHead";
+                        $getterContentTail = "))";
+                    }
+                }
+            } elsif ($codeGenerator->IsSVGAnimatedType($implClassName) and $codeGenerator->IsSVGTypeNeedingTearOff($idlType)) {
                 my $idlTypeWithNamespace = GetSVGTypeWithNamespace($idlType);
                 $getterContentHead = "kit(static_cast<$idlTypeWithNamespace*>($getterContentHead)";
@@ -1321 +1308 @@
                         $getter =~ s/IMPL->//;
                         $getter =~ s/\(//;
-                        my $updater = "update" . $codeGenerator->WK_ucfirst($getter);
-                        $getterContentHead = "kit(WTF::getPtr(${idlTypeWithNamespace}::create(IMPL, $getterContentHead$getterContentTail, &${implClassNameWithNamespace}::$updater";
+                        my $updateMethod = "&${implClassNameWithNamespace}::update" . $codeGenerator->WK_ucfirst($getter);
+                        $getterContentHead = "kit(WTF::getPtr(${idlTypeWithNamespace}::create(IMPL, $getterContentHead$getterContentTail, $updateMethod";
                         $getterContentTail .= "))";
                     } elsif ($idlTypeWithNamespace =~ /SVGStaticListPropertyTearOff/) {
@@ -1430 +1417 @@
                     $getterContentHead = "$getterExpressionPrefix";
                     push(@implContent, "    IMPL->$coreSetterName($arg);\n");
-                } elsif ($podType) {
-                    push(@implContent, "    IMPL->$coreSetterName($arg);\n");
                 } else {
                     my $setterExpressionPrefix = $codeGenerator->SetterExpressionPrefix(\%implIncludes, $interfaceName, $attribute);
@@ -1548 +1533 @@
 
             # FIXME! We need [Custom] support for ObjC, to move these hacks into DOMSVGLength/MatrixCustom.mm
-            my $svgMatrixRotateFromVector = ($podType and $podType eq "AffineTransform" and $functionName eq "rotateFromVector");
-            my $svgMatrixInverse = ($podType and $podType eq "AffineTransform" and $functionName eq "inverse");
             my $svgLengthConvertToSpecifiedUnits = ($svgPropertyType and $svgPropertyType eq "WebCore::SVGLength" and $functionName eq "convertToSpecifiedUnits");
 
             push(@parameterNames, "IMPL->contextElement()") if $svgLengthConvertToSpecifiedUnits; 
-            push(@parameterNames, "ec") if $raisesExceptions and !($svgMatrixRotateFromVector || $svgMatrixInverse);
+            push(@parameterNames, "ec") if $raisesExceptions;
 
             # Handle arguments that are 'SVGProperty' based (SVGAngle/SVGLength). We need to convert from SVGPropertyTearOff<Type>* to Type,
@@ -1562 +1545 @@
 
                 my $paramName = $param->name;
+
+                # make a new parameter name if the original conflicts with a property name
+                $paramName = "in" . ucfirst($paramName) if $attributeNames{$paramName};
+
                 my $idlType = $codeGenerator->StripModule($param->type);
                 next if not $codeGenerator->IsSVGTypeNeedingTearOff($idlType) or $implClassName =~ /List$/;
@@ -1592 +1579 @@
             }
 
-            if ($svgMatrixRotateFromVector) {
-                # Special case with rotateFromVector & SVGMatrix        
-                push(@functionContent, "    $exceptionInit\n");
-                push(@functionContent, "    if (x == 0.0 || y == 0.0)\n");
-                push(@functionContent, "        ec = WebCore::SVGException::SVG_INVALID_VALUE_ERR;\n");
-                push(@functionContent, "    $exceptionRaiseOnError\n");
-                push(@functionContent, "    return kit($content);\n");
-            } elsif ($svgMatrixInverse) {
-                # Special case with inverse & SVGMatrix
-                push(@functionContent, "    $exceptionInit\n");
-                push(@functionContent, "    if (!$caller->isInvertible())\n");
-                push(@functionContent, "        ec = WebCore::SVGException::SVG_MATRIX_NOT_INVERTABLE;\n");
-                push(@functionContent, "    $exceptionRaiseOnError\n");
-                push(@functionContent, "    return kit($content);\n");
-            } elsif ($returnType eq "void") {
+            if ($returnType eq "void") {
                 # Special case 'void' return type.
                 if ($raisesExceptions) {
@@ -1618 +1591 @@
                 } else {
                     push(@functionContent, "    $content;\n");
-                    push(@functionContent, "    IMPL->commitChange()\n") if $svgPropertyType;
+                    push(@functionContent, "    IMPL->commitChange();\n") if $svgPropertyType;
                 }
             } elsif (defined $needsCustom{"NodeToReturn"}) {
@@ -1642 +1615 @@
                         my $idlTypeWithNamespace = GetSVGTypeWithNamespace($function->signature->type);
                         $content = "kit(WTF::getPtr(${idlTypeWithNamespace}::create($content)))";
-                    } elsif ($codeGenerator->IsPodType($function->signature->type)) {
-                        $content = "kit($content)";
                     } else {
                         $content = "kit(WTF::getPtr($content))";
@@ -1694 +1665 @@
 
     # Generate internal interfaces
-    if ($podType) {
-        push(@implContent, "\n$podTypeWithNamespace core($className *wrapper)\n");
-        push(@implContent, "{\n");
-        push(@implContent, "    return wrapper ? *reinterpret_cast<$podTypeWithNamespace*>(wrapper->_internal) : $podTypeWithNamespace();\n");
-        push(@implContent, "}\n\n");
-    } else {
-        push(@implContent, "\n$implType* core($className *wrapper)\n");
-        push(@implContent, "{\n");
-        push(@implContent, "    return wrapper ? reinterpret_cast<$implType*>(wrapper->_internal) : 0;\n");
-        push(@implContent, "}\n\n");
-    }
-
-    if ($podType) {
-        # FIXME: Implement caching.
-        push(@implContent, "$className *kit($podTypeWithNamespace value)\n");
-        push(@implContent, "{\n");
-        push(@implContent, "    $assertMainThread;\n");
-        push(@implContent, "    $className *wrapper = [[$className alloc] _init];\n");
-        push(@implContent, "    wrapper->_internal = reinterpret_cast<DOMObjectInternal*>(new $podTypeWithNamespace(value));\n");
-        push(@implContent, "    return [wrapper autorelease];\n");
-        push(@implContent, "}\n");
-    } elsif ($parentImplClassName eq "Object") {        
+    push(@implContent, "\n$implType* core($className *wrapper)\n");
+    push(@implContent, "{\n");
+    push(@implContent, "    return wrapper ? reinterpret_cast<$implType*>(wrapper->_internal) : 0;\n");
+    push(@implContent, "}\n\n");
+
+    if ($parentImplClassName eq "Object") {        
         push(@implContent, "$className *kit($implType* value)\n");
         push(@implContent, "{\n");

trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -88 +88 @@
 }
 
-# Workaround for V8 bindings difference where RGBColor is not a POD type.
-# FIXME: This method will go away once all SVG animated properties are converted to the new scheme.
-sub IsPodType
-{
-    my $type = shift;
-    return $codeGenerator->IsPodType($type);
-}
-
 # Params: 'domClass' struct
 sub GenerateInterface
@@ -168 +160 @@
         $implIncludes{"wtf/text/AtomicString.h"} = 1;
     }
-}
-
-sub AddIncludesForSVGAnimatedType
-{
-    my $type = shift;
-    return if $codeGenerator->IsSVGNewStyleAnimatedType($type);
-
-    $type =~ s/SVGAnimated//;
-
-    if ($type eq "Point" or $type eq "Rect") {
-        $implIncludes{"Float$type.h"} = 1;
-    } elsif ($type eq "String") {
-        $implIncludes{"PlatformString.h"} = 1;
-    }
-
-    $implIncludes{"DeprecatedSVGAnimatedTemplate.h"} = 1;
 }
 
@@ -227 +203 @@
         $svgListPropertyType = $svgWrappedNativeType;
         $implIncludes{"SVGAnimatedListPropertyTearOff.h"} = 1;
-    }
-
-    $svgPropertyType = "SVGPoint" if $svgPropertyType eq "FloatPoint";
+    } elsif ($svgNativeType =~ /SVGTransformListPropertyTearOff/) {
+        $svgListPropertyType = $svgWrappedNativeType;
+        $implIncludes{"SVGAnimatedListPropertyTearOff.h"} = 1;
+        $implIncludes{"SVGTransformListPropertyTearOff.h"} = 1;
+    }
+
+    if ($svgPropertyType) {
+        $svgPropertyType = "SVGPoint" if $svgPropertyType eq "FloatPoint";
+    }
+
     return ($svgPropertyType, $svgListPropertyType, $svgNativeType);
 }
@@ -250 +233 @@
     # - Add default header template
     push(@headerContent, GenerateHeaderContentHeader($dataNode));
-    my $podType = $dataNode->extendedAttributes->{"PODType"};
 
     my %headerInclues = ();
-    $headerIncludes{"$podType.h"} = 1 if $podType and ($podType ne "double" and $podType ne "float" and $podType ne "RGBA32");
     $headerIncludes{"wtf/text/StringHash.h"} = 1;
     $headerIncludes{"WrapperTypeInfo.h"} = 1;
@@ -271 +252 @@
     
     push(@headerContent, "\nnamespace WebCore {\n");
-    push(@headerContent, "\ntemplate<typename PODType> class V8SVGPODTypeWrapper;\n") if $podType;
     push(@headerContent, "\ntemplate<typename PropertyType> class SVGPropertyTearOff;\n") if $svgPropertyType;
     if ($svgListPropertyType) {
@@ -479 +459 @@
     }
     return "" if ($codeGenerator->AvoidInclusionOfType($className));
-    return "DeprecatedSVGAnimatedTemplate.h" if $codeGenerator->IsSVGAnimatedType($className) and !$codeGenerator->IsSVGNewStyleAnimatedType($className); 
     return "${className}.h";
 }
@@ -705 +684 @@
 
     my $attrType = GetTypeFromSignature($attribute->signature);
-    my $attrIsPodType = IsPodType($attrType);
 
     my $nativeType = GetNativeTypeFromSignature($attribute->signature, -1);
-    my $isPodType = IsPodType($implClassName);
     my $skipContext = 0;
-
-    if ($isPodType) {
-        $implClassName = GetNativeType($implClassName);
-        $implIncludes{"V8SVGPODTypeWrapper.h"} = 1;
-    }
 
     # Special case: SVGZoomEvent's attributes are all read-only
     if ($implClassName eq "SVGZoomEvent") {
-        $attrIsPodType = 0;
         $skipContext = 1;
-    }
-
-    # Special case for SVGColor
-    if (($implClassName eq "SVGColor") and ($attrName eq "rgbColor")) {
-        $attrIsPodType = 0;
     }
 
@@ -740 +706 @@
 END
 
-    if ($isPodType) {
-        push(@implContentDecls, <<END);
-    V8SVGPODTypeWrapper<$implClassName>* impWrapper = V8SVGPODTypeWrapper<$implClassName>::toNative(info.Holder());
-    $implClassName impInstance = *impWrapper;
-END
-        if ($getterStringUsesImp) {
-            push(@implContentDecls, <<END);
-    $implClassName* imp = &impInstance;
-END
-        }
-    } elsif ($svgNativeType) {
+    if ($svgNativeType) {
         my $svgWrappedNativeType = $codeGenerator->GetSVGWrappedTypeNeedingTearOff($implClassName);
-        if ($svgWrappedNativeType =~ /List$/) {
+        if ($svgWrappedNativeType =~ /List/) {
             push(@implContentDecls, <<END);
     $svgNativeType* imp = V8${implClassName}::toNative(info.Holder());
@@ -809 +765 @@
     }
 
-    my $useExceptions = 1 if @{$attribute->getterExceptions} and !($isPodType);
+    my $useExceptions = 1 if @{$attribute->getterExceptions};
     if ($useExceptions) {
         $implIncludes{"ExceptionCode.h"} = 1;
@@ -833 +789 @@
     my $wrapper;
 
-    if ($attrIsPodType) {
-        $implIncludes{"V8SVGPODTypeWrapper.h"} = 1;
-
-        my $getter = $getterString;
-        $getter =~ s/imp->//;
-        $getter =~ s/\(\)//;
-        my $setter = "set" . $codeGenerator->WK_ucfirst($getter);
-
-        my $implClassIsAnimatedType = $codeGenerator->IsSVGAnimatedType($implClassName);
-        if (not $implClassIsAnimatedType and $codeGenerator->IsPodTypeWithWriteableProperties($attrType) and not defined $attribute->signature->extendedAttributes->{"Immutable"}) {
-            if (IsPodType($implClassName)) {
-                my $wrapper = "V8SVGStaticPODTypeWrapperWithPODTypeParent<$nativeType, $implClassName>::create($getterString, impWrapper)";
-                push(@implContentDecls, "    RefPtr<V8SVGStaticPODTypeWrapperWithPODTypeParent<$nativeType, $implClassName> > wrapper = $wrapper;\n");
-            } else {
-                my $wrapper = "V8SVGStaticPODTypeWrapperWithParent<$nativeType, $implClassName>::create(imp, &${implClassName}::$getter, &${implClassName}::$setter)";
-                push(@implContentDecls, "    RefPtr<V8SVGStaticPODTypeWrapperWithParent<$nativeType, $implClassName> > wrapper = $wrapper;\n");
-            }
+        if ($attribute->signature->type eq "EventListener" && $dataNode->name eq "DOMWindow") {
+        push(@implContentDecls, "    if (!imp->document())\n");
+        push(@implContentDecls, "        return v8::Handle<v8::Value>();\n");
+    }
+
+    if ($useExceptions) {
+        if ($nativeType =~ /^V8Parameter/) {
+          push(@implContentDecls, "    " . ConvertToV8Parameter($attribute->signature, $nativeType, "v", $getterString) . ";\n");
         } else {
-            if ($implClassIsAnimatedType) {
-                # We can't hash member function pointers, so instead generate
-                # some hashing material based on the names of the methods.
-                my $hashhex = substr(Digest::MD5::md5_hex("${implClassName}::$getter ${implClassName}::$setter)"), 0, 8);
-                my $wrapper = "V8SVGDynamicPODTypeWrapperCache<$nativeType, $implClassName>::lookupOrCreateWrapper(imp, &${implClassName}::$getter, &${implClassName}::$setter, 0x$hashhex)";
-                push(@implContentDecls, "    RefPtr<V8SVGPODTypeWrapper<" . $nativeType . "> > wrapper = $wrapper;\n");
-            } else {
-                my $wrapper = GenerateSVGStaticPodTypeWrapper($returnType, $getterString);
-                push(@implContentDecls, "    RefPtr<V8SVGStaticPODTypeWrapper<" . $nativeType . "> > wrapper = $wrapper;\n");
-            }
-        }
-
+          push(@implContentDecls, "    $nativeType v = $getterString;\n");
+        }
+        push(@implContentDecls, GenerateSetDOMException("    "));
+        $result = "v";
+        $result .= ".release()" if (IsRefPtrType($returnType));
     } else {
-        if ($attribute->signature->type eq "EventListener" && $dataNode->name eq "DOMWindow") {
-            push(@implContentDecls, "    if (!imp->document())\n");
-            push(@implContentDecls, "        return v8::Handle<v8::Value>();\n");
-        }
-
-        if ($useExceptions) {
-            if ($nativeType =~ /^V8Parameter/) {
-              push(@implContentDecls, "    " . ConvertToV8Parameter($attribute->signature, $nativeType, "v", $getterString) . ";\n");
-            } else {
-              push(@implContentDecls, "    $nativeType v = $getterString;\n");
-            }
-            push(@implContentDecls, GenerateSetDOMException("    "));
-            $result = "v";
-            $result .= ".release()" if (IsRefPtrType($returnType));
+        # Can inline the function call into the return statement to avoid overhead of using a Ref<> temporary
+        $result = $getterString;
+    }
+ 
+    # Special case for readonly or Replaceable attributes (with a few exceptions). This attempts to ensure that JS wrappers don't get
+    # garbage-collected prematurely when their lifetime is strongly tied to their owner. We accomplish this by inserting a reference to
+    # the newly created wrapper into an internal field of the holder object.
+    if (!IsNodeSubType($dataNode) && $attrName ne "self" && (IsWrapperType($returnType) && ($attribute->type =~ /^readonly/ || $attribute->signature->extendedAttributes->{"Replaceable"})
+        && $returnType ne "EventTarget" && $returnType ne "SerializedScriptValue" && $returnType ne "DOMWindow" 
+        && $returnType !~ /SVG/ && $returnType !~ /HTML/ && !IsDOMNodeType($returnType))) {
+        AddIncludesForType($returnType);
+        my $domMapFunction = GetDomMapFunction(0, $returnType);
+        # Check for a wrapper in the wrapper cache. If there is one, we know that a hidden reference has already
+        # been created. If we don't find a wrapper, we create both a wrapper and a hidden reference.
+        push(@implContentDecls, "    RefPtr<$returnType> result = ${getterString};\n");
+        push(@implContentDecls, "    v8::Handle<v8::Value> wrapper = result.get() ? ${domMapFunction}.get(result.get()) : v8::Handle<v8::Value>();\n");
+        push(@implContentDecls, "    if (wrapper.IsEmpty()) {\n");
+        push(@implContentDecls, "        wrapper = toV8(result.get());\n");
+        push(@implContentDecls, "        if (!wrapper.IsEmpty())\n");
+        if ($dataNode->name eq "DOMWindow") {
+            push(@implContentDecls, "            V8DOMWrapper::setHiddenWindowReference(imp->frame(), wrapper);\n");
         } else {
-            # Can inline the function call into the return statement to avoid overhead of using a Ref<> temporary
-            $result = $getterString;
-        }
- 
-        # Special case for readonly or Replaceable attributes (with a few exceptions). This attempts to ensure that JS wrappers don't get
-        # garbage-collected prematurely when their lifetime is strongly tied to their owner. We accomplish this by inserting a reference to
-        # the newly created wrapper into an internal field of the holder object.
-        if (!IsNodeSubType($dataNode) && $attrName ne "self" && (IsWrapperType($returnType) && ($attribute->type =~ /^readonly/ || $attribute->signature->extendedAttributes->{"Replaceable"})
-            && $returnType ne "EventTarget" && $returnType ne "SerializedScriptValue" && $returnType ne "DOMWindow" 
-            && $returnType !~ /SVG/ && $returnType !~ /HTML/ && !IsDOMNodeType($returnType))) {
-            AddIncludesForType($returnType);
-            my $domMapFunction = GetDomMapFunction(0, $returnType);
-            # Check for a wrapper in the wrapper cache. If there is one, we know that a hidden reference has already
-            # been created. If we don't find a wrapper, we create both a wrapper and a hidden reference.
-            push(@implContentDecls, "    RefPtr<$returnType> result = ${getterString};\n");
-            push(@implContentDecls, "    v8::Handle<v8::Value> wrapper = result.get() ? ${domMapFunction}.get(result.get()) : v8::Handle<v8::Value>();\n");
-            push(@implContentDecls, "    if (wrapper.IsEmpty()) {\n");
-            push(@implContentDecls, "        wrapper = toV8(result.get());\n");
-            push(@implContentDecls, "        if (!wrapper.IsEmpty())\n");
-            if ($dataNode->name eq "DOMWindow") {
-                push(@implContentDecls, "            V8DOMWrapper::setHiddenWindowReference(imp->frame(), wrapper);\n");
-            } else {
-                push(@implContentDecls, "            V8DOMWrapper::setHiddenReference(info.Holder(), wrapper);\n");
-            }
-            push(@implContentDecls, "    }\n");
-            push(@implContentDecls, "    return wrapper;\n");
-            push(@implContentDecls, "}\n\n");
-            push(@implContentDecls, "#endif // ${conditionalString}\n\n") if $conditionalString;
-            return;
-        }
+            push(@implContentDecls, "            V8DOMWrapper::setHiddenReference(info.Holder(), wrapper);\n");
+        }
+        push(@implContentDecls, "    }\n");
+        push(@implContentDecls, "    return wrapper;\n");
+        push(@implContentDecls, "}\n\n");
+        push(@implContentDecls, "#endif // ${conditionalString}\n\n") if $conditionalString;
+        return;
     }
 
     if (IsSVGTypeNeedingContextParameter($attrType) && !$skipContext) {
-        if ($attrIsPodType) {
-            push(@implContentDecls, GenerateSVGContextAssignment($implClassName, "wrapper.get()", "    "));
-        } else {
-            push(@implContentDecls, GenerateSVGContextRetrieval($implClassName, "    "));
-            # The templating associated with passing withSVGContext()'s return value directly into toV8 can get compilers confused,
-            # so just manually set the return value to a PassRefPtr of the expected type.
-            push(@implContentDecls, "    PassRefPtr<$attrType> resultAsPassRefPtr = V8Proxy::withSVGContext($result, context);\n");
-            $result = "resultAsPassRefPtr";
-        }
-    }
-
-    if ($codeGenerator->IsSVGNewStyleAnimatedType($implClassName) and $codeGenerator->IsSVGTypeNeedingTearOff($attrType)) {
+        push(@implContentDecls, GenerateSVGContextRetrieval($implClassName, "    "));
+        # The templating associated with passing withSVGContext()'s return value directly into toV8 can get compilers confused,
+        # so just manually set the return value to a PassRefPtr of the expected type.
+        push(@implContentDecls, "    PassRefPtr<$attrType> resultAsPassRefPtr = V8Proxy::withSVGContext($result, context);\n");
+        $result = "resultAsPassRefPtr";
+    }
+
+    if ($codeGenerator->IsSVGAnimatedType($implClassName) and $codeGenerator->IsSVGTypeNeedingTearOff($attrType)) {
         $implIncludes{"V8$attrType.h"} = 1;
         my $svgNativeType = $codeGenerator->GetSVGTypeNeedingTearOff($attrType);
@@ -933 +853 @@
         my $tearOffType = $codeGenerator->GetSVGTypeNeedingTearOff($attrType);
         if ($codeGenerator->IsSVGTypeWithWritablePropertiesNeedingTearOff($attrType) and not defined $attribute->signature->extendedAttributes->{"Immutable"}) {
-            $tearOffType =~ s/SVGPropertyTearOff</SVGStaticPropertyTearOff<$implClassName, /;
-            $implIncludes{"SVGStaticPropertyTearOff.h"} = 1;
-
             my $getter = $result;
             $getter =~ s/imp->//;
             $getter =~ s/\(\)//;
-            my $updater = "update" . $codeGenerator->WK_ucfirst($getter);
-            push(@implContentDecls, "    return toV8(WTF::getPtr(${tearOffType}::create(imp, $result, &${implClassName}::$updater)));\n");
+
+            my $updateMethod = "&${implClassName}::update" . $codeGenerator->WK_ucfirst($getter);
+
+            my $selfIsTearOffType = $codeGenerator->IsSVGTypeNeedingTearOff($implClassName);
+            if ($selfIsTearOffType) {
+                $implIncludes{"SVGStaticPropertyWithParentTearOff.h"} = 1;
+                $tearOffType =~ s/SVGPropertyTearOff</SVGStaticPropertyWithParentTearOff<$implClassName, /;
+
+                if ($result =~ /matrix/ and $implClassName eq "SVGTransform") {
+                    # SVGTransform offers a matrix() method for internal usage that returns an AffineTransform
+                    # and a svgMatrix() method returning a SVGMatrix, used for the bindings.
+                    $result =~ s/matrix/svgMatrix/;
+                }
+
+                push(@implContentDecls, "    return toV8(WTF::getPtr(${tearOffType}::create(wrapper, $result, $updateMethod)));\n");
+            } else {
+                $implIncludes{"SVGStaticPropertyTearOff.h"} = 1;
+                $tearOffType =~ s/SVGPropertyTearOff</SVGStaticPropertyTearOff<$implClassName, /;
+
+                push(@implContentDecls, "    return toV8(WTF::getPtr(${tearOffType}::create(imp, $result, $updateMethod)));\n");
+            }
         } elsif ($tearOffType =~ /SVGStaticListPropertyTearOff/) {
             my $extraImp = "GetOwnerElementForType<$implClassName, IsDerivedFromSVGElement<$implClassName>::value>::ownerElement(imp), ";
@@ -949 +885 @@
             push(@implContentDecls, "    return toV8(WTF::getPtr(${tearOffType}::create($result)));\n");
         }
-    } elsif ($attrIsPodType) {
-        $implIncludes{"V8${attrType}.h"} = 1;
-        push(@implContentDecls, "    return toV8(wrapper.release().get());\n");
     } else {
         push(@implContentDecls, "    " . ReturnNativeToJSValue($attribute->signature, $result, "    ").";\n");
@@ -1004 +937 @@
     }
 
-    my $isPodType = IsPodType($implClassName);
     my $svgNativeType = $codeGenerator->GetSVGTypeNeedingTearOff($implClassName);
-
-    if ($isPodType) {
-        $implClassName = GetNativeType($implClassName);
-        $implIncludes{"V8SVGPODTypeWrapper.h"} = 1;
-        push(@implContentDecls, "    V8SVGPODTypeWrapper<$implClassName>* wrapper = V8SVGPODTypeWrapper<$implClassName>::toNative(info.Holder());\n");
-        push(@implContentDecls, "    $implClassName impInstance = *wrapper;\n");
-        push(@implContentDecls, "    $implClassName* imp = &impInstance;\n");
-    } elsif ($svgNativeType) {
+    if ($svgNativeType) {
         my $svgWrappedNativeType = $codeGenerator->GetSVGWrappedTypeNeedingTearOff($implClassName);
         if ($svgWrappedNativeType =~ /List$/) {
@@ -1083 +1008 @@
     }
 
-    my $useExceptions = 1 if @{$attribute->setterExceptions} and !($isPodType);
+    my $useExceptions = 1 if @{$attribute->setterExceptions};
 
     if ($useExceptions) {
@@ -1117 +1042 @@
     }
 
-    if ($isPodType) {
-        push(@implContentDecls, "    wrapper->commitChange(*imp, V8Proxy::svgContext(wrapper));\n");
-    } elsif ($svgNativeType) {
+    if ($svgNativeType) {
         if ($useExceptions) {
             push(@implContentDecls, "    if (!ec)\n");
@@ -1128 +1051 @@
     } elsif (IsSVGTypeNeedingContextParameter($implClassName)) {
         $implIncludes{"SVGElement.h"} = 1;
-
-        my $currentObject = "imp";
-        if ($isPodType) {
-            $currentObject = "wrapper";
-        }
-
-        push(@implContentDecls, "    if (SVGElement* context = V8Proxy::svgContext($currentObject))\n");
+        push(@implContentDecls, "    if (SVGElement* context = V8Proxy::svgContext(imp))\n");
         push(@implContentDecls, "        context->svgAttributeChanged(imp->associatedAttributeName());\n");
     }
-    
+
     push(@implContentDecls, "    return;\n");
     push(@implContentDecls, "}\n\n");  # end of setter
@@ -1328 +1245 @@
     my ($svgPropertyType, $svgListPropertyType, $svgNativeType) = GetSVGPropertyTypes($implClassName);
 
-    if (IsPodType($implClassName)) {
-        my $nativeClassName = GetNativeType($implClassName);
-        push(@implContentDecls, "    V8SVGPODTypeWrapper<$nativeClassName>* impWrapper = V8SVGPODTypeWrapper<$nativeClassName>::toNative(args.Holder());\n");
-        push(@implContentDecls, "    $nativeClassName impInstance = *impWrapper;\n");
-        push(@implContentDecls, "    $nativeClassName* imp = &impInstance;\n");
-    } elsif ($svgNativeType) {
+    if ($svgNativeType) {
         my $nativeClassName = GetNativeType($implClassName); 
         if ($implClassName =~ /List$/) {
-            push(@implContentDecls, "    $nativeClassName imp = V8${svgListPropertyType}::toNative(args.Holder());\n");
+            push(@implContentDecls, "    $nativeClassName imp = V8${implClassName}::toNative(args.Holder());\n");
         } else {
             my $svgWrappedNativeType = $codeGenerator->GetSVGWrappedTypeNeedingTearOff($implClassName);
-            push(@implContentDecls, "    $nativeClassName wrapper = V8${svgPropertyType}::toNative(args.Holder());\n");
+            push(@implContentDecls, "    $nativeClassName wrapper = V8${implClassName}::toNative(args.Holder());\n");
             push(@implContentDecls, "    $svgWrappedNativeType& impInstance = wrapper->propertyReference();\n");
             push(@implContentDecls, "    $svgWrappedNativeType* imp = &impInstance;\n");
@@ -1411 +1323 @@
             push(@implContentDecls, $functionCall);
             push(@implContentDecls, "    }\n");
-        }
-
-        if (BasicTypeCanFailConversion($parameter)) {
-            push(@implContentDecls, "    bool ${parameterName}Ok;\n");
         }
 
@@ -1442 +1350 @@
         } elsif (TypeCanFailConversion($parameter)) {
             push(@implContentDecls, "    $nativeType $parameterName = " .
-                 JSValueToNative($parameter, "args[$paramIndex]", BasicTypeCanFailConversion($parameter) ?  "${parameterName}Ok" : undef) . ";\n");
-            push(@implContentDecls, "    if (UNLIKELY(!$parameterName" . (BasicTypeCanFailConversion($parameter) ? "Ok" : "") . ")) {\n");
+                 JSValueToNative($parameter, "args[$paramIndex]") . ";\n");
+            push(@implContentDecls, "    if (UNLIKELY(!$parameterName)) {\n");
             push(@implContentDecls, "        ec = TYPE_MISMATCH_ERR;\n");
             push(@implContentDecls, "        goto fail;\n");
             push(@implContentDecls, "    }\n");
         } elsif ($nativeType =~ /^V8Parameter/) {
-            my $value = JSValueToNative($parameter, "args[$paramIndex]", BasicTypeCanFailConversion($parameter) ?  "${parameterName}Ok" : undef);
+            my $value = JSValueToNative($parameter, "args[$paramIndex]");
             push(@implContentDecls, "    " . ConvertToV8Parameter($parameter, $nativeType, $parameterName, $value) . "\n");
         } else {
@@ -1475 +1383 @@
             }
             push(@implContentDecls, "    EXCEPTION_BLOCK($nativeType, $parameterName, " .
-                 JSValueToNative($parameter, "args[$paramIndex]", BasicTypeCanFailConversion($parameter) ?  "${parameterName}Ok" : undef) . ");\n");
+                 JSValueToNative($parameter, "args[$paramIndex]") . ");\n");
         }
 
@@ -1815 +1723 @@
     my $className = "V8$interfaceName";
     my $implClassName = $interfaceName;
-
     my $hasLegacyParent = $dataNode->extendedAttributes->{"LegacyParent"};
 
@@ -1827 +1734 @@
     $implIncludes{"V8DOMWrapper.h"} = 1;
     $implIncludes{"V8IsolatedContext.h"} = 1;
-
-    if ($className =~ /^V8SVGAnimated/) {
-        AddIncludesForSVGAnimatedType($interfaceName);
-    }
 
     AddIncludesForType($interfaceName);
@@ -2669 +2572 @@
     return "getDOMNodeMap()" if ($dataNode && IsNodeSubType($dataNode));
     # Only use getDOMSVGObjectWithContextMap() for non-node svg objects
-    return "getDOMSVGObjectWithContextMap()" if $type =~ /SVG/ and $type ne "SVGLength" and $type ne "SVGLengthList" and not $codeGenerator->IsSVGNewStyleAnimatedType($type);
+    return "getDOMSVGObjectWithContextMap()" if $type =~ /SVG/ and not $codeGenerator->IsSVGTypeNeedingTearOff($type) and not $codeGenerator->IsSVGAnimatedType($type);
     return "" if $type eq "DOMImplementation";
     return "getActiveDOMObjectMap()" if IsActiveDomType($type);
@@ -2697 +2600 @@
     my $type = shift;
 
-    $type = "AffineTransform" if $type eq "SVGMatrix";
-    $type = "V8SVGPODTypeWrapper<$type>" if $dataNode->extendedAttributes->{"PODType"};
     $type = $codeGenerator->GetSVGTypeNeedingTearOff($type) if $codeGenerator->IsSVGTypeNeedingTearOff($type); 
     return $type;
@@ -2711 +2612 @@
 
     my $name = $function->signature->name;
-    my $isPodType = IsPodType($implClassName);
     my $returnType = GetTypeFromSignature($function->signature);
-    my $returnsPodType = IsPodType($returnType);
     my $nativeReturnType = GetNativeType($returnType, 0);
     my $result = "";
@@ -2720 +2619 @@
     $nativeReturnType = $codeGenerator->GetSVGWrappedTypeNeedingTearOff($returnType) if $isSVGTearOffType;
 
-    # Special case: SVG matrix transform methods should not mutate
-    # the matrix but return a copy
-    my $copyFirst = 0;
-    if ($implClassName eq "SVGMatrix" && $function->signature->type eq "SVGMatrix") {
-        $copyFirst = 1;
-    }
-
     if ($function->signature->extendedAttributes->{"v8implname"}) {
         $name = $function->signature->extendedAttributes->{"v8implname"};
@@ -2736 +2628 @@
 
     my $functionString = "imp->${name}(";
-
-    if ($copyFirst) {
-        $functionString = "result.${name}(";
-    }
-
     if ($function->signature->extendedAttributes->{"ClassMethod"}) {
         $functionString = "${implClassName}::${name}(";
-    }
-
-    my $returnsListItemPodType = 0;
-    # SVG lists functions that return POD types require special handling
-    if (IsSVGListTypeNeedingSpecialHandling($implClassName) && IsSVGListMethod($name) && $returnsPodType) {
-        $returnsListItemPodType = 1;
-        $result .= $indent . "SVGList<RefPtr<SVGPODListItem<$nativeReturnType> > >* listImp = imp;\n";
-        $functionString = "listImp->${name}(";
     }
 
@@ -2788 +2667 @@
         my $paramType = $parameter->type;
 
-        # This is a bit of a hack... we need to convert parameters to methods on SVG lists
-        # of POD types which are items in the list to appropriate SVGList<> instances
-        if ($returnsListItemPodType && $paramType . "List" eq $implClassName) {
-            $paramName = "SVGPODListItem<" . GetNativeType($paramType, 1) . ">::copy($paramName)";
-        }
-
         if ($parameter->type eq "NodeFilter" || $parameter->type eq "XPathNSResolver") {
             $functionString .= "$paramName.get()";
@@ -2802 +2675 @@
             $result .= $indent . "    return v8::Handle<v8::Value>();\n";
             $result .= $indent . "}\n";
+        } elsif ($parameter->type eq "SVGMatrix" and $implClassName eq "SVGTransformList") {
+            $functionString .= "$paramName.get()";
         } else {
             $functionString .= $paramName;
@@ -2834 +2709 @@
     if ($returnType eq "void") {
         $result .= $indent . "$functionString;\n";
-    } elsif ($copyFirst) {
-        $result .= $indent . GetNativeType($returnType, 0) . " result = *imp;\n" . $indent . "$functionString;\n";
-    } elsif ($returnsListItemPodType) {
-        $result .= $indent . "RefPtr<SVGPODListItem<$nativeReturnType> > result = $functionString;\n";
-    } elsif ($hasScriptState or @{$function->raisesExceptions} or $returnsPodType or $isPodType or IsSVGTypeNeedingContextParameter($returnType)) {
+    } elsif ($hasScriptState or @{$function->raisesExceptions}) {
         $result .= $indent . $nativeReturnType . " result = $functionString;\n";
     } else {
@@ -2844 +2715 @@
         $return = $functionString;
         $returnIsRef = 0;
+    
+        if ($implClassName eq "SVGTransformList" and IsRefPtrType($returnType)) {
+            $return = "WTF::getPtr(" . $return . ")";
+        }
     }
 
@@ -2854 +2729 @@
         $result .= $indent . "if (state.hadException())\n";
         $result .= $indent . "    return throwError(state.exception());\n"
-    }
-
-    # If the return type is a POD type, separate out the wrapper generation
-    if ($returnsListItemPodType) {
-        $result .= $indent . "RefPtr<V8SVGPODTypeWrapper<" . $nativeReturnType . "> > wrapper = ";
-        $result .= "V8SVGPODTypeWrapperCreatorForList<" . $nativeReturnType . ">::create($return, imp->associatedAttributeName());\n";
-        $return = "wrapper";
-    } elsif ($returnsPodType) {
-        $result .= $indent . "RefPtr<V8SVGPODTypeWrapper<" . $nativeReturnType . "> > wrapper = ";
-        $result .= GenerateSVGStaticPodTypeWrapper($returnType, $return) . ";\n";
-        $return = "wrapper";
     }
 
@@ -2893 +2757 @@
 
     # If the implementing class is a POD type, commit changes
-    if ($isPodType) {
-        if (!$generatedSVGContextRetrieval) {
-            $result .= GenerateSVGContextRetrieval($implClassName, $indent);
-            $generatedSVGContextRetrieval = 1;
-        }
-
-        $result .= $indent . "impWrapper->commitChange(impInstance, context);\n";
-    } elsif ($codeGenerator->IsSVGTypeNeedingTearOff($implClassName) and not $implClassName =~ /List$/) {
+    if ($codeGenerator->IsSVGTypeNeedingTearOff($implClassName) and not $implClassName =~ /List$/) {
         $result .= $indent . "wrapper->commitChange();\n";
     }
 
-    if ($returnsPodType) {
-        $implIncludes{"V8${returnType}.h"} = 1;
-        $result .= $indent . "return toV8(wrapper.release());\n";
-    } else {
-        $return .= ".release()" if ($returnIsRef);
-        $result .= $indent . ReturnNativeToJSValue($function->signature, $return, $indent) . ";\n";
-    }
+    $return .= ".release()" if ($returnIsRef);
+    $result .= $indent . ReturnNativeToJSValue($function->signature, $return, $indent) . ";\n";
 
     return $result;
@@ -2998 +2850 @@
     return "String" if $type eq "DOMString";
     return "Range::CompareHow" if $type eq "CompareHow";
-    return "AffineTransform" if $type eq "SVGMatrix";
-    return "SVGTransform" if $type eq "SVGTransform";
     return "SVGPaint::SVGPaintType" if $type eq "SVGPaintType";
     return "DOMTimeStamp" if $type eq "DOMTimeStamp";
@@ -3044 +2894 @@
 }
 
-sub BasicTypeCanFailConversion
-{
-    my $signature = shift;
-    my $type = GetTypeFromSignature($signature);
-
-    return 1 if $type eq "SVGMatrix";
-    return 1 if $type eq "SVGTransform";
-    return 0;
-}
-
 sub TypeCanFailConversion
 {
@@ -3064 +2904 @@
     return 1 if $type eq "VoidCallback";
     return 1 if $type eq "IDBKey";
-    return BasicTypeCanFailConversion($signature);
+    return 0;
 }
 
@@ -3071 +2911 @@
     my $signature = shift;
     my $value = shift;
-    my $okParam = shift;
-    my $maybeOkParam = $okParam ? ", ${okParam}" : "";
 
     my $type = GetTypeFromSignature($signature);
@@ -3080 +2918 @@
     return "static_cast<$type>($value->NumberValue())" if $type eq "float" or $type eq "double";
 
-    return "toInt32($value${maybeOkParam})" if $type eq "long";
-    return "toUInt32($value${maybeOkParam})" if $type eq "unsigned long" or $type eq "unsigned short";
+    return "toInt32($value)" if $type eq "long";
+    return "toUInt32($value)" if $type eq "unsigned long" or $type eq "unsigned short";
     return "toInt64($value)" if $type eq "unsigned long long" or $type eq "long long";
     return "static_cast<Range::CompareHow>($value->Int32Value())" if $type eq "CompareHow";
@@ -3134 +2972 @@
     } else {
         $implIncludes{"V8$type.h"} = 1;
-
-        if (IsPodType($type)) {
-            my $nativeType = GetNativeType($type);
-            $implIncludes{"V8SVGPODTypeWrapper.h"} = 1;
-
-            return "V8SVGPODTypeUtil::toSVGPODType<${nativeType}>(&V8${type}::info, $value${maybeOkParam})"
-        }
-
-        $implIncludes{"V8${type}.h"} = 1;
 
         # Perform type checks on the parameter, if it is expected Node type,
@@ -3240 +3069 @@
     'CompareHow' => 1,
     'SerializedScriptValue' => 1,
-    'SVGAngle' => 1,
-    'SVGRect' => 1,
-    'SVGPoint' => 1,
-    'SVGPreserveAspectRatio' => 1,
-    'SVGMatrix' => 1,
-    'SVGTransform' => 1,
-    'SVGLength' => 1,
-    'SVGNumber' => 1,
     'SVGPaintType' => 1,
     'DOMTimeStamp' => 1,
@@ -3358 +3179 @@
     $implIncludes{"wtf/GetPtr.h"} = 1;
 
-    if (IsPodType($type)) {
-        $value = GenerateSVGStaticPodTypeWrapper($type, $value) . ".get()";
-    }
-
     return "return toV8($value)";
-}
-
-# FIXME: This method will go away once all SVG animated properties are converted to the new scheme.
-sub GenerateSVGStaticPodTypeWrapper {
-    my $type = shift;
-    my $value = shift;
-
-    $implIncludes{"V8$type.h"}=1;
-    $implIncludes{"V8SVGPODTypeWrapper.h"} = 1;
-
-    my $nativeType = GetNativeType($type);
-    return "V8SVGStaticPODTypeWrapper<$nativeType>::create($value)";
 }
 
@@ -3427 +3232 @@
     return 0 unless $implClassName =~ /SVG/;
     return 0 if $implClassName =~ /Element/;
-    return 0 if $codeGenerator->IsSVGNewStyleAnimatedType($implClassName);
+    return 0 if $codeGenerator->IsSVGAnimatedType($implClassName);
     return 0 if $codeGenerator->IsSVGTypeNeedingTearOff($implClassName);
 
@@ -3456 +3261 @@
     my $indent = shift;
 
-    my $srcIsPodType = IsPodType($srcType);
-
-    my $srcObject = "imp";
-    if ($srcIsPodType) {
-        $srcObject = "impWrapper";
-    }
-
-    my $contextDecl;
-
+    my $contextDecl = "imp";
     if (IsSVGTypeNeedingContextParameter($srcType)) {
-        $contextDecl = "V8Proxy::svgContext($srcObject)";
-    } else {
-        $contextDecl = $srcObject;
+        $contextDecl = "V8Proxy::svgContext($contextDecl)";
     }
 
@@ -3484 +3279 @@
     return 1 if $functionName eq "removeItem";
     return 1 if $functionName eq "appendItem";
-
-    return 0;
-}
-
-sub IsSVGListMethod
-{
-    my $functionName = shift;
-
-    return 1 if $functionName eq "getFirst";
-    return 1 if $functionName eq "getLast";
-    return 1 if $functionName eq "getItem";
-
-    return IsSVGListMutator($functionName);
-}
-
-sub IsSVGListTypeNeedingSpecialHandling
-{
-    my $className = shift;
-
-    return 1 if $className eq "SVGTransformList";
 
     return 0;

trunk/WebCore/svg/DeprecatedSVGAnimatedPropertyTraits.h

@@ -23 +23 @@
 
 #if ENABLE(SVG)
-#include "PlatformString.h"
-#include "SVGTransformList.h"
 
+// FIXME: Remove this file!
 namespace WebCore {
 
@@ -31 +30 @@
 struct DeprecatedSVGAnimatedPropertyTraits : public Noncopyable { };
 
-// SVGAnimatedTransformList
-template<>
-struct DeprecatedSVGAnimatedPropertyTraits<SVGTransformList*> : public Noncopyable {
-    typedef SVGTransformList* PassType;
-    typedef SVGTransformList* ReturnType;
-    typedef RefPtr<SVGTransformList> StoredType;
-
-    static ReturnType null() { return 0; }
-    static ReturnType toReturnType(const StoredType& type) { return type.get(); }
-    static String toString(PassType type) { return type ? type->valueAsString() : String(); }
-};
-
 }
 

trunk/WebCore/svg/DeprecatedSVGAnimatedTemplate.h

@@ -28 +28 @@
 #include <wtf/HashMap.h>
 
+// FIXME: Remove this file!
 namespace WebCore {
    
     class SVGElement;
-    class SVGTransformList;
 
     struct DeprecatedSVGAnimatedTypeWrapperKey {            
@@ -152 +152 @@
     }
 
-    // Common type definitions, to ease IDL generation.
-    typedef DeprecatedSVGAnimatedTemplate<SVGTransformList*> SVGAnimatedTransformList;
-
 }
 

trunk/WebCore/svg/SVGAnimateTransformElement.cpp

@@ -87 +87 @@
 
     
-static PassRefPtr<SVGTransformList> transformListFor(SVGElement* element)
+static SVGTransformList* transformListFor(SVGElement* element)
 {
     ASSERT(element);
     if (element->isStyledTransformable())
-        return static_cast<SVGStyledTransformableElement*>(element)->transform();
+        return &static_cast<SVGStyledTransformableElement*>(element)->transform();
     if (element->hasTagName(SVGNames::textTag))
-        return static_cast<SVGTextElement*>(element)->transform();
+        return &static_cast<SVGTextElement*>(element)->transform();
     if (element->hasTagName(SVGNames::linearGradientTag) || element->hasTagName(SVGNames::radialGradientTag))
-        return static_cast<SVGGradientElement*>(element)->gradientTransform();
+        return &static_cast<SVGGradientElement*>(element)->gradientTransform();
+    // FIXME: Handle patternTransform, which is obviously missing!
     return 0;
 }
@@ -110 +111 @@
 
     if (baseValue.isEmpty()) {
-        ExceptionCode ec;
-        RefPtr<SVGTransformList> list = transformListFor(targetElement());
-        list->clear(ec);
+        if (SVGTransformList* list = transformListFor(targetElement()))
+            list->clear();
     } else
         targetElement()->setAttribute(SVGNames::transformAttr, baseValue);
@@ -122 +122 @@
         return;
     SVGElement* targetElement = resultElement->targetElement();
-    RefPtr<SVGTransformList> transformList = transformListFor(targetElement);
+    SVGTransformList* transformList = transformListFor(targetElement);
     ASSERT(transformList);
 
-    ExceptionCode ec;
     if (!isAdditive())
-        transformList->clear(ec);
+        transformList->clear();
     if (isAccumulated() && repeat) {
         SVGTransform accumulatedTransform = SVGTransformDistance(m_fromTransform, m_toTransform).scaledDistance(repeat).addToSVGTransform(SVGTransform());
-        transformList->appendItem(accumulatedTransform, ec);
+        transformList->append(accumulatedTransform);
     }
     SVGTransform transform = SVGTransformDistance(m_fromTransform, m_toTransform).scaledDistance(percentage).addToSVGTransform(m_fromTransform);
-    transformList->appendItem(transform, ec);
+    transformList->append(transform);
 }
     
@@ -182 +181 @@
 
     // ...except in case where we have additional instances in <use> trees.
+    SVGTransformList* transformList = transformListFor(targetElement);
+    if (!transformList)
+        return;
+
     const HashSet<SVGElementInstance*>& instances = targetElement->instancesForElement();
-    RefPtr<SVGTransformList> transformList = transformListFor(targetElement);
     const HashSet<SVGElementInstance*>::const_iterator end = instances.end();
     for (HashSet<SVGElementInstance*>::const_iterator it = instances.begin(); it != end; ++it) {
@@ -189 +191 @@
         ASSERT(shadowTreeElement);
         if (shadowTreeElement->isStyledTransformable())
-            static_cast<SVGStyledTransformableElement*>(shadowTreeElement)->setTransformBaseValue(transformList.get());
+            static_cast<SVGStyledTransformableElement*>(shadowTreeElement)->setTransformBaseValue(*transformList);
         else if (shadowTreeElement->hasTagName(SVGNames::textTag))
-            static_cast<SVGTextElement*>(shadowTreeElement)->setTransformBaseValue(transformList.get());
+            static_cast<SVGTextElement*>(shadowTreeElement)->setTransformBaseValue(*transformList);
         else if (shadowTreeElement->hasTagName(SVGNames::linearGradientTag) || shadowTreeElement->hasTagName(SVGNames::radialGradientTag))
-            static_cast<SVGGradientElement*>(shadowTreeElement)->setGradientTransformBaseValue(transformList.get());
+            static_cast<SVGGradientElement*>(shadowTreeElement)->setGradientTransformBaseValue(*transformList);
+        // FIXME: Handle patternTransform, obviously missing!
         if (RenderObject* renderer = shadowTreeElement->renderer()) {
             renderer->setNeedsTransformUpdate();

trunk/WebCore/svg/SVGGradientElement.cpp

@@ -42 +42 @@
     : SVGStyledElement(tagName, document)
     , m_gradientUnits(SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX)
-    , m_gradientTransform(SVGTransformList::create(SVGNames::gradientTransformAttr))
 {
 }
@@ -54 +53 @@
             setGradientUnitsBaseValue(SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX);
     } else if (attr->name() == SVGNames::gradientTransformAttr) {
-        SVGTransformList* gradientTransforms = gradientTransformBaseValue();
-        if (!SVGTransformable::parseTransformAttribute(gradientTransforms, attr->value())) {
-            ExceptionCode ec = 0;
-            gradientTransforms->clear(ec);
-        }
+        SVGTransformList newList;
+        if (!SVGTransformable::parseTransformAttribute(newList, attr->value()))
+            newList.clear();
+
+        detachAnimatedGradientTransformListWrappers(newList.size());
+        gradientTransformBaseValue() = newList;
     } else if (attr->name() == SVGNames::spreadMethodAttr) {
         if (attr->value() == "reflect")

trunk/WebCore/svg/SVGGradientElement.h

@@ -25 +25 @@
 #include "Gradient.h"
 #include "SVGAnimatedPropertyMacros.h"
+#include "SVGAnimatedTransformList.h"
 #include "SVGExternalResourcesRequired.h"
 #include "SVGStyledElement.h"
@@ -52 +53 @@
         DECLARE_ANIMATED_STATIC_PROPERTY_NEW(SVGGradientElement, SVGNames::spreadMethodAttr, int, SpreadMethod, spreadMethod)
         DECLARE_ANIMATED_STATIC_PROPERTY_NEW(SVGGradientElement, SVGNames::gradientUnitsAttr, int, GradientUnits, gradientUnits)
-        DECLARE_ANIMATED_PROPERTY(SVGGradientElement, SVGNames::gradientTransformAttr, SVGTransformList*, GradientTransform, gradientTransform)
+        DECLARE_ANIMATED_TRANSFORM_LIST_PROPERTY_NEW(SVGGradientElement, SVGNames::gradientTransformAttr, SVGTransformList, GradientTransform, gradientTransform)
 
         // SVGURIReference

trunk/WebCore/svg/SVGLinearGradientElement.cpp

@@ -128 +128 @@
             attributes.setBoundingBoxMode(current->gradientUnits() == SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX);
 
-        if (!attributes.hasGradientTransform() && current->hasAttribute(SVGNames::gradientTransformAttr))
-            attributes.setGradientTransform(current->gradientTransform()->consolidate().matrix());
+        if (!attributes.hasGradientTransform() && current->hasAttribute(SVGNames::gradientTransformAttr)) {
+            AffineTransform transform;
+            current->gradientTransform().concatenate(transform);
+            attributes.setGradientTransform(transform);
+        }
 
         if (!attributes.hasStops()) {

trunk/WebCore/svg/SVGMatrix.idl

@@ -23 +23 @@
 module svg {
 
-    interface [Conditional=SVG, PODType=AffineTransform] SVGMatrix {
+    interface [Conditional=SVG] SVGMatrix {
         // FIXME: these attributes should all be floats but since we implement
         // AffineTransform with doubles setting these as doubles makes more sense.
-        attribute double a;
-        attribute double b;
-        attribute double c;
-        attribute double d;
-        attribute double e;
-        attribute double f;
+        attribute [StrictTypeChecking] double a;
+        attribute [StrictTypeChecking] double b;
+        attribute [StrictTypeChecking] double c;
+        attribute [StrictTypeChecking] double d;
+        attribute [StrictTypeChecking] double e;
+        attribute [StrictTypeChecking] double f;
 
-        [Custom] SVGMatrix multiply(in SVGMatrix secondMatrix);
-        [Custom] SVGMatrix inverse()
+        [StrictTypeChecking, RequiresAllArguments=Raise] SVGMatrix multiply(in SVGMatrix secondMatrix);
+        SVGMatrix inverse()
             raises(SVGException);
-        [Immutable] SVGMatrix translate(in float x, in float y);
-        [Immutable] SVGMatrix scale(in float scaleFactor);
-        [Immutable] SVGMatrix scaleNonUniform(in float scaleFactorX, in float scaleFactorY);
-        [Immutable] SVGMatrix rotate(in float angle);
-        [Custom] SVGMatrix rotateFromVector(in float x, in float y)
+        [Immutable, StrictTypeChecking, RequiresAllArguments=Raise] SVGMatrix translate(in float x, in float y);
+        [Immutable, StrictTypeChecking, RequiresAllArguments=Raise] SVGMatrix scale(in float scaleFactor);
+        [Immutable, StrictTypeChecking, RequiresAllArguments=Raise] SVGMatrix scaleNonUniform(in float scaleFactorX, in float scaleFactorY);
+        [Immutable, StrictTypeChecking, RequiresAllArguments=Raise] SVGMatrix rotate(in float angle);
+        [StrictTypeChecking, RequiresAllArguments=Raise] SVGMatrix rotateFromVector(in float x, in float y)
             raises(SVGException);
         [Immutable] SVGMatrix flipX();
         [Immutable] SVGMatrix flipY();
-        [Immutable] SVGMatrix skewX(in float angle);
-        [Immutable] SVGMatrix skewY(in float angle);
+        [Immutable, StrictTypeChecking, RequiresAllArguments=Raise] SVGMatrix skewX(in float angle);
+        [Immutable, StrictTypeChecking, RequiresAllArguments=Raise] SVGMatrix skewY(in float angle);
     };
 

trunk/WebCore/svg/SVGPatternElement.cpp

@@ -58 +58 @@
     , m_patternUnits(SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX)
     , m_patternContentUnits(SVGUnitTypes::SVG_UNIT_TYPE_USERSPACEONUSE)
-    , m_patternTransform(SVGTransformList::create(SVGNames::patternTransformAttr))
 {
 }
@@ -80 +79 @@
             setPatternContentUnitsBaseValue(SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX);
     } else if (attr->name() == SVGNames::patternTransformAttr) {
-        SVGTransformList* patternTransforms = patternTransformBaseValue();
-        if (!SVGTransformable::parseTransformAttribute(patternTransforms, attr->value())) {
-            ExceptionCode ec = 0;
-            patternTransforms->clear(ec);
-        }
+        SVGTransformList newList;
+        if (!SVGTransformable::parseTransformAttribute(newList, attr->value()))
+            newList.clear();
+
+        detachAnimatedPatternTransformListWrappers(newList.size());
+        patternTransformBaseValue() = newList;
     } else if (attr->name() == SVGNames::xAttr)
         setXBaseValue(SVGLength(LengthModeWidth, attr->value()));
@@ -225 +225 @@
             attributes.setBoundingBoxModeContent(current->patternContentUnits() == SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX);
 
-        if (!attributes.hasPatternTransform() && current->hasAttribute(SVGNames::patternTransformAttr))
-            attributes.setPatternTransform(current->patternTransform()->consolidate().matrix());
+        if (!attributes.hasPatternTransform() && current->hasAttribute(SVGNames::patternTransformAttr)) {
+            AffineTransform transform;
+            current->patternTransform().concatenate(transform);
+            attributes.setPatternTransform(transform);
+        }
 
         if (!attributes.hasPatternContentElement() && current->hasChildNodes())

trunk/WebCore/svg/SVGPatternElement.h

@@ -25 +25 @@
 #include "SVGAnimatedLength.h"
 #include "SVGAnimatedPropertyMacros.h"
+#include "SVGAnimatedTransformList.h"
 #include "SVGExternalResourcesRequired.h"
 #include "SVGFitToViewBox.h"
@@ -71 +72 @@
         DECLARE_ANIMATED_STATIC_PROPERTY_NEW(SVGPatternElement, SVGNames::patternUnitsAttr, int, PatternUnits, patternUnits)
         DECLARE_ANIMATED_STATIC_PROPERTY_NEW(SVGPatternElement, SVGNames::patternContentUnitsAttr, int, PatternContentUnits, patternContentUnits)
-        DECLARE_ANIMATED_PROPERTY(SVGPatternElement, SVGNames::patternTransformAttr, SVGTransformList*, PatternTransform, patternTransform)
+        DECLARE_ANIMATED_TRANSFORM_LIST_PROPERTY_NEW(SVGPatternElement, SVGNames::patternTransformAttr, SVGTransformList, PatternTransform, patternTransform)
 
         // SVGURIReference

trunk/WebCore/svg/SVGPoint.idl

@@ -27 +27 @@
         attribute [StrictTypeChecking] float y;
 
-        SVGPoint matrixTransform(in SVGMatrix matrix);
+        [StrictTypeChecking, RequiresAllArguments=Raise] SVGPoint matrixTransform(in SVGMatrix matrix);
     };
 

trunk/WebCore/svg/SVGRadialGradientElement.cpp

@@ -138 +138 @@
             attributes.setBoundingBoxMode(current->gradientUnits() == SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX);
 
-        if (!attributes.hasGradientTransform() && current->hasAttribute(SVGNames::gradientTransformAttr))
-            attributes.setGradientTransform(current->gradientTransform()->consolidate().matrix());
+        if (!attributes.hasGradientTransform() && current->hasAttribute(SVGNames::gradientTransformAttr)) {
+            AffineTransform transform;
+            current->gradientTransform().concatenate(transform);
+            attributes.setGradientTransform(transform);
+        }
 
         if (!attributes.hasStops()) {

trunk/WebCore/svg/SVGSVGElement.cpp

@@ -450 +450 @@
 }
 
-AffineTransform SVGSVGElement::createSVGMatrix()
-{
-    return AffineTransform();
+SVGMatrix SVGSVGElement::createSVGMatrix()
+{
+    return SVGMatrix();
 }
 
@@ -465 +465 @@
 }
 
-SVGTransform SVGSVGElement::createSVGTransformFromMatrix(const AffineTransform& matrix)
-{
-    return SVGTransform(matrix);
+SVGTransform SVGSVGElement::createSVGTransformFromMatrix(const SVGMatrix& matrix)
+{
+    return SVGTransform(static_cast<const AffineTransform&>(matrix));
 }
 
@@ -583 +583 @@
 
     AffineTransform ctm = SVGFitToViewBox::viewBoxToViewTransform(viewBoxRect, preserveAspectRatio(), viewWidth, viewHeight);
-    if (useCurrentView() && currentView())
-        return currentView()->transform()->concatenate().matrix() * ctm;
+    if (useCurrentView() && currentView()) {
+        AffineTransform transform;
+        if (!currentView()->transform().concatenate(transform))
+            return ctm;
+
+        return transform * ctm;
+    }
 
     return ctm;

trunk/WebCore/svg/SVGSVGElement.h

@@ -36 +36 @@
     class SVGAngle;
     class SVGLength;
+    class SVGMatrix;
     class SVGTransform;
     class SVGViewSpec;
@@ -109 +110 @@
         static SVGAngle createSVGAngle();
         static FloatPoint createSVGPoint();
-        static AffineTransform createSVGMatrix();
+        static SVGMatrix createSVGMatrix();
         static FloatRect createSVGRect();
         static SVGTransform createSVGTransform();
-        static SVGTransform createSVGTransformFromMatrix(const AffineTransform&);
+        static SVGTransform createSVGTransformFromMatrix(const SVGMatrix&);
 
         AffineTransform viewBoxToViewTransform(float viewWidth, float viewHeight) const;

trunk/WebCore/svg/SVGStyledTransformableElement.cpp

@@ -35 +35 @@
 SVGStyledTransformableElement::SVGStyledTransformableElement(const QualifiedName& tagName, Document* document)
     : SVGStyledLocatableElement(tagName, document)
-    , m_transform(SVGTransformList::create(SVGNames::transformAttr))
 {
 }
@@ -55 +54 @@
 AffineTransform SVGStyledTransformableElement::animatedLocalTransform() const
 {
-    return m_supplementalTransform ? *m_supplementalTransform * transform()->concatenate().matrix() : transform()->concatenate().matrix();
+    AffineTransform matrix;
+    transform().concatenate(matrix);
+    return m_supplementalTransform ? *m_supplementalTransform * matrix : matrix;
 }
-    
+
 AffineTransform* SVGStyledTransformableElement::supplementalTransform()
 {
@@ -68 +69 @@
 {
     if (SVGTransformable::isKnownAttribute(attr->name())) {
-        SVGTransformList* localTransforms = transformBaseValue();
-        if (!SVGTransformable::parseTransformAttribute(localTransforms, attr->value())) {
-            ExceptionCode ec = 0;
-            localTransforms->clear(ec);
-        }
+        SVGTransformList newList;
+        if (!SVGTransformable::parseTransformAttribute(newList, attr->value()))
+            newList.clear();
+        detachAnimatedTransformListWrappers(newList.size());
+        transformBaseValue() = newList;
     } else 
         SVGStyledLocatableElement::parseMappedAttribute(attr);

trunk/WebCore/svg/SVGStyledTransformableElement.h

@@ -61 +61 @@
     virtual void synchronizeProperty(const QualifiedName&);
 
-    DECLARE_ANIMATED_PROPERTY(SVGStyledTransformableElement, SVGNames::transformAttr, SVGTransformList*, Transform, transform)
+    DECLARE_ANIMATED_TRANSFORM_LIST_PROPERTY_NEW(SVGStyledTransformableElement, SVGNames::transformAttr, SVGTransformList, Transform, transform)
 
 private:

trunk/WebCore/svg/SVGTextElement.cpp

@@ -39 +39 @@
     : SVGTextPositioningElement(tagName, doc)
     , SVGTransformable()
-    , m_transform(SVGTransformList::create(SVGNames::transformAttr))
 {
 }
@@ -51 +50 @@
 {
     if (SVGTransformable::isKnownAttribute(attr->name())) {
-        SVGTransformList* localTransforms = transformBaseValue();
-        if (!SVGTransformable::parseTransformAttribute(localTransforms, attr->value())) {
-            ExceptionCode ec = 0;
-            localTransforms->clear(ec);
-        }
+        SVGTransformList newList;
+        if (!SVGTransformable::parseTransformAttribute(newList, attr->value()))
+            newList.clear();
+
+        detachAnimatedTransformListWrappers(newList.size());
+        transformBaseValue() = newList;
     } else
         SVGTextPositioningElement::parseMappedAttribute(attr);
@@ -87 +87 @@
 AffineTransform SVGTextElement::animatedLocalTransform() const
 {
-    return m_supplementalTransform ? *m_supplementalTransform * transform()->concatenate().matrix() : transform()->concatenate().matrix();
+    AffineTransform matrix;
+    transform().concatenate(matrix);
+    return m_supplementalTransform ? *m_supplementalTransform * matrix : matrix;
 }
 

trunk/WebCore/svg/SVGTextElement.h

@@ -23 +23 @@
 
 #if ENABLE(SVG)
+#include "SVGAnimatedTransformList.h"
 #include "SVGTextPositioningElement.h"
 #include "SVGTransformable.h"
@@ -55 +56 @@
         virtual void synchronizeProperty(const QualifiedName&);
 
-        DECLARE_ANIMATED_PROPERTY(SVGTextElement, SVGNames::transformAttr, SVGTransformList*, Transform, transform)
+        DECLARE_ANIMATED_TRANSFORM_LIST_PROPERTY_NEW(SVGTextElement, SVGNames::transformAttr, SVGTransformList, Transform, transform)
        
         // Used by <animateMotion>

trunk/WebCore/svg/SVGTransform.cpp

@@ -20 +20 @@
 
 #include "config.h"
+
 #if ENABLE(SVG)
-
 #include "FloatPoint.h"
 #include "FloatSize.h"
@@ -28 +28 @@
 #include "SVGTransform.h"
 
-#include <math.h>
+#include <wtf/MathExtras.h>
 
-using namespace WebCore;
+namespace WebCore {
 
 SVGTransform::SVGTransform()
@@ -41 +41 @@
     : m_type(type)
     , m_angle(0)
-    , m_center(FloatPoint())
-    , m_matrix(AffineTransform())
 {
 }
@@ -53 +51 @@
 }
 
-bool SVGTransform::isValid()
-{
-    return (m_type != SVG_TRANSFORM_UNKNOWN);
-}
-
-SVGTransform::SVGTransformType SVGTransform::type() const
-{
-    return m_type;
-}
-
-AffineTransform SVGTransform::matrix() const
-{
-    return m_matrix;
-}
-
-float SVGTransform::angle() const
-{
-    return m_angle;
-}
-
-FloatPoint SVGTransform::rotationCenter() const
-{
-    return m_center;
-}
-
-void SVGTransform::setMatrix(AffineTransform matrix)
+void SVGTransform::setMatrix(const AffineTransform& matrix)
 {
     m_type = SVG_TRANSFORM_MATRIX;
     m_angle = 0;
+    m_matrix = matrix;
+}
 
-    m_matrix = matrix;
+void SVGTransform::updateMatrix()
+{
+    // The underlying matrix has been changed, alter the transformation type.
+    // Spec: In case the matrix object is changed directly (i.e., without using the methods on the SVGTransform interface itself)
+    // then the type of the SVGTransform changes to SVG_TRANSFORM_MATRIX.
+    m_type = SVG_TRANSFORM_MATRIX;
+    m_angle = 0;
 }
 
@@ -146 +127 @@
 }
 
+} // namespace WebCore
+
 #endif // ENABLE(SVG)
-

trunk/WebCore/svg/SVGTransform.h

@@ -23 +23 @@
 
 #if ENABLE(SVG)
-#include "AffineTransform.h"
 #include "FloatPoint.h"
+#include "SVGMatrix.h"
 
 namespace WebCore {
+
+class FloatSize;
+
+class SVGTransform {
+public:
+    enum SVGTransformType {
+        SVG_TRANSFORM_UNKNOWN = 0,
+        SVG_TRANSFORM_MATRIX = 1,
+        SVG_TRANSFORM_TRANSLATE = 2,
+        SVG_TRANSFORM_SCALE = 3,
+        SVG_TRANSFORM_ROTATE = 4,
+        SVG_TRANSFORM_SKEWX = 5,
+        SVG_TRANSFORM_SKEWY = 6
+    };
+ 
+    SVGTransform();
+    SVGTransform(SVGTransformType);
+    explicit SVGTransform(const AffineTransform&);
+
+    SVGTransformType type() const { return m_type; }
+
+    SVGMatrix& svgMatrix() { return static_cast<SVGMatrix&>(m_matrix); }
+    AffineTransform matrix() const { return m_matrix; }
+    void updateMatrix();
+
+    float angle() const { return m_angle; }
+    FloatPoint rotationCenter() const { return m_center; }
+
+    void setMatrix(const AffineTransform&);
+    void setTranslate(float tx, float ty);
+    void setScale(float sx, float sy);
+    void setRotate(float angle, float cx, float cy);
+    void setSkewX(float angle);
+    void setSkewY(float angle);
     
-    class FloatSize;
+    // Internal use only (animation system)
+    FloatPoint translate() const;
+    FloatSize scale() const;
 
-    class SVGTransform {
-    public:
-        enum SVGTransformType {
-            SVG_TRANSFORM_UNKNOWN           = 0,
-            SVG_TRANSFORM_MATRIX            = 1,
-            SVG_TRANSFORM_TRANSLATE         = 2,
-            SVG_TRANSFORM_SCALE             = 3,
-            SVG_TRANSFORM_ROTATE            = 4,
-            SVG_TRANSFORM_SKEWX             = 5,
-            SVG_TRANSFORM_SKEWY             = 6
-        };
- 
-        SVGTransform();
-        SVGTransform(SVGTransformType);
-        explicit SVGTransform(const AffineTransform&);
+    bool isValid() const { return m_type != SVG_TRANSFORM_UNKNOWN; }
 
-        SVGTransformType type() const;
+private:
+    friend bool operator==(const SVGTransform& a, const SVGTransform& b);
 
-        AffineTransform matrix() const;
-    
-        float angle() const;
-        FloatPoint rotationCenter() const;
+    SVGTransformType m_type;
+    float m_angle;
+    FloatPoint m_center;
+    AffineTransform m_matrix;
+};
 
-        void setMatrix(AffineTransform);
+inline bool operator==(const SVGTransform& a, const SVGTransform& b)
+{
+    return a.m_type == b.m_type && a.m_angle == b.m_angle && a.m_matrix == b.m_matrix;
+}
 
-        void setTranslate(float tx, float ty);
-        void setScale(float sx, float sy);
-        void setRotate(float angle, float cx, float cy);
-        void setSkewX(float angle);
-        void setSkewY(float angle);
-        
-        // Internal use only (animation system)
-        FloatPoint translate() const;
-        FloatSize scale() const;
-        
-        bool isValid();
+inline bool operator!=(const SVGTransform& a, const SVGTransform& b)
+{
+    return !(a == b);
+}
 
-    private:
-        SVGTransformType m_type;
-        float m_angle;
-        FloatPoint m_center;
-        AffineTransform m_matrix;
-    };
-
-    inline bool operator==(const SVGTransform& a, const SVGTransform& b)
-    {
-        return a.type() == b.type() && a.angle() == b.angle() && a.matrix() == b.matrix();
-    }
-    
-    inline bool operator!=(const SVGTransform& a, const SVGTransform& b)
-    {
-        return !(a == b);
-    }
-    
 } // namespace WebCore
 

trunk/WebCore/svg/SVGTransform.idl

@@ -22 +22 @@
 module svg {
 
-    interface [Conditional=SVG, PODType=SVGTransform] SVGTransform { 
+    interface [Conditional=SVG] SVGTransform { 
         // Transform Types
-        const unsigned short SVG_TRANSFORM_UNKNOWN   = 0;
-        const unsigned short SVG_TRANSFORM_MATRIX    = 1;
+        const unsigned short SVG_TRANSFORM_UNKNOWN = 0;
+        const unsigned short SVG_TRANSFORM_MATRIX = 1;
         const unsigned short SVG_TRANSFORM_TRANSLATE = 2;
-        const unsigned short SVG_TRANSFORM_SCALE     = 3;
-        const unsigned short SVG_TRANSFORM_ROTATE    = 4;
-        const unsigned short SVG_TRANSFORM_SKEWX     = 5;
-        const unsigned short SVG_TRANSFORM_SKEWY     = 6;
+        const unsigned short SVG_TRANSFORM_SCALE = 3;
+        const unsigned short SVG_TRANSFORM_ROTATE = 4;
+        const unsigned short SVG_TRANSFORM_SKEWX = 5;
+        const unsigned short SVG_TRANSFORM_SKEWY = 6;
 
         readonly attribute unsigned short type;
@@ -36 +36 @@
         readonly attribute float angle;
 
-        void setMatrix(in SVGMatrix matrix);
-        void setTranslate(in float tx, in float ty);
-        void setScale(in float sx, in float sy);
-        void setRotate(in float angle, in float cx, in float cy);
-        void setSkewX(in float angle);
-        void setSkewY(in float angle);
+        [StrictTypeChecking, RequiresAllArguments=Raise] void setMatrix(in SVGMatrix matrix);
+        [StrictTypeChecking, RequiresAllArguments=Raise] void setTranslate(in float tx, in float ty);
+        [StrictTypeChecking, RequiresAllArguments=Raise] void setScale(in float sx, in float sy);
+        [StrictTypeChecking, RequiresAllArguments=Raise] void setRotate(in float angle, in float cx, in float cy);
+        [StrictTypeChecking, RequiresAllArguments=Raise] void setSkewX(in float angle);
+        [StrictTypeChecking, RequiresAllArguments=Raise] void setSkewY(in float angle);
     };
 

trunk/WebCore/svg/SVGTransformList.cpp

@@ -27 +27 @@
 #include "SVGSVGElement.h"
 #include "SVGTransform.h"
+#include <wtf/text/StringConcatenate.h>
+#include <wtf/text/StringBuilder.h>
 
-using namespace WebCore;
+namespace WebCore {
 
-SVGTransformList::SVGTransformList(const QualifiedName& attributeName)
-    : SVGPODList<SVGTransform>(attributeName)
-{
-}
-
-SVGTransformList::~SVGTransformList()
-{
-}
-
-SVGTransform SVGTransformList::createSVGTransformFromMatrix(const AffineTransform& matrix) const
+SVGTransform SVGTransformList::createSVGTransformFromMatrix(const SVGMatrix& matrix) const
 {
     return SVGSVGElement::createSVGTransformFromMatrix(matrix);
@@ -46 +39 @@
 SVGTransform SVGTransformList::consolidate()
 {
-    ExceptionCode ec = 0;
-    return initialize(concatenate(), ec);
+    AffineTransform matrix;
+    if (!concatenate(matrix))
+        return SVGTransform();
+
+    SVGTransform transform(matrix);
+    clear();
+    append(transform);
+    return transform;
 }
 
-SVGTransform SVGTransformList::concatenate() const
+bool SVGTransformList::concatenate(AffineTransform& result) const
 {
-    unsigned int length = numberOfItems();
-    if (!length)
-        return SVGTransform();
-        
-    AffineTransform matrix;
-    ExceptionCode ec = 0;
-    for (unsigned int i = 0; i < length; i++)
-        matrix = getItem(i, ec).matrix() * matrix;
+    unsigned size = this->size();
+    if (!size)
+        return false;
 
-    return SVGTransform(matrix);
+    for (unsigned i = 0; i < size; ++i)
+        result = at(i).matrix() * result;
+
+    return true;
 }
 
@@ -67 +64 @@
 {
     // TODO: We may want to build a real transform string, instead of concatting to a matrix(...).
-    SVGTransform transform = concatenate();
-    if (transform.type() == SVGTransform::SVG_TRANSFORM_MATRIX) {
-        AffineTransform matrix = transform.matrix();
-        return String::format("matrix(%f %f %f %f %f %f)", matrix.a(), matrix.b(), matrix.c(), matrix.d(), matrix.e(), matrix.f());
-    }
+    AffineTransform matrix;
+    concatenate(matrix);
 
-    return String();
+    StringBuilder builder;
+    builder.append(makeString("matrix(", String::number(matrix.a()), ' ', String::number(matrix.b()), ' ', String::number(matrix.c()), ' '));
+    builder.append(makeString(String::number(matrix.d()), ' ', String::number(matrix.e()), ' ', String::number(matrix.f()), ')'));
+    return builder.toString();
 }
 
+} // namespace WebCore
+
 #endif // ENABLE(SVG)

trunk/WebCore/svg/SVGTransformList.h

@@ -23 +23 @@
 
 #if ENABLE(SVG)
-#include "SVGList.h"
 #include "SVGTransform.h"
-#include <wtf/Forward.h>
-#include <wtf/PassRefPtr.h>
+#include <wtf/Vector.h>
+#include <wtf/text/WTFString.h>
 
 namespace WebCore {
 
-    class SVGTransformList : public SVGPODList<SVGTransform> {
-    public:
-        static PassRefPtr<SVGTransformList> create(const QualifiedName& attributeName) { return adoptRef(new SVGTransformList(attributeName)); }
-        virtual ~SVGTransformList();
+class SVGTransformList : public Vector<SVGTransform> {
+public:
+    SVGTransformList() { }
 
-        SVGTransform createSVGTransformFromMatrix(const AffineTransform&) const;
-        SVGTransform consolidate();
+    SVGTransform createSVGTransformFromMatrix(const SVGMatrix&) const;
+    SVGTransform consolidate();
 
-        // Internal use only
-        SVGTransform concatenate() const;
+    // Internal use only
+    bool concatenate(AffineTransform& result) const;
  
-        String valueAsString() const;
-
-    private:
-        SVGTransformList(const QualifiedName&);
-    };
+    String valueAsString() const;
+};
 
 } // namespace WebCore

trunk/WebCore/svg/SVGTransformList.idl

@@ -32 +32 @@
         void clear()
             raises(DOMException);
-        SVGTransform initialize(in SVGTransform item)
+        [StrictTypeChecking, RequiresAllArguments=Raise] SVGTransform initialize(in SVGTransform item)
             raises(DOMException, SVGException);
-        SVGTransform getItem(in unsigned long index)
+        [StrictTypeChecking, RequiresAllArguments=Raise] SVGTransform getItem(in unsigned long index)
             raises(DOMException);
-        SVGTransform insertItemBefore(in SVGTransform item, in unsigned long index)
+        [StrictTypeChecking, RequiresAllArguments=Raise] SVGTransform insertItemBefore(in SVGTransform item, in unsigned long index)
             raises(DOMException, SVGException);
-        SVGTransform replaceItem(in SVGTransform item, in unsigned long index)
+        [StrictTypeChecking, RequiresAllArguments=Raise] SVGTransform replaceItem(in SVGTransform item, in unsigned long index)
             raises(DOMException, SVGException);
-        SVGTransform removeItem(in unsigned long index)
+        [StrictTypeChecking, RequiresAllArguments=Raise] SVGTransform removeItem(in unsigned long index)
             raises(DOMException);
-        SVGTransform appendItem(in SVGTransform item)
+        [StrictTypeChecking, RequiresAllArguments=Raise] SVGTransform appendItem(in SVGTransform item)
             raises(DOMException, SVGException);
-        SVGTransform createSVGTransformFromMatrix(in SVGMatrix matrix);
-        SVGTransform consolidate();
+
+        [StrictTypeChecking, RequiresAllArguments=Raise] SVGTransform createSVGTransformFromMatrix(in SVGMatrix matrix);
+        SVGTransform consolidate()
+            raises(DOMException);
     };
 

trunk/WebCore/svg/SVGTransformable.cpp

@@ -90 +90 @@
 static const int optionalValuesForType[] =  {0, 0, 1, 1, 2, 0, 0};
 
-bool SVGTransformable::parseTransformValue(unsigned type, const UChar*& ptr, const UChar* end, SVGTransform& t)
+bool SVGTransformable::parseTransformValue(unsigned type, const UChar*& ptr, const UChar* end, SVGTransform& transform)
 {
     if (type == SVGTransform::SVG_TRANSFORM_UNKNOWN)
@@ -101 +101 @@
 
     switch (type) {
-        case SVGTransform::SVG_TRANSFORM_SKEWX:
-           t.setSkewX(values[0]);
-            break;
-        case SVGTransform::SVG_TRANSFORM_SKEWY:
-               t.setSkewY(values[0]);
-            break;
-        case SVGTransform::SVG_TRANSFORM_SCALE:
-              if (valueCount == 1) // Spec: if only one param given, assume uniform scaling
-                  t.setScale(values[0], values[0]);
-              else
-                  t.setScale(values[0], values[1]);
-            break;
-        case SVGTransform::SVG_TRANSFORM_TRANSLATE:
-              if (valueCount == 1) // Spec: if only one param given, assume 2nd param to be 0
-                  t.setTranslate(values[0], 0);
-              else
-                  t.setTranslate(values[0], values[1]);
-            break;
-        case SVGTransform::SVG_TRANSFORM_ROTATE:
-              if (valueCount == 1)
-                  t.setRotate(values[0], 0, 0);
-              else
-                  t.setRotate(values[0], values[1], values[2]);
-            break;
-        case SVGTransform::SVG_TRANSFORM_MATRIX:
-            t.setMatrix(AffineTransform(values[0], values[1], values[2], values[3], values[4], values[5]));
-            break;
+    case SVGTransform::SVG_TRANSFORM_SKEWX:
+        transform.setSkewX(values[0]);
+        break;
+    case SVGTransform::SVG_TRANSFORM_SKEWY:
+        transform.setSkewY(values[0]);
+        break;
+    case SVGTransform::SVG_TRANSFORM_SCALE:
+        if (valueCount == 1) // Spec: if only one param given, assume uniform scaling
+            transform.setScale(values[0], values[0]);
+        else
+            transform.setScale(values[0], values[1]);
+        break;
+    case SVGTransform::SVG_TRANSFORM_TRANSLATE:
+        if (valueCount == 1) // Spec: if only one param given, assume 2nd param to be 0
+            transform.setTranslate(values[0], 0);
+        else
+            transform.setTranslate(values[0], values[1]);
+        break;
+    case SVGTransform::SVG_TRANSFORM_ROTATE:
+        if (valueCount == 1)
+            transform.setRotate(values[0], 0, 0);
+        else
+            transform.setRotate(values[0], values[1], values[2]);
+        break;
+    case SVGTransform::SVG_TRANSFORM_MATRIX:
+        transform.setMatrix(AffineTransform(values[0], values[1], values[2], values[3], values[4], values[5]));
+        break;
     }
 
@@ -166 +166 @@
 }
 
-bool SVGTransformable::parseTransformAttribute(SVGTransformList* list, const AtomicString& transform)
+bool SVGTransformable::parseTransformAttribute(SVGTransformList& list, const AtomicString& transform)
 {
     const UChar* start = transform.characters();
@@ -172 +172 @@
 }
 
-bool SVGTransformable::parseTransformAttribute(SVGTransformList* list, const UChar*& currTransform, const UChar* end, TransformParsingMode mode)
-{
-    ExceptionCode ec = 0;
-    if (mode == ClearList) {
-        list->clear(ec);
-        ASSERT(!ec);
-    }
+bool SVGTransformable::parseTransformAttribute(SVGTransformList& list, const UChar*& currTransform, const UChar* end, TransformParsingMode mode)
+{
+    if (mode == ClearList)
+        list.clear();
 
     bool delimParsed = false;
@@ -189 +186 @@
             return false;
 
-        SVGTransform t;
-        if (!parseTransformValue(type, currTransform, end, t))
+        SVGTransform transform;
+        if (!parseTransformValue(type, currTransform, end, transform))
             return false;
 
-        list->appendItem(t, ec);
+        list.append(transform);
         skipOptionalSpaces(currTransform, end);
         if (currTransform < end && *currTransform == ',') {

trunk/WebCore/svg/SVGTransformable.h

@@ -41 +41 @@
     };
 
-    static bool parseTransformAttribute(SVGTransformList*, const AtomicString& transform);
-    static bool parseTransformAttribute(SVGTransformList*, const UChar*& ptr, const UChar* end, TransformParsingMode mode = ClearList);
+    static bool parseTransformAttribute(SVGTransformList&, const AtomicString& transform);
+    static bool parseTransformAttribute(SVGTransformList&, const UChar*& ptr, const UChar* end, TransformParsingMode mode = ClearList);
     static bool parseTransformValue(unsigned type, const UChar*& ptr, const UChar* end, SVGTransform&);
 

trunk/WebCore/svg/SVGViewSpec.cpp

@@ -34 +34 @@
 SVGViewSpec::SVGViewSpec(SVGElement* contextElement)
     : m_contextElement(contextElement)
-    , m_transform(SVGTransformList::create(SVGNames::transformAttr))
 {
 }
@@ -40 +39 @@
 void SVGViewSpec::setTransform(const String& transform)
 {
-    SVGTransformable::parseTransformAttribute(m_transform.get(), transform);
+    SVGTransformable::parseTransformAttribute(m_transform, transform);
 }
 
@@ -145 +144 @@
                 return false;
             currViewSpec++;
-            SVGTransformable::parseTransformAttribute(m_transform.get(), currViewSpec, end, SVGTransformable::DoNotClearList);
+            SVGTransformable::parseTransformAttribute(m_transform, currViewSpec, end, SVGTransformable::DoNotClearList);
             if (currViewSpec >= end || *currViewSpec != ')')
                 return false;

trunk/WebCore/svg/SVGViewSpec.h

@@ -43 +43 @@
 
         void setTransform(const String&);
-        SVGTransformList* transform() const { return m_transform.get(); }
+        SVGTransformList transform() const { return m_transform; }
 
         void setViewBoxString(const String&);
@@ -62 +62 @@
         DECLARE_ANIMATED_PROPERTY_NEW(SVGViewSpec, SVGNames::preserveAspectRatioAttr, SVGPreserveAspectRatio, PreserveAspectRatio, preserveAspectRatio)
 
-        mutable RefPtr<SVGTransformList> m_transform;
+        SVGTransformList m_transform;
         String m_viewTargetString;
     };

trunk/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h

@@ -92 +92 @@
     }
 
+protected:
     SVGAnimatedListPropertyTearOff(SVGElement* contextElement, const QualifiedName& attributeName, PropertyType& values)
         : SVGAnimatedProperty(contextElement, attributeName)
@@ -100 +101 @@
     }
 
-private:
     PropertyType& m_values;
 

trunk/WebCore/svg/properties/SVGAnimatedPropertyMacros.h

@@ -28 +28 @@
 #include "SVGAnimatedPropertySynchronizer.h"
 #include "SVGAnimatedPropertyTearOff.h"
+#include "SVGAnimatedTransformListPropertyTearOff.h"
 #include "SVGNames.h" // FIXME: Temporary hack, until we expand the macros in all files, so we don't need a global SVGNames.h include
 #include "SVGPropertyTraits.h"
@@ -157 +158 @@
 }
 
+#define DECLARE_ANIMATED_TRANSFORM_LIST_PROPERTY_NEW(OwnerType, DOMAttribute, PropertyType, UpperProperty, LowerProperty) \
+DECLARE_ANIMATED_PROPERTY_NEW_SHARED(OwnerType, DOMAttribute, DOMAttribute.localName(), SVGAnimatedTransformListPropertyTearOff, PropertyType, UpperProperty, LowerProperty) \
+\
+void detachAnimated##UpperProperty##ListWrappers(unsigned newListSize) \
+{ \
+    SVGElement* contextElement = GetOwnerElementForType<OwnerType, IsDerivedFromSVGElement<OwnerType>::value>::ownerElement(this); \
+    SVGAnimatedProperty* wrapper = SVGAnimatedProperty::lookupWrapper<SVGAnimatedTransformListPropertyTearOff>(contextElement, DOMAttribute.localName()); \
+    if (!wrapper) \
+        return; \
+    static_cast<SVGAnimatedTransformListPropertyTearOff*>(wrapper)->detachListWrappers(newListSize); \
+}
+
+
 }
 

trunk/WebCore/svg/properties/SVGListPropertyTearOff.h

@@ -110 +110 @@
     }
 
-private:
+protected:
     SVGListPropertyTearOff(AnimatedListPropertyTearOff* animatedProperty, SVGPropertyRole role)
         : SVGListProperty<PropertyType>(role)
@@ -180 +180 @@
     }
 
-private:
     // Back pointer to the animated property that created us
     // For example (text.x.baseVal): m_animatedProperty points to the 'x' SVGAnimatedLengthList object

trunk/WebCore/svg/properties/SVGProperty.h

@@ -35 +35 @@
 public:
     virtual ~SVGProperty() { }
+
+    virtual void commitChange() = 0;
 };
 

trunk/WebCore/svg/properties/SVGPropertyTearOff.h

@@ -70 +70 @@
     void detachWrapper()
     {
+        if (m_valueIsCopy)
+            return;
+
         // Switch from a live value, to a non-live value.
         // For example: <text x="50"/>
@@ -77 +80 @@
         // w/o changing the "new item" (with x=100) in the text element.
         // Whenever the XML DOM modifies the "x" attribute, all existing wrappers are detached, using this function.
-        ASSERT(!m_valueIsCopy);
         m_value = new PropertyType(*m_value);
         m_valueIsCopy = true;

trunk/WebCore/svg/properties/SVGPropertyTraits.h

@@ -31 +31 @@
 #include "SVGPreserveAspectRatio.h"
 #include "SVGStringList.h"
+#include "SVGTransformList.h"
 #include <wtf/text/StringBuilder.h>
 
@@ -131 +132 @@
 };
 
+template<>
+struct SVGPropertyTraits<SVGTransformList> {
+    static SVGTransformList initialValue() { return SVGTransformList(); }
+    static String toString(const SVGTransformList& type) { return type.valueAsString(); }
+    typedef SVGTransform ListItemType;
+};
+
 }