Changeset 71881 in webkit

Timestamp:

Nov 11, 2010 8:16:12 PM (13 years ago)

Author:

chang.shu@nokia.com

Message:

2010-11-11 Chang Shu <​chang.shu@nokia.com>

Reviewed by Antonio Gomes.

[GTK] Unskip tests that are passing now.
fast/events/spatial-navigation/snav-input.html
fast/events/spatial-navigation/snav-textarea.html
​https://bugs.webkit.org/show_bug.cgi?id=49056

• platform/gtk/Skipped:

2010-11-11 Chang Shu <​chang.shu@nokia.com>

Reviewed by Antonio Gomes.

[GTK] Replace "MoveForward"/"MoveBackward" with "MoveRight"/"MoveLeft"
to make spatial navigation work on input/textarea.
​https://bugs.webkit.org/show_bug.cgi?id=49056

• WebCoreSupport/EditorClientGtk.cpp: (WebKit::moveCursorCallback):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• WebKit/gtk/ChangeLog (modified) (1 diff)
• WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-11-11  Chang Shu  <chang.shu@nokia.com>
+
+        Reviewed by Antonio Gomes.
+
+        [GTK] Unskip tests that are passing now.
+        fast/events/spatial-navigation/snav-input.html
+        fast/events/spatial-navigation/snav-textarea.html
+        https://bugs.webkit.org/show_bug.cgi?id=49056
+
+        * platform/gtk/Skipped:
+
 2010-11-11  Julie-Jeongeun-Kim  <jiyuluna@gmail.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -4965 +4965 @@
 fast/loader/crash-copying-backforwardlist.html
 
-# Spatial Navigation
-# https://bugs.webkit.org/show_bug.cgi?id=49056
-fast/events/spatial-navigation/snav-input.html
-fast/events/spatial-navigation/snav-textarea.html
-
 # Implement LayoutTestController::callShouldCloseOnWebView()
 fast/events/onbeforeunload-focused-iframe.html

trunk/WebKit/gtk/ChangeLog

@@ +1 @@
+2010-11-11  Chang Shu  <chang.shu@nokia.com>
+
+        Reviewed by Antonio Gomes.
+
+        [GTK] Replace "MoveForward"/"MoveBackward" with "MoveRight"/"MoveLeft"
+        to make spatial navigation work on input/textarea.
+        https://bugs.webkit.org/show_bug.cgi?id=49056
+
+        * WebCoreSupport/EditorClientGtk.cpp:
+        (WebKit::moveCursorCallback):
+
 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
 

trunk/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp

@@ -214 +214 @@
         return;
 
+    if (isSpatialNavigationEnabled(core(client->webView())->focusController()->focusedOrMainFrame()) && step == 1) {
+        if (direction == 1)
+            rawCommand = "MoveRight";
+        else if (!direction)
+            rawCommand = "MoveLeft";
+    }
+
     for (int i = 0; i < abs(count); i++)
         client->addPendingEditorCommand(rawCommand);