Changeset 72211 in webkit


Ignore:
Timestamp:
Nov 17, 2010 9:08:31 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2010-11-17 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Add a layout test to check that Geoposition timestamps are
well-formed. See ​https://bugs.webkit.org/show_bug.cgi?id=48518

  • fast/dom/Geolocation/script-tests/timestamp.js: Added. (checkPosition):
  • fast/dom/Geolocation/timestamp-expected.txt: Added.
  • fast/dom/Geolocation/timestamp.html: Added.

2010-11-17 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Convert correctly between GeolocationPosition and Geoposition
timestamp formats.
​https://bugs.webkit.org/show_bug.cgi?id=48518

Test: fast/dom/Geolocation/timestamp.html

  • page/Geolocation.cpp: (WebCore::createGeoposition):
Location:
trunk
Files:
4 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r72210 r72211  
     12010-11-17  John Knottenbelt  <jknotten@chromium.org>
     2
     3        Reviewed by Jeremy Orlow.
     4
     5        Add a layout test to check that Geoposition timestamps are
     6        well-formed. See https://bugs.webkit.org/show_bug.cgi?id=48518
     7
     8        * fast/dom/Geolocation/script-tests/timestamp.js: Added.
     9        (checkPosition):
     10        * fast/dom/Geolocation/timestamp-expected.txt: Added.
     11        * fast/dom/Geolocation/timestamp.html: Added.
     12
    1132010-11-17  Chang Shu  <chang.shu@nokia.com>
    214

  • trunk/WebCore/ChangeLog

    r72210 r72211  
     12010-11-17  John Knottenbelt  <jknotten@chromium.org>
     2
     3        Reviewed by Jeremy Orlow.
     4
     5        Convert correctly between GeolocationPosition and Geoposition
     6        timestamp formats.
     7        https://bugs.webkit.org/show_bug.cgi?id=48518
     8
     9        Test: fast/dom/Geolocation/timestamp.html
     10
     11        * page/Geolocation.cpp:
     12        (WebCore::createGeoposition):
     13
    1142010-11-17  Chang Shu  <chang.shu@nokia.com>
    215

  • trunk/WebCore/page/Geolocation.cpp

    r71602 r72211  
    6262                                                          position->accuracy(), position->canProvideAltitudeAccuracy(), position->altitudeAccuracy(),
    6363                                                          position->canProvideHeading(), position->heading(), position->canProvideSpeed(), position->speed());
    64     return Geoposition::create(coordinates.release(), position->timestamp());
     64    return Geoposition::create(coordinates.release(), convertSecondsToDOMTimeStamp(position->timestamp()));
    6565}
    6666

  • trunk/WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm

    r72146 r72211  
    7171#import <WebKit/WebViewPrivate.h>
    7272#import <WebKit/WebWorkersPrivate.h>
     73#import <wtf/CurrentTime.h>
    7374#import <wtf/HashMap.h>
    7475#import <wtf/RetainPtr.h>
    … …  
    354355void LayoutTestController::setMockGeolocationPosition(double latitude, double longitude, double accuracy)
    355356{
    356     WebGeolocationPosition *position = [[WebGeolocationPosition alloc] initWithTimestamp:0 latitude:latitude longitude:longitude accuracy:accuracy];
     357    WebGeolocationPosition *position = [[WebGeolocationPosition alloc] initWithTimestamp:currentTime() latitude:latitude longitude:longitude accuracy:accuracy];
    357358    [[MockGeolocationProvider shared] setPosition:position];
    358359    [position release];
Note: See TracChangeset for help on using the changeset viewer.