Changeset 72327 in webkit


Ignore:
Timestamp:
Nov 18, 2010 12:42:44 PM (13 years ago)
Author:
sfalken@apple.com
Message:

WebCore: [chromium] REGRESSION(72141): Chromium fails acid3 on windows and linux
​https://bugs.webkit.org/show_bug.cgi?id=49638

Patch by James Robinson <​jamesr@chromium.org> on 2010-11-18
Reviewed by Darin Fisher.

Avoid clamping zero text size to 12pt in FontPlatformData::setupPaint() in FontPlatformDataLinux.cpp
Set all metrics to 0 if the font size is specified as zero in SimpleFontDataChromiumWin.cpp, just
like Safari Win did in r72270.

Test: fast/text/font-size-zero.html

  • platform/graphics/chromium/FontPlatformDataLinux.cpp:

(WebCore::FontPlatformData::setupPaint):

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformInit):

WebKit/win: Debug_Internal Windows configuration is unnecessary, should be removed
​https://bugs.webkit.org/show_bug.cgi?id=49753

Reviewed by Adam Roben.

  • WebKitPrefix.h:

WebKit2: Keep the web process alive if there are active downloads
​https://bugs.webkit.org/show_bug.cgi?id=49755

Patch by Anders Carlsson <​andersca@apple.com> on 2010-11-18
Reviewed by Sam Weinig.

Make sure that Download objects are destroyed when the download finishes or fails.
Don't close the web process if there are live Download objects.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didFail):
Add stub.

  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/Downloads/DownloadProxy.messages.in:

Add DidFail message.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::didFinish):
Call DownloadManager::downloadFinished.

(WebKit::Download::didFail):
Send DidFail message and call DownloadManager::downloadFinished.

  • WebProcess/Downloads/Download.h:

(WebKit::Download::destinationID):
Call downloadID().

(WebKit::Download::downloadID):
Return the download ID.

  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::downloadFinished):
Delete the Download object and call WebProcess::shutdownIfPossible.

  • WebProcess/Downloads/DownloadManager.h:

(WebKit::DownloadManager::isDownloading):
Return whether the download manager has any active downloads.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:didFailWithError:]):
Call Download::didFail.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::removeWebPage):
Call shutdownIfPossible.

(WebKit::WebProcess::shutdownIfPossible):
New function. Don't shutdown if there are live pages or active downloads.

  • WebProcess/WebProcess.h:

WebKitLibraries: Debug_Internal Windows configuration is unnecessary, should be removed
​https://bugs.webkit.org/show_bug.cgi?id=49753

Reviewed by Adam Roben.

  • win/tools/vsprops/debug.vsprops:
  • win/tools/vsprops/debug_internal.vsprops:

WebKitTools: update-webkit-support-libs should fall back to existing
WebKitSupportLibrary version if there is no internet connectivity
​https://bugs.webkit.org/show_bug.cgi?id=49503

Patch by Daniel Bates <​dbates@rim.com> on 2010-11-18
Reviewed by Adam Roben.

Fall back to existing support libraries (if present) when there is
no internet connection.

Currently, update-webkit-support-libs dies with an "out-of-date"
error when there is no internet connection because it cannot
retrieve versioning information from developer.apple.com. Because
update-webkit-support-libs fails, build-webkit fails. Instead,
if there is no internet connection and the support libraries are
present then we should warn the user and exit() with success so
that build-webkit can work without an internet connection.

  • Scripts/update-webkit-support-libs:
Location:
trunk
Files:
15 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r72324 r72327  
    3131        (WebCore::loadFullScreenRulesIfNeeded):
    3232        (WebCore::CSSStyleSelector::styleForElement):
     33
     342010-11-18  Steve Falkenburg  <sfalken@apple.com>
     35
     36        Reviewed by Adam Roben.
     37
     38        Debug_Internal Windows configuration is unnecessary, should be removed
     39        https://bugs.webkit.org/show_bug.cgi?id=49753
     40
     41        * WebCorePrefix.h:
    3342
    34432010-11-18  Steve Falkenburg  <sfalken@apple.com>

  • trunk/WebCore/WebCorePrefix.h

    r72158 r72327  
    157157#undef catch
    158158#endif
     159

  • trunk/WebKit/win/ChangeLog

    r72296 r72327  
     12010-11-18  Steve Falkenburg  <sfalken@apple.com>
     2
     3        Reviewed by Adam Roben.
     4
     5        Debug_Internal Windows configuration is unnecessary, should be removed
     6        https://bugs.webkit.org/show_bug.cgi?id=49753
     7
     8        * WebKitPrefix.h:
     9
    1102010-11-17  Steve Falkenburg  <sfalken@apple.com>
    211

  • trunk/WebKit/win/WebKitPrefix.h

    r72158 r72327  
    5050#include <CoreFoundation/CoreFoundation.h>
    5151#include <WebKit/WebKit.h>
    52 

  • trunk/WebKit2/ChangeLog

    r72323 r72327  
    5151
    5252        * WebProcess/WebProcess.h:
     53
     542010-11-18  Steve Falkenburg  <sfalken@apple.com>
     55
     56        Reviewed by Adam Roben.
     57
     58        Debug_Internal Windows configuration is unnecessary, should be removed
     59        https://bugs.webkit.org/show_bug.cgi?id=49753
     60
     61        * UIProcess/Launcher/win/ProcessLauncherWin.cpp:
     62        * WebKit2Prefix.h:
    5363
    54642010-11-18  Steve Falkenburg  <sfalken@apple.com>

  • trunk/WebKit2/UIProcess/Launcher/win/ProcessLauncherWin.cpp

    r70460 r72327  
    3131#include <wtf/text/WTFString.h>
    3232
    33 #if !defined(NDEBUG) && (!defined(DEBUG_INTERNAL) || defined(DEBUG_ALL))
     33#ifdef DEBUG_ALL
    3434const LPCWSTR webProcessName = L"WebKit2WebProcess_debug.exe";
    3535#else

  • trunk/WebKit2/WebKit2Prefix.h

    r72158 r72327  
    110110
    111111#endif /* defined(WIN32) || defined(_WIN32) */
     112

  • trunk/WebKitLibraries/ChangeLog

    r72219 r72327  
     12010-11-18  Steve Falkenburg  <sfalken@apple.com>
     2
     3        Reviewed by Adam Roben.
     4
     5        Debug_Internal Windows configuration is unnecessary, should be removed
     6        https://bugs.webkit.org/show_bug.cgi?id=49753
     7
     8        * win/tools/vsprops/debug.vsprops:
     9        * win/tools/vsprops/debug_internal.vsprops:
     10
    1112010-11-17  Steve Falkenburg  <sfalken@apple.com>
    212

  • trunk/WebKitLibraries/win/tools/vsprops/debug.vsprops

    r29845 r72327  
    2121        <UserMacro
    2222                Name="WebKitConfigSuffix"
    23                 Value="_debug"
     23                Value=""
    2424                PerformEnvironmentSet="true"
    2525        />

  • trunk/WebKitLibraries/win/tools/vsprops/debug_internal.vsprops

    r49705 r72327  
    55        Name="debug_internal"
    66        >
    7         <Tool
    8                 Name="VCCLCompilerTool"
    9                 PreprocessorDefinitions="DEBUG_INTERNAL"
    10         />
    11         <UserMacro
    12                 Name="WebKitConfigSuffix"
    13                 Value=""
    14                 PerformEnvironmentSet="true"
    15         />
    16         <UserMacro
    17                 Name="LibraryConfigSuffix"
    18                 Value=""
    19                 PerformEnvironmentSet="true"
    20         />
    21         <UserMacro
    22                 Name="WebKitDLLConfigSuffix"
    23                 Value=""
    24         />
    257</VisualStudioPropertySheet>

  • trunk/WebKitTools/ChangeLog

    r72326 r72327  
    1919
    2020        * Scripts/update-webkit-support-libs:
     21
     222010-11-18  Steve Falkenburg  <sfalken@apple.com>
     23
     24        Reviewed by Adam Roben.
     25
     26        Debug_Internal Windows configuration is unnecessary, should be removed
     27        https://bugs.webkit.org/show_bug.cgi?id=49753
     28
     29        * DumpRenderTree/win/DumpRenderTree.cpp:
     30        * MiniBrowser/win/stdafx.h:
     31        * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
     32        * WebKitTestRunner/win/TestControllerWin.cpp:
    2133
    22342010-11-18  Steve Falkenburg  <sfalken@apple.com>

  • trunk/WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp

    r72264 r72327  
    6767using namespace std;
    6868
    69 #if !defined(NDEBUG) && (!defined(DEBUG_INTERNAL) || defined(DEBUG_ALL))
     69#ifdef DEBUG_ALL
    7070const LPWSTR TestPluginDir = L"TestNetscapePlugin_Debug";
    7171#else

  • trunk/WebKitTools/MiniBrowser/win/stdafx.h

    r72158 r72327  
    2929#include <tchar.h>
    3030#include <windows.h>
     31

  • trunk/WebKitTools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp

    r70197 r72327  
    3333namespace Util {
    3434
    35 #if !defined(NDEBUG) && (!defined(DEBUG_INTERNAL) || defined(DEBUG_ALL))
     35#ifdef DEBUG_ALL
    3636const char* injectedBundleDLL = "\\InjectedBundle_debug.dll";
    3737#else

  • trunk/WebKitTools/WebKitTestRunner/win/TestControllerWin.cpp

    r72031 r72327  
    3939namespace WTR {
    4040
    41 #if !defined(NDEBUG) && (!defined(DEBUG_INTERNAL) || defined(DEBUG_ALL))
     41#ifdef DEBUG_ALL
    4242const LPWSTR testPluginDirectoryName = L"TestNetscapePlugin_Debug";
    4343const char* injectedBundleDLL = "\\InjectedBundle_debug.dll";
Note: See TracChangeset for help on using the changeset viewer.