Changeset 72644 in webkit


Ignore:
Timestamp:
Nov 23, 2010 8:14:40 PM (13 years ago)
Author:
inferno@chromium.org
Message:

2010-11-22 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

r71925 broke the chrome new tab page. r71925 blocked drag and drop
of same security origin objects onto themselves if their origin is
marked unique. We need to allow drag and drop in that scenario.
https://bugs.webkit.org/show_bug.cgi?id=49098

Test: http/tests/security/drag-drop-same-unique-origin.html

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canReceiveDragData):

2010-11-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Tests that drag and drop is allowed across the same security origin object,
even if they are marked unique.

  • http/tests/security/drag-drop-same-unique-origin-expected.txt: Added.
  • http/tests/security/drag-drop-same-unique-origin.html: Added.
  • http/tests/security/resources/drag-drop-allowed.html: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r72643 r72644  
     12010-11-23  Abhishek Arya  <inferno@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Tests that drag and drop is allowed across the same security origin object,
     6        even if they are marked unique.
     7
     8        * http/tests/security/drag-drop-same-unique-origin-expected.txt: Added.
     9        * http/tests/security/drag-drop-same-unique-origin.html: Added.
     10        * http/tests/security/resources/drag-drop-allowed.html: Added.
     11
    1122010-11-23  Ryosuke Niwa  <rniwa@webkit.org>
    213
  • trunk/WebCore/ChangeLog

    r72639 r72644  
     12010-11-22  Abhishek Arya  <inferno@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        r71925 broke the chrome new tab page. r71925 blocked drag and drop
     6        of same security origin objects onto themselves if their origin is
     7        marked unique. We need to allow drag and drop in that scenario.
     8        https://bugs.webkit.org/show_bug.cgi?id=49098
     9
     10        Test: http/tests/security/drag-drop-same-unique-origin.html
     11
     12        * page/SecurityOrigin.cpp:
     13        (WebCore::SecurityOrigin::canReceiveDragData):
     14
    1152010-11-23  Cris Neckar  <cdn@chromium.org>
    216
  • trunk/WebCore/page/SecurityOrigin.cpp

    r71925 r72644  
    276276bool SecurityOrigin::canReceiveDragData(const SecurityOrigin* dragInitiator) const
    277277{
     278    if (this == dragInitiator)
     279        return true;
     280
    278281    // FIXME: Currently we treat data URLs as having a unique origin, contrary to the
    279282    // current (9/19/2009) draft of the HTML5 specification. We still want to allow
Note: See TracChangeset for help on using the changeset viewer.