Changeset 72963 in webkit

Timestamp:

Nov 30, 2010 2:07:13 PM (13 years ago)

Author:

mario@webkit.org

Message:

2010-11-30 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

GTK: AX: implement press in DRT
​https://bugs.webkit.org/show_bug.cgi?id=36146

Unskipped test accessibility/label-element-press.html.

• platform/gtk/Skipped: Unskip passing test.

2010-11-30 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

GTK: AX: implement press in DRT
​https://bugs.webkit.org/show_bug.cgi?id=36146

Implement AccessibilityUIElement::press() for GTK.

• DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::press): Implemented.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
+
+        Reviewed by Xan Lopez.
+
+        GTK: AX: implement press in DRT
+        https://bugs.webkit.org/show_bug.cgi?id=36146
+
+        Unskipped test accessibility/label-element-press.html.
+
+        * platform/gtk/Skipped: Unskip passing test.
+
 2010-11-30  Daniel Bates  <dbates@rim.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -121 +121 @@
 accessibility/table-with-rules.html
 accessibility/aria-list-and-listitem.html
-
-# https://bugs.webkit.org/show_bug.cgi?id=36146 - GTK: AX: implement press in DRT 
-accessibility/label-element-press.html
 
 # Tests in css2.1/ directory

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
+
+        Reviewed by Xan Lopez.
+
+        GTK: AX: implement press in DRT
+        https://bugs.webkit.org/show_bug.cgi?id=36146
+
+        Implement AccessibilityUIElement::press() for GTK.
+
+        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
+        (AccessibilityUIElement::press): Implemented.
+
 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
 

trunk/WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp

@@ -571 +571 @@
 void AccessibilityUIElement::press()
 {
-    // FIXME: implement
+    if (!m_element)
+        return;
+
+    ASSERT(ATK_IS_OBJECT(m_element));
+
+    if (!ATK_IS_ACTION(m_element))
+        return;
+
+    // Only one action per object is supported so far.
+    atk_action_do_action(ATK_ACTION(m_element), 0);
 }