Changeset 73009 in webkit


Ignore:
Timestamp:
Nov 30, 2010 9:37:32 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2010-11-30 Avi Drissman <​avi@google.com>

Reviewed by Darin Adler.

Add preference to not select when right-clicked
​https://bugs.webkit.org/show_bug.cgi?id=23351

Removed 5109817 because it is entirely superseded by
context-menu-text-selection; updated 5354455-1 to explicitly set the
editing behavior and test all three platforms.

  • editing/selection/5109817.html: Removed.
  • editing/selection/5354455-1-expected.txt: Added.
  • editing/selection/5354455-1.html:
  • platform/chromium-win/editing/selection/5109817-expected.txt: Removed.
  • platform/chromium-win/editing/selection/5354455-1-expected.txt: Removed.
  • platform/gtk/editing/selection/5109817-expected.txt: Removed.
  • platform/gtk/editing/selection/5354455-1-expected.txt: Removed.
  • platform/mac-leopard/editing/selection/5109817-expected.checksum: Removed.
  • platform/mac-leopard/editing/selection/5109817-expected.png: Removed.
  • platform/mac/editing/selection/5109817-expected.checksum: Removed.
  • platform/mac/editing/selection/5109817-expected.png: Removed.
  • platform/mac/editing/selection/5109817-expected.txt: Removed.
  • platform/mac/editing/selection/5354455-1-expected.txt: Removed.
  • platform/win/editing/selection/5109817-expected.checksum: Removed.
  • platform/win/editing/selection/5109817-expected.png: Removed.
  • platform/win/editing/selection/5109817-expected.txt: Removed.
  • platform/win/editing/selection/5354455-1-expected.txt: Removed.
Location:
trunk/LayoutTests
Files:
1 added
15 deleted
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r73005 r73009  
     12010-11-30  Avi Drissman  <avi@google.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Add preference to not select when right-clicked
     6        https://bugs.webkit.org/show_bug.cgi?id=23351
     7
     8        Removed 5109817 because it is entirely superseded by
     9        context-menu-text-selection; updated 5354455-1 to explicitly set the
     10        editing behavior and test all three platforms.
     11       
     12        * editing/selection/5109817.html: Removed.
     13        * editing/selection/5354455-1-expected.txt: Added.
     14        * editing/selection/5354455-1.html:
     15        * platform/chromium-win/editing/selection/5109817-expected.txt: Removed.
     16        * platform/chromium-win/editing/selection/5354455-1-expected.txt: Removed.
     17        * platform/gtk/editing/selection/5109817-expected.txt: Removed.
     18        * platform/gtk/editing/selection/5354455-1-expected.txt: Removed.
     19        * platform/mac-leopard/editing/selection/5109817-expected.checksum: Removed.
     20        * platform/mac-leopard/editing/selection/5109817-expected.png: Removed.
     21        * platform/mac/editing/selection/5109817-expected.checksum: Removed.
     22        * platform/mac/editing/selection/5109817-expected.png: Removed.
     23        * platform/mac/editing/selection/5109817-expected.txt: Removed.
     24        * platform/mac/editing/selection/5354455-1-expected.txt: Removed.
     25        * platform/win/editing/selection/5109817-expected.checksum: Removed.
     26        * platform/win/editing/selection/5109817-expected.png: Removed.
     27        * platform/win/editing/selection/5109817-expected.txt: Removed.
     28        * platform/win/editing/selection/5354455-1-expected.txt: Removed.
     29
    1302010-11-30  Rob Buis  <rwlbuis@gmail.com>
    231

  • trunk/LayoutTests/editing/selection/5354455-1.html

    r68948 r73009  
    1 <script src="../../resources/dump-as-markup.js"></script>
    2 
    3 <p>This tests whether right clicking on a paragraph break in editable content selects it.  The break should be selected on OS X, but not on Windows or Linux.  To run it manually, right click on the paragraph break after the first paragraph below.</p>
    4 <div id="dump">
     1<p>This tests whether right clicking on a paragraph break in editable content selects it.  The break should be selected on OS X, but not on Windows or Unix.  To run it manually, right click on the paragraph break after the first paragraph below.</p>
    52<div id="div" contenteditable="true">
    63<div><span id="text">The following paragraph break should be selected on OS X.</span></div>
    74<br>
    85</div>
    9 </div>
     6<p>Mac: <span id="resultmac">RUNNING</span></p>
     7<p>Win: <span id="resultwin">RUNNING</span></p>
     8<p>Unix: <span id="resultunix">RUNNING</span></p>
    109
    1110<script>
    12 if (window.layoutTestController) {
     11function test(platform, result) {
     12    window.getSelection().removeAllRanges();
     13    layoutTestController.setEditingBehavior(platform);
     14   
    1315    paragraph = document.getElementById("text");
    1416    x = paragraph.offsetParent.offsetLeft + paragraph.offsetLeft + paragraph.offsetWidth + 10;
    … …  
    2022    // Right click on the paragraph break to select it.
    2123    eventSender.contextClick();
     24    // esc key to kill the context menu.
     25    eventSender.keyDown(String.fromCharCode(0x001B), null);
     26   
     27    document.getElementById(result).innerHTML = window.getSelection().type;
    2228}
    23 Markup.dump(document.getElementById("dump"));
     29
     30if (window.eventSender && window.layoutTestController) {
     31    layoutTestController.dumpAsText();
     32
     33    test('mac', 'resultmac');
     34    test('win', 'resultwin');
     35    test('unix', 'resultunix');
     36}
    2437</script>
    2538
Note: See TracChangeset for help on using the changeset viewer.