Changeset 73150 in webkit


Ignore:
Timestamp:
Dec 2, 2010 10:14:33 AM (13 years ago)
Author:
Martin Robinson
Message:

2010-12-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DumpRenderTree has two copies of JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=49877

Prevent the need to compile JSC into DumpRenderTree twice, by adjusting
the symbol visibility rules for libwebkit. Make all JSC symbols visible,
while hiding WebCore/WebKit symbols.

  • GNUmakefile.am: Move the symbol visibility flags to the WebKit build.
  • autotools/symbols.filter: Update the symbol filter list with the real mangled names of the symbols and include other symbols that DRT needs.

2010-12-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DumpRenderTree has two copies of JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=49877

Keep WebKit/WebCore symbols hidden.

  • GNUmakefile.am: Move the symbol visibility rules here, because now JSC symbols are visible, but WebCore/WebKit symbols are hidden.

2010-12-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DumpRenderTree has two copies of JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=49877

  • GNUmakefile.am: Remove the second copy of JavaScriptCore from the LDADD list for DumpRenderTree.
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r73113 r73150  
     12010-12-02  Martin Robinson  <mrobinson@igalia.com>
     2
     3        Reviewed by Xan Lopez.
     4
     5        [GTK] DumpRenderTree has two copies of JavaScriptCore
     6        https://bugs.webkit.org/show_bug.cgi?id=49877
     7
     8        Prevent the need to compile JSC into DumpRenderTree twice, by adjusting
     9        the symbol visibility rules for libwebkit. Make all JSC symbols visible,
     10        while hiding WebCore/WebKit symbols.
     11
     12        * GNUmakefile.am: Move the symbol visibility flags to the WebKit build.
     13        * autotools/symbols.filter: Update the symbol filter list with the real
     14        mangled names of the symbols and include other symbols that DRT needs.
     15
    1162010-12-02  Daniel Bates  <dbates@rim.com>
    217

  • trunk/GNUmakefile.am

    r72744 r73150  
    9393
    9494global_cxxflags += \
    95         $(SYMBOL_VISIBILITY_INLINES) \
    9695        -fno-rtti
    9796
    … …  
    179178if !ENABLE_DEBUG
    180179global_cppflags += -DNDEBUG
    181 global_cflags += $(SYMBOL_VISIBILITY)
    182180else
    183181global_cppflags += \

  • trunk/WebKit/gtk/ChangeLog

    r73113 r73150  
     12010-12-02  Martin Robinson  <mrobinson@igalia.com>
     2
     3        Reviewed by Xan Lopez.
     4
     5        [GTK] DumpRenderTree has two copies of JavaScriptCore
     6        https://bugs.webkit.org/show_bug.cgi?id=49877
     7
     8        Keep WebKit/WebCore symbols hidden.
     9
     10        * GNUmakefile.am: Move the symbol visibility rules here, because
     11        now JSC symbols are visible, but WebCore/WebKit symbols are hidden.
     12
    1132010-12-02  Daniel Bates  <dbates@rim.com>
    214

  • trunk/WebKit/gtk/GNUmakefile.am

    r72744 r73150  
    2828
    2929libwebkitgtk_@WEBKITGTK_API_MAJOR_VERSION@_@WEBKITGTK_API_MINOR_VERSION@_la_CXXFLAGS = \
     30        $(SYMBOL_VISIBILITY_INLINES) \
    3031        $(global_cxxflags)
    3132
    3233libwebkitgtk_@WEBKITGTK_API_MAJOR_VERSION@_@WEBKITGTK_API_MINOR_VERSION@_la_CFLAGS = \
     34        $(SYMBOL_VISIBILITY) \
    3335        $(global_cflags)
    3436

  • trunk/WebKitTools/ChangeLog

    r73115 r73150  
     12010-12-02  Martin Robinson  <mrobinson@igalia.com>
     2
     3        Reviewed by Xan Lopez.
     4
     5        [GTK] DumpRenderTree has two copies of JavaScriptCore
     6        https://bugs.webkit.org/show_bug.cgi?id=49877
     7
     8        * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
     9        LDADD list for DumpRenderTree.
     10
    1112010-12-02  Sergio Villar Senin  <svillar@igalia.com>
    212

  • trunk/WebKitTools/GNUmakefile.am

    r73069 r73150  
    100100Programs_DumpRenderTree_LDADD = \
    101101        libwebkitgtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la \
    102         libJavaScriptCore.la \
    103102        $(GLOBALDEPS_LIBS) \
    104103        $(CAIRO_LIBS) \

  • trunk/autotools/symbols.filter

    r72744 r73150  
    11{
    22global:
    3 _ZN3WTF10fastMallocEj;
    4 _ZN3WTF11fastReallocEPvj;
     3_ZN3WTF10fastCallocEmm;
     4_ZN3WTF10fastMallocEm;
     5_ZN3WTF10fastStrDupEPKc;
     6_ZN3WTF11fastReallocEPvm;
     7_ZN3WTF14fastMallocSizeEPKv;
     8_ZN3WTF16fastZeroedMallocEm;
     9_ZN3WTF20fastMallocStatisticsEv;
    510_ZN3WTF8fastFreeEPv;
    6 _ZN3WTF10fastCallocEjj;
     11_ZN3WTF3MD58addBytesEPKhm;
     12_ZN3WTF3MD58checksumERNS_6VectorIhLm16EEE;
     13_ZN3WTF3MD5C1Ev;
     14_ZN3WTF3MD5C2Ev;
     15_ZN3WTFL12MD5TransformEPjPKj;
     16_ZN3WTF7CString11mutableDataEv;
     17_ZN3WTF7CString16newUninitializedEmRPc;
     18_ZN3WTF7CString18copyBufferIfNeededEv;
     19_ZN3WTF7CString4initEPKcm;
     20_ZN3WTF7CStringC1EPKc;
     21_ZN3WTF7CStringC1EPKcm;
     22_ZN3WTF7CStringC2EPKc;
     23_ZN3WTF7CStringC2EPKcm;
     24_ZN3WTF7CStringD1Ev;
     25_ZN3WTF7CStringaSERKS0_;
    726_ZN24DumpRenderTreeSupportGtk*;
    827local:
Note: See TracChangeset for help on using the changeset viewer.